[GitHub] [echarts] pissang closed issue #14534: TypeError Failed to execute 'createLinearGradient' on 'CanvasRenderingContext2D': The provided double value is non-finite.
pissang closed issue #14534: URL: https://github.com/apache/echarts/issues/14534 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] maozf opened a new issue #14701: Uncaught TypeError: Cannot read property 'getData' of undefined
maozf opened a new issue #14701: URL: https://github.com/apache/echarts/issues/14701 Uncaught TypeError: Cannot read property 'getData' of undefined in map(geo) ->tooltip -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] closed issue #14701: Uncaught TypeError: Cannot read property 'getData' of undefined
echarts-bot[bot] closed issue #14701: URL: https://github.com/apache/echarts/issues/14701 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on issue #14701: Uncaught TypeError: Cannot read property 'getData' of undefined
echarts-bot[bot] commented on issue #14701: URL: https://github.com/apache/echarts/issues/14701#issuecomment-821923031 This issue is not created using [issue template](https://ecomfe.github.io/echarts-issue-helper/) so I'm going to close it. 🙊 Sorry for this, but it helps save our maintainers' time so that more developers get helped. Feel free to create another issue using the issue template. If you think you have already made your point clear without the template, or your problem cannot be covered by it, you may re-open this issue again. 这个 issue 未使用 [issue 模板](https://ecomfe.github.io/echarts-issue-helper/?lang=zh-cn) 创建，所以我将关闭此 issue。 为此带来的麻烦我深表歉意，但是请理解这是为了节约社区维护者的时间，以更高效地服务社区的开发者群体。 如果您愿意，请使用 issue 模板重新创建 issue。 如果您认为虽然没有使用模板，但您已经提供了复现问题的充分描述，或者您的问题无法使用模板表达，也可以重新 open 这个 issue。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on issue #14700: Reverse stacking order for line charts
echarts-bot[bot] commented on issue #14700: URL: https://github.com/apache/echarts/issues/14700#issuecomment-821910900 Hi! We've received your issue and please be patient to get responded. 🎉 The average response time is expected to be within one day for weekdays. In the meanwhile, please make sure that **you have posted enough image to demo your request**. You may also check out the [API](http://echarts.apache.org/api.html) and [chart option](http://echarts.apache.org/option.html) to get the answer. If you don't get helped for a long time (over a week) or have an urgent question to ask, you may also send an email to d...@echarts.apache.org. Please attach the issue link if it's a technical question. If you are interested in the project, you may also subscribe our [mailing list](https://echarts.apache.org/en/maillist.html). Have a nice day! 🍵 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Bilge opened a new issue #14700: Reverse stacking order for line charts
Bilge opened a new issue #14700: URL: https://github.com/apache/echarts/issues/14700 ### What problem does this feature solve? The stacking order of a stacked line chart is determined by the order in which the series are defined. However, this definition order also determines the order of other components, such as the legend, tooltip and dataset. When one wants to reverse the stacking order, currently the only option is to redefine the order the series are defined in. Unfortunately, this implies the order show in the legend and tooltip may be the reverse of what we want. Generally, redefining the series order may adversely impact other components and feels like the wrong approach to redeclare the data to suit the presentation. It is worth noting the tooltip can work around this because it has an `order: 'seriesDesc'` option, and also custom formatting option, but the legend does not. Again, in general it feels like the wrong approach to design every component to be "reversible", when this is just a presentation problem. ### What does the proposed API look like? It would probably be best if there was simply an option to draw the stacked series in reverse order so all the other components will continue to work as normal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Bilge edited a comment on issue #13415: Position tooltip relative to highlighted data item
Bilge edited a comment on issue #13415: URL: https://github.com/apache/echarts/issues/13415#issuecomment-821896912 @susiwen8 How did 5.0 solve this? The [documentation for tooltip.position](https://echarts.apache.org/en/option.html#tooltip.position) is word-for-word [the same as v4](https://echarts.apache.org/v4/en/option.html#tooltip.position). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Bilge commented on issue #13415: Position tooltip relative to highlighted data item
Bilge commented on issue #13415: URL: https://github.com/apache/echarts/issues/13415#issuecomment-821896912 @susiwen8 How did 5.0 solve this? The [documentation for tooltip.position](https://echarts.apache.org/en/option.html#tooltip.position) is word-for-word the same as v4. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] wilnerjs commented on issue #14092: Series Label on Custom Series not working properly
wilnerjs commented on issue #14092: URL: https://github.com/apache/echarts/issues/14092#issuecomment-821892860 This is not working on 5.1.0 =\ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] xgqfrms edited a comment on issue #2941: Handling click events on chart grid columns
xgqfrms edited a comment on issue #2941:
URL: https://github.com/apache/echarts/issues/2941#issuecomment-821831174
# online demo
https://www.runoob.com/try/try.php?filename=tryecharts_event1
```html
ECharts 实例
https://cdn.staticfile.org/echarts/4.3.0/echarts.min.js";>
// 基于准备好的dom，初始化ECharts实例
var myChart = echarts.init(document.getElementById('main'));
// 指定图表的配置项和数据
var option = {
xAxis: {
data: ["衬衫","羊毛衫","雪纺衫","裤子","高跟鞋","袜子"]
},
yAxis: {},
series: [{
name: '销量',
type: 'bar',
data: [5, 20, 36, 10, 10, 20]
}]
};
// 使用刚指定的配置项和数据显示图表。
myChart.setOption(option);
// 处理点击事件并且弹出数据名称
myChart.on('click', function (params) {
console.log('params', params, params.name);
});
myChart.on('click', 'series', function (params) {
console.log('series', params, params.name);
});
myChart.on('click', 'series.line', function (params) {
console.log('series.line', params, params.name);
});
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] xgqfrms commented on issue #2941: Handling click events on chart grid columns
xgqfrms commented on issue #2941:
URL: https://github.com/apache/echarts/issues/2941#issuecomment-821831174
# online demo
https://www.runoob.com/try/try.php?filename=tryecharts_event1
```html
ECharts 实例
https://cdn.staticfile.org/echarts/4.3.0/echarts.min.js";>
// 基于准备好的dom，初始化ECharts实例
var myChart = echarts.init(document.getElementById('main'));
// 指定图表的配置项和数据
var option = {
xAxis: {
data: ["衬衫","羊毛衫","雪纺衫","裤子","高跟鞋","袜子"]
},
yAxis: {},
series: [{
name: '销量',
type: 'bar',
data: [5, 20, 36, 10, 10, 20]
}]
};
// 使用刚指定的配置项和数据显示图表。
myChart.setOption(option);
// 处理点击事件并且弹出数据名称
myChart.on('click', function (params) {
console.log('params', params, params.name);
});
myChart.on('click', 'series', function (params) {
console.log('series', params, params.name);
});
myChart.on('click', 'series.line', function (params) {
console.log('series.line', params, params.name);
});
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on issue #14699: error in demo
echarts-bot[bot] commented on issue #14699: URL: https://github.com/apache/echarts/issues/14699#issuecomment-821802953 Hi! We've received your issue and please be patient to get responded. 🎉 The average response time is expected to be within one day for weekdays. In the meanwhile, please make sure that **you have posted enough image to demo your request**. You may also check out the [API](http://echarts.apache.org/api.html) and [chart option](http://echarts.apache.org/option.html) to get the answer. If you don't get helped for a long time (over a week) or have an urgent question to ask, you may also send an email to d...@echarts.apache.org. Please attach the issue link if it's a technical question. If you are interested in the project, you may also subscribe our [mailing list](https://echarts.apache.org/en/maillist.html). Have a nice day! 🍵 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Muromi-Rikka opened a new issue #14699: error in demo
Muromi-Rikka opened a new issue #14699: URL: https://github.com/apache/echarts/issues/14699 ### Version 5.1.0 ### Reproduction link [https://echarts.apache.org/examples/zh/editor.html?c=map-usa](https://echarts.apache.org/examples/zh/editor.html?c=map-usa) ### Steps to reproduce ```bash Cannot read property 'getData' of undefined at e._showSeriesItemTooltip (echarts.min.js:45) at e._tryShow (echarts.min.js:45) at e. (echarts.min.js:45) at XO (echarts.min.js:45) at echarts.min.js:35 at echarts.min.js:45 at P (echarts.min.js:35) at e. (echarts.min.js:45) at e.t.trigger (echarts.min.js:35) at e.dispatchToElement (echarts.min.js:35) ``` ### What is expected? null ### What is actually happening? null -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on issue #14698: Overlapping line graph areas fight for foreground layer on mouse movement
echarts-bot[bot] commented on issue #14698: URL: https://github.com/apache/echarts/issues/14698#issuecomment-821799466 Hi! We've received your issue and please be patient to get responded. 🎉 The average response time is expected to be within one day for weekdays. In the meanwhile, please make sure that **you have posted enough image to demo your request**. You may also check out the [API](http://echarts.apache.org/api.html) and [chart option](http://echarts.apache.org/option.html) to get the answer. If you don't get helped for a long time (over a week) or have an urgent question to ask, you may also send an email to d...@echarts.apache.org. Please attach the issue link if it's a technical question. If you are interested in the project, you may also subscribe our [mailing list](https://echarts.apache.org/en/maillist.html). Have a nice day! 🍵 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Bilge opened a new issue #14698: Overlapping line graph areas fight for foreground layer on mouse movement
Bilge opened a new issue #14698: URL: https://github.com/apache/echarts/issues/14698 ### Version 5.0.2 ### Steps to reproduce 1. Draw overlapping line graphs. 2. Move mouse over overlapping area. ### What is expected? Chart should display consistently, with one line in front of the other, that does not change. ### What is actually happening? As mouse moves over the overlapping area, lines swap foreground/background layers in a pseudo-random fashion, as they fight for the foreground layer. * **Top example** is from different charting software. * **Bottom example** is ECharts 5.0.2.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Bilge opened a new issue #14697: Connected charts become disconnected when data points outside axis range
Bilge opened a new issue #14697: URL: https://github.com/apache/echarts/issues/14697 ### Version 5.1.0 ### Steps to reproduce 1. Create chart with visible data points. 2. Create connected chart with data points below the axis range (not drawn on chart). ### What is expected? Charts should always be bidirectionally connected. ### What is actually happening? Charts become unidirectionally connected if paired chart's data points are outside the axis range.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on issue #14697: Connected charts become disconnected when data points outside axis range
echarts-bot[bot] commented on issue #14697: URL: https://github.com/apache/echarts/issues/14697#issuecomment-821797978 Hi! We've received your issue and please be patient to get responded. 🎉 The average response time is expected to be within one day for weekdays. In the meanwhile, please make sure that **you have posted enough image to demo your request**. You may also check out the [API](http://echarts.apache.org/api.html) and [chart option](http://echarts.apache.org/option.html) to get the answer. If you don't get helped for a long time (over a week) or have an urgent question to ask, you may also send an email to d...@echarts.apache.org. Please attach the issue link if it's a technical question. If you are interested in the project, you may also subscribe our [mailing list](https://echarts.apache.org/en/maillist.html). Have a nice day! 🍵 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Bilge opened a new issue #14696: markLine requires symbolOffset (BC break)
Bilge opened a new issue #14696:
URL: https://github.com/apache/echarts/issues/14696
### Version
5.1.0
### Steps to reproduce
```js
series: [{
step: 'end',
data: AppCharts.dataset,
markLine: {
data: [
{
yAxis: 123,
lineStyle: {
color: '#fff3',
},
label: {
formatter: 'min\n${c}',
fontSize: 12,
color: '#677a59',
},
},
],
},
}],
```
### What is expected?
`symbolOffset` should be optional.
### What is actually happening?
`symbolOffset` is required.
> TS2322: Type '{ yAxis: number; lineStyle: { color: string; }; label: {
formatter: string; fontSize: number; color: string; }; }' is not assignable to
type 'MarkLine1DDataItemOption | MarkLine2DDataItemOption'.
Property 'symbolOffset' is missing in type '{ yAxis: number; lineStyle: {
color: string; }; label: { formatter: string; fontSize: number; color: string;
}; }' but required in type 'MarkLine1DDataItemOption'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on issue #14696: markLine requires symbolOffset (BC break)
echarts-bot[bot] commented on issue #14696: URL: https://github.com/apache/echarts/issues/14696#issuecomment-821797049 Hi! We've received your issue and please be patient to get responded. 🎉 The average response time is expected to be within one day for weekdays. In the meanwhile, please make sure that **you have posted enough image to demo your request**. You may also check out the [API](http://echarts.apache.org/api.html) and [chart option](http://echarts.apache.org/option.html) to get the answer. If you don't get helped for a long time (over a week) or have an urgent question to ask, you may also send an email to d...@echarts.apache.org. Please attach the issue link if it's a technical question. If you are interested in the project, you may also subscribe our [mailing list](https://echarts.apache.org/en/maillist.html). Have a nice day! 🍵 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Bilge opened a new issue #14695: Connected tooltip lags and glitches on paired chart
Bilge opened a new issue #14695:
URL: https://github.com/apache/echarts/issues/14695
### Version
5.1.0
### Steps to reproduce
```js
echarts.connect([chart1, chart2]);
```
### What is expected?
Tooltips animate in unison.
### What is actually happening?
The tooltip of the paired chart that the user is *not* interacting with lags
behind the one that the user *is* interacting with. In 5.1.0, it becomes even
worse, starting to "glitch out", by warping to random positions at single frame
intervals.
5.0.2 (lag)
5.1.0 (lag and glitching)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on issue #14695: Connected tooltip lags and glitches on paired chart
echarts-bot[bot] commented on issue #14695: URL: https://github.com/apache/echarts/issues/14695#issuecomment-821795457 Hi! We've received your issue and please be patient to get responded. 🎉 The average response time is expected to be within one day for weekdays. In the meanwhile, please make sure that **you have posted enough image to demo your request**. You may also check out the [API](http://echarts.apache.org/api.html) and [chart option](http://echarts.apache.org/option.html) to get the answer. If you don't get helped for a long time (over a week) or have an urgent question to ask, you may also send an email to d...@echarts.apache.org. Please attach the issue link if it's a technical question. If you are interested in the project, you may also subscribe our [mailing list](https://echarts.apache.org/en/maillist.html). Have a nice day! 🍵 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Bilge commented on issue #14690: LegendOption is missing a definition for property "icon"
Bilge commented on issue #14690: URL: https://github.com/apache/echarts/issues/14690#issuecomment-821792084 That seems like it would fix it, but I still have the problem in 5.1.0, so maybe it just hasn't been released yet? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on issue #14694: Custom 的 itemstyle 里希望也可以应用 borderRadius 属性
echarts-bot[bot] commented on issue #14694: URL: https://github.com/apache/echarts/issues/14694#issuecomment-821783519 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Uzizkp opened a new issue #14694: Custom 的 itemstyle 里希望也可以应用 borderRadius 属性
Uzizkp opened a new issue #14694: URL: https://github.com/apache/echarts/issues/14694 ### What problem does this feature solve? Im trying to draw a gant, but seems like the official documentations and examples didn't give the way to add border radius to those kind of rect, is there anyone know how to deal with it ? ### What does the proposed API look like? Itemstyle 的 borderradius 属性覆盖所有类目 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] villebro commented on pull request #14693: fix(markLine): symbolOffset incorrectly marked as mandatory
villebro commented on pull request #14693: URL: https://github.com/apache/echarts/pull/14693#issuecomment-821783271 Btw sorry for not catching this sooner! I meant to test the 5.1.0 release candidate, but I ran out of time before the vote was closed. But anyway, this is mostly a cosmetic issue, so probably not something that requires a new release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[echarts] branch master updated: fix(markLine): symbolOffset incorrectly marked as mandatory
This is an automated email from the ASF dual-hosted git repository.
wangzx pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/echarts.git
The following commit(s) were added to refs/heads/master by this push:
new 1ab33f2 fix(markLine): symbolOffset incorrectly marked as mandatory
new af367b8 Merge pull request #14693 from
preset-io/villebro/fix-markline/symbolOffset
1ab33f2 is described below
commit 1ab33f2417c6684eeac5d4d4ac92dde14341ca08
Author: Ville Brofeldt
AuthorDate: Sat Apr 17 09:03:26 2021 +0300
fix(markLine): symbolOffset incorrectly marked as mandatory
---
src/component/marker/MarkLineModel.ts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/component/marker/MarkLineModel.ts
b/src/component/marker/MarkLineModel.ts
index 4fed8c5..0c27667 100644
--- a/src/component/marker/MarkLineModel.ts
+++ b/src/component/marker/MarkLineModel.ts
@@ -61,7 +61,7 @@ export interface MarkLine1DDataItemOption extends
MarkLineDataItemOptionBase {
symbol?: string[] | string
symbolSize?: number[] | number
symbolRotate?: number[] | number
-symbolOffset: number | string | (number | string)[]
+symbolOffset?: number | string | (number | string)[]
}
// 2D markLine on any direction
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] plainheart merged pull request #14693: fix(markLine): symbolOffset incorrectly marked as mandatory
plainheart merged pull request #14693: URL: https://github.com/apache/echarts/pull/14693 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #14693: fix(markLine): symbolOffset incorrectly marked as mandatory
echarts-bot[bot] commented on pull request #14693: URL: https://github.com/apache/echarts/pull/14693#issuecomment-821783164 Congratulations! Your PR has been merged. Thanks for your contribution! 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] plainheart commented on pull request #14693: fix(markLine): symbolOffset incorrectly marked as mandatory
plainheart commented on pull request #14693: URL: https://github.com/apache/echarts/pull/14693#issuecomment-821783138 > is it ok to merge now? I think this should be okay. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] villebro commented on pull request #14693: fix(markLine): symbolOffset incorrectly marked as mandatory
villebro commented on pull request #14693: URL: https://github.com/apache/echarts/pull/14693#issuecomment-821782996 Thanks for the review @plainheart - is it ok to merge now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
