[GitHub] [incubator-echarts] susiwen8 commented on a change in pull request #12155: Fix geo don't show again when show once set false

2020-02-16 Thread GitBox 
susiwen8 commented on a change in pull request #12155: Fix geo don't show again 
when show once set false
URL: 
https://github.com/apache/incubator-echarts/pull/12155#discussion_r379911544
 
 

 ##
 File path: src/component/geo/GeoView.js
 ##
 @@ -39,12 +39,17 @@ export default echarts.extendComponentView({
 return;
 }
 
-var mapDraw = this._mapDraw;
 if (geoModel.get('show')) {
-mapDraw.draw(geoModel, ecModel, api, this, payload);
+if (this._mapDraw.hasDraw) {
+this._mapDraw.group.show();
+}
+else {
+this._mapDraw.draw(geoModel, ecModel, api, this, payload);
 
 Review comment:
   Oh yeah, That make sense, because it was removed, so we need to create a new 
one


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org

[GitHub] [incubator-echarts] susiwen8 commented on a change in pull request #12155: Fix geo don't show again when show once set false

2020-02-16 Thread GitBox 
susiwen8 commented on a change in pull request #12155: Fix geo don't show again 
when show once set false
URL: 
https://github.com/apache/incubator-echarts/pull/12155#discussion_r379911325
 
 

 ##
 File path: src/component/geo/GeoView.js
 ##
 @@ -39,12 +39,17 @@ export default echarts.extendComponentView({
 return;
 }
 
-var mapDraw = this._mapDraw;
 if (geoModel.get('show')) {
-mapDraw.draw(geoModel, ecModel, api, this, payload);
+if (this._mapDraw.hasDraw) {
+this._mapDraw.group.show();
+}
+else {
+this._mapDraw.draw(geoModel, ecModel, api, this, payload);
 
 Review comment:
   That means we should call `new MapDraw` on every update?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org