[GitHub] [echarts] tmscer commented on issue #14689: Using sampling with connectNulls connects regular datapoints with null ones when zoomed out

2022-01-23 Thread GitBox


tmscer commented on issue #14689:
URL: https://github.com/apache/echarts/issues/14689#issuecomment-1019548153


   > Seems it's because the null values are filtered during sampling
   
   An idea: a null value should then split the dataseries into separate chunks 
that can be then sampled separately.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [echarts] tmscer commented on issue #14689: Using sampling with connectNulls connects regular datapoints with null ones when zoomed out

2021-10-01 Thread GitBox


tmscer commented on issue #14689:
URL: https://github.com/apache/echarts/issues/14689#issuecomment-932027460


   @Ovilia.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [echarts] tmscer commented on issue #14689: Using sampling with connectNulls connects regular datapoints with null ones when zoomed out

2021-09-01 Thread GitBox


tmscer commented on issue #14689:
URL: https://github.com/apache/echarts/issues/14689#issuecomment-910128820


   I see that `5.2.0` has been released, should the milestone be updated or is 
it possible that this bug will be fixed in some `5.2.x`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [echarts] tmscer commented on issue #14689: Using sampling with connectNulls connects regular datapoints with null ones when zoomed out

2021-04-22 Thread GitBox


tmscer commented on issue #14689:
URL: https://github.com/apache/echarts/issues/14689#issuecomment-825381533


   I've simplified the example. I removed as much as possible, however, to see 
the bug, some data (~1600 datapoints) is left in the example to actually see 
the bug. See https://codepen.io/tmscer/pen/yLgGXbo.
   
   There is a `null` value on line 634 with which other datapoints shouldn't be 
connected. I suspect sampling may play a role since once removed, the null 
value is no longer connected. Zooming, as per issue's first comment, 
disconnects the `null` datapoint.
   
   Let me know if the demo is simple enough. But I am afraid that further 
significant simplification isn't possible.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [echarts] tmscer commented on issue #14689: Using sampling with connectNulls connects

2021-04-16 Thread GitBox


tmscer commented on issue #14689:
URL: https://github.com/apache/echarts/issues/14689#issuecomment-821461042


   ## Images
   
   ### When zoomed out
   
![2021-04-16_20-45-59](https://user-images.githubusercontent.com/7033199/115070165-dbb1bf00-9ef4-11eb-8141-6a3940ac8d90.png)
   
   ### When zoomed in
   
![2021-04-16_20-46-07](https://user-images.githubusercontent.com/7033199/115070198-e8ceae00-9ef4-11eb-9a46-f6091162841c.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org