[GitHub] [echarts] villebro commented on issue #14684: Please add support for slice visibility threshold in Pie Chart
villebro commented on issue #14684: URL: https://github.com/apache/echarts/issues/14684#issuecomment-826046259 I set out to implement `labelThreshold`, and when I started adding the code I found `minShowLabelAngle` which essentially does this (it just needs to be converted from percentages to angles). So this feature already exists. Next I'll work on adding slice grouping (the "other" slice for slices that fall below a predefined threshold) as discussed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] villebro commented on issue #14684: Please add support for slice visibility threshold in Pie Chart
villebro commented on issue #14684: URL: https://github.com/apache/echarts/issues/14684#issuecomment-826046259 I set out to implement `labelThreshold`, and when I started adding the code I found `minShowLabelAngle` which essentially does this (it just needs to be converted from percentages to angles). So this feature already exists. Next I'll work on adding slice grouping (the "other" slice for slices that fall below a predefined threshold) as discussed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] villebro commented on issue #14684: Please add support for slice visibility threshold in Pie Chart
villebro commented on issue #14684: URL: https://github.com/apache/echarts/issues/14684#issuecomment-820957191 > Another consideration is, should `"The others"` slice have a special color (gray?) or use the color palette by default? > Tooltip and legend should also be taken care of. I think it could default to grey or some other "downgraded" color, of course with the option to define a custom one. Regarding tooltip/legend, we can experiment with different options and see what looks best (we can potentially ask our design team to come up with a few suggestions if you'd like). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] villebro commented on issue #14684: Please add support for slice visibility threshold in Pie Chart
villebro commented on issue #14684: URL: https://github.com/apache/echarts/issues/14684#issuecomment-820951680 > @villebro I think there may also be cases where slices should be merged if the slice amount reachs a threshold. For example, if data values could be `8%, 7%, 7.2%, 7.1%, 6.4%, ...` or `53%, 4%, 3.2%, ` and the developer may not have a clue to how these values distribute, it may not be a good idea to set a value threshold in this case. In stead, a slice amount threshold is more helpful. For example, we can show the largest 5 slices and merge the others. I think maybe both the policy should be provided. Your PR may not implement them both, but should give the consideration of API design for such future features. Excellent point @Ovilia , and now that you mention it, actually something I've run into. > Or, would it be helpful if we provide a `mergePolicy` callback to let developers decide how slices should be merged? Yes, this is an even better design, as it will make it easy to customize. I'll start working on a callback based approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] villebro commented on issue #14684: Please add support for slice visibility threshold in Pie Chart
villebro commented on issue #14684: URL: https://github.com/apache/echarts/issues/14684#issuecomment-820939155 It could be nice to have to options: - `labelThreshold`: minimum threshold that determines which labels and label lines should be drawn. Similar to the `labelThreshold` property on NVD3 Pie Chart: https://nvd3.org/examples/pie.html - `sliceThreshold`: minimum threshold that determines which slices should be drawn as separate slices and which should be grouped into an "Other" category. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
