[GitHub] [incubator-echarts] Ovilia commented on pull request #12859: feat: time axis label formatter

2020-07-21 Thread GitBox
Ovilia commented on pull request #12859: URL: https://github.com/apache/incubator-echarts/pull/12859#issuecomment-661758950 Most of the functions above have been implemented, but not *week of year*. Leaving it for another PR.

[GitHub] [incubator-echarts] Ovilia commented on pull request #12859: feat: time axis label formatter

2020-07-09 Thread GitBox
Ovilia commented on pull request #12859: URL: https://github.com/apache/incubator-echarts/pull/12859#issuecomment-655951837 @100pah I think that makes sense. `一、二` should take `ee` if we have future feature requests. This

[GitHub] [incubator-echarts] Ovilia commented on pull request #12859: feat: time axis label formatter

2020-07-09 Thread GitBox
Ovilia commented on pull request #12859: URL: https://github.com/apache/incubator-echarts/pull/12859#issuecomment-655945171 @quillblue Thanks for your comments. Here are my thoughts on this. ## Primary & Secondary Ticks I think secondary ticks may not be a minor tick.