leeoniya commented on pull request #13314:
URL:
https://github.com/apache/incubator-echarts/pull/13314#issuecomment-699704516
thanks @pissang
would you like to submit a PR to the uPlot repo for the implementation
improvements as well as bumping the echarts lib when the next alpha
leeoniya commented on pull request #13314:
URL:
https://github.com/apache/incubator-echarts/pull/13314#issuecomment-695785582
This is an automated message from the Apache Git Service.
To respond to the message, please log on
leeoniya commented on pull request #13314:
URL:
https://github.com/apache/incubator-echarts/pull/13314#issuecomment-695890304
thanks for the detailed reply. i agree that exceeding the local extremes is
a worse outcome than a more "S" shaped creative interpolation between
datapoints.
leeoniya commented on pull request #13314:
URL:
https://github.com/apache/incubator-echarts/pull/13314#issuecomment-695785582
> I'm not sure if you did any modification on the original Catmull-Rom
Spline algorithm.
i simply adjusted the algo for the uPlot demo from this gist:
leeoniya commented on pull request #13314:
URL:
https://github.com/apache/incubator-echarts/pull/13314#issuecomment-695746133
also, your smoothing does not represent the data well. take a look at using
the Catmull-Rom Spline (Centripetal) algo:
leeoniya commented on pull request #13314:
URL:
https://github.com/apache/incubator-echarts/pull/13314#issuecomment-695745867
wow, this is super exciting. can't wait to test this improvement on the
uPlot benchmark!
https://github.com/leeoniya/uPlot#performance
a 10x
