liulinboyi commented on pull request #12834:
URL:
https://github.com/apache/incubator-echarts/pull/12834#issuecomment-647934695
> Seems there are still two request changes from @plainheart @susiwen8 need
to be resolved before this PR can ben merged
@pissang All request changes are
liulinboyi commented on pull request #12834:
URL:
https://github.com/apache/incubator-echarts/pull/12834#issuecomment-647916698
> Perhaps the `_moveTooltip` can be renamed to a more specific name like
`_moveTooltipIfResized`
>
> Others all look good to me. Thanks for the wonderful
liulinboyi commented on pull request #12834:
URL:
https://github.com/apache/incubator-echarts/pull/12834#issuecomment-647901046
> Perhaps the `_moveTooltip` can be renamed to a more specific name like
`_moveTooltipIfResized`
>
> Others all look good to me. Thanks for the wonderful
liulinboyi commented on pull request #12834:
URL:
https://github.com/apache/incubator-echarts/pull/12834#issuecomment-647495244
> @liulinboyi Would you mind providing a test case for this?
@plainheart Test case is done, Please help review, thanks!
liulinboyi commented on pull request #12834:
URL:
https://github.com/apache/incubator-echarts/pull/12834#issuecomment-647399422
> @liulinboyi Would you mind providing a test case for this?
Let me have a try.
This is
liulinboyi commented on pull request #12834:
URL:
https://github.com/apache/incubator-echarts/pull/12834#issuecomment-647362101
> Finally, the same changes should be applied to `TooltipRichContent`, which
will be used when
liulinboyi commented on pull request #12834:
URL:
https://github.com/apache/incubator-echarts/pull/12834#issuecomment-647333159
> Finally, the same changes should be applied to `TooltipRichContent`, which
will be used when
liulinboyi commented on pull request #12834:
URL:
https://github.com/apache/incubator-echarts/pull/12834#issuecomment-647288842
@plainheart All the problems are solved, Please help review, thanks!
This is an automated
liulinboyi commented on pull request #12834:
URL:
https://github.com/apache/incubator-echarts/pull/12834#issuecomment-647268371
> Why hide tooltip rather than relocate it to the proper coordinate?
> And I think doing it here is a bit inappropriate.
@plainheart The effect is as
liulinboyi commented on pull request #12834:
URL:
https://github.com/apache/incubator-echarts/pull/12834#issuecomment-647263289
> Why hide tooltip rather than relocate it to the proper coordinate?
> And I think doing it here is a bit inappropriate.
Let me have a try.
10 matches
Mail list logo
