plainheart commented on a change in pull request #13084:
URL:
https://github.com/apache/incubator-echarts/pull/13084#discussion_r466182308
##########
File path: src/chart/bar/BarView.js
##########
@@ -182,13 +187,19 @@ export default echarts.extendChartView({
var layout = getLayout[coord.type](data, newIndex, itemModel);
if (drawBackground) {
- var bgEl = oldBgEls[oldIndex];
- bgEl.useStyle(backgroundModel.getBarItemStyle());
- // Only cartesian2d support borderRadius.
- if (coord.type === 'cartesian2d') {
- bgEl.setShape('r', barBorderRadius);
+ var bgEl;
+ if (oldBgEls.length === 0) {
+ bgEl = createBackground(oldIndex);
+ }
+ else {
+ var bgEl = oldBgEls[oldIndex];
Review comment:
```suggestion
bgEl = oldBgEls[oldIndex];
```
The `var` should be removed, otherwise, it may lead to an error after
confusion and compression.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
