[GitHub] [incubator-echarts] plainheart commented on pull request #12834: fix: #12812

2020-06-23 Thread GitBox
plainheart commented on pull request #12834: URL: https://github.com/apache/incubator-echarts/pull/12834#issuecomment-647964829 > > Seems there are still two request changes from @plainheart @susiwen8 need to be resolved before this PR can ben merged > > @pissang All request changes

[GitHub] [incubator-echarts] plainheart commented on pull request #12834: fix: #12812

2020-06-22 Thread GitBox
plainheart commented on pull request #12834: URL: https://github.com/apache/incubator-echarts/pull/12834#issuecomment-647395874 @liulinboyi Would you mind providing a test case for this? This is an automated message from the

[GitHub] [incubator-echarts] plainheart commented on pull request #12834: fix: #12812

2020-06-22 Thread GitBox
plainheart commented on pull request #12834: URL: https://github.com/apache/incubator-echarts/pull/12834#issuecomment-647394300 @liulinboyi Thank you, great work! All looks good to me now, please @pissang have a look. This

[GitHub] [incubator-echarts] plainheart commented on pull request #12834: fix: #12812

2020-06-21 Thread GitBox
plainheart commented on pull request #12834: URL: https://github.com/apache/incubator-echarts/pull/12834#issuecomment-647309247 Finally, the same changed should be applied to `TooltipRichContent`, which will be used when [`renderMode`](https://echarts.apache.org/en/option.html#tooltip.ren

[GitHub] [incubator-echarts] plainheart commented on pull request #12834: fix: #12812

2020-06-21 Thread GitBox
plainheart commented on pull request #12834: URL: https://github.com/apache/incubator-echarts/pull/12834#issuecomment-647208160 Why hide tooltip rather than relocate it to the proper coordinate? And I think doing it here is a bit inappropriate. -