[GitHub] [incubator-echarts] susiwen8 commented on a change in pull request #13210: Feat: multiple value axis alignment

2020-09-25 Thread GitBox
susiwen8 commented on a change in pull request #13210: URL: https://github.com/apache/incubator-echarts/pull/13210#discussion_r494289507 ## File path: src/coord/cartesian/Grid.ts ## @@ -85,18 +86,68 @@ class Grid implements CoordinateSystemMaster { return this._rect;

[GitHub] [incubator-echarts] susiwen8 commented on a change in pull request #13210: Feat: multiple value axis alignment

2020-09-24 Thread GitBox
susiwen8 commented on a change in pull request #13210: URL: https://github.com/apache/incubator-echarts/pull/13210#discussion_r494289507 ## File path: src/coord/cartesian/Grid.ts ## @@ -85,18 +86,68 @@ class Grid implements CoordinateSystemMaster { return this._rect;

[GitHub] [incubator-echarts] susiwen8 commented on a change in pull request #13210: Feat: multiple value axis alignment

2020-09-22 Thread GitBox
susiwen8 commented on a change in pull request #13210: URL: https://github.com/apache/incubator-echarts/pull/13210#discussion_r492436816 ## File path: src/component/axis/AxisBuilder.ts ## @@ -372,7 +372,7 @@ const builders: Record<'axisLine' | 'axisTickLabel' | 'axisName',

[GitHub] [incubator-echarts] susiwen8 commented on a change in pull request #13210: Feat: multiple value axis alignment

2020-09-21 Thread GitBox
susiwen8 commented on a change in pull request #13210: URL: https://github.com/apache/incubator-echarts/pull/13210#discussion_r492436816 ## File path: src/component/axis/AxisBuilder.ts ## @@ -372,7 +372,7 @@ const builders: Record<'axisLine' | 'axisTickLabel' | 'axisName',

[GitHub] [incubator-echarts] susiwen8 commented on a change in pull request #13210: Feat: multiple value axis alignment

2020-09-21 Thread GitBox
susiwen8 commented on a change in pull request #13210: URL: https://github.com/apache/incubator-echarts/pull/13210#discussion_r492436816 ## File path: src/component/axis/AxisBuilder.ts ## @@ -372,7 +372,7 @@ const builders: Record<'axisLine' | 'axisTickLabel' | 'axisName',

[GitHub] [incubator-echarts] susiwen8 commented on a change in pull request #13210: Feat: multiple value axis alignment

2020-09-21 Thread GitBox
susiwen8 commented on a change in pull request #13210: URL: https://github.com/apache/incubator-echarts/pull/13210#discussion_r492437140 ## File path: src/component/axis/AxisBuilder.ts ## @@ -372,7 +372,7 @@ const builders: Record<'axisLine' | 'axisTickLabel' | 'axisName',

[GitHub] [incubator-echarts] susiwen8 commented on a change in pull request #13210: Feat: multiple value axis alignment

2020-09-21 Thread GitBox
susiwen8 commented on a change in pull request #13210: URL: https://github.com/apache/incubator-echarts/pull/13210#discussion_r492436816 ## File path: src/component/axis/AxisBuilder.ts ## @@ -372,7 +372,7 @@ const builders: Record<'axisLine' | 'axisTickLabel' | 'axisName',