This is an automated email from the ASF dual-hosted git repository.
shenyi pushed a commit to branch test-autorun
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git
The following commit(s) were added to refs/heads/test-autorun by this push:
new 1e3a730 test: add --no-save in the puppeteer install hint. add
preview dialog.
1e3a730 is described below
commit 1e3a730f5d252d8db014a52c8818bf727b475e0e
Author: pissang <bm2736...@gmail.com>
AuthorDate: Thu Sep 12 17:05:02 2019 +0800
test: add --no-save in the puppeteer install hint. add preview dialog.
---
.github/CONTRIBUTING.md | 2 +-
test/runTest/client/index.html | 5 ++++-
test/runTest/server.js | 2 +-
3 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md
index f8912b8..f22526b 100644
--- a/.github/CONTRIBUTING.md
+++ b/.github/CONTRIBUTING.md
@@ -107,7 +107,7 @@ Then, open the test cases under `~/workspace/echarts/test`
in Web browser. You c
```bash
# puppeteer is not in the devDependencies and needs to be installed manually
-npm install puppeteer
+npm install puppeteer --no-save
npm run test:visual
```
diff --git a/test/runTest/client/index.html b/test/runTest/client/index.html
index b077070..2d94b97 100644
--- a/test/runTest/client/index.html
+++ b/test/runTest/client/index.html
@@ -233,9 +233,12 @@ under the License.
<el-dialog
:visible.sync="showIframeDialog"
:center="true"
- :title="previewTitle"
width="850px"
>
+ <div slot="title">
+ {{previewTitle}}
+ <a target="_blank" :href="'../../' + previewTitle"><i
class="el-icon-link"></i>Open in New Window</a>
+ </div>
<iframe :src="previewIframeSrc" width="800"
height="600"></iframe>
</el-dialog>
</el-main>
diff --git a/test/runTest/server.js b/test/runTest/server.js
index 554f591..565cb21 100644
--- a/test/runTest/server.js
+++ b/test/runTest/server.js
@@ -184,7 +184,7 @@ function checkPuppeteer() {
async function start() {
if (!checkPuppeteer()) {
// TODO Check version.
- console.error(`Can't find puppeteer >= 1.19.0, use 'npm install
puppeteer' to install or update`);
+ console.error(`Can't find puppeteer >= 1.19.0, use 'npm install
puppeteer --no-save' to install or update`);
return;
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
