vorburger commented on issue #629: Swagger documentation gsoc2019
URL: https://github.com/apache/fineract/pull/629#issuecomment-574047849
/rebase
This is an automated message from the Apache Git Service.
To respond to the mess
vorburger commented on a change in pull request #629: Swagger documentation
gsoc2019
URL: https://github.com/apache/fineract/pull/629#discussion_r366189471
##
File path:
fineract-provider/src/main/java/org/apache/fineract/portfolio/floatingrates/api/FloatingRatesApiResource.java
#
vorburger commented on a change in pull request #629: Swagger documentation
gsoc2019
URL: https://github.com/apache/fineract/pull/629#discussion_r366188664
##
File path: fineract-provider/build.gradle
##
@@ -59,6 +60,8 @@ apply plugin: 'eclipse'
apply plugin: 'idea'
appl
This is an automated email from the ASF dual-hosted git repository.
vorburger pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git
The following commit(s) were added to refs/heads/develop by this push:
new 653b0b7 add /rebase comment support for
vorburger commented on issue #691: add /rebase comment support for Pull Requests
URL: https://github.com/apache/fineract/pull/691#issuecomment-574045294
self merging this one based on @awasum comment in #692 ("no experience with
Github Actions. Merge when you feel comfortable with this.") -
vorburger merged pull request #691: add /rebase comment support for Pull
Requests
URL: https://github.com/apache/fineract/pull/691
This is an automated message from the Apache Git Service.
To respond to the message, please l
awasum commented on issue #688: clean up all whitespace issues in Java files
(FINERACT-821)
URL: https://github.com/apache/fineract/pull/688#issuecomment-574044939
> > Makes sense. Go for it.
>
> but I'm waiting for you to review and hopefully merge #684 and #685 ...
I think y
awasum merged pull request #685: clean up GLAccountBuilder, following SpotBugs
(FINERACT-702)
URL: https://github.com/apache/fineract/pull/685
This is an automated message from the Apache Git Service.
To respond to the mes
This is an automated email from the ASF dual-hosted git repository.
awasum pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git
The following commit(s) were added to refs/heads/develop by this push:
new a5c60b0 clean up GLAccountBuilder, followin
This is an automated email from the ASF dual-hosted git repository.
awasum pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git
The following commit(s) were added to refs/heads/develop by this push:
new 6ca1a67 more SpotBugs related / inspired co
awasum merged pull request #684: more SpotBugs related / inspired code clean
up (see FINERACT-702)
URL: https://github.com/apache/fineract/pull/684
This is an automated message from the Apache Git Service.
To respond to th
awasum commented on issue #685: clean up GLAccountBuilder, following SpotBugs
(FINERACT-702)
URL: https://github.com/apache/fineract/pull/685#issuecomment-574044586
This looks good merging now.
This is an automated message
awasum commented on issue #691: add /rebase comment support for Pull Requests
URL: https://github.com/apache/fineract/pull/691#issuecomment-574043551
@vorburger Do we need this documented somewhere on the readme. It can be
done after this has been merged if you want. Looks like just writing
vorburger commented on issue #688: clean up all whitespace issues in Java files
(FINERACT-821)
URL: https://github.com/apache/fineract/pull/688#issuecomment-574043410
> Makes sense. Go for it.
but I'm waiting for you to review and hopefully merge #684 and #685 ...
:smiley:
---
awasum commented on issue #688: clean up all whitespace issues in Java files
(FINERACT-821)
URL: https://github.com/apache/fineract/pull/688#issuecomment-574042839
> @awasum I'll fix the Merge Conflicts on this one **AFTER** my other work
in #684 and #685 has been reviewed and merged. (I e
This is an automated email from the ASF dual-hosted git repository.
vorburger pushed a change to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git.
from 54b7ddf add GitHub Action to autoclose stale pull requests
add efb0a55 FINERACT-824: Removed the second
vorburger merged pull request #683: FINERACT-824: NullPointerException is
thrown when submitting a loan account application with an existing externalId
URL: https://github.com/apache/fineract/pull/683
This is an automated me
vorburger merged pull request #692: add GitHub Action to autoclose stale pull
requests
URL: https://github.com/apache/fineract/pull/692
This is an automated message from the Apache Git Service.
To respond to the message, ple
This is an automated email from the ASF dual-hosted git repository.
vorburger pushed a change to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git.
from 0379ba7 fix build.gradle for RAT to ignore .github/workflows/
add 54b7ddf add GitHub Action to autoclose
vorburger commented on issue #688: clean up all whitespace issues in Java files
(FINERACT-821)
URL: https://github.com/apache/fineract/pull/688#issuecomment-574040714
@awasum I'll fix the Merge Conflicts on this one **AFTER** my other work in
#684 and #685 has been reviewed and merged. (I
awasum commented on issue #629: Swagger documentation gsoc2019
URL: https://github.com/apache/fineract/pull/629#issuecomment-574038079
@Sanyam96 , @vorburger , Seems conflicts are now fixed by @kangbreder and
Travis is passing. Merge this when yo feel comfortable... instead create more
is
awasum commented on issue #592: FINERACT-614: Rates Module
URL: https://github.com/apache/fineract/pull/592#issuecomment-574036658
@angelboxes , we now have spotbugs enabled for Fineract. So check to make
sure your changes do not fail spotbug rules. See #670 #673
Fineract has also
This is an automated email from the ASF dual-hosted git repository.
angelboxes pushed a change to branch Fineract-614
in repository https://gitbox.apache.org/repos/asf/fineract.git.
from bf0393b Fixing some code to be compatible with Spring update
add 565999a Fineract-614: Renaming SQ
This is an automated email from the ASF dual-hosted git repository.
angelboxes pushed a change to branch Fineract-614
in repository https://gitbox.apache.org/repos/asf/fineract.git.
discard 867e7e1 Merge branch 'develop' into Fineract-614
discard c66c55f FINERACT-737: Updated Api Docs to inc
awasum commented on issue #692: add GitHub Action to autoclose stale pull
requests
URL: https://github.com/apache/fineract/pull/692#issuecomment-573834932
> @awasum and anyone else reading this, how about adding this?
This makes sense to have a 60 day auto close rule. I have no exper
vorburger commented on issue #664:
FINERACT-802-restrict-client-to-have-single-self-service-user
URL: https://github.com/apache/fineract/pull/664#issuecomment-573794166
jamesidw@ yes sorry you are absolutely correct of course... ;-)
aimanoj@ will you rebase and resolve conflicts for
vorburger commented on issue #592: FINERACT-614: Rates Module
URL: https://github.com/apache/fineract/pull/592#issuecomment-573793341
> Ok, I will rebase the branch with dev. No problem
@angelboxes were you still planning to do that? Just asking. If not, would
you like to close this
vorburger closed pull request #692: add GitHub Action to autoclose stale pull
requests
URL: https://github.com/apache/fineract/pull/692
This is an automated message from the Apache Git Service.
To respond to the message, ple
vorburger opened a new pull request #692: add GitHub Action to autoclose stale
pull requests
URL: https://github.com/apache/fineract/pull/692
It will automatically add a comment after 30 days, and then another 30 days
later (so after a total of 60 days of inactivity) automatically close Pu
vorburger commented on issue #692: add GitHub Action to autoclose stale pull
requests
URL: https://github.com/apache/fineract/pull/692#issuecomment-573791466
The test build failure seen here seems arbitrary, I've created
[FINERACT-828](https://issues.apache.org/jira/browse/FINERACT-828), l
vorburger opened a new pull request #684: more SpotBugs related / inspired
code clean up (see FINERACT-702)
URL: https://github.com/apache/fineract/pull/684
based upon code review of changes made by @awasum in previous commit:
- fix clear contains() GC_UNRELATED_TYPES bug in Loan
vorburger opened a new pull request #685: clean up GLAccountBuilder, following
SpotBugs (FINERACT-702)
URL: https://github.com/apache/fineract/pull/685
This is an automated message from the Apache Git Service.
To respond t
vorburger closed pull request #684: more SpotBugs related / inspired code
clean up (see FINERACT-702)
URL: https://github.com/apache/fineract/pull/684
This is an automated message from the Apache Git Service.
To respond to
vorburger closed pull request #685: clean up GLAccountBuilder, following
SpotBugs (FINERACT-702)
URL: https://github.com/apache/fineract/pull/685
This is an automated message from the Apache Git Service.
To respond to the
jamesidw commented on issue #664:
FINERACT-802-restrict-client-to-have-single-self-service-user
URL: https://github.com/apache/fineract/pull/664#issuecomment-573663057
@aimanoj I believe that should have been directed at you (since this PR
comes from your repository)
@vorburger Don't th
This is an automated email from the ASF dual-hosted git repository.
vorburger pushed a change to branch vorburger-slash-rebase-pr-comment-action
in repository https://gitbox.apache.org/repos/asf/fineract.git.
discard aa310aa add /rebase comment support for Pull Requests
add 0379ba7 fix b
vorburger commented on issue #692: add GitHub Action to autoclose stale pull
requests
URL: https://github.com/apache/fineract/pull/692#issuecomment-573563316
@awasum and anyone else reading this, how about adding this?
This i
This is an automated email from the ASF dual-hosted git repository.
vorburger pushed a change to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git.
from 7420545 Merge pull request #690 from
vorburger/FINERACT-773_fix-docker-compose
add 0379ba7 fix build.gr
This is an automated email from the ASF dual-hosted git repository.
vorburger pushed a change to branch vorburger-stale-action
in repository https://gitbox.apache.org/repos/asf/fineract.git.
discard a8c0e97 add GitHub Action to autoclose stale pull requests
add 0379ba7 fix build.gradle f
vorburger merged pull request #693: fix build.gradle for RAT to ignore
.github/workflows/
URL: https://github.com/apache/fineract/pull/693
This is an automated message from the Apache Git Service.
To respond to the message,
vorburger commented on issue #691: add /rebase comment support for Pull Requests
URL: https://github.com/apache/fineract/pull/691#issuecomment-573554719
#693 will fix the build failure seen here
This is an automated message fr
vorburger commented on issue #684: more SpotBugs related / inspired code clean
up (see FINERACT-702)
URL: https://github.com/apache/fineract/pull/684#issuecomment-573551071
@awasum this now passed the build (because it's Monday), and is finished and
ready from my side.
Will you re
vorburger opened a new pull request #692: add GitHub Action to autoclose stale
pull requests
URL: https://github.com/apache/fineract/pull/692
It will automatically add a comment after 30 days, and then another 30 days
later (so after a total of 60 days of inactivity) automatically close Pu
This is an automated email from the ASF dual-hosted git repository.
nazeer1100126 pushed a change to annotated tag release-1.4.0
in repository https://gitbox.apache.org/repos/asf/fineract.git.
at 5d9773d (tag)
tagging 7420545d8f9c35276954def94a58800b29bdde93 (commit)
replaces 1.3.0
This is an automated email from the ASF dual-hosted git repository.
nazeer1100126 pushed a change to branch 1.4.0
in repository https://gitbox.apache.org/repos/asf/fineract.git.
at 7420545 Merge pull request #690 from
vorburger/FINERACT-773_fix-docker-compose
No new revisions were added
This is an automated email from the ASF dual-hosted git repository.
vorburger pushed a commit to branch vorburger-stale-action
in repository https://gitbox.apache.org/repos/asf/fineract.git
commit a8c0e97217616175a7a8f54ae598701115d99a46
Author: Michael Vorburger ⛑️
AuthorDate: Mon Jan 13 09:13:
This is an automated email from the ASF dual-hosted git repository.
vorburger pushed a change to branch vorburger-stale-action
in repository https://gitbox.apache.org/repos/asf/fineract.git.
at a8c0e97 add GitHub Action to autoclose stale pull requests
This branch includes the following
This is an automated email from the ASF dual-hosted git repository.
vorburger pushed a change to branch vorburger-slash-rebase-pr-comment-action
in repository https://gitbox.apache.org/repos/asf/fineract.git.
discard ad56f0d add /rebase comment support for Pull Requests
add aa310aa add /
48 matches
Mail list logo