github-actions[bot] commented on pull request #1368:
URL: https://github.com/apache/fineract/pull/1368#issuecomment-721445788
This pull request seems to be stale. Are you still planning to work on it?
We will automatically close it in 30 days.
vidakovic edited a comment on pull request #1490:
URL: https://github.com/apache/fineract/pull/1490#issuecomment-720384580
@vorburger I might have created a duplicate PR #1492. At least partially...
I've also cleaned up the test dependencies in fineract-provider. So maybe we
can merge it
vorburger edited a comment on pull request #1486:
URL: https://github.com/apache/fineract/pull/1486#issuecomment-720368347
FTR: The build on this was green, but it needed a rebase following #1465...
hopefully still green now.
vidakovic commented on pull request #1468:
URL: https://github.com/apache/fineract/pull/1468#issuecomment-720404268
@vorburger #1465 and #1489 are included here. Just waiting for the build to
finish...
This is an automated
vorburger commented on pull request #1491:
URL: https://github.com/apache/fineract/pull/1491#issuecomment-720365957
@vidakovic how about this?
This is an automated message from the Apache Git Service.
To respond to the
vidakovic merged pull request #1489:
URL: https://github.com/apache/fineract/pull/1489
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
vidakovic commented on pull request #1491:
URL: https://github.com/apache/fineract/pull/1491#issuecomment-720387657
@vorburger I just ran tests locally for fineract-provider and it was
complaining about the missing restassured dependencies. Other than that I think
this is good.
vorburger commented on pull request #1492:
URL: https://github.com/apache/fineract/pull/1492#issuecomment-720385000
Oups, we overlapped, sorry; see also #1490 & #1491.
This is an automated message from the Apache Git
vidakovic edited a comment on pull request #1491:
URL: https://github.com/apache/fineract/pull/1491#issuecomment-720387657
@vorburger I just ran tests locally for fineract-provider and it was
complaining about the missing restassured dependencies. Other than that I think
this is good.
fynmanoj commented on pull request #1486:
URL: https://github.com/apache/fineract/pull/1486#issuecomment-720876811
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
vidakovic commented on pull request #1490:
URL: https://github.com/apache/fineract/pull/1490#issuecomment-720384580
@vorburger I might have created a duplicate PR #1492. Feel free to close it
if not needed anymore. Just FYI.
vidakovic closed pull request #1492:
URL: https://github.com/apache/fineract/pull/1492
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
fynmanoj commented on pull request #1488:
URL: https://github.com/apache/fineract/pull/1488#issuecomment-72084
@vorburger, sure. kindly drop me a comment here once #1486 is merged. I
shall re work on this PR
vorburger merged pull request #1468:
URL: https://github.com/apache/fineract/pull/1468
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
vorburger merged pull request #1465:
URL: https://github.com/apache/fineract/pull/1465
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
vorburger opened a new pull request #1490:
URL: https://github.com/apache/fineract/pull/1490
because https://github.com/apache/fineract/pull/1477/files
moved this from fineract-provider/build.gradle to the root ./build.gradle
so it's inherited.
vorburger commented on pull request #1490:
URL: https://github.com/apache/fineract/pull/1490#issuecomment-720351267
@vidakovic my Gradle foo isn't as strong as yours smile but isn't this from
1465 "inherited" from the root build.gradle, after (my) #1477?
Nota bene I have **NOT**
vorburger commented on a change in pull request #1465:
URL: https://github.com/apache/fineract/pull/1465#discussion_r515821598
##
File path: integration-tests/build.gradle
##
@@ -0,0 +1,73 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
vorburger commented on pull request #1487:
URL: https://github.com/apache/fineract/pull/1487#issuecomment-720329525
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
vidakovic merged pull request #1490:
URL: https://github.com/apache/fineract/pull/1490
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
avikganguly01 commented on pull request #1488:
URL: https://github.com/apache/fineract/pull/1488#issuecomment-720989585
@fynmanoj : Michael's PR merged.
This is an automated message from the Apache Git Service.
To respond to
vidakovic merged pull request #1487:
URL: https://github.com/apache/fineract/pull/1487
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
avikganguly01 merged pull request #1486:
URL: https://github.com/apache/fineract/pull/1486
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
vidakovic commented on a change in pull request #1465:
URL: https://github.com/apache/fineract/pull/1465#discussion_r515826451
##
File path: integration-tests/build.gradle
##
@@ -0,0 +1,73 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
vidakovic merged pull request #1491:
URL: https://github.com/apache/fineract/pull/1491
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
vidakovic edited a comment on pull request #1492:
URL: https://github.com/apache/fineract/pull/1492#issuecomment-720385874
Yup, I've put a comment on your PR. We can merge yours first and then this
one (to cleanup fineract-provider test dependencies too).
Update: let's close this
vorburger commented on pull request #1486:
URL: https://github.com/apache/fineract/pull/1486#issuecomment-720368347
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
avikganguly01 commented on a change in pull request #1486:
URL: https://github.com/apache/fineract/pull/1486#discussion_r516501351
##
File path:
integration-tests/src/test/java/org/apache/fineract/integrationtests/HookIntegrationTest.java
##
@@ -98,12 +93,11 @@ public void
vidakovic commented on pull request #1492:
URL: https://github.com/apache/fineract/pull/1492#issuecomment-720385874
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
vorburger commented on a change in pull request #1486:
URL: https://github.com/apache/fineract/pull/1486#discussion_r516484425
##
File path:
fineract-provider/src/main/java/org/apache/fineract/infrastructure/hooks/service/HookWritePlatformServiceJpaRepositoryImpl.java
##
@@
vidakovic opened a new pull request #1492:
URL: https://github.com/apache/fineract/pull/1492
## Description
As discussed on FINERACT-1247. Removed unnecessary test dependencies from
"fineract-provider", and "integration-tests" build.gradle test configuration is
"trimmed".
This is an automated email from the ASF dual-hosted git repository.
avikg pushed a change to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git.
from 26cd903 Test downloaded file name (FINERACT-1218)
add 7b34e83 Bump ancient OkHTTP & Retrofit in Hooks
32 matches
Mail list logo
