vidakovic opened a new pull request #2038:
URL: https://github.com/apache/fineract/pull/2038
## Description
- Spring Boot 2.6.3
- Spring 5.3.16
- Gradle 7.4
- JUnit 5.8.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
sandeepsoni911 commented on pull request #2034:
URL: https://github.com/apache/fineract/pull/2034#issuecomment-1045945608
@ptuomola : Hi i have squashed my commit to 1 commit, I should have done
that earlier but forgot to do same. Requesting you to review and merge the
same. Thank you
vidakovic commented on pull request #2037:
URL: https://github.com/apache/fineract/pull/2037#issuecomment-1045938633
@ptuomola ... would be great if you could review this until Monday... you
can quickly test with:
```
./gradlew :fineract-war:binaryDistTar -x test
./gradlew
vidakovic opened a new pull request #2037:
URL: https://github.com/apache/fineract/pull/2037
## Description
Since we split the WAR build into a separate module we've excluded the WAR,
because of a circular dependency issue. Adding the WAR file again as there was
no general vote to
vidakovic commented on pull request #2023:
URL: https://github.com/apache/fineract/pull/2023#issuecomment-1045772957
@ptuomola yep, finally have some time to take care of this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
ptuomola commented on pull request #2023:
URL: https://github.com/apache/fineract/pull/2023#issuecomment-1045564527
@vidakovic looks like some checkstyle errors... can you fix and we can then
merge?
--
This is an automated message from the Apache Git Service.
To respond to the message,
ptuomola merged pull request #2029:
URL: https://github.com/apache/fineract/pull/2029
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
ptuomola pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git
The following commit(s) were added to refs/heads/develop by this push:
new d6aba7e FINERACT-1497: Proper file URI
ptuomola commented on pull request #2034:
URL: https://github.com/apache/fineract/pull/2034#issuecomment-1045562593
Looks good - thanks! One more small thing: to keep the commit history clean,
your PR should have 1 commit only. It currently has 3. Could you squash your
commits with git so
This is an automated email from the ASF dual-hosted git repository.
avikg pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git
The following commit(s) were added to refs/heads/develop by this push:
new f1c38fb
avikganguly01 merged pull request #2036:
URL: https://github.com/apache/fineract/pull/2036
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
fynmanoj commented on pull request #2036:
URL: https://github.com/apache/fineract/pull/2036#issuecomment-1045120728
@avikganguly01 please review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
fynmanoj opened a new pull request #2036:
URL: https://github.com/apache/fineract/pull/2036
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA
avikganguly01 merged pull request #2033:
URL: https://github.com/apache/fineract/pull/2033
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
avikg pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git
The following commit(s) were added to refs/heads/develop by this push:
new 7c235c5
15 matches
Mail list logo