[GitHub] [fineract] fynmanoj commented on a change in pull request #2049: FINERACT-1510-reversal-transaction-posting-pg-migration

2022-02-22 Thread GitBox
fynmanoj commented on a change in pull request #2049: URL: https://github.com/apache/fineract/pull/2049#discussion_r812625983 ## File path: fineract-provider/src/main/resources/db/changelog/tenant/parts/0005_savings_transaction_reversal.xml ## @@ -25,7 +25,7 @@

[GitHub] [fineract] galovics commented on a change in pull request #2046: Fineract 1510

2022-02-22 Thread GitBox
galovics commented on a change in pull request #2046: URL: https://github.com/apache/fineract/pull/2046#discussion_r812617375 ## File path: fineract-provider/src/main/resources/db/changelog/tenant/parts/0005_savings_transaction_reversal.xml ## @@ -0,0 +1,49 @@ + +

[GitHub] [fineract] galovics commented on a change in pull request #2049: FINERACT-1510-reversal-transaction-posting-pg-migration

2022-02-22 Thread GitBox
galovics commented on a change in pull request #2049: URL: https://github.com/apache/fineract/pull/2049#discussion_r812617016 ## File path: fineract-provider/src/main/resources/db/changelog/tenant/parts/0005_savings_transaction_reversal.xml ## @@ -25,7 +25,7 @@

[GitHub] [fineract] fynmanoj commented on a change in pull request #2046: Fineract 1510

2022-02-22 Thread GitBox
fynmanoj commented on a change in pull request #2046: URL: https://github.com/apache/fineract/pull/2046#discussion_r812615122 ## File path: fineract-provider/src/main/resources/db/changelog/tenant/parts/0005_savings_transaction_reversal.xml ## @@ -0,0 +1,49 @@ + +

[GitHub] [fineract] fynmanoj opened a new pull request #2049: FINERACT-1510-reversal-transaction-posting-pg-migration

2022-02-22 Thread GitBox
fynmanoj opened a new pull request #2049: URL: https://github.com/apache/fineract/pull/2049 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] fynmanoj commented on a change in pull request #2046: Fineract 1510

2022-02-22 Thread GitBox
fynmanoj commented on a change in pull request #2046: URL: https://github.com/apache/fineract/pull/2046#discussion_r812612707 ## File path: fineract-provider/src/main/resources/db/changelog/tenant/parts/0005_savings_transaction_reversal.xml ## @@ -0,0 +1,49 @@ + +

[GitHub] [fineract] francisguchie commented on pull request #1984: FINERACT-1431:PassportDropDown-in-ClientIdentifier

2022-02-22 Thread GitBox
francisguchie commented on pull request #1984: URL: https://github.com/apache/fineract/pull/1984#issuecomment-1048480594 @vidakovic you so much, @rrpawar96 please address this. Reach out to me if you need my help -- This is an automated message from the Apache Git Service. To respond

[GitHub] [fineract] galovics commented on a change in pull request #2046: Fineract 1510

2022-02-22 Thread GitBox
galovics commented on a change in pull request #2046: URL: https://github.com/apache/fineract/pull/2046#discussion_r812363808 ## File path: fineract-provider/src/main/resources/db/changelog/tenant/parts/0005_savings_transaction_reversal.xml ## @@ -0,0 +1,49 @@ + +

[GitHub] [fineract] galovics opened a new pull request #2048: FINERACT-984-7: Extend GitHub Action pipeline for PostgreSQL

2022-02-22 Thread GitBox
galovics opened a new pull request #2048: URL: https://github.com/apache/fineract/pull/2048 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[fineract] branch develop updated: FINERACT-1510-reversal-transaction-posting (#2046)

2022-02-22 Thread avikg
This is an automated email from the ASF dual-hosted git repository. avikg pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/fineract.git The following commit(s) were added to refs/heads/develop by this push: new d7d9a83

[GitHub] [fineract] avikganguly01 merged pull request #2046: Fineract 1510

2022-02-22 Thread GitBox
avikganguly01 merged pull request #2046: URL: https://github.com/apache/fineract/pull/2046 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] vidakovic merged pull request #2047: FINERACT-984: PostgreSQL support

2022-02-22 Thread GitBox
vidakovic merged pull request #2047: URL: https://github.com/apache/fineract/pull/2047 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] vidakovic commented on pull request #1984: FINERACT-1431:PassportDropDown-in-ClientIdentifier

2022-02-22 Thread GitBox
vidakovic commented on pull request #1984: URL: https://github.com/apache/fineract/pull/1984#issuecomment-1047968075 @rrpawar96 @francisguchie ... most of it looks ok for me... but the database migration scripts need to be rewritten for Liquibase... Flyway not used anymore. -- This is

[GitHub] [fineract] galovics opened a new pull request #2047: FINERACT-984-6: PostgreSQL support

2022-02-22 Thread GitBox
galovics opened a new pull request #2047: URL: https://github.com/apache/fineract/pull/2047 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] avikganguly01 commented on pull request #2046: Fineract 1510

2022-02-22 Thread GitBox
avikganguly01 commented on pull request #2046: URL: https://github.com/apache/fineract/pull/2046#issuecomment-1047916120 @fynmanoj : testAccountBalanceAfterSavingsTransactionReversalPosting() FAILED java.lang.AssertionError: 1 expectation failed. Expected status code <200> but was

[GitHub] [fineract] fynmanoj commented on pull request #2046: Fineract 1510

2022-02-22 Thread GitBox
fynmanoj commented on pull request #2046: URL: https://github.com/apache/fineract/pull/2046#issuecomment-1047891528 I have changed migration script to liquibase format. Also this migration script is running fine in my local when ran separately -- This is an automated message from the

[GitHub] [fineract] avikganguly01 commented on pull request #2046: Fineract 1510

2022-02-22 Thread GitBox
avikganguly01 commented on pull request #2046: URL: https://github.com/apache/fineract/pull/2046#issuecomment-1047867093 testApplyAnnualFeeForSavingsJobOutcome seems to be failing. Is it passing if you run that test separate from all the other integration tests? -- This is an automated

[GitHub] [fineract] avikganguly01 commented on pull request #2046: Fineract 1510

2022-02-22 Thread GitBox
avikganguly01 commented on pull request #2046: URL: https://github.com/apache/fineract/pull/2046#issuecomment-1047635596 @fynmanoj : Some checkstyle errors are there in SavingsAccount files which is failing the basicauth build. -- This is an automated message from the Apache Git

[GitHub] [fineract] avikganguly01 commented on a change in pull request #2046: Fineract 1510

2022-02-22 Thread GitBox
avikganguly01 commented on a change in pull request #2046: URL: https://github.com/apache/fineract/pull/2046#discussion_r811780665 ## File path: integration-tests/src/test/java/org/apache/fineract/integrationtests/ClientSavingsIntegrationTest.java ## @@ -2324,4 +2324,56 @@