[PR] FINERACT-1932: Fineract modularization - fineract-branch [fineract]

2024-04-02 Thread via GitHub
alberto-art3ch opened a new pull request, #3847: URL: https://github.com/apache/fineract/pull/3847 ## Description Create the initial `fineract-branch` module - used as branch domain module classes and interfaces, for Teller and Cashier management

Re: [PR] FINERACT-1991: Added search feature to antora generated documentation site [fineract]

2024-04-02 Thread via GitHub
github-actions[bot] closed pull request #3494: FINERACT-1991: Added search feature to antora generated documentation site URL: https://github.com/apache/fineract/pull/3494 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] FINERACT-2020:Added currency field to LoanAccountSummaryData, also ad… [fineract]

2024-04-02 Thread via GitHub
Aboya1417 commented on PR #3842: URL: https://github.com/apache/fineract/pull/3842#issuecomment-2032948841 > I see a failure in the build, might be unrelated. But, need to have you also check the boxes on the commit. See list and make sure all are covered. > > Why is the delinquency

(fineract) branch develop updated: FINERACT-1971: use KeyHolder instead of LASTVAL/LAST_INSERT_ID

2024-04-02 Thread adamsaghy
This is an automated email from the ASF dual-hosted git repository. adamsaghy pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/fineract.git The following commit(s) were added to refs/heads/develop by this push: new 749d6511e FINERACT-1971: use KeyHolder

Re: [PR] FINERACT-1971: use KeyHolder instead of LASTVAL/LAST_INSERT_ID [fineract]

2024-04-02 Thread via GitHub
adamsaghy merged PR #3841: URL: https://github.com/apache/fineract/pull/3841 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] FINERACT-2065: Fix schedule handling with higher fixed length value t… [fineract]

2024-04-02 Thread via GitHub
adamsaghy commented on code in PR #3836: URL: https://github.com/apache/fineract/pull/3836#discussion_r1548265863 ## fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/LoanApplicationTerms.java: ## @@ -1871,4 +1871,16 @@ public LocalDate

Re: [PR] FINERACT-2065: Fix schedule handling with higher fixed length value t… [fineract]

2024-04-02 Thread via GitHub
adamsaghy commented on code in PR #3836: URL: https://github.com/apache/fineract/pull/3836#discussion_r1548267907 ## fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/data/LoanTermVariationsDataWrapper.java: ## @@ -172,4 +172,8 @@ public void

Re: [PR] FINERACT-2065: Fix schedule handling with higher fixed length value t… [fineract]

2024-04-02 Thread via GitHub
adamsaghy commented on code in PR #3836: URL: https://github.com/apache/fineract/pull/3836#discussion_r1548263958 ## fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/LoanApplicationTerms.java: ## @@ -1871,4 +1871,16 @@ public LocalDate

Re: [PR] FINERACT-2065: Fix schedule handling with higher fixed length value t… [fineract]

2024-04-02 Thread via GitHub
alberto-art3ch commented on code in PR #3836: URL: https://github.com/apache/fineract/pull/3836#discussion_r1548204300 ## fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/data/LoanTermVariationsDataWrapper.java: ## @@ -172,4 +172,8 @@ public void

Re: [PR] FINERACT-2065: Fix schedule handling with higher fixed length value t… [fineract]

2024-04-02 Thread via GitHub
alberto-art3ch commented on code in PR #3836: URL: https://github.com/apache/fineract/pull/3836#discussion_r1548201859 ## fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/LoanApplicationTerms.java: ## @@ -1871,4 +1871,16 @@ public

Re: [PR] FINERACT-2056: (chore) make use of builder pattern in saving module. [fineract]

2024-04-02 Thread via GitHub
adamsaghy commented on code in PR #3843: URL: https://github.com/apache/fineract/pull/3843#discussion_r1548143442 ## fineract-savings/src/main/java/org/apache/fineract/portfolio/savings/service/GSIMReadPlatformServiceImpl.java: ## @@ -73,8 +73,11 @@ public

Re: [PR] FINERACT-2056: (chore) make use of builder pattern in saving module. [fineract]

2024-04-02 Thread via GitHub
Zeyad2003 commented on code in PR #3843: URL: https://github.com/apache/fineract/pull/3843#discussion_r1547755267 ## fineract-savings/src/main/java/org/apache/fineract/portfolio/savings/service/GSIMReadPlatformServiceImpl.java: ## @@ -73,8 +73,11 @@ public

Re: [PR] FINERACT-2056: (chore) make use of builder pattern in saving module. [fineract]

2024-04-02 Thread via GitHub
adamsaghy commented on code in PR #3843: URL: https://github.com/apache/fineract/pull/3843#discussion_r1547704933 ## fineract-savings/src/main/java/org/apache/fineract/portfolio/savings/service/GSIMReadPlatformServiceImpl.java: ## @@ -73,8 +73,11 @@ public

Re: [PR] FINERACT-2056: (chore) make use of builder pattern in saving module. [fineract]

2024-04-02 Thread via GitHub
adamsaghy commented on code in PR #3843: URL: https://github.com/apache/fineract/pull/3843#discussion_r1547704933 ## fineract-savings/src/main/java/org/apache/fineract/portfolio/savings/service/GSIMReadPlatformServiceImpl.java: ## @@ -73,8 +73,11 @@ public

Re: [PR] FINERACT-2065: Fix schedule handling with higher fixed length value t… [fineract]

2024-04-02 Thread via GitHub
adamsaghy commented on code in PR #3836: URL: https://github.com/apache/fineract/pull/3836#discussion_r1547549360 ## fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/LoanApplicationTerms.java: ## @@ -1871,4 +1871,16 @@ public LocalDate

Re: [PR] FINERACT-2065: Fix schedule handling with higher fixed length value t… [fineract]

2024-04-02 Thread via GitHub
adamsaghy commented on code in PR #3836: URL: https://github.com/apache/fineract/pull/3836#discussion_r1547548281 ## fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/data/LoanTermVariationsDataWrapper.java: ## @@ -172,4 +172,8 @@ public void

[PR] Update statistical_scoring.py [fineract-credit-scorecard]

2024-04-02 Thread via GitHub
shubhampal62 opened a new pull request, #24: URL: https://github.com/apache/fineract-credit-scorecard/pull/24 Label Encoded the Risk column -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] FINERACT-2065: Fix schedule handling with higher fixed length value t… [fineract]

2024-04-02 Thread via GitHub
alberto-art3ch commented on code in PR #3836: URL: https://github.com/apache/fineract/pull/3836#discussion_r1547466951 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/AbstractProgressiveLoanScheduleGenerator.java: ## @@ -181,6