alberto-art3ch commented on PR #3829:
URL: https://github.com/apache/fineract/pull/3829#issuecomment-2036207267
> Kindly add the proper FINERACT story for this PR and check my review!
Done
--
This is an automated message from the Apache Git Service.
To respond to the message,
Mariappan-Sivakumar-ZS0528 commented on PR #3750:
URL: https://github.com/apache/fineract/pull/3750#issuecomment-2036195396
Hi @adamsaghy
While using 'of' as an alias for the 'm_office' table in MySQL, it's not
recognized as an alias but rather as a reserved keyword in SQL. Therefore,
Aboya1417 commented on PR #3842:
URL: https://github.com/apache/fineract/pull/3842#issuecomment-2035272618
> @Aboya1417 Please fix the conflicts and squash your commits!
@adamsaghy commits has been been squashed and conflicts has been resolved.
--
This is an automated message from
Aboya1417 closed pull request #3849: My fixes
URL: https://github.com/apache/fineract/pull/3849
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Aboya1417 closed pull request #3849: My fixes
URL: https://github.com/apache/fineract/pull/3849
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Aboya1417 opened a new pull request, #3849:
URL: https://github.com/apache/fineract/pull/3849
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA
Aboya1417 closed pull request #3842: FINERACT-2020:Added currency field to
LoanAccountSummaryData, also ad…
URL: https://github.com/apache/fineract/pull/3842
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
alberto-art3ch commented on code in PR #3836:
URL: https://github.com/apache/fineract/pull/3836#discussion_r1549620496
##
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/data/LoanTermVariationsDataWrapper.java:
##
@@ -172,4 +172,8 @@ public void
adamsaghy commented on PR #3331:
URL: https://github.com/apache/fineract/pull/3331#issuecomment-2034409544
@jogathogo Please squash your commits and check why the tests were failing!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
adamsaghy commented on PR #3630:
URL: https://github.com/apache/fineract/pull/3630#issuecomment-2034408740
@hero78 Please fix the conflict and check why the tests were failing!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
adamsaghy commented on PR #3737:
URL: https://github.com/apache/fineract/pull/3737#issuecomment-2034407767
@daviestobialex Kindly asking you to squash your commits and finish the unit
test!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
adamsaghy commented on PR #3750:
URL: https://github.com/apache/fineract/pull/3750#issuecomment-2034405341
@Mariappan-Sivakumar-ZS0528 Please help me understand why renaming the alias
would sort this issue?
--
This is an automated message from the Apache Git Service.
To respond to the
adamsaghy commented on PR #3765:
URL: https://github.com/apache/fineract/pull/3765#issuecomment-2034400965
@abhinav7sinha Please fix the conflicts (rebase your PR) and squash the
commits!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
adamsaghy commented on PR #3766:
URL: https://github.com/apache/fineract/pull/3766#issuecomment-2034400048
@HarimbolaSantatra Please follow the conventions on how to format the pull
request title
("[FINERACT-1234](https://issues.apache.org/jira/browse/FINERACT-1234): Title
of the JIRA
adamsaghy commented on code in PR #3795:
URL: https://github.com/apache/fineract/pull/3795#discussion_r1549595443
##
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/DefaultPaymentPeriodsInOneYearCalculator.java:
##
@@ -32,15 +32,15
adamsaghy commented on PR #3842:
URL: https://github.com/apache/fineract/pull/3842#issuecomment-2034387127
@Aboya1417 Please fix the conflicts and squash your commits!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
adamsaghy closed pull request #3842: FINERACT-2020:Added currency field to
LoanAccountSummaryData, also ad…
URL: https://github.com/apache/fineract/pull/3842
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
adamsaghy opened a new pull request, #3848:
URL: https://github.com/apache/fineract/pull/3848
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA
18 matches
Mail list logo
