[PR] FINERACT-2022: Rewrite account domain, services and jobs using QueryDSL. [fineract]

2024-04-08 Thread via GitHub
mariiaKraievska opened a new pull request, #3854: URL: https://github.com/apache/fineract/pull/3854 ## Description JIRA ticket - https://issues.apache.org/jira/browse/FINERACT-2022 In this PR, I implemented QueryDSL to generate code for type-safe SQL queries for the Account

Re: [PR] FINERACT-2020:Added currency field to LoanAccountSummaryData, also ad… [fineract]

2024-04-08 Thread via GitHub
adamsaghy commented on PR #3842: URL: https://github.com/apache/fineract/pull/3842#issuecomment-2043243552 https://github.com/apache/fineract/pull/3851 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] FINERACT-2020:Added currency field to LoanAccountSummaryData, also ad… [fineract]

2024-04-08 Thread via GitHub
Aboya1417 commented on PR #3842: URL: https://github.com/apache/fineract/pull/3842#issuecomment-2043228390 > @Aboya1417 Hi > > It was fixed in a separate PR. I am triggering new build Everything seems fine now, can you please share what the issues was and the fixes you made?

Re: [PR] FINERACT-2020:Added currency field to LoanAccountSummaryData, also ad… [fineract]

2024-04-08 Thread via GitHub
adamsaghy commented on PR #3842: URL: https://github.com/apache/fineract/pull/3842#issuecomment-2043111882 @Aboya1417 Hi It was fixed in a separate PR. I am triggering new build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] FINERACT-2020:Added currency field to LoanAccountSummaryData, also ad… [fineract]

2024-04-08 Thread via GitHub
Aboya1417 commented on PR #3842: URL: https://github.com/apache/fineract/pull/3842#issuecomment-2043108171 > @Aboya1417 Feel free to give a try...i will check also why it could happen... Hi @adamsaghy, any development on this because on my end the test gets to build successfully.

Re: [PR] FINERACT-2060: Fix balance of reamortization at the event of reverse-replay [fineract]

2024-04-08 Thread via GitHub
adamsaghy merged PR #3852: URL: https://github.com/apache/fineract/pull/3852 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(fineract) branch develop updated: FINERACT-2060: Fix balance of reamortization at the event of reverse-replay

2024-04-08 Thread adamsaghy
This is an automated email from the ASF dual-hosted git repository. adamsaghy pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/fineract.git The following commit(s) were added to refs/heads/develop by this push: new 4c503fff0 FINERACT-2060: Fix balance of

Re: [PR] FINERACT-2060: Fix balance of reamortization at the event of reverse-replay [fineract]

2024-04-08 Thread via GitHub
adamsaghy commented on PR #3852: URL: https://github.com/apache/fineract/pull/3852#issuecomment-2042546119 > @adamsaghy there are a handful of test failures in the new tests... looks like a recurring pattern. Yes, I sent he patch for this! -- This is an automated message from the

(fineract) branch develop updated: FINERACT-1926: Enhance performance of "Trial balance with Asset owner" report

2024-04-08 Thread adamsaghy
This is an automated email from the ASF dual-hosted git repository. adamsaghy pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/fineract.git The following commit(s) were added to refs/heads/develop by this push: new 60b4a618a FINERACT-1926: Enhance

Re: [PR] FINERACT-1926: Enhance performance of "Trial balance with Asset owner" report [fineract]

2024-04-08 Thread via GitHub
adamsaghy merged PR #3848: URL: https://github.com/apache/fineract/pull/3848 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] FINERACT-2060: Fix balance of reamortization at the event of reverse-replay [fineract]

2024-04-08 Thread via GitHub
vidakovic commented on PR #3852: URL: https://github.com/apache/fineract/pull/3852#issuecomment-204259 @adamsaghy there are a handful of test failures in the new tests... looks like a recurring pattern. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] FINERACT-2065: Fix schedule handling with higher fixed length value t… [fineract]

2024-04-08 Thread via GitHub
adamsaghy commented on code in PR #3836: URL: https://github.com/apache/fineract/pull/3836#discussion_r1555417782 ## fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/data/LoanTermVariationsDataWrapper.java: ## @@ -172,4 +172,8 @@ public void

Re: [PR] FINERACT-2065: Fix schedule handling with higher fixed length value t… [fineract]

2024-04-08 Thread via GitHub
adamsaghy commented on code in PR #3836: URL: https://github.com/apache/fineract/pull/3836#discussion_r1555417782 ## fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/data/LoanTermVariationsDataWrapper.java: ## @@ -172,4 +172,8 @@ public void