[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

2022-12-13 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1047635664 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanReadPlatformServiceImpl.java: ## @@ -1485,7 +1486,7 @@

[GitHub] [fineract] galovics merged pull request #2805: FINERACT-1724 - Swagger generated class name collision

2022-12-13 Thread GitBox
galovics merged PR #2805: URL: https://github.com/apache/fineract/pull/2805 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] ruchiD opened a new pull request, #2807: FINERACT-1818-New-Parameter-Loan-Api

2022-12-13 Thread GitBox
ruchiD opened a new pull request, #2807: URL: https://github.com/apache/fineract/pull/2807 ## Description Fix for loan transaction summary when no association parameters given for loan retrieve api. Describe the changes made and why they were made. Ignore if these details

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

2022-12-13 Thread GitBox
adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1047148112 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanReadPlatformServiceImpl.java: ## @@ -1485,7 +1486,7 @@ public

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

2022-12-13 Thread GitBox
adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1047148112 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanReadPlatformServiceImpl.java: ## @@ -1485,7 +1486,7 @@ public

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

2022-12-13 Thread GitBox
adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1047148112 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanReadPlatformServiceImpl.java: ## @@ -1485,7 +1486,7 @@ public

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

2022-12-13 Thread GitBox
adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1047148112 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanReadPlatformServiceImpl.java: ## @@ -1485,7 +1486,7 @@ public

[GitHub] [fineract] galovics merged pull request #2797: FINERACT-1785: Allow to add charge (penalty) with same disbursement date

2022-12-13 Thread GitBox
galovics merged PR #2797: URL: https://github.com/apache/fineract/pull/2797 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics merged pull request #2806: chore(deps): bump actions/checkout from 3.1.0 to 3.2.0

2022-12-13 Thread GitBox
galovics merged PR #2806: URL: https://github.com/apache/fineract/pull/2806 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] dependabot[bot] opened a new pull request, #2806: chore(deps): bump actions/checkout from 3.1.0 to 3.2.0

2022-12-12 Thread GitBox
dependabot[bot] opened a new pull request, #2806: URL: https://github.com/apache/fineract/pull/2806 Bumps [actions/checkout](https://github.com/actions/checkout) from 3.1.0 to 3.2.0. Release notes Sourced from https://github.com/actions/checkout/releases;>actions/checkout's

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2797: FINERACT-1785: Allow to add charge (penalty) with same disbursement date

2022-12-12 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2797: URL: https://github.com/apache/fineract/pull/2797#discussion_r1046644809 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanRepaymentScheduleProcessingWrapper.java: ## @@ -213,6

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2797: FINERACT-1785: Allow to add charge (penalty) with same disbursement date

2022-12-12 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2797: URL: https://github.com/apache/fineract/pull/2797#discussion_r1046644809 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanRepaymentScheduleProcessingWrapper.java: ## @@ -213,6

[GitHub] [fineract] github-actions[bot] closed pull request #2578: FINERACT-1732: Introduce Lombok to bulkimport module

2022-12-12 Thread GitBox
github-actions[bot] closed pull request #2578: FINERACT-1732: Introduce Lombok to bulkimport module URL: https://github.com/apache/fineract/pull/2578 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [fineract] github-actions[bot] closed pull request #2591: FINERACT-1742: Introduce Lombok to dataqueries module

2022-12-12 Thread GitBox
github-actions[bot] closed pull request #2591: FINERACT-1742: Introduce Lombok to dataqueries module URL: https://github.com/apache/fineract/pull/2591 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [fineract] b0c1 opened a new pull request, #2805: FINERACT-1724

2022-12-12 Thread GitBox
b0c1 opened a new pull request, #2805: URL: https://github.com/apache/fineract/pull/2805 FINERACT-1724 - [x] Swagger `Changes` class name collision. ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2797: FINERACT-1785: Allow to add charge (penalty) with same disbursement date

2022-12-12 Thread GitBox
adamsaghy commented on code in PR #2797: URL: https://github.com/apache/fineract/pull/2797#discussion_r1046294626 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanRepaymentScheduleProcessingWrapper.java: ## @@ -213,6 +213,10 @@ private

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2797: FINERACT-1785: Allow to add charge (penalty) with same disbursement date

2022-12-12 Thread GitBox
adamsaghy commented on code in PR #2797: URL: https://github.com/apache/fineract/pull/2797#discussion_r1046294626 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanRepaymentScheduleProcessingWrapper.java: ## @@ -213,6 +213,10 @@ private

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2797: FINERACT-1785: Allow to add charge (penalty) with same disbursement date

2022-12-12 Thread GitBox
adamsaghy commented on code in PR #2797: URL: https://github.com/apache/fineract/pull/2797#discussion_r1046294626 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanRepaymentScheduleProcessingWrapper.java: ## @@ -213,6 +213,10 @@ private

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2797: FINERACT-1785: Allow to add charge (penalty) with same disbursement date

2022-12-12 Thread GitBox
adamsaghy commented on code in PR #2797: URL: https://github.com/apache/fineract/pull/2797#discussion_r1046294626 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanRepaymentScheduleProcessingWrapper.java: ## @@ -213,6 +213,10 @@ private

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2797: FINERACT-1785: Allow to add charge (penalty) with same disbursement date

2022-12-12 Thread GitBox
adamsaghy commented on code in PR #2797: URL: https://github.com/apache/fineract/pull/2797#discussion_r1046272829 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanRepaymentScheduleProcessingWrapper.java: ## @@ -213,6 +213,10 @@ private

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

2022-12-12 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1046234696 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanReadPlatformServiceImpl.java: ## @@ -1485,7 +1486,7 @@

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

2022-12-12 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1046086290 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientReadPlatformServiceImpl.java: ## @@ -545,90 +543,77 @@

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

2022-12-12 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1046085648 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientReadPlatformServiceImpl.java: ## @@ -370,77 +305,141 @@

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2797: FINERACT-1785: Allow to add charge (penalty) with same disbursement date

2022-12-12 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2797: URL: https://github.com/apache/fineract/pull/2797#discussion_r1046080521 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/LoanChargeSpecificDueDateTest.java: ## @@ -110,7 +110,60 @@ public void

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2797: FINERACT-1785: Allow to add charge (penalty) with same disbursement date

2022-12-12 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2797: URL: https://github.com/apache/fineract/pull/2797#discussion_r1046064916 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/common/loans/LoanTransactionHelper.java: ## @@ -1563,6 +1563,14 @@ public

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2797: FINERACT-1785: Allow to add charge (penalty) with same disbursement date

2022-12-12 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2797: URL: https://github.com/apache/fineract/pull/2797#discussion_r1046060125 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanRepaymentScheduleProcessingWrapper.java: ## @@ -213,6

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2797: FINERACT-1785: Allow to add charge (penalty) with same disbursement date

2022-12-12 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2797: URL: https://github.com/apache/fineract/pull/2797#discussion_r1046058356 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/LoanChargeSpecificDueDateTest.java: ## @@ -110,7 +110,60 @@ public void

[GitHub] [fineract] b0c1 commented on a diff in pull request #2795: FINERACT-1744 - Batch API Support

2022-12-12 Thread GitBox
b0c1 commented on code in PR #2795: URL: https://github.com/apache/fineract/pull/2795#discussion_r1045987299 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/domain/FineractRequestContextHolder.java: ## @@ -0,0 +1,64 @@ +/** + * Licensed to the Apache

[GitHub] [fineract] galovics merged pull request #2798: FINERACT-1760-Index-or-Unique-column-creation-datatables

2022-12-12 Thread GitBox
galovics merged PR #2798: URL: https://github.com/apache/fineract/pull/2798 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics commented on a diff in pull request #2798: FINERACT-1760-Index-or-Unique-column-creation-datatables

2022-12-12 Thread GitBox
galovics commented on code in PR #2798: URL: https://github.com/apache/fineract/pull/2798#discussion_r1045939862 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/ReadWriteNonCoreDataServiceImpl.java: ## @@ -871,6 +884,24 @@ public

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

2022-12-12 Thread GitBox
adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1045871843 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanReadPlatformServiceImpl.java: ## @@ -1485,7 +1486,7 @@ public

[GitHub] [fineract] galovics merged pull request #2801: chore(deps): update actions/stale action to v6

2022-12-12 Thread GitBox
galovics merged PR #2801: URL: https://github.com/apache/fineract/pull/2801 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics commented on a diff in pull request #2797: FINERACT-1785: Allow to add charge (penalty) with same disbursement date

2022-12-12 Thread GitBox
galovics commented on code in PR #2797: URL: https://github.com/apache/fineract/pull/2797#discussion_r1045560791 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanRepaymentScheduleProcessingWrapper.java: ## @@ -213,6 +213,10 @@ private

[GitHub] [fineract] galovics commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

2022-12-12 Thread GitBox
galovics commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1045521379 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientReadPlatformServiceImpl.java: ## @@ -370,77 +305,141 @@ public Collection

[GitHub] [fineract] ruchiD commented on a diff in pull request #2798: FINERACT-1760-Index-or-Unique-column-creation-datatables

2022-12-12 Thread GitBox
ruchiD commented on code in PR #2798: URL: https://github.com/apache/fineract/pull/2798#discussion_r1045507415 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/ReadWriteNonCoreDataServiceImpl.java: ## @@ -871,6 +884,24 @@ public

[GitHub] [fineract] galovics commented on a diff in pull request #2798: FINERACT-1760-Index-or-Unique-column-creation-datatables

2022-12-12 Thread GitBox
galovics commented on code in PR #2798: URL: https://github.com/apache/fineract/pull/2798#discussion_r1045499016 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/service/database/DatabaseQueryService.java: ## @@ -29,4 +29,6 @@ public interface

[GitHub] [fineract] galovics commented on a diff in pull request #2795: FINERACT-1744 - Batch API Support

2022-12-11 Thread GitBox
galovics commented on code in PR #2795: URL: https://github.com/apache/fineract/pull/2795#discussion_r1045277210 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/domain/FineractRequestContextHolder.java: ## @@ -0,0 +1,64 @@ +/** + * Licensed to the

[GitHub] [fineract] renovate-bot opened a new pull request, #2804: chore(deps): update dependency org.slf4j:jul-to-slf4j to v2

2022-12-11 Thread GitBox
renovate-bot opened a new pull request, #2804: URL: https://github.com/apache/fineract/pull/2804 [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing |

[GitHub] [fineract] renovate-bot opened a new pull request, #2803: chore(deps): update dependency org.slf4j:jcl-over-slf4j to v2

2022-12-11 Thread GitBox
renovate-bot opened a new pull request, #2803: URL: https://github.com/apache/fineract/pull/2803 [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing |

[GitHub] [fineract] renovate-bot opened a new pull request, #2802: chore(deps): update dependency io.github.resilience4j:resilience4j-spring-boot2 to v2

2022-12-11 Thread GitBox
renovate-bot opened a new pull request, #2802: URL: https://github.com/apache/fineract/pull/2802 [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing |

[GitHub] [fineract] renovate-bot opened a new pull request, #2801: chore(deps): update actions/stale action to v6

2022-12-11 Thread GitBox
renovate-bot opened a new pull request, #2801: URL: https://github.com/apache/fineract/pull/2801 [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change |

[GitHub] [fineract] renovate-bot opened a new pull request, #2800: fix(deps): update non-major

2022-12-11 Thread GitBox
renovate-bot opened a new pull request, #2800: URL: https://github.com/apache/fineract/pull/2800 [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing |

[GitHub] [fineract] renovate-bot opened a new pull request, #2799: chore(deps): update all non-major dependencies

2022-12-11 Thread GitBox
renovate-bot opened a new pull request, #2799: URL: https://github.com/apache/fineract/pull/2799 [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | Age |

[GitHub] [fineract] github-actions[bot] closed pull request #2592: FINERACT-1743: Introduce Lombok to documentmanagement module

2022-12-11 Thread GitBox
github-actions[bot] closed pull request #2592: FINERACT-1743: Introduce Lombok to documentmanagement module URL: https://github.com/apache/fineract/pull/2592 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [fineract] github-actions[bot] closed pull request #2642: Refinement to existing documentation on the enhanced ability to separate read/write/batch API operations for greater performance

2022-12-11 Thread GitBox
github-actions[bot] closed pull request #2642: Refinement to existing documentation on the enhanced ability to separate read/write/batch API operations for greater performance URL: https://github.com/apache/fineract/pull/2642 -- This is an automated message from the Apache Git Service. To

[GitHub] [fineract] ruchiD opened a new pull request, #2798: FINERACT-1760-Index-or-Unique-column-creation-datatables

2022-12-09 Thread GitBox
ruchiD opened a new pull request, #2798: URL: https://github.com/apache/fineract/pull/2798 ## Description 1.Added unique and indexed attributes for datatable columns 2.Updated column details to show unique or indexed status 3.Modified to add support for columns to indexed or unique

[GitHub] [fineract] galovics merged pull request #2796: FINERACT-1724: Fix delinquency tags swagger response type

2022-12-09 Thread GitBox
galovics merged PR #2796: URL: https://github.com/apache/fineract/pull/2796 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] josehernandezfintecheandomx opened a new pull request, #2797: FINERACT-1785: Allow to add charge (penalty) with same disbursement date

2022-12-09 Thread GitBox
josehernandezfintecheandomx opened a new pull request, #2797: URL: https://github.com/apache/fineract/pull/2797 ## Description When trying to apply specified due date fees or penalties on the date of the loan’s disbursement date, it won’t be effective and It's not added as

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

2022-12-09 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1044529090 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientReadPlatformServiceImpl.java: ## @@ -370,77 +305,141 @@

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

2022-12-09 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1044527454 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientReadPlatformServiceImpl.java: ## @@ -370,77 +305,141 @@

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

2022-12-09 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1044480018 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientReadPlatformServiceImpl.java: ## @@ -732,6 +718,20 @@ public

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

2022-12-09 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1044479707 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientReadPlatformServiceImpl.java: ## @@ -370,77 +305,141 @@

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

2022-12-09 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1044479372 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientReadPlatformServiceImpl.java: ## @@ -370,77 +305,141 @@

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

2022-12-09 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1044478616 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientReadPlatformServiceImpl.java: ## @@ -545,90 +543,77 @@

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

2022-12-09 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1044464638 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/mapper/ClientMapper.java: ## @@ -0,0 +1,159 @@ +/** + * Licensed to the

[GitHub] [fineract] galovics merged pull request #2794: FINERACT-1707: Update r_enum_value table with new transaction_types v…

2022-12-09 Thread GitBox
galovics merged PR #2794: URL: https://github.com/apache/fineract/pull/2794 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] adamsaghy opened a new pull request, #2796: FINERACT-1724: Fix delinquency tags swagger response type

2022-12-09 Thread GitBox
adamsaghy opened a new pull request, #2796: URL: https://github.com/apache/fineract/pull/2796 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] IOhacker closed pull request #2768: FINERACT-1821 Postgresql Support for Tellers ->Cashiers->Transactions

2022-12-08 Thread GitBox
IOhacker closed pull request #2768: FINERACT-1821 Postgresql Support for Tellers ->Cashiers->Transactions URL: https://github.com/apache/fineract/pull/2768 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [fineract] b0c1 opened a new pull request, #2795: FINERACT-1744 - Batch API Support

2022-12-08 Thread GitBox
b0c1 opened a new pull request, #2795: URL: https://github.com/apache/fineract/pull/2795 FINERACT-1744 - Batch API Support - [x] Batch api support for idempotency - [x] BatchFilter for generic batch filtering - [x] LoanCOBApiFilter extend with BatchFilter support - [x]

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

2022-12-08 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1043556557 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/Client.java: ## @@ -358,7 +324,7 @@ private void validate() {

[GitHub] [fineract] josehernandezfintecheandomx opened a new pull request, #2794: FINERACT-1707: Update r_enum_value table with new transaction_types v…

2022-12-08 Thread GitBox
josehernandezfintecheandomx opened a new pull request, #2794: URL: https://github.com/apache/fineract/pull/2794 …alues ## Description We need to add all the newly introduced `transaction_types` into `r_enum_value` table and It is done using a `liquibase` migration so that

[GitHub] [fineract-cn-fims-web-app] dependabot[bot] opened a new pull request, #36: Bump express from 4.16.3 to 4.18.2

2022-12-08 Thread GitBox
dependabot[bot] opened a new pull request, #36: URL: https://github.com/apache/fineract-cn-fims-web-app/pull/36 Bumps [express](https://github.com/expressjs/express) from 4.16.3 to 4.18.2. Release notes Sourced from https://github.com/expressjs/express/releases;>express's

[GitHub] [fineract-cn-group-finance] sonarcloud[bot] commented on pull request #20: Bump express from 4.16.3 to 4.18.2

2022-12-07 Thread GitBox
sonarcloud[bot] commented on PR #20: URL: https://github.com/apache/fineract-cn-group-finance/pull/20#issuecomment-1342106610 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [fineract-cn-group-finance] dependabot[bot] opened a new pull request, #20: Bump express from 4.16.3 to 4.18.2

2022-12-07 Thread GitBox
dependabot[bot] opened a new pull request, #20: URL: https://github.com/apache/fineract-cn-group-finance/pull/20 Bumps [express](https://github.com/expressjs/express) from 4.16.3 to 4.18.2. Release notes Sourced from https://github.com/expressjs/express/releases;>express's

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

2022-12-07 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1042815557 ## gradle.properties: ## @@ -16,7 +16,7 @@ # specific language governing permissions and limitations # under the License. #

[GitHub] [fineract-cn-fims-web-app] dependabot[bot] opened a new pull request, #35: Bump qs from 6.2.3 to 6.2.4

2022-12-07 Thread GitBox
dependabot[bot] opened a new pull request, #35: URL: https://github.com/apache/fineract-cn-fims-web-app/pull/35 Bumps [qs](https://github.com/ljharb/qs) from 6.2.3 to 6.2.4. Changelog Sourced from https://github.com/ljharb/qs/blob/main/CHANGELOG.md;>qs's changelog. 6.2.4

[GitHub] [fineract] galovics merged pull request #2793: FINERACT-1760: Batch API for datatable query update

2022-12-07 Thread GitBox
galovics merged PR #2793: URL: https://github.com/apache/fineract/pull/2793 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract-cn-group-finance] sonarcloud[bot] commented on pull request #19: Bump qs from 6.3.2 to 6.3.3

2022-12-07 Thread GitBox
sonarcloud[bot] commented on PR #19: URL: https://github.com/apache/fineract-cn-group-finance/pull/19#issuecomment-1341556621 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [fineract-cn-group-finance] dependabot[bot] opened a new pull request, #19: Bump qs from 6.3.2 to 6.3.3

2022-12-07 Thread GitBox
dependabot[bot] opened a new pull request, #19: URL: https://github.com/apache/fineract-cn-group-finance/pull/19 Bumps [qs](https://github.com/ljharb/qs) from 6.3.2 to 6.3.3. Changelog Sourced from https://github.com/ljharb/qs/blob/main/CHANGELOG.md;>qs's changelog. 6.3.3

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

2022-12-07 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1042269698 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/Client.java: ## @@ -463,7 +459,7 @@ public boolean isWithdrawn() {

[GitHub] [fineract] adamsaghy opened a new pull request, #2793: FINERACT-1760: Batch API for datatable query update

2022-12-07 Thread GitBox
adamsaghy opened a new pull request, #2793: URL: https://github.com/apache/fineract/pull/2793 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

2022-12-07 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1042242044 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/ClientDomainServiceImpl.java: ## @@ -0,0 +1,225 @@ +/** + *

[GitHub] [fineract] galovics commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

2022-12-07 Thread GitBox
galovics commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1042072148 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientReadPlatformServiceImpl.java: ## @@ -370,77 +305,141 @@ public Collection

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

2022-12-07 Thread GitBox
adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1041911963 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/Client.java: ## @@ -358,7 +324,7 @@ private void validate() { } -private

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

2022-12-07 Thread GitBox
adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1041911174 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/ClientDomainServiceImpl.java: ## @@ -0,0 +1,225 @@ +/** + * Licensed to the Apache

[GitHub] [fineract] galovics merged pull request #2788: FINERACT-1827: Last installment is not closed if there is a chargeback transaction

2022-12-06 Thread GitBox
galovics merged PR #2788: URL: https://github.com/apache/fineract/pull/2788 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

2022-12-06 Thread GitBox
adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1041379158 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/Client.java: ## @@ -463,7 +459,7 @@ public boolean isWithdrawn() { return

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

2022-12-06 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1041320902 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientReadPlatformService.java: ## @@ -60,4 +61,7 @@ public

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

2022-12-06 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1041317869 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/Client.java: ## @@ -224,12 +227,11 @@ public class Client extends

[GitHub] [fineract] galovics merged pull request #2787: chore(deps): update all non-major dependencies

2022-12-06 Thread GitBox
galovics merged PR #2787: URL: https://github.com/apache/fineract/pull/2787 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] adamsaghy merged pull request #2792: FINERACT-1828: Fix datatable audit time handling

2022-12-06 Thread GitBox
adamsaghy merged PR #2792: URL: https://github.com/apache/fineract/pull/2792 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

2022-12-06 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1041084358 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/ClientExternalIdTest.java: ## @@ -0,0 +1,320 @@ +/** + * Licensed to the

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

2022-12-06 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1041079865 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/ClientExternalIdTest.java: ## @@ -0,0 +1,320 @@ +/** + * Licensed to the

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

2022-12-06 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1041079491 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/ClientExternalIdTest.java: ## @@ -0,0 +1,320 @@ +/** + * Licensed to the

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

2022-12-06 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1041080198 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/ClientExternalIdTest.java: ## @@ -0,0 +1,320 @@ +/** + * Licensed to the

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

2022-12-06 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1041075520 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/ClientRepositoryWrapper.java: ## @@ -86,8 +87,21 @@ public Client

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

2022-12-06 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1041073352 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/Client.java: ## @@ -763,30 +750,18 @@ public boolean isStaff() {

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

2022-12-06 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1041069351 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/api/ClientsApiResource.java: ## @@ -415,25 +300,302 @@ public String

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

2022-12-06 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1041068946 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/api/ClientsApiResource.java: ## @@ -415,25 +300,302 @@ public String

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

2022-12-06 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1041068105 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/api/ClientsApiResource.java: ## @@ -415,25 +300,302 @@ public String

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

2022-12-06 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1041066866 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/api/ClientsApiResource.java: ## @@ -415,25 +300,302 @@ public String

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

2022-12-06 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1041066272 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/api/ClientsApiResource.java: ## @@ -415,25 +300,302 @@ public String

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

2022-12-06 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1041064743 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/api/ClientsApiResource.java: ## @@ -415,25 +300,302 @@ public String

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

2022-12-06 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1041063786 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/api/ClientsApiResource.java: ## @@ -415,25 +300,302 @@ public String

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

2022-12-06 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1041060275 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/populator/AbstractWorkbookPopulator.java: ## @@ -130,7 +130,7 @@

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2788: FINERACT-1827: Fix to set obligation met date for installment with chargeback transa…

2022-12-06 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2788: URL: https://github.com/apache/fineract/pull/2788#discussion_r1041003032 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/DelinquencyAndChargebackIntegrationTest.java: ## @@ -281,6 +285,26 @@

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2788: FINERACT-1827: Fix to set obligation met date for installment with chargeback transa…

2022-12-06 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2788: URL: https://github.com/apache/fineract/pull/2788#discussion_r1041016880 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/DelinquencyAndChargebackIntegrationTest.java: ## @@ -281,6 +285,26 @@

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2788: FINERACT-1827: Fix to set obligation met date for installment with chargeback transa…

2022-12-06 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2788: URL: https://github.com/apache/fineract/pull/2788#discussion_r1041012950 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/DelinquencyAndChargebackIntegrationTest.java: ## @@ -281,6 +285,26 @@

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2788: FINERACT-1827: Fix to set obligation met date for installment with chargeback transa…

2022-12-06 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2788: URL: https://github.com/apache/fineract/pull/2788#discussion_r1041003032 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/DelinquencyAndChargebackIntegrationTest.java: ## @@ -281,6 +285,26 @@

[GitHub] [fineract] galovics merged pull request #2753: FINERACT-1816: Create client with datatable subentity type

2022-12-06 Thread GitBox
galovics merged PR #2753: URL: https://github.com/apache/fineract/pull/2753 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

<    1   2   3   4   5   6   7   8   9   10   >