[GitHub] [fineract] vorburger commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API

2020-11-21 Thread GitBox
vorburger commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-731561291 > Sorry for delaying this long, I have been juggling between college exams, assignments and health :( Don't say Sorry! You have no "obligation" to continue

[GitHub] [fineract] vorburger commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API

2020-10-27 Thread GitBox
vorburger commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-717046148 @thesmallstar @ptuomola where were we with this one? Good to merge as-is, or updates needed? (Perhaps best to rebase it now.)

[GitHub] [fineract] vorburger commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API

2020-09-25 Thread GitBox
vorburger commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-698790415 @thesmallstar sounds like a plan, and PK for me to add the IT in a follow up. But the build on this is not passing, did you see? BTW watch the related discussion over on

[GitHub] [fineract] vorburger commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API

2020-09-25 Thread GitBox
vorburger commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-698790415 @thesmallstar sounds like a plan, and PK for me to add the IT in a follow up. But the build on this is not passing, did you see? BTW watch the related discussion over on

[GitHub] [fineract] vorburger commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API

2020-09-22 Thread GitBox
vorburger commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-696929477 @thesmallstar hope your exams went well! Whenever you have time to pick this up, we appreciate your contributions, very much!

[GitHub] [fineract] vorburger commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API

2020-09-22 Thread GitBox
vorburger commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-696929477 @thesmallstar hope your exams went well! Whenever you have time to pick this up, we appreciate your contributions, very much!

[GitHub] [fineract] vorburger commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API

2020-09-12 Thread GitBox
vorburger commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-691273760 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [fineract] vorburger commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API

2020-09-12 Thread GitBox
vorburger commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-691273760 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [fineract] vorburger commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API

2020-09-11 Thread GitBox
vorburger commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-691273760 @thesmallstar friendly ping, update? (as well as now have to rebase and fix merge conflict) This is an

[GitHub] [fineract] vorburger commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API

2020-09-06 Thread GitBox
vorburger commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-687845780 @thesmallstar the suggestion from @ptuomola in the last comment on FINERACT-1095 to use e.g. `"loanStatus": ["all","active","overpaid"], "loanProducts":

[GitHub] [fineract] vorburger commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API

2020-08-25 Thread GitBox
vorburger commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-680293678 > @vorburger @ptuomola taking exceptionally long time to write tests since it is really hard to understand how loans work :( if you have a more specific question, then

[GitHub] [fineract] vorburger commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API

2020-08-24 Thread GitBox
vorburger commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-679000204 @thesmallstar are you on this? :smiling_imp: This is an automated message from the Apache Git Service. To