Re: [PR] FINERACT-2065: Fix schedule handling with higher fixed length value t… [fineract]

adamsaghy merged PR #3836: URL: https://github.com/apache/fineract/pull/3836 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] FINERACT-2065: Fix schedule handling with higher fixed length value t… [fineract]

alberto-art3ch commented on code in PR #3836: URL: https://github.com/apache/fineract/pull/3836#discussion_r1560995254 ## fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/LoanApplicationTerms.java: ## @@ -69,6 +69,7 @@ public final class

Re: [PR] FINERACT-2065: Fix schedule handling with higher fixed length value t… [fineract]

adamsaghy commented on code in PR #3836: URL: https://github.com/apache/fineract/pull/3836#discussion_r1560629475 ## fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/LoanApplicationTerms.java: ## @@ -69,6 +69,7 @@ public final class

Re: [PR] FINERACT-2065: Fix schedule handling with higher fixed length value t… [fineract]

alberto-art3ch commented on code in PR #3836: URL: https://github.com/apache/fineract/pull/3836#discussion_r1560064338 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/LoanScheduleModelRepaymentPeriod.java: ## @@ -55,6 +55,13 @@

Re: [PR] FINERACT-2065: Fix schedule handling with higher fixed length value t… [fineract]

adamsaghy commented on code in PR #3836: URL: https://github.com/apache/fineract/pull/3836#discussion_r1559021163 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/AdvancedPaymentAllocationLoanRepaymentScheduleTest.java: ## @@ -3819,6 +3819,126 @@ public

Re: [PR] FINERACT-2065: Fix schedule handling with higher fixed length value t… [fineract]

adamsaghy commented on code in PR #3836: URL: https://github.com/apache/fineract/pull/3836#discussion_r1559020673 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/AdvancedPaymentAllocationLoanRepaymentScheduleTest.java: ## @@ -3819,6 +3819,126 @@ public

Re: [PR] FINERACT-2065: Fix schedule handling with higher fixed length value t… [fineract]

adamsaghy commented on code in PR #3836: URL: https://github.com/apache/fineract/pull/3836#discussion_r1559017008 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/LoanScheduleModelRepaymentPeriod.java: ## @@ -55,6 +55,13 @@ public

Re: [PR] FINERACT-2065: Fix schedule handling with higher fixed length value t… [fineract]

alberto-art3ch commented on code in PR #3836: URL: https://github.com/apache/fineract/pull/3836#discussion_r1558380950 ## fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/data/LoanTermVariationsDataWrapper.java: ## @@ -172,4 +172,8 @@ public void

Re: [PR] FINERACT-2065: Fix schedule handling with higher fixed length value t… [fineract]

adamsaghy commented on code in PR #3836: URL: https://github.com/apache/fineract/pull/3836#discussion_r1555417782 ## fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/data/LoanTermVariationsDataWrapper.java: ## @@ -172,4 +172,8 @@ public void

Re: [PR] FINERACT-2065: Fix schedule handling with higher fixed length value t… [fineract]

adamsaghy commented on code in PR #3836: URL: https://github.com/apache/fineract/pull/3836#discussion_r1555417782 ## fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/data/LoanTermVariationsDataWrapper.java: ## @@ -172,4 +172,8 @@ public void

Re: [PR] FINERACT-2065: Fix schedule handling with higher fixed length value t… [fineract]

alberto-art3ch commented on code in PR #3836: URL: https://github.com/apache/fineract/pull/3836#discussion_r1549620496 ## fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/data/LoanTermVariationsDataWrapper.java: ## @@ -172,4 +172,8 @@ public void

Re: [PR] FINERACT-2065: Fix schedule handling with higher fixed length value t… [fineract]

adamsaghy commented on code in PR #3836: URL: https://github.com/apache/fineract/pull/3836#discussion_r1548265863 ## fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/LoanApplicationTerms.java: ## @@ -1871,4 +1871,16 @@ public LocalDate

Re: [PR] FINERACT-2065: Fix schedule handling with higher fixed length value t… [fineract]

adamsaghy commented on code in PR #3836: URL: https://github.com/apache/fineract/pull/3836#discussion_r1548267907 ## fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/data/LoanTermVariationsDataWrapper.java: ## @@ -172,4 +172,8 @@ public void

Re: [PR] FINERACT-2065: Fix schedule handling with higher fixed length value t… [fineract]

adamsaghy commented on code in PR #3836: URL: https://github.com/apache/fineract/pull/3836#discussion_r1548263958 ## fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/LoanApplicationTerms.java: ## @@ -1871,4 +1871,16 @@ public LocalDate

Re: [PR] FINERACT-2065: Fix schedule handling with higher fixed length value t… [fineract]

alberto-art3ch commented on code in PR #3836: URL: https://github.com/apache/fineract/pull/3836#discussion_r1548204300 ## fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/data/LoanTermVariationsDataWrapper.java: ## @@ -172,4 +172,8 @@ public void

Re: [PR] FINERACT-2065: Fix schedule handling with higher fixed length value t… [fineract]

alberto-art3ch commented on code in PR #3836: URL: https://github.com/apache/fineract/pull/3836#discussion_r1548201859 ## fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/LoanApplicationTerms.java: ## @@ -1871,4 +1871,16 @@ public

Re: [PR] FINERACT-2065: Fix schedule handling with higher fixed length value t… [fineract]

adamsaghy commented on code in PR #3836: URL: https://github.com/apache/fineract/pull/3836#discussion_r1547549360 ## fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/LoanApplicationTerms.java: ## @@ -1871,4 +1871,16 @@ public LocalDate

Re: [PR] FINERACT-2065: Fix schedule handling with higher fixed length value t… [fineract]

adamsaghy commented on code in PR #3836: URL: https://github.com/apache/fineract/pull/3836#discussion_r1547548281 ## fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/data/LoanTermVariationsDataWrapper.java: ## @@ -172,4 +172,8 @@ public void

Re: [PR] FINERACT-2065: Fix schedule handling with higher fixed length value t… [fineract]

alberto-art3ch commented on code in PR #3836: URL: https://github.com/apache/fineract/pull/3836#discussion_r1547466951 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/AbstractProgressiveLoanScheduleGenerator.java: ## @@ -181,6

Re: [PR] FINERACT-2065: Fix schedule handling with higher fixed length value t… [fineract]

adamsaghy commented on code in PR #3836: URL: https://github.com/apache/fineract/pull/3836#discussion_r1543234638 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/AbstractProgressiveLoanScheduleGenerator.java: ## @@ -181,6 +181,13

[PR] FINERACT-2065: Fix schedule handling with higher fixed length value t… [fineract]

alberto-art3ch opened a new pull request, #3836: URL: https://github.com/apache/fineract/pull/3836 …han Loan term ## Description Following with the Loan Product Fixed Length configuration we need to consider the schedule generation with this new setting.