[GitHub] abhijitramesh commented on issue #27: style: removed hard_coded strings

2019-01-16 Thread GitBox
abhijitramesh commented on issue #27: style: removed hard_coded strings URL: https://github.com/apache/fineract-cn-mobile/pull/27#issuecomment-454775298 Changes were made to String that requires translation This is an

[GitHub] abhijitramesh opened a new pull request #27: style: removed hard_coded strings

2019-01-16 Thread GitBox
abhijitramesh opened a new pull request #27: style: removed hard_coded strings URL: https://github.com/apache/fineract-cn-mobile/pull/27 Fixes #33 - [x] Apply the `AndroidStyle.xml` style template to your code in Android Studio. - [x] Run the unit tests with

[GitHub] abhijitramesh opened a new pull request #28: style: removed redundant type casting

2019-01-16 Thread GitBox
abhijitramesh opened a new pull request #28: style: removed redundant type casting URL: https://github.com/apache/fineract-cn-mobile/pull/28 Fixes #32 - [x] Apply the `AndroidStyle.xml` style template to your code in Android Studio. - [x] Run the unit tests with

[GitHub] SunnyDay74 opened a new pull request #510: Thread.run()->Thread.start()

2019-01-16 Thread GitBox
SunnyDay74 opened a new pull request #510: Thread.run()->Thread.start() URL: https://github.com/apache/fineract/pull/510 Hello, To utilize the multiple-thread of Java, is it good to use Thread.start() instead of Thread.run()?