rrpawar96 commented on pull request #1235:
URL: https://github.com/apache/fineract/pull/1235#issuecomment-670226448
@vorburger, yes there is an open JIRA issue for this PR.
https://issues.apache.org/jira/browse/FINERACT-734
thesmallstar commented on pull request #1237:
URL: https://github.com/apache/fineract/pull/1237#issuecomment-670196720
From:
https://demo.fineract.dev/fineract-provider/api-docs/apiLive.htm#periodicaccrualaccounting
and comment from @ptuomola I believe it is not anything sensitive. Hidden
thesmallstar opened a new pull request #1240:
URL: https://github.com/apache/fineract/pull/1240
There are another 175 files that need to be fixed, I will send another PR
for that. I have verified from my side that only "redundant modifiers" as
caught by checkstyle are removed, but I
thesmallstar commented on pull request #1238:
URL: https://github.com/apache/fineract/pull/1238#issuecomment-670168858
Take this code for example:
ptuomola commented on pull request #1237:
URL: https://github.com/apache/fineract/pull/1237#issuecomment-670305942
@thesmallstar great to hear it works! Wonder why it wasn't done like that to
start off with... hope there isn't some sort of non-obvious side effect.
Are there lots of
ptuomola commented on pull request #1207:
URL: https://github.com/apache/fineract/pull/1207#issuecomment-670306126
@thesmallstar thanks - will take a look tomorrow morning!
This is an automated message from the Apache Git
This is an automated email from the ASF dual-hosted git repository.
vorburger pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git
The following commit(s) were added to refs/heads/develop by this push:
new 7b72bbe Update dependency
vorburger merged pull request #1236:
URL: https://github.com/apache/fineract/pull/1236
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
vorburger commented on pull request #1235:
URL: https://github.com/apache/fineract/pull/1235#issuecomment-669755663
Could you please a open a JIRA issue for this, so that it appears on the
Release Notes?
>
This
vorburger merged pull request #1239:
URL: https://github.com/apache/fineract/pull/1239
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
This is an automated email from the ASF dual-hosted git repository.
vorburger pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git
The following commit(s) were added to refs/heads/develop by this push:
new d306bcf FINERACT-971 Added
ptuomola commented on pull request #1237:
URL: https://github.com/apache/fineract/pull/1237#issuecomment-669916044
Hmm... I thought the idea here was that the actual argument
(jsonRequestBody) is hidden, and instead a "pseudo-argument" is created with
the correct schema type using the
12 matches
Mail list logo
