[GitHub] [fineract] Mk9894 commented on a diff in pull request #3317: FINERACT-1943 Add SubmittedOnDate to Savings Transaction

Mk9894 commented on code in PR #3317: URL: https://github.com/apache/fineract/pull/3317#discussion_r1274628139 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsSchedularInterestPoster.java: ## @@ -206,7 +206,8 @@ private void

[GitHub] [fineract] adamsaghy commented on a diff in pull request #3333: FINERACT-1724-Snooze-fee-due-date-payment-due-new-fee-failure

adamsaghy commented on code in PR #: URL: https://github.com/apache/fineract/pull/#discussion_r1274571909 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanAccrualWritePlatformServiceImpl.java: ## @@ -385,10 +385,9 @@ private void

[fineract] branch develop updated: FINERACT-1724-Snooze-fee-due-date-payment-due-new-fee-failure

This is an automated email from the ASF dual-hosted git repository. adamsaghy pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/fineract.git The following commit(s) were added to refs/heads/develop by this push: new dd8e0cf6e

[GitHub] [fineract] adamsaghy commented on a diff in pull request #3317: FINERACT-1943 Add SubmittedOnDate to Savings Transaction

adamsaghy commented on code in PR #3317: URL: https://github.com/apache/fineract/pull/3317#discussion_r1274629900 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsSchedularInterestPoster.java: ## @@ -206,7 +206,8 @@ private void

[GitHub] [fineract] adamsaghy commented on a diff in pull request #3333: FINERACT-1724-Snooze-fee-due-date-payment-due-new-fee-failure

adamsaghy commented on code in PR #: URL: https://github.com/apache/fineract/pull/#discussion_r1274571909 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanAccrualWritePlatformServiceImpl.java: ## @@ -385,10 +385,9 @@ private void

[GitHub] [fineract] adamsaghy commented on a diff in pull request #3315: FINERACT-1724: Refactoring SQLInjectionValidator

adamsaghy commented on code in PR #3315: URL: https://github.com/apache/fineract/pull/3315#discussion_r1274662609 ## fineract-core/src/main/java/org/apache/fineract/infrastructure/security/utils/SQLInjectionValidator.java: ## @@ -180,4 +143,17 @@ private static void

[GitHub] [fineract] adamsaghy commented on a diff in pull request #3315: FINERACT-1724: Refactoring SQLInjectionValidator

adamsaghy commented on code in PR #3315: URL: https://github.com/apache/fineract/pull/3315#discussion_r1274660193 ## fineract-core/src/main/java/org/apache/fineract/infrastructure/security/utils/SQLInjectionValidator.java: ## @@ -180,4 +143,17 @@ private static void

[GitHub] [fineract] adamsaghy commented on a diff in pull request #3317: FINERACT-1943 Add SubmittedOnDate to Savings Transaction

adamsaghy commented on code in PR #3317: URL: https://github.com/apache/fineract/pull/3317#discussion_r1274577292 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsSchedularInterestPoster.java: ## @@ -206,7 +206,8 @@ private void

[GitHub] [fineract] adamsaghy merged pull request #3333: FINERACT-1724-Snooze-fee-due-date-payment-due-new-fee-failure

adamsaghy merged PR #: URL: https://github.com/apache/fineract/pull/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] adamsaghy commented on a diff in pull request #3333: FINERACT-1724-Snooze-fee-due-date-payment-due-new-fee-failure

adamsaghy commented on code in PR #: URL: https://github.com/apache/fineract/pull/#discussion_r1274571909 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanAccrualWritePlatformServiceImpl.java: ## @@ -385,10 +385,9 @@ private void

[GitHub] [fineract] adamsaghy commented on a diff in pull request #3315: FINERACT-1724: Refactoring SQLInjectionValidator

adamsaghy commented on code in PR #3315: URL: https://github.com/apache/fineract/pull/3315#discussion_r1274660193 ## fineract-core/src/main/java/org/apache/fineract/infrastructure/security/utils/SQLInjectionValidator.java: ## @@ -180,4 +143,17 @@ private static void

[GitHub] [fineract] adamsaghy commented on a diff in pull request #3315: FINERACT-1724: Refactoring SQLInjectionValidator

adamsaghy commented on code in PR #3315: URL: https://github.com/apache/fineract/pull/3315#discussion_r1274671039 ## fineract-core/src/main/java/org/apache/fineract/infrastructure/security/utils/SQLCommandCondition.java: ## @@ -0,0 +1,5 @@ +package

[GitHub] [fineract] Mk9894 commented on a diff in pull request #3317: FINERACT-1943 Add SubmittedOnDate to Savings Transaction

Mk9894 commented on code in PR #3317: URL: https://github.com/apache/fineract/pull/3317#discussion_r1274815196 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsSchedularInterestPoster.java: ## @@ -206,7 +206,8 @@ private void

[GitHub] [fineract] adamsaghy merged pull request #3317: FINERACT-1943 Add SubmittedOnDate to Savings Transaction

adamsaghy merged PR #3317: URL: https://github.com/apache/fineract/pull/3317 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[fineract] branch develop updated: FINERACT-1943 Add SubmittedOnDate to Savings Transaction

This is an automated email from the ASF dual-hosted git repository. adamsaghy pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/fineract.git The following commit(s) were added to refs/heads/develop by this push: new fe5d7ccce FINERACT-1943 Add

[GitHub] [fineract] adamsaghy commented on a diff in pull request #3317: FINERACT-1943 Add SubmittedOnDate to Savings Transaction

adamsaghy commented on code in PR #3317: URL: https://github.com/apache/fineract/pull/3317#discussion_r1274786071 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccountTransaction.java: ## @@ -365,6 +369,7 @@ private

[GitHub] [fineract] adamsaghy commented on a diff in pull request #3317: FINERACT-1943 Add SubmittedOnDate to Savings Transaction

adamsaghy commented on code in PR #3317: URL: https://github.com/apache/fineract/pull/3317#discussion_r1274786071 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccountTransaction.java: ## @@ -365,6 +369,7 @@ private

[GitHub] [fineract] marta-jankovics commented on a diff in pull request #3317: FINERACT-1943 Add SubmittedOnDate to Savings Transaction

marta-jankovics commented on code in PR #3317: URL: https://github.com/apache/fineract/pull/3317#discussion_r1274764054 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsSchedularInterestPoster.java: ## @@ -206,7 +206,8 @@ private void

[GitHub] [fineract] marta-jankovics commented on a diff in pull request #3321: Fineract-1910 data table query advanced marta

marta-jankovics commented on code in PR #3321: URL: https://github.com/apache/fineract/pull/3321#discussion_r1275182347 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/data/EntityTables.java: ## @@ -18,88 +18,114 @@ */ package

[GitHub] [fineract] galovics commented on a diff in pull request #3321: Fineract-1910 data table query advanced marta

galovics commented on code in PR #3321: URL: https://github.com/apache/fineract/pull/3321#discussion_r1275016683 ## fineract-core/src/main/java/org/apache/fineract/infrastructure/core/service/database/DatabaseSpecificSQLGenerator.java: ## @@ -189,4 +207,49 @@ public String

[GitHub] [fineract] adamsaghy commented on a diff in pull request #3321: Fineract-1910 data table query advanced marta

adamsaghy commented on code in PR #3321: URL: https://github.com/apache/fineract/pull/3321#discussion_r1275175512 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/data/EntityTables.java: ## @@ -18,88 +18,114 @@ */ package

[GitHub] [fineract] marta-jankovics commented on a diff in pull request #3321: Fineract-1910 data table query advanced marta

marta-jankovics commented on code in PR #3321: URL: https://github.com/apache/fineract/pull/3321#discussion_r1275185065 ## fineract-core/src/main/java/org/apache/fineract/infrastructure/core/service/database/DatabaseSpecificSQLGenerator.java: ## @@ -36,14 +42,26 @@ public

[GitHub] [fineract] galovics commented on a diff in pull request #3321: Fineract-1910 data table query advanced marta

galovics commented on code in PR #3321: URL: https://github.com/apache/fineract/pull/3321#discussion_r1275215678 ## fineract-core/src/main/java/org/apache/fineract/infrastructure/core/service/database/DatabaseSpecificSQLGenerator.java: ## @@ -36,14 +42,26 @@ public

[GitHub] [fineract] adamsaghy commented on a diff in pull request #3321: Fineract-1910 data table query advanced marta

adamsaghy commented on code in PR #3321: URL: https://github.com/apache/fineract/pull/3321#discussion_r1275175512 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/data/EntityTables.java: ## @@ -18,88 +18,114 @@ */ package

[GitHub] [fineract] adamsaghy commented on a diff in pull request #3321: Fineract-1910 data table query advanced marta

adamsaghy commented on code in PR #3321: URL: https://github.com/apache/fineract/pull/3321#discussion_r1275192469 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/data/EntityTables.java: ## @@ -18,88 +18,114 @@ */ package

[GitHub] [fineract] adamsaghy commented on a diff in pull request #3321: Fineract-1910 data table query advanced marta

adamsaghy commented on code in PR #3321: URL: https://github.com/apache/fineract/pull/3321#discussion_r1275192469 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/data/EntityTables.java: ## @@ -18,88 +18,114 @@ */ package

[GitHub] [fineract] adamsaghy commented on a diff in pull request #3321: Fineract-1910 data table query advanced marta

adamsaghy commented on code in PR #3321: URL: https://github.com/apache/fineract/pull/3321#discussion_r1275175512 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/data/EntityTables.java: ## @@ -18,88 +18,114 @@ */ package

[GitHub] [fineract] marta-jankovics commented on a diff in pull request #3321: Fineract-1910 data table query advanced marta

marta-jankovics commented on code in PR #3321: URL: https://github.com/apache/fineract/pull/3321#discussion_r1275178102 ## fineract-core/src/main/java/org/apache/fineract/infrastructure/core/service/database/DatabaseSpecificSQLGenerator.java: ## @@ -36,14 +42,26 @@ public

[GitHub] [fineract] galovics commented on a diff in pull request #3321: Fineract-1910 data table query advanced marta

galovics commented on code in PR #3321: URL: https://github.com/apache/fineract/pull/3321#discussion_r1275216677 ## fineract-core/src/main/java/org/apache/fineract/infrastructure/core/service/database/DatabaseSpecificSQLGenerator.java: ## @@ -36,14 +42,26 @@ public