Re: [PR] FINERTACT-1724: Advanced payment allocation should only support Progr… [fineract]

2023-11-30 Thread via GitHub
josehernandezfintecheandomx commented on code in PR #3611: URL: https://github.com/apache/fineract/pull/3611#discussion_r1411568859 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/AdvancedPaymentAllocationLoanRepaymentScheduleTest.java: ## @@ -2962,6

Re: [PR] FINERTACT-1724: Advanced payment allocation should only support Progr… [fineract]

2023-11-30 Thread via GitHub
josehernandezfintecheandomx commented on PR #3611: URL: https://github.com/apache/fineract/pull/3611#issuecomment-1835410750 > Please see my comments! Comments resolved -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] FINERTACT-1724: Advanced payment allocation should only support Progr… [fineract]

2023-11-30 Thread via GitHub
josehernandezfintecheandomx commented on code in PR #3611: URL: https://github.com/apache/fineract/pull/3611#discussion_r1411568761 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/AdvancedPaymentAllocationLoanRepaymentScheduleTest.java: ## @@ -2962,6

(fineract) branch develop updated: FINERACT-1968 Waive loan charges with advanced payment allocations

2023-11-30 Thread adamsaghy
This is an automated email from the ASF dual-hosted git repository. adamsaghy pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/fineract.git The following commit(s) were added to refs/heads/develop by this push: new 9129fb89a FINERACT-1968 Waive loan

Re: [PR] FINERACT-1992: Multi Delinquency event for installment range change [fineract]

2023-11-30 Thread via GitHub
adamsaghy merged PR #3610: URL: https://github.com/apache/fineract/pull/3610 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(fineract) branch develop updated (9129fb89a -> 570b67b18)

2023-11-30 Thread adamsaghy
This is an automated email from the ASF dual-hosted git repository. adamsaghy pushed a change to branch develop in repository https://gitbox.apache.org/repos/asf/fineract.git from 9129fb89a FINERACT-1968 Waive loan charges with advanced payment allocations add 570b67b18 FINERACT-1992:

Re: [PR] FINERACT-1968 Support for waive loan charges with advanced payment allocations [fineract]

2023-11-30 Thread via GitHub
adamsaghy merged PR #3609: URL: https://github.com/apache/fineract/pull/3609 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] FINERTACT-1724: Advanced payment allocation should only support Progr… [fineract]

2023-11-30 Thread via GitHub
adamsaghy commented on code in PR #3611: URL: https://github.com/apache/fineract/pull/3611#discussion_r1410410854 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/AdvancedPaymentAllocationLoanRepaymentScheduleTest.java: ## @@ -2962,6 +2962,32 @@ public

Re: [PR] FINERTACT-1724: Advanced payment allocation should only support Progr… [fineract]

2023-11-30 Thread via GitHub
adamsaghy commented on code in PR #3611: URL: https://github.com/apache/fineract/pull/3611#discussion_r1410411544 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanproduct/serialization/LoanProductDataValidator.java: ## @@ -1788,6 +1795,14 @@ public void

Re: [PR] FINERACT-1992: Multi Delinquency event for installment range change [fineract]

2023-11-30 Thread via GitHub
ruchiD commented on code in PR #3610: URL: https://github.com/apache/fineract/pull/3610#discussion_r1410286448 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/delinquency/service/DelinquencyWritePlatformServiceImpl.java: ## @@ -441,20 +450,29 @@ public int

[PR] FINERACT-1992 Fixing consecutive pause periods [fineract]

2023-11-30 Thread via GitHub
reluxa opened a new pull request, #3614: URL: https://github.com/apache/fineract/pull/3614 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

Re: [PR] FINERTACT-1724: Advanced payment allocation should only support Progr… [fineract]

2023-11-30 Thread via GitHub
adamsaghy commented on code in PR #3611: URL: https://github.com/apache/fineract/pull/3611#discussion_r1410412492 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/AdvancedPaymentAllocationLoanRepaymentScheduleTest.java: ## @@ -2962,6 +2962,32 @@ public

[PR] FINERACT-1971 Credit balance refund for future date shall be rejected [fineract]

2023-11-30 Thread via GitHub
reluxa opened a new pull request, #3616: URL: https://github.com/apache/fineract/pull/3616 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

Re: [PR] FINERACT-1724 Fix compilation issue after auto rebase [fineract]

2023-11-30 Thread via GitHub
adamsaghy merged PR #3615: URL: https://github.com/apache/fineract/pull/3615 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(fineract) branch develop updated: FINERACT-1724 Fix compilation issue after auto rebase

2023-11-30 Thread adamsaghy
This is an automated email from the ASF dual-hosted git repository. adamsaghy pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/fineract.git The following commit(s) were added to refs/heads/develop by this push: new 5e5511f70 FINERACT-1724 Fix compilation

(fineract) branch develop updated: FINERACT-1981: Order disbursements and repayment periods properly

2023-11-30 Thread adamsaghy
This is an automated email from the ASF dual-hosted git repository. adamsaghy pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/fineract.git The following commit(s) were added to refs/heads/develop by this push: new ea68edce2 FINERACT-1981: Order

Re: [PR] FINERACT-1992 Fixing consecutive pause periods [fineract]

2023-11-30 Thread via GitHub
adamsaghy merged PR #3614: URL: https://github.com/apache/fineract/pull/3614 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] FINERACT-1981: Order disbursements and repayment periods properly for Progressive loan schedule [fineract]

2023-11-30 Thread via GitHub
adamsaghy merged PR #3607: URL: https://github.com/apache/fineract/pull/3607 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] FINERACT-1724 Fix compilation issue after auto rebase [fineract]

2023-11-30 Thread via GitHub
reluxa opened a new pull request, #3615: URL: https://github.com/apache/fineract/pull/3615 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

(fineract) branch develop updated: FINERACT-1992 Fixing consecutive pause periods

2023-11-30 Thread adamsaghy
This is an automated email from the ASF dual-hosted git repository. adamsaghy pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/fineract.git The following commit(s) were added to refs/heads/develop by this push: new b08fd9b57 FINERACT-1992 Fixing

Re: [PR] FINERACT-1981: Order disbursements and repayment periods properly for Progressive loan schedule [fineract]

2023-11-30 Thread via GitHub
reluxa commented on code in PR #3607: URL: https://github.com/apache/fineract/pull/3607#discussion_r1410516896 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/AdvancedPaymentAllocationLoanRepaymentScheduleTest.java: ## @@ -122,10 +121,7 @@ public static

Re: [PR] FINERACT-1956: Added the skeleton structure necessary to publish doc … [fineract]

2023-11-30 Thread via GitHub
jdailey commented on PR #3331: URL: https://github.com/apache/fineract/pull/3331#issuecomment-1834595643 Aleks - can we push now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] FINERACT-1956: Added the skeleton structure necessary to publish doc … [fineract]

2023-11-30 Thread via GitHub
jdailey commented on PR #3331: URL: https://github.com/apache/fineract/pull/3331#issuecomment-1834607207 No conflicts w base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] FINERACT-1971 Credit balance refund for future date shall be rejected [fineract]

2023-11-30 Thread via GitHub
adamsaghy merged PR #3616: URL: https://github.com/apache/fineract/pull/3616 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(fineract) branch develop updated: FINERACT-1971 Credit balance refund for future date shall be rejected

2023-11-30 Thread adamsaghy
This is an automated email from the ASF dual-hosted git repository. adamsaghy pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/fineract.git The following commit(s) were added to refs/heads/develop by this push: new 8505145fd FINERACT-1971 Credit balance

[PR] FINERACT-1805: Fix getting details of a share transactions [fineract]

2023-11-30 Thread via GitHub
mariiaKraievska opened a new pull request, #3617: URL: https://github.com/apache/fineract/pull/3617 ## Description Loan and Savings transactionIds start with a single capital letter (L and S repectively) but share transactions start with 2 capital letters (SH). Originally all

Re: [PR] FINERACT-1971: Fix (disabled) job scheduling [fineract]

2023-11-30 Thread via GitHub
github-actions[bot] commented on PR #3550: URL: https://github.com/apache/fineract/pull/3550#issuecomment-1835031414 This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. -- This is an automated message from the Apache Git