[GitHub] fineract pull request #424: Notification sub-system

2017-12-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/fineract/pull/424 ---

[GitHub] fineract pull request #405: Notification sub-system

2017-12-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/fineract/pull/405 ---

[1/2] fineract git commit: Close #405

2017-12-13 Thread avikg
Repository: fineract Updated Branches: refs/heads/develop b3c94ebca -> 95ff9ab3c Close #405 Project: http://git-wip-us.apache.org/repos/asf/fineract/repo Commit: http://git-wip-us.apache.org/repos/asf/fineract/commit/bd5225b7 Tree:

[2/2] fineract git commit: Close #424

2017-12-13 Thread avikg
Close #424 Project: http://git-wip-us.apache.org/repos/asf/fineract/repo Commit: http://git-wip-us.apache.org/repos/asf/fineract/commit/95ff9ab3 Tree: http://git-wip-us.apache.org/repos/asf/fineract/tree/95ff9ab3 Diff: http://git-wip-us.apache.org/repos/asf/fineract/diff/95ff9ab3 Branch:

[GitHub] fineract issue #424: Notification sub-system

2017-12-13 Thread avikganguly01
Github user avikganguly01 commented on the issue: https://github.com/apache/fineract/pull/424 @Anh3h : I have taken the liberty of rebasing your code, fixing a minor conflict and merging it. Closing this PR as well as your previous open PR which I believe is a subset of this PR.

[GitHub] fineract pull request #135: validating disbursement date against expected di...

2017-12-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/fineract/pull/135 ---

fineract git commit: Close #135

2017-12-13 Thread avikg
Repository: fineract Updated Branches: refs/heads/develop 0b0212966 -> b3c94ebca Close #135 Project: http://git-wip-us.apache.org/repos/asf/fineract/repo Commit: http://git-wip-us.apache.org/repos/asf/fineract/commit/b3c94ebc Tree:

[GitHub] fineract issue #135: validating disbursement date against expected disbursem...

2017-12-13 Thread avikganguly01
Github user avikganguly01 commented on the issue: https://github.com/apache/fineract/pull/135 @nazeer1100126 : I think that this validation is already there but the code seems to be attempting some sort of sync. Closing this as I could not find any open JIRA ticket related to this.

[2/5] fineract git commit: Add Spring Events to be used when activemq is not available

2017-12-13 Thread avikg
Add Spring Events to be used when activemq is not available Project: http://git-wip-us.apache.org/repos/asf/fineract/repo Commit: http://git-wip-us.apache.org/repos/asf/fineract/commit/0b021296 Tree: http://git-wip-us.apache.org/repos/asf/fineract/tree/0b021296 Diff:

[3/5] fineract git commit: Notification sub-system

2017-12-13 Thread avikg
http://git-wip-us.apache.org/repos/asf/fineract/blob/7395d6c5/fineract-provider/src/main/java/org/apache/fineract/notification/service/TopicReadPlatformServiceImpl.java -- diff --git

[1/5] fineract git commit: Add Spring Events to be used when activemq is not available

2017-12-13 Thread avikg
Repository: fineract Updated Branches: refs/heads/develop 06932137b -> 0b0212966 http://git-wip-us.apache.org/repos/asf/fineract/blob/0b021296/fineract-provider/src/test/java/org/apache/fineract/notification/StorageTest.java

[5/5] fineract git commit: Removing unnecessary constructors

2017-12-13 Thread avikg
Removing unnecessary constructors Project: http://git-wip-us.apache.org/repos/asf/fineract/repo Commit: http://git-wip-us.apache.org/repos/asf/fineract/commit/58184a52 Tree: http://git-wip-us.apache.org/repos/asf/fineract/tree/58184a52 Diff:

[4/5] fineract git commit: Notification sub-system

2017-12-13 Thread avikg
Notification sub-system Project: http://git-wip-us.apache.org/repos/asf/fineract/repo Commit: http://git-wip-us.apache.org/repos/asf/fineract/commit/7395d6c5 Tree: http://git-wip-us.apache.org/repos/asf/fineract/tree/7395d6c5 Diff: http://git-wip-us.apache.org/repos/asf/fineract/diff/7395d6c5

[GitHub] fineract-site issue #10: Congratulations on graduating!

2017-12-13 Thread myrle-krantz
Github user myrle-krantz commented on the issue: https://github.com/apache/fineract-site/pull/10 Thank you Shane! Sorry, I didn't see your pull request sooner! ---

[1/3] fineract-site git commit: Congratulations on graduating!

2017-12-13 Thread myrle
Repository: fineract-site Updated Branches: refs/heads/master e7ec048cc -> 289d8366d Congratulations on graduating! Project: http://git-wip-us.apache.org/repos/asf/fineract-site/repo Commit: http://git-wip-us.apache.org/repos/asf/fineract-site/commit/3ad10703 Tree:

[3/3] fineract-site git commit: Merge branch 'ShaneCurcuru-patch-1' into asf-site

2017-12-13 Thread myrle
Merge branch 'ShaneCurcuru-patch-1' into asf-site Project: http://git-wip-us.apache.org/repos/asf/fineract-site/repo Commit: http://git-wip-us.apache.org/repos/asf/fineract-site/commit/077583b5 Tree: http://git-wip-us.apache.org/repos/asf/fineract-site/tree/077583b5 Diff:

[GitHub] fineract-site pull request #10: Congratulations on graduating!

2017-12-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/fineract-site/pull/10 ---

[2/3] fineract-site git commit: Merge branch 'patch-1' of https://github.com/ShaneCurcuru/fineract-site into ShaneCurcuru-patch-1

2017-12-13 Thread myrle
Merge branch 'patch-1' of https://github.com/ShaneCurcuru/fineract-site into ShaneCurcuru-patch-1 Project: http://git-wip-us.apache.org/repos/asf/fineract-site/repo Commit: http://git-wip-us.apache.org/repos/asf/fineract-site/commit/4af4a814 Tree:

[3/3] fineract-site git commit: Merge branch 'ShaneCurcuru-patch-1'

2017-12-13 Thread myrle
Merge branch 'ShaneCurcuru-patch-1' Project: http://git-wip-us.apache.org/repos/asf/fineract-site/repo Commit: http://git-wip-us.apache.org/repos/asf/fineract-site/commit/289d8366 Tree: http://git-wip-us.apache.org/repos/asf/fineract-site/tree/289d8366 Diff:

[2/3] fineract-site git commit: Merge branch 'patch-1' of https://github.com/ShaneCurcuru/fineract-site into ShaneCurcuru-patch-1

2017-12-13 Thread myrle
Merge branch 'patch-1' of https://github.com/ShaneCurcuru/fineract-site into ShaneCurcuru-patch-1 Project: http://git-wip-us.apache.org/repos/asf/fineract-site/repo Commit: http://git-wip-us.apache.org/repos/asf/fineract-site/commit/4af4a814 Tree:

[1/3] fineract-site git commit: Congratulations on graduating!

2017-12-13 Thread myrle
Repository: fineract-site Updated Branches: refs/heads/asf-site e7ec048cc -> 077583b54 Congratulations on graduating! Project: http://git-wip-us.apache.org/repos/asf/fineract-site/repo Commit: http://git-wip-us.apache.org/repos/asf/fineract-site/commit/3ad10703 Tree:

[GitHub] fineract issue #380: (FINERACT-241) Include "Add Note" to Savings Transactio...

2017-12-13 Thread nazeer1100126
Github user nazeer1100126 commented on the issue: https://github.com/apache/fineract/pull/380 @myrle-krantz Thank you :-) ---

[GitHub] fineract issue #380: (FINERACT-241) Include "Add Note" to Savings Transactio...

2017-12-13 Thread myrle-krantz
Github user myrle-krantz commented on the issue: https://github.com/apache/fineract/pull/380 Have closed. For future reference, you can close a PR with an empty commit message as explained here:

fineract git commit: Close #380

2017-12-13 Thread myrle
Repository: fineract Updated Branches: refs/heads/develop 3c69754f2 -> 06932137b Close #380 Project: http://git-wip-us.apache.org/repos/asf/fineract/repo Commit: http://git-wip-us.apache.org/repos/asf/fineract/commit/06932137 Tree:

[GitHub] fineract pull request #380: (FINERACT-241) Include "Add Note" to Savings Tra...

2017-12-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/fineract/pull/380 ---

[GitHub] fineract issue #409: GSOC'17:swagger and swagger UI integration on fineract-...

2017-12-13 Thread avikganguly01
Github user avikganguly01 commented on the issue: https://github.com/apache/fineract/pull/409 @Sanyam96 : I am unable to pull in this code as you included following files in your source which I believe belongs to Swagger. src/main/resources/swagger-ui/swagger-ui-bundle.js.map

[GitHub] fineract issue #380: (FINERACT-241) Include "Add Note" to Savings Transactio...

2017-12-13 Thread nazeer1100126
Github user nazeer1100126 commented on the issue: https://github.com/apache/fineract/pull/380 @myrle-krantz please close this PR. I have already implemented this feature and it is merged recently ---

[GitHub] fineract issue #118: 293_post_interest_job

2017-12-13 Thread myrle-krantz
Github user myrle-krantz commented on the issue: https://github.com/apache/fineract/pull/118 ping Is this pull request still "alive"? Will Nazeer and Avik's question receive an answer? If there's no response in a week this pull request will be closed. ---

[GitHub] fineract issue #118: 293_post_interest_job

2017-12-13 Thread myrlen
Github user myrlen commented on the issue: https://github.com/apache/fineract/pull/118 PR ping. Is this Pull Request still alive? ---

[GitHub] fineract pull request #116: Adding multiple selection option for reportparam...

2017-12-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/fineract/pull/116 ---

fineract git commit: Close #116

2017-12-13 Thread myrle
Repository: fineract Updated Branches: refs/heads/develop 1c0af3ba2 -> 3c69754f2 Close #116 Project: http://git-wip-us.apache.org/repos/asf/fineract/repo Commit: http://git-wip-us.apache.org/repos/asf/fineract/commit/3c69754f Tree:

[GitHub] fineract pull request #256: FINERACT-7: Sort loanInstallmentCharges before u...

2017-12-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/fineract/pull/256 ---

[GitHub] fineract issue #429: EOY-Closure: FINERACT-38

2017-12-13 Thread Ippezrobert
Github user Ippezrobert commented on the issue: https://github.com/apache/fineract/pull/429 @avikganguly01 , Conflict Resolved so you can review and the ticket is https://issues.apache.org/jira/browse/FINERACT-38 ---

[GitHub] fineract issue #152: FINERACT-186 batch job optimisation

2017-12-13 Thread avikganguly01
Github user avikganguly01 commented on the issue: https://github.com/apache/fineract/pull/152 @nazeer1100126 : I am fine with this change. Should I go ahead, resolve the conflict and merge it? ---

[GitHub] fineract issue #417: Associate guid with request

2017-12-13 Thread avikganguly01
Github user avikganguly01 commented on the issue: https://github.com/apache/fineract/pull/417 @lingalamadhukar : Can you address Nazeer's comment so that the PR can be reviewed? ---

[GitHub] fineract issue #407: Group loan Individual monitoring and group saving indiv...

2017-12-13 Thread avikganguly01
Github user avikganguly01 commented on the issue: https://github.com/apache/fineract/pull/407 @nikpawar89 : How are the unit tests going? I have tested out the functionality of the code as per the demo and it looks great. If you can push the unit tests and fix the conflicts, this can

[GitHub] fineract issue #424: Notification sub-system

2017-12-13 Thread avikganguly01
Github user avikganguly01 commented on the issue: https://github.com/apache/fineract/pull/424 @Anh3h : Great to see that you covered spring events, can you fix the conflicts so that this can be pulled in? ---

[15/19] fineract git commit: all modules populate & import

2017-12-13 Thread avikg
http://git-wip-us.apache.org/repos/asf/fineract/blob/210647d4/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/savings/SavingsAccountHelper.java -- diff --git

[13/19] fineract git commit: all modules populate & import

2017-12-13 Thread avikg
http://git-wip-us.apache.org/repos/asf/fineract/blob/210647d4/fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/importhandler/client/ClientPersonImportHandler.java -- diff --git

[05/19] fineract git commit: all modules populate & import

2017-12-13 Thread avikg
http://git-wip-us.apache.org/repos/asf/fineract/blob/210647d4/fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/populator/savings/SavingsWorkbookPopulator.java -- diff --git

[09/19] fineract git commit: all modules populate & import

2017-12-13 Thread avikg
http://git-wip-us.apache.org/repos/asf/fineract/blob/210647d4/fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/populator/centers/CentersWorkbookPopulator.java -- diff --git

[02/19] fineract git commit: all modules populate & import

2017-12-13 Thread avikg
http://git-wip-us.apache.org/repos/asf/fineract/blob/210647d4/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/data/LoanAccountData.java -- diff --git

[10/19] fineract git commit: all modules populate & import

2017-12-13 Thread avikg
http://git-wip-us.apache.org/repos/asf/fineract/blob/210647d4/fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/populator/ExtrasSheetPopulator.java -- diff --git

[17/19] fineract git commit: Merge branch 'extend-mifos-data-import-tool-branch-all-modules' of https://github.com/wkk91193/incubator-fineract into dit

2017-12-13 Thread avikg
Merge branch 'extend-mifos-data-import-tool-branch-all-modules' of https://github.com/wkk91193/incubator-fineract into dit Project: http://git-wip-us.apache.org/repos/asf/fineract/repo Commit: http://git-wip-us.apache.org/repos/asf/fineract/commit/4c302865 Tree:

[07/19] fineract git commit: all modules populate & import

2017-12-13 Thread avikg
http://git-wip-us.apache.org/repos/asf/fineract/blob/210647d4/fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/populator/journalentry/JournalEntriesWorkbookPopulator.java -- diff --git

[01/19] fineract git commit: all modules populate & import

2017-12-13 Thread avikg
Repository: fineract Updated Branches: refs/heads/develop bf894732d -> 98f5612ac http://git-wip-us.apache.org/repos/asf/fineract/blob/210647d4/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/data/SavingsAccountApplicationTimelineData.java

[06/19] fineract git commit: all modules populate & import

2017-12-13 Thread avikg
http://git-wip-us.apache.org/repos/asf/fineract/blob/210647d4/fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/populator/recurringdeposit/RecurringDepositTransactionWorkbookPopulator.java -- diff --git

[12/19] fineract git commit: all modules populate & import

2017-12-13 Thread avikg
http://git-wip-us.apache.org/repos/asf/fineract/blob/210647d4/fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/importhandler/journalentry/JournalEntriesImportHandler.java -- diff --git

[03/19] fineract git commit: all modules populate & import

2017-12-13 Thread avikg
http://git-wip-us.apache.org/repos/asf/fineract/blob/210647d4/fineract-provider/src/main/java/org/apache/fineract/portfolio/accounts/api/AccountsApiResource.java -- diff --git

[16/19] fineract git commit: all modules populate & import

2017-12-13 Thread avikg
all modules populate & import Project: http://git-wip-us.apache.org/repos/asf/fineract/repo Commit: http://git-wip-us.apache.org/repos/asf/fineract/commit/210647d4 Tree: http://git-wip-us.apache.org/repos/asf/fineract/tree/210647d4 Diff:

[19/19] fineract git commit: Merge DIT branch

2017-12-13 Thread avikg
Merge DIT branch Project: http://git-wip-us.apache.org/repos/asf/fineract/repo Commit: http://git-wip-us.apache.org/repos/asf/fineract/commit/98f5612a Tree: http://git-wip-us.apache.org/repos/asf/fineract/tree/98f5612a Diff: http://git-wip-us.apache.org/repos/asf/fineract/diff/98f5612a Branch:

[08/19] fineract git commit: all modules populate & import

2017-12-13 Thread avikg
http://git-wip-us.apache.org/repos/asf/fineract/blob/210647d4/fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/populator/fixeddeposits/FixedDepositTransactionWorkbookPopulator.java -- diff --git

[GitHub] fineract pull request #415: Extend-mifos-data-import-tool-all-modules-popula...

2017-12-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/fineract/pull/415 ---