[GitHub] pembemiriam commented on issue #2: fixed issues due to angular redux

2018-08-01 Thread GitBox
pembemiriam commented on issue #2: fixed issues due to angular redux URL: https://github.com/apache/fineract-cn-group-finance/pull/2#issuecomment-409800226 Hello Awasum, I tried doing npm audit but I got an error saying 'audit' is not an npm command. NodeJS version: 8.9.4

[GitHub] awasum commented on issue #2: fixed issues due to angular redux

2018-08-01 Thread GitBox
awasum commented on issue #2: fixed issues due to angular redux URL: https://github.com/apache/fineract-cn-group-finance/pull/2#issuecomment-409693391 Did you check all the previous comments on the PR thread? Run npm audit and see if you dont get vulnerability issues. What version of

[GitHub] pembemiriam commented on issue #2: fixed issues due to angular redux

2018-08-01 Thread GitBox
pembemiriam commented on issue #2: fixed issues due to angular redux URL: https://github.com/apache/fineract-cn-group-finance/pull/2#issuecomment-409666205 Hello Awasum, I don't have any vulnerability issues so far in the repository that I am pushing to so I hope everything will

[GitHub] kengneruphine opened a new pull request #6: Extending fims-web-app to provide a UI for the Group microservice

2018-08-01 Thread GitBox
kengneruphine opened a new pull request #6: Extending fims-web-app to provide a UI for the Group microservice URL: https://github.com/apache/fineract-cn-fims-web-app/pull/6 Description For GSoC, I have extended the fims-web-app to provide a web UI for the Group microservice. I have

[GitHub] fineract pull request #452: fineract changes for community app bug 1863

2018-08-01 Thread ShruthiRajaram
Github user ShruthiRajaram commented on a diff in the pull request: https://github.com/apache/fineract/pull/452#discussion_r206880756 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/accountdetails/service/AccountDetailsReadPlatformServiceJpaRepositoryImpl.java

[GitHub] fineract pull request #465: Fineract 614: Rates module

2018-08-01 Thread ShruthiRajaram
Github user ShruthiRajaram commented on a diff in the pull request: https://github.com/apache/fineract/pull/465#discussion_r206853841 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanproduct/service/LoanProductReadPlatformServiceImpl.java --- @@ -465,7

[GitHub] fineract pull request #465: Fineract 614: Rates module

2018-08-01 Thread ShruthiRajaram
Github user ShruthiRajaram commented on a diff in the pull request: https://github.com/apache/fineract/pull/465#discussion_r206854050 --- Diff: fineract-provider/src/main/resources/sql/migrations/core_db/V343__rates.sql --- @@ -0,0 +1,62 @@ +-- +-- Licensed to the Apache

[GitHub] fineract pull request #465: Fineract 614: Rates module

2018-08-01 Thread ShruthiRajaram
Github user ShruthiRajaram commented on a diff in the pull request: https://github.com/apache/fineract/pull/465#discussion_r206853561 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanUtilService.java --- @@ -325,4 +332,35 @@ private

[GitHub] fineract pull request #465: Fineract 614: Rates module

2018-08-01 Thread ShruthiRajaram
Github user ShruthiRajaram commented on a diff in the pull request: https://github.com/apache/fineract/pull/465#discussion_r206853418 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/api/LoansApiResource.java --- @@ -178,30 +180,30 @@

[GitHub] fineract pull request #465: Fineract 614: Rates module

2018-08-01 Thread ShruthiRajaram
Github user ShruthiRajaram commented on a diff in the pull request: https://github.com/apache/fineract/pull/465#discussion_r206853778 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanproduct/domain/LoanProduct.java --- @@ -102,6 +103,10 @@

[GitHub] fineract pull request #465: Fineract 614: Rates module

2018-08-01 Thread ShruthiRajaram
Github user ShruthiRajaram commented on a diff in the pull request: https://github.com/apache/fineract/pull/465#discussion_r206853632 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanUtilService.java --- @@ -325,4 +332,35 @@ private

[GitHub] fineract pull request #465: Fineract 614: Rates module

2018-08-01 Thread ShruthiRajaram
Github user ShruthiRajaram commented on a diff in the pull request: https://github.com/apache/fineract/pull/465#discussion_r206853956 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/rate/handler/DeleteRateCommandHandler.java --- @@ -0,0 +1,26 @@ +/**

[GitHub] fineract pull request #465: Fineract 614: Rates module

2018-08-01 Thread ShruthiRajaram
Github user ShruthiRajaram commented on a diff in the pull request: https://github.com/apache/fineract/pull/465#discussion_r206853697 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanUtilService.java --- @@ -325,4 +332,35 @@ private

[GitHub] fineract pull request #465: Fineract 614: Rates module

2018-08-01 Thread ShruthiRajaram
Github user ShruthiRajaram commented on a diff in the pull request: https://github.com/apache/fineract/pull/465#discussion_r206853888 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanproduct/service/LoanProductWritePlatformServiceJpaRepositoryImpl.java ---

[GitHub] fineract pull request #465: Fineract 614: Rates module

2018-08-01 Thread ShruthiRajaram
Github user ShruthiRajaram commented on a diff in the pull request: https://github.com/apache/fineract/pull/465#discussion_r206854038 --- Diff: fineract-provider/src/main/resources/sql/migrations/core_db/V343__rates.sql --- @@ -0,0 +1,62 @@ +-- +-- Licensed to the Apache

[GitHub] fineract pull request #465: Fineract 614: Rates module

2018-08-01 Thread ShruthiRajaram
Github user ShruthiRajaram commented on a diff in the pull request: https://github.com/apache/fineract/pull/465#discussion_r206853497 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java --- @@ -392,20 +395,24 @@

[GitHub] awasum commented on issue #2: fixed issues due to angular redux

2018-08-01 Thread GitBox
awasum commented on issue #2: fixed issues due to angular redux URL: https://github.com/apache/fineract-cn-group-finance/pull/2#issuecomment-409467380 @pembemiriam Have u fixed the vulnerabilities in this latest commit? This

[GitHub] fineract pull request #465: Fineract 614: Rates module

2018-08-01 Thread ShruthiRajaram
Github user ShruthiRajaram commented on a diff in the pull request: https://github.com/apache/fineract/pull/465#discussion_r206768853 --- Diff: fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/serialization/JsonParserHelper.java --- @@ -454,7 +454,7 @@

[GitHub] fineract pull request #467: FINERACT-628 Savings account APIs for Self Servi...

2018-08-01 Thread ShruthiRajaram
GitHub user ShruthiRajaram opened a pull request: https://github.com/apache/fineract/pull/467 FINERACT-628 Savings account APIs for Self Service App You can merge this pull request into a Git repository by running: $ git pull https://github.com/ShruthiRajaram/fineract