[GitHub] fineract pull request #465: Fineract 614: Rates module

2018-08-02 Thread angelboxes
Github user angelboxes commented on a diff in the pull request: https://github.com/apache/fineract/pull/465#discussion_r207370679 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java --- @@ -392,20 +395,24 @@

[GitHub] fineract pull request #465: Fineract 614: Rates module

2018-08-02 Thread angelboxes
Github user angelboxes commented on a diff in the pull request: https://github.com/apache/fineract/pull/465#discussion_r207369492 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/api/LoansApiResource.java --- @@ -178,30 +180,30 @@

[GitHub] fineract pull request #465: Fineract 614: Rates module

2018-08-02 Thread angelboxes
Github user angelboxes commented on a diff in the pull request: https://github.com/apache/fineract/pull/465#discussion_r207369345 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/rate/handler/DeleteRateCommandHandler.java --- @@ -0,0 +1,26 @@ +/**

[GitHub] fineract pull request #465: Fineract 614: Rates module

2018-08-02 Thread angelboxes
Github user angelboxes commented on a diff in the pull request: https://github.com/apache/fineract/pull/465#discussion_r207365498 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanUtilService.java --- @@ -325,4 +332,35 @@ private

[GitHub] fineract pull request #465: Fineract 614: Rates module

2018-08-02 Thread angelboxes
Github user angelboxes commented on a diff in the pull request: https://github.com/apache/fineract/pull/465#discussion_r207364751 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanproduct/domain/LoanProduct.java --- @@ -102,6 +103,10 @@

[GitHub] fineract pull request #465: Fineract 614: Rates module

2018-08-02 Thread angelboxes
Github user angelboxes commented on a diff in the pull request: https://github.com/apache/fineract/pull/465#discussion_r207358094 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanUtilService.java --- @@ -325,4 +332,35 @@ private

[fineract-cn-fims-web-app] branch develop updated (58252f8 -> 6b10d04)

2018-08-02 Thread awasum
This is an automated email from the ASF dual-hosted git repository. awasum pushed a change to branch develop in repository https://gitbox.apache.org/repos/asf/fineract-cn-fims-web-app.git. from 58252f8 Merge pull request #6 from kengneruphine/develop add 40beedc Lift node version max

[fineract-cn-fims-web-app] 01/01: Merge pull request #5 from davidyaha/feature/fix-ts

2018-08-02 Thread awasum
This is an automated email from the ASF dual-hosted git repository. awasum pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/fineract-cn-fims-web-app.git commit 6b10d04bf196c432dac28e1b858b8a9a621738cd Merge: 58252f8 3bcc5ef Author: Awasum Yannick AuthorDate:

[GitHub] awasum commented on issue #5: Fix ts compilation

2018-08-02 Thread GitBox
awasum commented on issue #5: Fix ts compilation URL: https://github.com/apache/fineract-cn-fims-web-app/pull/5#issuecomment-410013829 Thanks for your answer @davidyaha , A new PR has just been merged which attempts to fix the vulnerability problems. See:

[fineract-cn-fims-web-app] branch develop updated (1a7b311 -> 58252f8)

2018-08-02 Thread awasum
This is an automated email from the ASF dual-hosted git repository. awasum pushed a change to branch develop in repository https://gitbox.apache.org/repos/asf/fineract-cn-fims-web-app.git. from 1a7b311 Merge pull request #4 from myrle-krantz/develop add 4fbe03f create group component

[fineract-cn-fims-web-app] 01/01: Merge pull request #6 from kengneruphine/develop

2018-08-02 Thread awasum
This is an automated email from the ASF dual-hosted git repository. awasum pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/fineract-cn-fims-web-app.git commit 58252f8bdf639443dd9549ad224fe8ac00d00c83 Merge: 1a7b311 ba6f421 Author: Awasum Yannick AuthorDate:

[GitHub] davidyaha commented on issue #5: Fix ts compilation

2018-08-02 Thread GitBox
davidyaha commented on issue #5: Fix ts compilation URL: https://github.com/apache/fineract-cn-fims-web-app/pull/5#issuecomment-409992342 Hey @awasum! Thanks for taking the time to review my PR! Didn't see those vulnerability issues before upgrading my `npm` to version ^6 so that's

[GitHub] kengneruphine opened a new pull request #7: Changes added to the Group Microservice

2018-08-02 Thread GitBox
kengneruphine opened a new pull request #7: Changes added to the Group Microservice URL: https://github.com/apache/fineract-cn-group/pull/7 Here are the changes I added to the Group microservice - PermittableGroupIds to group and modifying the boostrap .yml - Modify the requestparams

[GitHub] kengneruphine commented on issue #6: Extending fims-web-app to provide a UI for the Group microservice

2018-08-02 Thread GitBox
kengneruphine commented on issue #6: Extending fims-web-app to provide a UI for the Group microservice URL: https://github.com/apache/fineract-cn-fims-web-app/pull/6#issuecomment-409964176 Hello, I have reverted the base Urls for the different services in the proxy.conf.json

[GitHub] awasum commented on issue #6: Extending fims-web-app to provide a UI for the Group microservice

2018-08-02 Thread GitBox
awasum commented on issue #6: Extending fims-web-app to provide a UI for the Group microservice URL: https://github.com/apache/fineract-cn-fims-web-app/pull/6#issuecomment-409924278 @kengneruphine This commit changes the base urls of the different services:

[GitHub] awasum commented on issue #5: Fix ts compilation

2018-08-02 Thread GitBox
awasum commented on issue #5: Fix ts compilation URL: https://github.com/apache/fineract-cn-fims-web-app/pull/5#issuecomment-409917948 @davidyaha Did you see these Vulnerability issues when you ran 'npm i' ? Or is this just from my side? Try to address them and I can merge.

[fineract-cn-group-finance] 01/01: Merge pull request #3 from awasum/master

2018-08-02 Thread awasum
This is an automated email from the ASF dual-hosted git repository. awasum pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/fineract-cn-group-finance.git commit e62bc13cc5c032b78e47c3cd9f7b327f84176d0d Merge: eea6746 2f31a0c Author: Awasum Yannick AuthorDate:

[GitHub] awasum opened a new pull request #3: Fixed security vulnerabilities using 'npm audit fix' command

2018-08-02 Thread GitBox
awasum opened a new pull request #3: Fixed security vulnerabilities using 'npm audit fix' command URL: https://github.com/apache/fineract-cn-group-finance/pull/3 ## Description Fixed security vulnerabilities using 'npm audit fix' command ### What's included? - Package

[fineract-cn-group-finance] 01/01: Merge pull request #2 from pembemiriam/master

2018-08-02 Thread awasum
This is an automated email from the ASF dual-hosted git repository. awasum pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/fineract-cn-group-finance.git commit eea6746f60bdbb89e1d4ecda823a9be479b483cc Merge: f990533 8339859 Author: Awasum Yannick AuthorDate:

[GitHub] awasum commented on issue #2: fixed issues due to angular redux

2018-08-02 Thread GitBox
awasum commented on issue #2: fixed issues due to angular redux URL: https://github.com/apache/fineract-cn-group-finance/pull/2#issuecomment-409910802 Ok This is an automated message from the Apache Git Service. To respond

[GitHub] mohak1712 opened a new pull request #19: added payroll api support

2018-08-02 Thread GitBox
mohak1712 opened a new pull request #19: added payroll api support URL: https://github.com/apache/fineract-cn-mobile/pull/19 Please make sure these boxes are checked before submitting your pull request - thanks! - [x] Apply the `AndroidStyle.xml` style template to your code in