[fineract-cn-office] branch develop updated (3b2677b -> 5d496da)

2018-09-05 Thread awasum
This is an automated email from the ASF dual-hosted git repository. awasum pushed a change to branch develop in repository https://gitbox.apache.org/repos/asf/fineract-cn-office.git. from 3b2677b Merge pull request #6 from apache/revert-5-develop add b6b7c0d Set up testing and

[GitHub] awasum closed pull request #7: Document office API to manage offices & employees

2018-09-05 Thread GitBox
awasum closed pull request #7: Document office API to manage offices & employees URL: https://github.com/apache/fineract-cn-office/pull/7 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] Izakey commented on issue #7: Document office API to manage offices & employees

2018-09-05 Thread GitBox
Izakey commented on issue #7: Document office API to manage offices & employees URL: https://github.com/apache/fineract-cn-office/pull/7#issuecomment-418689441 Thanks very much Awasum, I've updated the PR with some fixes. I await your review.

[GitHub] Izakey removed a comment on issue #7: Document APIs for transaction types, journal entries, accounts and le…

2018-09-05 Thread GitBox
Izakey removed a comment on issue #7: Document APIs for transaction types, journal entries, accounts and le… URL: https://github.com/apache/fineract-cn-accounting/pull/7#issuecomment-418689045 Hey Awasum, I've updated the PR with some fixes. I await your review.

[GitHub] Izakey commented on issue #7: Document APIs for transaction types, journal entries, accounts and le…

2018-09-05 Thread GitBox
Izakey commented on issue #7: Document APIs for transaction types, journal entries, accounts and le… URL: https://github.com/apache/fineract-cn-accounting/pull/7#issuecomment-418689045 Hey Awasum, I've updated the PR with some fixes. I await your review.

[GitHub] awasum commented on issue #7: Document office API to manage offices & employees

2018-09-05 Thread GitBox
awasum commented on issue #7: Document office API to manage offices & employees URL: https://github.com/apache/fineract-cn-office/pull/7#issuecomment-418674026 OfficeApiDocumentation: 1) In documentAddExternalReference: "java.lang.AssertionError: Status Expected :202 Actual

[GitHub] awasum commented on issue #7: Document office API to manage offices & employees

2018-09-05 Thread GitBox
awasum commented on issue #7: Document office API to manage offices & employees URL: https://github.com/apache/fineract-cn-office/pull/7#issuecomment-418672661 For the EmployeeApiDocument, Here are some issues I faced: 1) In 'documentUpdateEmployee' : "10:35:31.503