[GitHub] Izakey closed pull request #8: Document Group API to manage group savings and lending

2018-09-06 Thread GitBox
Izakey closed pull request #8: Document Group API to manage group savings and lending URL: https://github.com/apache/fineract-cn-group/pull/8 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As thi

[GitHub] Izakey commented on issue #8: Document Group API to manage group savings and lending

2018-09-06 Thread GitBox
Izakey commented on issue #8: Document Group API to manage group savings and lending URL: https://github.com/apache/fineract-cn-group/pull/8#issuecomment-419337406 Thanks @awasum . Let me close this PR, resolve conflicts and further document changes which @kengneruphine incorporated. ---

[GitHub] Izakey commented on issue #7: Document APIs for transaction types, journal entries, accounts and le…

2018-09-06 Thread GitBox
Izakey commented on issue #7: Document APIs for transaction types, journal entries, accounts and le… URL: https://github.com/apache/fineract-cn-accounting/pull/7#issuecomment-419156444 Thanks Awasum. I've open a PR https://github.com/apache/fineract-cn-accounting/pull/8 which addresses th

[GitHub] Izakey opened a new pull request #8: Documenting accounting reports viz trial balance, chart of accounts, …

2018-09-06 Thread GitBox
Izakey opened a new pull request #8: Documenting accounting reports viz trial balance, chart of accounts, … URL: https://github.com/apache/fineract-cn-accounting/pull/8 Documenting accounting reports viz trial balance, chart of accounts, income statement and financial condition --

[GitHub] awasum commented on issue #8: Document Group API to manage group savings and lending

2018-09-06 Thread GitBox
awasum commented on issue #8: Document Group API to manage group savings and lending URL: https://github.com/apache/fineract-cn-group/pull/8#issuecomment-419144639 @Izakey Please take a look at this again. There are conflicts now that I have merged the other PR. Please resolve them and we

[GitHub] awasum commented on issue #7: Changes added to the Group Microservice [GSoC period]

2018-09-06 Thread GitBox
awasum commented on issue #7: Changes added to the Group Microservice [GSoC period] URL: https://github.com/apache/fineract-cn-group/pull/7#issuecomment-419143402 Thank you @kengneruphine This is an automated message from th

[fineract-cn-group] 01/01: Merge pull request #7 from kengneruphine/develop

2018-09-06 Thread awasum
This is an automated email from the ASF dual-hosted git repository. awasum pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/fineract-cn-group.git commit acdd06484bf0b9ea2cf5003d96fe03521dc438d7 Merge: c9f6fb4 4b1b30b Author: Awasum Yannick AuthorDate: Thu Sep 6

[GitHub] awasum closed pull request #7: Changes added to the Group Microservice [GSoC period]

2018-09-06 Thread GitBox
awasum closed pull request #7: Changes added to the Group Microservice [GSoC period] URL: https://github.com/apache/fineract-cn-group/pull/7 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[fineract-cn-group] branch develop updated (c9f6fb4 -> acdd064)

2018-09-06 Thread awasum
This is an automated email from the ASF dual-hosted git repository. awasum pushed a change to branch develop in repository https://gitbox.apache.org/repos/asf/fineract-cn-group.git. from c9f6fb4 Merge pull request #6 from apache/revert-5-develop add 3ce19f9 adding permittableGroupIds

[GitHub] kengneruphine commented on issue #7: Changes added to the Group Microservice [GSoC period]

2018-09-06 Thread GitBox
kengneruphine commented on issue #7: Changes added to the Group Microservice [GSoC period] URL: https://github.com/apache/fineract-cn-group/pull/7#issuecomment-419077104 Hello Awasum I have updated the pull request to include the unit tests for group update and group definition up

[fineract-cn-payroll] branch develop updated (3b637b9 -> 9f53efc)

2018-09-06 Thread awasum
This is an automated email from the ASF dual-hosted git repository. awasum pushed a change to branch develop in repository https://gitbox.apache.org/repos/asf/fineract-cn-payroll.git. from 3b637b9 Merge pull request #6 from apache/revert-5-develop add 6094e1e Document Payroll API to c

[GitHub] awasum closed pull request #7: Document Payroll API to configure payroll allocations

2018-09-06 Thread GitBox
awasum closed pull request #7: Document Payroll API to configure payroll allocations URL: https://github.com/apache/fineract-cn-payroll/pull/7 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As th

[fineract-cn-payroll] 01/01: Merge pull request #7 from Izakey/develop

2018-09-06 Thread awasum
This is an automated email from the ASF dual-hosted git repository. awasum pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/fineract-cn-payroll.git commit 9f53efc1a7e813c0c1870534a8c8667d04d6c34b Merge: 3b637b9 d596ee2 Author: Awasum Yannick AuthorDate: Thu Sep

[fineract-cn-deposit-account-management] 01/01: Merge pull request #8 from Izakey/develop

2018-09-06 Thread awasum
This is an automated email from the ASF dual-hosted git repository. awasum pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/fineract-cn-deposit-account-management.git commit 72b563b8c17ee72bbb321f0a401749c5a25a7033 Merge: 36e5765 b520887 Author: Awasum Yannick

[GitHub] awasum closed pull request #8: Document Deposit API to manage various deposit accounts

2018-09-06 Thread GitBox
awasum closed pull request #8: Document Deposit API to manage various deposit accounts URL: https://github.com/apache/fineract-cn-deposit-account-management/pull/8 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[fineract-cn-deposit-account-management] branch develop updated (36e5765 -> 72b563b)

2018-09-06 Thread awasum
This is an automated email from the ASF dual-hosted git repository. awasum pushed a change to branch develop in repository https://gitbox.apache.org/repos/asf/fineract-cn-deposit-account-management.git. from 36e5765 Merge pull request #7 from apache/revert-6-develop add b520887 Docum

[fineract-cn-identity] branch develop updated (36c7e12 -> 7f9842b)

2018-09-06 Thread awasum
This is an automated email from the ASF dual-hosted git repository. awasum pushed a change to branch develop in repository https://gitbox.apache.org/repos/asf/fineract-cn-identity.git. from 36c7e12 Merge pull request #6 from apache/revert-5-develop add f2014be Document Identity API to

[fineract-cn-identity] 01/01: Merge pull request #7 from Izakey/develop

2018-09-06 Thread awasum
This is an automated email from the ASF dual-hosted git repository. awasum pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/fineract-cn-identity.git commit 7f9842b8da53d534526738879766ac88512fab5f Merge: 36c7e12 10f7b9b Author: Awasum Yannick AuthorDate: Thu Se

[GitHub] awasum closed pull request #7: Document Identity API to manage identities, roles and permissions

2018-09-06 Thread GitBox
awasum closed pull request #7: Document Identity API to manage identities, roles and permissions URL: https://github.com/apache/fineract-cn-identity/pull/7 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of prove

[GitHub] Izakey commented on issue #7: Document APIs for transaction types, journal entries, accounts and le…

2018-09-06 Thread GitBox
Izakey commented on issue #7: Document APIs for transaction types, journal entries, accounts and le… URL: https://github.com/apache/fineract-cn-accounting/pull/7#issuecomment-419034660 Thanks for the kind review @awasum. Let check if this is from my side and fix it. -

[GitHub] awasum commented on issue #8: Document Group API to manage group savings and lending

2018-09-06 Thread GitBox
awasum commented on issue #8: Document Group API to manage group savings and lending URL: https://github.com/apache/fineract-cn-group/pull/8#issuecomment-419030407 I will look at this last as Ruphine is sending in some of her test which will affect this work. Some changes will have to be d

[fineract-cn-teller] 01/01: Merge pull request #7 from Izakey/develop

2018-09-06 Thread awasum
This is an automated email from the ASF dual-hosted git repository. awasum pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/fineract-cn-teller.git commit fb3a74a5ffacfb1e8513caf0698a77f2188be4f0 Merge: d9dc9b0 02d379f Author: Awasum Yannick AuthorDate: Thu Sep

[GitHub] awasum commented on issue #7: Document Teller API to manage teller operations

2018-09-06 Thread GitBox
awasum commented on issue #7: Document Teller API to manage teller operations URL: https://github.com/apache/fineract-cn-teller/pull/7#issuecomment-419028364 This looks good. I am merging now. This is an automated message from

[GitHub] awasum closed pull request #7: Document Teller API to manage teller operations

2018-09-06 Thread GitBox
awasum closed pull request #7: Document Teller API to manage teller operations URL: https://github.com/apache/fineract-cn-teller/pull/7 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[fineract-cn-teller] branch develop updated (d9dc9b0 -> fb3a74a)

2018-09-06 Thread awasum
This is an automated email from the ASF dual-hosted git repository. awasum pushed a change to branch develop in repository https://gitbox.apache.org/repos/asf/fineract-cn-teller.git. from d9dc9b0 Merge pull request #6 from apache/revert-5-develop add b093025 Document Teller API to man

[fineract-cn-accounting] branch develop updated (9259b57 -> 27fac6c)

2018-09-06 Thread awasum
This is an automated email from the ASF dual-hosted git repository. awasum pushed a change to branch develop in repository https://gitbox.apache.org/repos/asf/fineract-cn-accounting.git. from 9259b57 Merge pull request #6 from apache/revert-5-develop add 0958648 Document APIs for tran

[fineract-cn-accounting] 01/01: Merge pull request #7 from Izakey/develop

2018-09-06 Thread awasum
This is an automated email from the ASF dual-hosted git repository. awasum pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/fineract-cn-accounting.git commit 27fac6cf4ba1757a2d362e22608a7037aa45fe97 Merge: 9259b57 b79433c Author: Awasum Yannick AuthorDate: Thu

[GitHub] awasum closed pull request #7: Document APIs for transaction types, journal entries, accounts and le…

2018-09-06 Thread GitBox
awasum closed pull request #7: Document APIs for transaction types, journal entries, accounts and le… URL: https://github.com/apache/fineract-cn-accounting/pull/7 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake o

[GitHub] awasum commented on issue #7: Document APIs for transaction types, journal entries, accounts and le…

2018-09-06 Thread GitBox
awasum commented on issue #7: Document APIs for transaction types, journal entries, accounts and le… URL: https://github.com/apache/fineract-cn-accounting/pull/7#issuecomment-419020487 In LedgerAPIDoc.documentAddSubLedger(): org.springframework.web.util.NestedServletException: Reque

[GitHub] awasum commented on issue #7: Document APIs for transaction types, journal entries, accounts and le…

2018-09-06 Thread GitBox
awasum commented on issue #7: Document APIs for transaction types, journal entries, accounts and le… URL: https://github.com/apache/fineract-cn-accounting/pull/7#issuecomment-419019813 @Izakey Is there a reason for not documenting Chart of accounts and the other accounting reports APIs?