[GitHub] angelboxes commented on a change in pull request #465: Fineract 614: Rates module

2019-02-26 Thread GitBox
angelboxes commented on a change in pull request #465: Fineract 614: Rates module URL: https://github.com/apache/fineract/pull/465#discussion_r260537893 ## File path: fineract-provider/src/main/java/org/apache/fineract/portfolio/rate/domain/Rate.java ## @@ -0,0 +1,209 @@

[GitHub] vishwasbabu closed pull request #510: Thread.run()->Thread.start()

2019-02-26 Thread GitBox
vishwasbabu closed pull request #510: Thread.run()->Thread.start() URL: https://github.com/apache/fineract/pull/510 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] vishwasbabu commented on issue #510: Thread.run()->Thread.start()

2019-02-26 Thread GitBox
vishwasbabu commented on issue #510: Thread.run()->Thread.start() URL: https://github.com/apache/fineract/pull/510#issuecomment-467366233 @SunnyDay74 : Closing this pr as per @vorburger's comments. This is an automated

[GitHub] vishwasbabu commented on issue #526: FINERACT-684: Create and approve loan on batch mode

2019-02-26 Thread GitBox
vishwasbabu commented on issue #526: FINERACT-684: Create and approve loan on batch mode URL: https://github.com/apache/fineract/pull/526#issuecomment-467360334 @hungnguyen2712 , the integration test seems to be failing. Can you please address the same and resend the pr? Here's the

[fineract] 01/01: Merge pull request #529 from apache/revert-526-create-and-approve-loan-on-batch-mode

2019-02-26 Thread vishwasbabu
This is an automated email from the ASF dual-hosted git repository. vishwasbabu pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/fineract.git commit fa05d5a30ea8868522857f1cb90c5c62f45e8983 Merge: 5c78283 dd0771b Author: Vishwas Babu A J AuthorDate: Tue Feb 26

[fineract] branch develop updated (5c78283 -> fa05d5a)

2019-02-26 Thread vishwasbabu
This is an automated email from the ASF dual-hosted git repository. vishwasbabu pushed a change to branch develop in repository https://gitbox.apache.org/repos/asf/fineract.git. from 5c78283 Merge pull request #516 from aasaru/develop add dd0771b Revert "FINERACT-684: Create and

[GitHub] vishwasbabu merged pull request #529: Revert "FINERACT-684: Create and approve loan on batch mode "

2019-02-26 Thread GitBox
vishwasbabu merged pull request #529: Revert "FINERACT-684: Create and approve loan on batch mode " URL: https://github.com/apache/fineract/pull/529 This is an automated message from the Apache Git Service. To respond to

[GitHub] vishwasbabu opened a new pull request #529: Revert "FINERACT-684: Create and approve loan on batch mode "

2019-02-26 Thread GitBox
vishwasbabu opened a new pull request #529: Revert "FINERACT-684: Create and approve loan on batch mode " URL: https://github.com/apache/fineract/pull/529 Reverts apache/fineract#526 This is an automated message from the

[fineract] branch develop updated (0534f37 -> 5c78283)

2019-02-26 Thread vishwasbabu
This is an automated email from the ASF dual-hosted git repository. vishwasbabu pushed a change to branch develop in repository https://gitbox.apache.org/repos/asf/fineract.git. from 0534f37 Merge pull request #526 from hungnguyen2712/create-and-approve-loan-on-batch-mode new 0800bb7

[fineract] branch develop updated: - Fix issue FINERACT-684 (approve loan on batch mode return null pointer exception) - Add integration test to cover the fix

2019-02-26 Thread vishwasbabu
This is an automated email from the ASF dual-hosted git repository. vishwasbabu pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/fineract.git The following commit(s) were added to refs/heads/develop by this push: new 3965724 - Fix issue FINERACT-684

[GitHub] vishwasbabu merged pull request #526: FINERACT-684: Create and approve loan on batch mode

2019-02-26 Thread GitBox
vishwasbabu merged pull request #526: FINERACT-684: Create and approve loan on batch mode URL: https://github.com/apache/fineract/pull/526 This is an automated message from the Apache Git Service. To respond to the

[GitHub] vishwasbabu closed pull request #504: GLIM_GSIM enhancement

2019-02-26 Thread GitBox
vishwasbabu closed pull request #504: GLIM_GSIM enhancement URL: https://github.com/apache/fineract/pull/504 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use

[GitHub] vishwasbabu closed pull request #397: Integrated TOIF into apache-fineract

2019-02-26 Thread GitBox
vishwasbabu closed pull request #397: Integrated TOIF into apache-fineract URL: https://github.com/apache/fineract/pull/397 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] vishwasbabu merged pull request #176: commit for FINERACT-52 (Null value not handled in 'ClientWritePlatformServiceJpaRepositoryImpl.CloseClient' date comparison)

2019-02-26 Thread GitBox
vishwasbabu merged pull request #176: commit for FINERACT-52 (Null value not handled in 'ClientWritePlatformServiceJpaRepositoryImpl.CloseClient' date comparison) URL: https://github.com/apache/fineract/pull/176 This is an

[GitHub] vishwasbabu merged pull request #507: FINERACT-646 Pockets API

2019-02-26 Thread GitBox
vishwasbabu merged pull request #507: FINERACT-646 Pockets API URL: https://github.com/apache/fineract/pull/507 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and

[fineract] branch develop updated (26d5459 -> 0a24570)

2019-02-26 Thread vishwasbabu
This is an automated email from the ASF dual-hosted git repository. vishwasbabu pushed a change to branch develop in repository https://gitbox.apache.org/repos/asf/fineract.git. from 26d5459 Merge pull request #528 from vishwasbabu/travis add 3a67d01 FINERACT-646 Pockets API new

[fineract] 01/01: Merge pull request #507 from ShruthiRajaram/Fineract-646

2019-02-26 Thread vishwasbabu
This is an automated email from the ASF dual-hosted git repository. vishwasbabu pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/fineract.git commit 0a245701d8ae2581f3a9a14a9bca08281d059797 Merge: 26d5459 3a67d01 Author: Vishwas Babu A J AuthorDate: Tue Feb 26