[GitHub] [fineract] awasum commented on issue #545: Prevent Apache rat task from failing subsequently after building project: FINERACT-731

awasum commented on issue #545: Prevent Apache rat task from failing subsequently after building project: FINERACT-731 URL: https://github.com/apache/fineract/pull/545#issuecomment-471415269 The gradle folder I ignored is in the root directory( it was one which i added). The one inside the

[GitHub] [fineract] wkk91193 commented on a change in pull request #450: Adding a compress response filter, registering filter

wkk91193 commented on a change in pull request #450: Adding a compress response filter,registering filter URL: https://github.com/apache/fineract/pull/450#discussion_r264098243 ## File path: fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/boot/WebXmlConfigur

[GitHub] [fineract] wkk91193 commented on issue #546: Consolidating changes: Bulk import-fixing importhandler integration t…

wkk91193 commented on issue #546: Consolidating changes: Bulk import-fixing importhandler integration t… URL: https://github.com/apache/fineract/pull/546#issuecomment-471412451 @vishwasbabu Removed the Ignore annotation,code updated

[GitHub] [fineract] vishwasbabu commented on issue #545: Prevent Apache rat task from failing subsequently after building project: FINERACT-731

vishwasbabu commented on issue #545: Prevent Apache rat task from failing subsequently after building project: FINERACT-731 URL: https://github.com/apache/fineract/pull/545#issuecomment-471410949 @awasum : you are correct, the gradle folder is a part of the codebase. --

[GitHub] [fineract] vishwasbabu closed pull request #444: Bulk import-fixing importhandler integration test failures

vishwasbabu closed pull request #444: Bulk import-fixing importhandler integration test failures URL: https://github.com/apache/fineract/pull/444 This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [fineract] vishwasbabu commented on issue #546: Consolidating changes: Bulk import-fixing importhandler integration t…

vishwasbabu commented on issue #546: Consolidating changes: Bulk import-fixing importhandler integration t… URL: https://github.com/apache/fineract/pull/546#issuecomment-471410168 Looks good @wkk91193! Can you please remove the ignore annotation from all 4 test cases, so that Travis can co

[GitHub] [fineract] wkk91193 commented on issue #444: Bulk import-fixing importhandler integration test failures

wkk91193 commented on issue #444: Bulk import-fixing importhandler integration test failures URL: https://github.com/apache/fineract/pull/444#issuecomment-471403607 @vishwasbabu @vorburger Opened a new PR #546 after rebasing and with the changes requested. Closing this one ---

[GitHub] [fineract] wkk91193 opened a new pull request #546: Consolidating changes: Bulk import-fixing importhandler integration t…

wkk91193 opened a new pull request #546: Consolidating changes: Bulk import-fixing importhandler integration t… URL: https://github.com/apache/fineract/pull/546 Opening a new PR for #444 changes. This is an automated message

[GitHub] [fineract] awasum commented on issue #545: Prevent Apache rat task from failing subsequently after building project: FINERACT-731

awasum commented on issue #545: Prevent Apache rat task from failing subsequently after building project: FINERACT-731 URL: https://github.com/apache/fineract/pull/545#issuecomment-471363657 Don't merge this yet. I think I ignored the gradle folder. Is it suppose to be ignored or part of t

[GitHub] [fineract] awasum opened a new pull request #545: Prevent Apache rat task from failing subsequently after building project: FINERACT-731

awasum opened a new pull request #545: Prevent Apache rat task from failing subsequently after building project: FINERACT-731 URL: https://github.com/apache/fineract/pull/545 ## Description Building project subsequently after the first build task make the rat task to fail: FINERACT-731

[GitHub] [fineract] TypicalGitHubUser commented on issue #514: [MIFOSX-2114] Change assignment staff to groups and clients in center.

TypicalGitHubUser commented on issue #514: [MIFOSX-2114] Change assignment staff to groups and clients in center. URL: https://github.com/apache/fineract/pull/514#issuecomment-471314161 @vishwasbabu No, I won't be able to do this in near future.

[GitHub] [fineract] TypicalGitHubUser removed a comment on issue #514: [MIFOSX-2114] Change assignment staff to groups and clients in center.

TypicalGitHubUser removed a comment on issue #514: [MIFOSX-2114] Change assignment staff to groups and clients in center. URL: https://github.com/apache/fineract/pull/514#issuecomment-471314161 @vishwasbabu No, I won't be able to do this in near future.

[GitHub] [fineract] TypicalGitHubUser commented on issue #514: [MIFOSX-2114] Change assignment staff to groups and clients in center.

TypicalGitHubUser commented on issue #514: [MIFOSX-2114] Change assignment staff to groups and clients in center. URL: https://github.com/apache/fineract/pull/514#issuecomment-471314097 @vishwasbabu No, I won't be able to do this in near future.