[GitHub] vigyat123 opened a new pull request #8: Compilation error

2018-08-14 Thread GitBox
vigyat123 opened a new pull request #8: Compilation error URL: https://github.com/apache/fineract-cn-fims-web-app/pull/8 ## Description Variable not defined and a variable spelled incorrectly ### What's included? - "lastModifiedBy" spelled incorrectly in

[GitHub] ebenezergraham commented on issue #1: Update

2018-08-14 Thread GitBox
ebenezergraham commented on issue #1: Update URL: https://github.com/apache/fineract-cn-notifications/pull/1#issuecomment-413068577 Thanks for the feedback. I will rectify this. On Tue, 14 Aug 2018, 19:14 Awasum Yannick, wrote: > @ebenezergraham

[GitHub] ebenezergraham opened a new pull request #1: Update

2018-08-12 Thread GitBox
ebenezergraham opened a new pull request #1: Update URL: https://github.com/apache/fineract-cn-notifications/pull/1 Created a notification service to utilize the customer adapter, the SMS and email service Created an authentication class to authenticate with the identity service

[GitHub] ebenezergraham closed pull request #18: Adding the notification service to the demo server

2018-08-12 Thread GitBox
ebenezergraham closed pull request #18: Adding the notification service to the demo server URL: https://github.com/apache/fineract-cn-demo-server/pull/18 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] awasum commented on issue #7: Changes added to the Group Microservice [GSoC period]

2018-08-14 Thread GitBox
awasum commented on issue #7: Changes added to the Group Microservice [GSoC period] URL: https://github.com/apache/fineract-cn-group/pull/7#issuecomment-412898552 @kengneruphine Please Add unit tests for GroupDefinitions and UpdateGroups then I can merge this. Also run licenseFormat to

[GitHub] awasum commented on issue #1: Update

2018-08-14 Thread GitBox
awasum commented on issue #1: Update URL: https://github.com/apache/fineract-cn-notifications/pull/1#issuecomment-412907661 @ebenezergraham Add unit tests for your service. Also ignore these files: service/build/ service/out/ service/.gradle/ component-test/.gradle/

[GitHub] awasum closed pull request #7: Consume sign-off meeting endpoint [GSoC Period]

2018-08-14 Thread GitBox
awasum closed pull request #7: Consume sign-off meeting endpoint [GSoC Period] URL: https://github.com/apache/fineract-cn-fims-web-app/pull/7 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] awasum commented on issue #7: Consume sign-off meeting endpoint [GSoC Period]

2018-08-14 Thread GitBox
awasum commented on issue #7: Consume sign-off meeting endpoint [GSoC Period] URL: https://github.com/apache/fineract-cn-fims-web-app/pull/7#issuecomment-412885295 @kengneruphine I have merged your PR. Make sure to pull before adding any other code on your side.

[GitHub] awasum commented on issue #8: Compilation error

2018-08-14 Thread GitBox
awasum commented on issue #8: Compilation error URL: https://github.com/apache/fineract-cn-fims-web-app/pull/8#issuecomment-412889199 ![image](https://user-images.githubusercontent.com/15528032/44097182-1a3bfffa-9fd5-11e8-9b9a-7d9b72d58096.png) @vigyat123 There is the above error I

[GitHub] ebenezergraham commented on issue #19: Integrating the notification service

2018-08-20 Thread GitBox
ebenezergraham commented on issue #19: Integrating the notification service URL: https://github.com/apache/fineract-cn-demo-server/pull/19#issuecomment-414391422 @awasum I noticed that too. This is because of how I am testing the server. I push the code onto GitHub and pull onto the VM.

[GitHub] therajanmaurya commented on issue #19: added payroll api support

2018-08-21 Thread GitBox
therajanmaurya commented on issue #19: added payroll api support URL: https://github.com/apache/fineract-cn-mobile/pull/19#issuecomment-414637211 Fix Conflicts. This is an automated message from the Apache Git Service. To

[GitHub] therajanmaurya commented on issue #17: feat: list and search products

2018-08-21 Thread GitBox
therajanmaurya commented on issue #17: feat: list and search products URL: https://github.com/apache/fineract-cn-mobile/pull/17#issuecomment-414637287 Fix Conflicts. This is an automated message from the Apache Git Service.

[GitHub] therajanmaurya closed pull request #18: fix: move files to .github

2018-08-21 Thread GitBox
therajanmaurya closed pull request #18: fix: move files to .github URL: https://github.com/apache/fineract-cn-mobile/pull/18 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] therajanmaurya closed pull request #20: fix: visibilty issue in ledger

2018-08-21 Thread GitBox
therajanmaurya closed pull request #20: fix: visibilty issue in ledger URL: https://github.com/apache/fineract-cn-mobile/pull/20 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] therajanmaurya closed pull request #14: feat : list and search tellers

2018-08-21 Thread GitBox
therajanmaurya closed pull request #14: feat : list and search tellers URL: https://github.com/apache/fineract-cn-mobile/pull/14 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] ebenezergraham closed pull request #2: Delete .travis.yml

2018-08-21 Thread GitBox
ebenezergraham closed pull request #2: Delete .travis.yml URL: https://github.com/apache/fineract-cn-notifications/pull/2 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] ebenezergraham closed pull request #3: Delete system-analysis.mdj

2018-08-21 Thread GitBox
ebenezergraham closed pull request #3: Delete system-analysis.mdj URL: https://github.com/apache/fineract-cn-notifications/pull/3 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] ebenezergraham opened a new pull request #5: Unit and component Tests, Rest and command updates and Bug Fixes

2018-08-21 Thread GitBox
ebenezergraham opened a new pull request #5: Unit and component Tests,Rest and command updates and Bug Fixes URL: https://github.com/apache/fineract-cn-notifications/pull/5 Added dependencies to shared Gradle file Created new group IDs for SMS and Email management Added creation and

[GitHub] ebenezergraham opened a new pull request #4: Unit and component Tests, Rest and command updates and Bug Fixes

2018-08-21 Thread GitBox
ebenezergraham opened a new pull request #4: Unit and component Tests,Rest and command updates and Bug Fixes URL: https://github.com/apache/fineract-cn-notifications/pull/4 added dependencies to shared Gradle file Created new group IDs for SMS and Email management Added creation and

[GitHub] ebenezergraham commented on issue #4: Unit and component Tests, Rest and command updates and Bug Fixes

2018-08-21 Thread GitBox
ebenezergraham commented on issue #4: Unit and component Tests,Rest and command updates and Bug Fixes URL: https://github.com/apache/fineract-cn-notifications/pull/4#issuecomment-414883232 @awasum In an attempt to clean up this repository I messed up my original fork and so I have

[GitHub] ebenezergraham removed a comment on issue #4: Unit and component Tests, Rest and command updates and Bug Fixes

2018-08-21 Thread GitBox
ebenezergraham removed a comment on issue #4: Unit and component Tests,Rest and command updates and Bug Fixes URL: https://github.com/apache/fineract-cn-notifications/pull/4#issuecomment-414883232 @awasum In an attempt to clean up this repository I messed up my original fork and so I

[GitHub] ebenezergraham closed pull request #4: Unit and component Tests, Rest and command updates and Bug Fixes

2018-08-21 Thread GitBox
ebenezergraham closed pull request #4: Unit and component Tests,Rest and command updates and Bug Fixes URL: https://github.com/apache/fineract-cn-notifications/pull/4 This is an automated message from the Apache Git

[GitHub] ebenezergraham closed pull request #1: Update

2018-08-22 Thread GitBox
ebenezergraham closed pull request #1: Update URL: https://github.com/apache/fineract-cn-notifications/pull/1 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use

[GitHub] myrle-krantz closed pull request #20: Integrating the notification service

2018-08-23 Thread GitBox
myrle-krantz closed pull request #20: Integrating the notification service URL: https://github.com/apache/fineract-cn-demo-server/pull/20 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] myrle-krantz commented on issue #20: Integrating the notification service

2018-08-23 Thread GitBox
myrle-krantz commented on issue #20: Integrating the notification service URL: https://github.com/apache/fineract-cn-demo-server/pull/20#issuecomment-415572038 Looks good. Thank you very much for the PR Ebenezer! This is an

[GitHub] ebenezergraham opened a new pull request #20: Integrating the notification service

2018-08-21 Thread GitBox
ebenezergraham opened a new pull request #20: Integrating the notification service URL: https://github.com/apache/fineract-cn-demo-server/pull/20 1 Added the repository to the initial-setup and pull-all scripts 2 Added notification service dependency to the Gradle file 3 Created an

[GitHub] ebenezergraham closed pull request #19: Integrating the notification service

2018-08-21 Thread GitBox
ebenezergraham closed pull request #19: Integrating the notification service URL: https://github.com/apache/fineract-cn-demo-server/pull/19 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] MexinaD commented on issue #454: FINERACT-623 - Restriction of product mix fix

2018-08-28 Thread GitBox
MexinaD commented on issue #454: FINERACT-623 - Restriction of product mix fix URL: https://github.com/apache/fineract/pull/454#issuecomment-416580383 Hello @ShruthiRajaram I have already updated the PR with change of implementation, if the loan products should not co-exist, its enough

[GitHub] MexinaD commented on issue #436: FINERACT-416 Interest of the whole term

2018-08-28 Thread GitBox
MexinaD commented on issue #436: FINERACT-416 Interest of the whole term URL: https://github.com/apache/fineract/pull/436#issuecomment-416581077 Hello @ShruthiRajaram Can you help to review this too This is an automated

[GitHub] ShruthiRajaram opened a new pull request #471: FINERACT-627 back dated client transfer

2018-08-28 Thread GitBox
ShruthiRajaram opened a new pull request #471: FINERACT-627 back dated client transfer URL: https://github.com/apache/fineract/pull/471 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] pwairuru opened a new pull request #472: Make repayments file download for bulk import tool

2018-08-28 Thread GitBox
pwairuru opened a new pull request #472: Make repayments file download for bulk import tool URL: https://github.com/apache/fineract/pull/472 This is an automated message from the Apache Git Service. To respond to the

[GitHub] MexinaD commented on issue #454: FINERACT-623 - Restriction of product mix fix

2018-08-29 Thread GitBox
MexinaD commented on issue #454: FINERACT-623 - Restriction of product mix fix URL: https://github.com/apache/fineract/pull/454#issuecomment-416836595 Hello @ShruthiRajaram I think if the loan has already passed the state of approval that means the user was okay with their co-existence at

[GitHub] ShruthiRajaram commented on issue #454: FINERACT-623 - Restriction of product mix fix

2018-08-28 Thread GitBox
ShruthiRajaram commented on issue #454: FINERACT-623 - Restriction of product mix fix URL: https://github.com/apache/fineract/pull/454#issuecomment-416833518 @MexinaD I think there is a little confusion over my last comment. I was completely fine with validation during disbursal and

[GitHub] awasum commented on issue #19: Integrating the notification service

2018-08-19 Thread GitBox
awasum commented on issue #19: Integrating the notification service URL: https://github.com/apache/fineract-cn-demo-server/pull/19#issuecomment-414154042 U keep splitting single lines code changes into distinct commits. For such a small feature, u are using too many commits. Squash all of

[GitHub] awasum closed pull request #17: Update initial-setup.bat

2018-08-19 Thread GitBox
awasum closed pull request #17: Update initial-setup.bat URL: https://github.com/apache/fineract-cn-demo-server/pull/17 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] myrle-krantz removed a comment on issue #5: Unit and component Tests, Rest and command updates and Bug Fixes

2018-08-22 Thread GitBox
myrle-krantz removed a comment on issue #5: Unit and component Tests,Rest and command updates and Bug Fixes URL: https://github.com/apache/fineract-cn-notifications/pull/5#issuecomment-415015289 You need to run your tests. SMSConfigurationTest doesn't compile. TestEmailService doesn't

[GitHub] myrle-krantz edited a comment on issue #5: Unit and component Tests, Rest and command updates and Bug Fixes

2018-08-22 Thread GitBox
myrle-krantz edited a comment on issue #5: Unit and component Tests,Rest and command updates and Bug Fixes URL: https://github.com/apache/fineract-cn-notifications/pull/5#issuecomment-415014208 Unfortunately comments in github aren't threaded, so this is going to be a large dump. I'm

[GitHub] myrle-krantz edited a comment on issue #5: Unit and component Tests, Rest and command updates and Bug Fixes

2018-08-22 Thread GitBox
myrle-krantz edited a comment on issue #5: Unit and component Tests,Rest and command updates and Bug Fixes URL: https://github.com/apache/fineract-cn-notifications/pull/5#issuecomment-415014208 Unfortunately comments in github aren't threaded, so this is going to be a large dump. I'm

[GitHub] myrle-krantz edited a comment on issue #5: Unit and component Tests, Rest and command updates and Bug Fixes

2018-08-22 Thread GitBox
myrle-krantz edited a comment on issue #5: Unit and component Tests,Rest and command updates and Bug Fixes URL: https://github.com/apache/fineract-cn-notifications/pull/5#issuecomment-415014208 Unfortunately comments in github aren't threaded, so this is going to be a large dump. I'm

[GitHub] myrle-krantz closed pull request #3: Docker infrastructure for Eureka and ActiveMQ

2018-08-22 Thread GitBox
myrle-krantz closed pull request #3: Docker infrastructure for Eureka and ActiveMQ URL: https://github.com/apache/fineract-cn-demo-server/pull/3 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] myrle-krantz commented on issue #3: Docker infrastructure for Eureka and ActiveMQ

2018-08-22 Thread GitBox
myrle-krantz commented on issue #3: Docker infrastructure for Eureka and ActiveMQ URL: https://github.com/apache/fineract-cn-demo-server/pull/3#issuecomment-415050247 Closing for inactivity. This is an automated message

[GitHub] myrle-krantz commented on issue #20: Integrating the notification service

2018-08-22 Thread GitBox
myrle-krantz commented on issue #20: Integrating the notification service URL: https://github.com/apache/fineract-cn-demo-server/pull/20#issuecomment-415049995 Looks good. I'd only like to ask for one change before I merge: Please give the notification user and the password

[GitHub] myrle-krantz commented on issue #5: Unit and component Tests, Rest and command updates and Bug Fixes

2018-08-22 Thread GitBox
myrle-krantz commented on issue #5: Unit and component Tests,Rest and command updates and Bug Fixes URL: https://github.com/apache/fineract-cn-notifications/pull/5#issuecomment-415015289 You need to run your tests. SMSConfigurationTest doesn't compile. TestEmailService doesn't pass.

[GitHub] myrle-krantz removed a comment on issue #5: Unit and component Tests, Rest and command updates and Bug Fixes

2018-08-22 Thread GitBox
myrle-krantz removed a comment on issue #5: Unit and component Tests,Rest and command updates and Bug Fixes URL: https://github.com/apache/fineract-cn-notifications/pull/5#issuecomment-415015724 What is the purpose of the Event domain object?

[GitHub] myrle-krantz commented on issue #5: Unit and component Tests, Rest and command updates and Bug Fixes

2018-08-22 Thread GitBox
myrle-krantz commented on issue #5: Unit and component Tests,Rest and command updates and Bug Fixes URL: https://github.com/apache/fineract-cn-notifications/pull/5#issuecomment-415015724 What is the purpose of the Event domain object?

[GitHub] myrle-krantz edited a comment on issue #5: Unit and component Tests, Rest and command updates and Bug Fixes

2018-08-22 Thread GitBox
myrle-krantz edited a comment on issue #5: Unit and component Tests,Rest and command updates and Bug Fixes URL: https://github.com/apache/fineract-cn-notifications/pull/5#issuecomment-415014208 Unfortunately comments in github aren't threaded, so this is going to be a large dump. I'm

[GitHub] myrle-krantz edited a comment on issue #5: Unit and component Tests, Rest and command updates and Bug Fixes

2018-08-22 Thread GitBox
myrle-krantz edited a comment on issue #5: Unit and component Tests,Rest and command updates and Bug Fixes URL: https://github.com/apache/fineract-cn-notifications/pull/5#issuecomment-415014208 Unfortunately comments in github aren't threaded, so this is going to be a large dump. I'm

[GitHub] ebenezergraham edited a comment on issue #5: Unit and component Tests, Rest and command updates and Bug Fixes

2018-08-22 Thread GitBox
ebenezergraham edited a comment on issue #5: Unit and component Tests,Rest and command updates and Bug Fixes URL: https://github.com/apache/fineract-cn-notifications/pull/5#issuecomment-415146388 @myrle-krantz @awasum @Izakey - [x] 1.) Comment - I have added the relevant licenses to

[GitHub] ebenezergraham edited a comment on issue #5: Unit and component Tests, Rest and command updates and Bug Fixes

2018-08-22 Thread GitBox
ebenezergraham edited a comment on issue #5: Unit and component Tests,Rest and command updates and Bug Fixes URL: https://github.com/apache/fineract-cn-notifications/pull/5#issuecomment-415146388 Checklist for myself - [x] 1.) Comment - I have added the relevant licenses to the

[GitHub] ebenezergraham commented on issue #20: Integrating the notification service

2018-08-22 Thread GitBox
ebenezergraham commented on issue #20: Integrating the notification service URL: https://github.com/apache/fineract-cn-demo-server/pull/20#issuecomment-415210843 @myrle-krantz I have changed the constant name and squashed it. Loving this squash feature :smile:

[GitHub] myrle-krantz commented on issue #5: Unit and component Tests, Rest and command updates and Bug Fixes

2018-08-22 Thread GitBox
myrle-krantz commented on issue #5: Unit and component Tests,Rest and command updates and Bug Fixes URL: https://github.com/apache/fineract-cn-notifications/pull/5#issuecomment-415014208 Hey Ebenezeer this is a long list, so I'm going to break it up into one comment per item. If we need

[GitHub] ebenezergraham commented on issue #5: Unit and component Tests, Rest and command updates and Bug Fixes

2018-08-22 Thread GitBox
ebenezergraham commented on issue #5: Unit and component Tests,Rest and command updates and Bug Fixes URL: https://github.com/apache/fineract-cn-notifications/pull/5#issuecomment-415140148 @myrle-krantz Thanks for the feedback. I expected a long this like this :smile:. Let me get down it

[GitHub] ebenezergraham edited a comment on issue #5: Unit and component Tests, Rest and command updates and Bug Fixes

2018-08-22 Thread GitBox
ebenezergraham edited a comment on issue #5: Unit and component Tests,Rest and command updates and Bug Fixes URL: https://github.com/apache/fineract-cn-notifications/pull/5#issuecomment-415146388 Checklist for myself [x] 1.) You need to run the rat tests. At least three files are

[GitHub] ebenezergraham edited a comment on issue #5: Unit and component Tests, Rest and command updates and Bug Fixes

2018-08-22 Thread GitBox
ebenezergraham edited a comment on issue #5: Unit and component Tests,Rest and command updates and Bug Fixes URL: https://github.com/apache/fineract-cn-notifications/pull/5#issuecomment-415146388 Checklist for myself [ x ] 1.) You need to run the rat tests. At least three files are

[GitHub] ebenezergraham commented on issue #5: Unit and component Tests, Rest and command updates and Bug Fixes

2018-08-22 Thread GitBox
ebenezergraham commented on issue #5: Unit and component Tests,Rest and command updates and Bug Fixes URL: https://github.com/apache/fineract-cn-notifications/pull/5#issuecomment-415146388 Checklist for myself [ ]1.) You need to run the rat tests. At least three files are missing their

[GitHub] ebenezergraham edited a comment on issue #5: Unit and component Tests, Rest and command updates and Bug Fixes

2018-08-22 Thread GitBox
ebenezergraham edited a comment on issue #5: Unit and component Tests,Rest and command updates and Bug Fixes URL: https://github.com/apache/fineract-cn-notifications/pull/5#issuecomment-415146388 Checklist for myself [x]1.) You need to run the rat tests. At least three files are

[GitHub] myrle-krantz closed pull request #6: Fixed NPE, removed code warning.

2018-07-16 Thread GitBox
myrle-krantz closed pull request #6: Fixed NPE, removed code warning. URL: https://github.com/apache/fineract-cn-test/pull/6 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] myrle-krantz opened a new pull request #6: Fixed NPE, removed code warning.

2018-07-16 Thread GitBox
myrle-krantz opened a new pull request #6: Fixed NPE, removed code warning. URL: https://github.com/apache/fineract-cn-test/pull/6 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] therajanmaurya closed pull request #10: feat: Sync feature for customer and customer details

2018-07-23 Thread GitBox
therajanmaurya closed pull request #10: feat: Sync feature for customer and customer details URL: https://github.com/apache/fineract-cn-mobile/pull/10 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] mohak1712 opened a new pull request #15: feat: list and search ledger

2018-07-19 Thread GitBox
mohak1712 opened a new pull request #15: feat: list and search ledger URL: https://github.com/apache/fineract-cn-mobile/pull/15 Please make sure these boxes are checked before submitting your pull request - thanks! - [x] Apply the `AndroidStyle.xml` style template to your code in

[GitHub] dilpreet96 commented on a change in pull request #10: feat: Sync feature for customer and customer details

2018-07-19 Thread GitBox
dilpreet96 commented on a change in pull request #10: feat: Sync feature for customer and customer details URL: https://github.com/apache/fineract-cn-mobile/pull/10#discussion_r203806953 ## File path: app/src/main/java/org/apache/fineract/jobs/StartSyncJob.java ## @@ -0,0

[GitHub] dilpreet96 commented on a change in pull request #10: feat: Sync feature for customer and customer details

2018-07-19 Thread GitBox
dilpreet96 commented on a change in pull request #10: feat: Sync feature for customer and customer details URL: https://github.com/apache/fineract-cn-mobile/pull/10#discussion_r203806443 ## File path: app/src/main/java/org/apache/fineract/ui/adapters/CustomerAdapter.java

[GitHub] dilpreet96 commented on a change in pull request #10: feat: Sync feature for customer and customer details

2018-07-19 Thread GitBox
dilpreet96 commented on a change in pull request #10: feat: Sync feature for customer and customer details URL: https://github.com/apache/fineract-cn-mobile/pull/10#discussion_r203807514 ## File path: app/src/main/java/org/apache/fineract/ui/offline/CustomerPayloadFragment.java

[GitHub] therajanmaurya commented on a change in pull request #10: feat: Sync feature for customer and customer details

2018-07-19 Thread GitBox
therajanmaurya commented on a change in pull request #10: feat: Sync feature for customer and customer details URL: https://github.com/apache/fineract-cn-mobile/pull/10#discussion_r203730525 ## File path: app/src/main/java/org/apache/fineract/data/models/customer/Address.kt

[GitHub] therajanmaurya commented on a change in pull request #10: feat: Sync feature for customer and customer details

2018-07-19 Thread GitBox
therajanmaurya commented on a change in pull request #10: feat: Sync feature for customer and customer details URL: https://github.com/apache/fineract-cn-mobile/pull/10#discussion_r203735236 ## File path: app/src/main/java/org/apache/fineract/ui/adapters/CustomerAdapter.java

[GitHub] therajanmaurya commented on a change in pull request #10: feat: Sync feature for customer and customer details

2018-07-19 Thread GitBox
therajanmaurya commented on a change in pull request #10: feat: Sync feature for customer and customer details URL: https://github.com/apache/fineract-cn-mobile/pull/10#discussion_r203736311 ## File path:

[GitHub] therajanmaurya commented on a change in pull request #10: feat: Sync feature for customer and customer details

2018-07-19 Thread GitBox
therajanmaurya commented on a change in pull request #10: feat: Sync feature for customer and customer details URL: https://github.com/apache/fineract-cn-mobile/pull/10#discussion_r203735467 ## File path:

[GitHub] therajanmaurya commented on a change in pull request #10: feat: Sync feature for customer and customer details

2018-07-19 Thread GitBox
therajanmaurya commented on a change in pull request #10: feat: Sync feature for customer and customer details URL: https://github.com/apache/fineract-cn-mobile/pull/10#discussion_r203736177 ## File path:

[GitHub] therajanmaurya commented on a change in pull request #10: feat: Sync feature for customer and customer details

2018-07-19 Thread GitBox
therajanmaurya commented on a change in pull request #10: feat: Sync feature for customer and customer details URL: https://github.com/apache/fineract-cn-mobile/pull/10#discussion_r203734528 ## File path: app/src/main/java/org/apache/fineract/jobs/StartSyncJob.java ## @@

[GitHub] therajanmaurya commented on a change in pull request #10: feat: Sync feature for customer and customer details

2018-07-19 Thread GitBox
therajanmaurya commented on a change in pull request #10: feat: Sync feature for customer and customer details URL: https://github.com/apache/fineract-cn-mobile/pull/10#discussion_r203730782 ## File path: app/src/main/java/org/apache/fineract/data/models/customer/ContactDetail.kt

[GitHub] therajanmaurya commented on a change in pull request #10: feat: Sync feature for customer and customer details

2018-07-19 Thread GitBox
therajanmaurya commented on a change in pull request #10: feat: Sync feature for customer and customer details URL: https://github.com/apache/fineract-cn-mobile/pull/10#discussion_r203734768 ## File path: app/src/main/java/org/apache/fineract/ui/adapters/CustomerAdapter.java

[GitHub] therajanmaurya commented on a change in pull request #10: feat: Sync feature for customer and customer details

2018-07-19 Thread GitBox
therajanmaurya commented on a change in pull request #10: feat: Sync feature for customer and customer details URL: https://github.com/apache/fineract-cn-mobile/pull/10#discussion_r203735803 ## File path:

[GitHub] therajanmaurya commented on a change in pull request #10: feat: Sync feature for customer and customer details

2018-07-19 Thread GitBox
therajanmaurya commented on a change in pull request #10: feat: Sync feature for customer and customer details URL: https://github.com/apache/fineract-cn-mobile/pull/10#discussion_r203735964 ## File path:

[GitHub] therajanmaurya commented on a change in pull request #10: feat: Sync feature for customer and customer details

2018-07-19 Thread GitBox
therajanmaurya commented on a change in pull request #10: feat: Sync feature for customer and customer details URL: https://github.com/apache/fineract-cn-mobile/pull/10#discussion_r203828796 ## File path: app/src/main/java/org/apache/fineract/jobs/StartSyncJob.java ## @@

[GitHub] dilpreet96 commented on a change in pull request #10: feat: Sync feature for customer and customer details

2018-07-19 Thread GitBox
dilpreet96 commented on a change in pull request #10: feat: Sync feature for customer and customer details URL: https://github.com/apache/fineract-cn-mobile/pull/10#discussion_r203805965 ## File path:

[GitHub] dilpreet96 commented on a change in pull request #10: feat: Sync feature for customer and customer details

2018-07-19 Thread GitBox
dilpreet96 commented on a change in pull request #10: feat: Sync feature for customer and customer details URL: https://github.com/apache/fineract-cn-mobile/pull/10#discussion_r203805842 ## File path: app/src/main/AndroidManifest.xml ## @@ -72,6 +72,12 @@ +

[GitHub] pembemiriam opened a new pull request #2: fixed issues due to angular redux

2018-07-14 Thread GitBox
pembemiriam opened a new pull request #2: fixed issues due to angular redux URL: https://github.com/apache/fineract-cn-group-finance/pull/2 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] therajanmaurya commented on a change in pull request #15: feat: ledger and account

2018-07-24 Thread GitBox
therajanmaurya commented on a change in pull request #15: feat: ledger and account URL: https://github.com/apache/fineract-cn-mobile/pull/15#discussion_r204980325 ## File path: app/src/main/java/org/apache/fineract/ui/online/accounting/accounts/AccountsPresenter.kt ## @@

[GitHub] therajanmaurya commented on a change in pull request #15: feat: ledger and account

2018-07-24 Thread GitBox
therajanmaurya commented on a change in pull request #15: feat: ledger and account URL: https://github.com/apache/fineract-cn-mobile/pull/15#discussion_r204980090 ## File path: app/src/main/java/org/apache/fineract/ui/adapters/AccountsAdapter.kt ## @@ -0,0 +1,66 @@

[GitHub] therajanmaurya commented on a change in pull request #15: feat: ledger and account

2018-07-24 Thread GitBox
therajanmaurya commented on a change in pull request #15: feat: ledger and account URL: https://github.com/apache/fineract-cn-mobile/pull/15#discussion_r204981484 ## File path: app/src/main/java/org/apache/fineract/ui/online/accounting/accounts/AccountsPresenter.kt ## @@

[GitHub] therajanmaurya commented on a change in pull request #15: feat: ledger and account

2018-07-24 Thread GitBox
therajanmaurya commented on a change in pull request #15: feat: ledger and account URL: https://github.com/apache/fineract-cn-mobile/pull/15#discussion_r204980120 ## File path: app/src/main/java/org/apache/fineract/ui/adapters/LedgerAdapter.kt ## @@ -0,0 +1,65 @@ +package

[GitHub] therajanmaurya commented on a change in pull request #15: feat: ledger and account

2018-07-24 Thread GitBox
therajanmaurya commented on a change in pull request #15: feat: ledger and account URL: https://github.com/apache/fineract-cn-mobile/pull/15#discussion_r204980224 ## File path: app/src/main/java/org/apache/fineract/ui/online/accounting/accounts/AccountsFragment.kt ## @@

[GitHub] therajanmaurya commented on a change in pull request #14: feat : list and search tellers

2018-07-24 Thread GitBox
therajanmaurya commented on a change in pull request #14: feat : list and search tellers URL: https://github.com/apache/fineract-cn-mobile/pull/14#discussion_r204981806 ## File path: app/src/main/java/org/apache/fineract/data/services/TellersService.kt ## @@ -0,0 +1,18

[GitHub] therajanmaurya commented on a change in pull request #14: feat : list and search tellers

2018-07-24 Thread GitBox
therajanmaurya commented on a change in pull request #14: feat : list and search tellers URL: https://github.com/apache/fineract-cn-mobile/pull/14#discussion_r204982201 ## File path: app/src/main/java/org/apache/fineract/ui/online/teller/TellerFragment.kt ## @@ -0,0

[GitHub] therajanmaurya commented on a change in pull request #14: feat : list and search tellers

2018-07-24 Thread GitBox
therajanmaurya commented on a change in pull request #14: feat : list and search tellers URL: https://github.com/apache/fineract-cn-mobile/pull/14#discussion_r204981943 ## File path: app/src/main/java/org/apache/fineract/ui/adapters/TellerAdapter.kt ## @@ -0,0 +1,67 @@

[GitHub] therajanmaurya commented on a change in pull request #14: feat : list and search tellers

2018-07-24 Thread GitBox
therajanmaurya commented on a change in pull request #14: feat : list and search tellers URL: https://github.com/apache/fineract-cn-mobile/pull/14#discussion_r204982303 ## File path: app/src/main/java/org/apache/fineract/ui/online/teller/TellerFragment.kt ## @@ -0,0

[GitHub] therajanmaurya commented on a change in pull request #14: feat : list and search tellers

2018-07-24 Thread GitBox
therajanmaurya commented on a change in pull request #14: feat : list and search tellers URL: https://github.com/apache/fineract-cn-mobile/pull/14#discussion_r204981834 ## File path: app/src/main/java/org/apache/fineract/data/services/TellersService.kt ## @@ -0,0 +1,18

[GitHub] therajanmaurya closed pull request #7: fix: Exception in loan details

2018-07-24 Thread GitBox
therajanmaurya closed pull request #7: fix: Exception in loan details URL: https://github.com/apache/fineract-cn-mobile/pull/7 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] mohak1712 commented on a change in pull request #15: feat: ledger and account

2018-07-25 Thread GitBox
mohak1712 commented on a change in pull request #15: feat: ledger and account URL: https://github.com/apache/fineract-cn-mobile/pull/15#discussion_r205171233 ## File path: app/src/main/java/org/apache/fineract/ui/online/accounting/accounts/AccountsPresenter.kt ## @@ -0,0

[GitHub] ebenezergraham commented on issue #5: Unit and component Tests, Rest and command updates and Bug Fixes

2018-09-01 Thread GitBox
ebenezergraham commented on issue #5: Unit and component Tests,Rest and command updates and Bug Fixes URL: https://github.com/apache/fineract-cn-notifications/pull/5#issuecomment-417867980 Yes, the conflict is because I squashed the commits to reduce the commit noise in the old

[GitHub] awasum commented on issue #7: Changes added to the Group Microservice [GSoC period]

2018-09-01 Thread GitBox
awasum commented on issue #7: Changes added to the Group Microservice [GSoC period] URL: https://github.com/apache/fineract-cn-group/pull/7#issuecomment-417862546 Am still waiting for the unit test for group update before this can merged.

[GitHub] awasum commented on issue #7: Document Customer API IN component-test module

2018-09-01 Thread GitBox
awasum commented on issue #7: Document Customer API IN component-test module URL: https://github.com/apache/fineract-cn-customer/pull/7#issuecomment-417862447 Hey @Izakey I ran the tests and customerApiDocs test all pass but for some cassandra timeout problem some tests in

[GitHub] ebenezergraham opened a new pull request #6: Increment 2

2018-09-01 Thread GitBox
ebenezergraham opened a new pull request #6: Increment 2 URL: https://github.com/apache/fineract-cn-notifications/pull/6 Unit and component Tests,Rest and command added dependencies to shared Gradle file Created new group IDs for SMS and Email management Added

[GitHub] ebenezergraham commented on issue #6: Increment 2

2018-09-01 Thread GitBox
ebenezergraham commented on issue #6: Increment 2 URL: https://github.com/apache/fineract-cn-notifications/pull/6#issuecomment-417882080 Hi @awasum I have created a new request and maintained the old commits This is an

[GitHub] awasum commented on issue #5: Unit and component Tests, Rest and command updates and Bug Fixes

2018-09-01 Thread GitBox
awasum commented on issue #5: Unit and component Tests,Rest and command updates and Bug Fixes URL: https://github.com/apache/fineract-cn-notifications/pull/5#issuecomment-417862698 I see there seems to be conflicts here. Maybe you should close this PR and send in a new one without the

[GitHub] ebenezergraham commented on issue #6: Increment 2

2018-09-02 Thread GitBox
ebenezergraham commented on issue #6: Increment 2 URL: https://github.com/apache/fineract-cn-notifications/pull/6#issuecomment-417909585 Feedback from Myrle in the old commits https://github.com/apache/fineract-cn-notifications/pull/5#issuecomment-415014208 My responses:

[GitHub] ebenezergraham edited a comment on issue #6: Increment 2

2018-09-02 Thread GitBox
ebenezergraham edited a comment on issue #6: Increment 2 URL: https://github.com/apache/fineract-cn-notifications/pull/6#issuecomment-417882080 Hi @awasum I have created a new request and maintained the old commits to resolve the conflicts

[GitHub] awasum closed pull request #7: Document office API to manage offices & employees

2018-09-05 Thread GitBox
awasum closed pull request #7: Document office API to manage offices & employees URL: https://github.com/apache/fineract-cn-office/pull/7 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] awasum commented on issue #7: Document office API to manage offices & employees

2018-09-05 Thread GitBox
awasum commented on issue #7: Document office API to manage offices & employees URL: https://github.com/apache/fineract-cn-office/pull/7#issuecomment-418771009 Looks good. Merging now. This is an automated message from the

[GitHub] Izakey opened a new pull request #7: Document Teller API to manage teller operations

2018-09-04 Thread GitBox
Izakey opened a new pull request #7: Document Teller API to manage teller operations URL: https://github.com/apache/fineract-cn-teller/pull/7 Document Teller API to manage teller operations This is an automated message from

<    1   2   3   4   5   6   7   8   9   10   >