santoshconflux edited a comment on issue #465: Fineract 614: Rates module
URL: https://github.com/apache/fineract/pull/465#issuecomment-470904550
@awasum , We know @angelboxes did great job including this feature. Since
UI is not yet developed in Community app level and we still have
santoshconflux commented on issue #465: Fineract 614: Rates module
URL: https://github.com/apache/fineract/pull/465#issuecomment-470904550
@awasum , We know @angelboxes did great including this feature. Since UI
is not yet developed in Community app level and we still have open ticket
santoshconflux commented on issue #465: Fineract 614: Rates module
URL: https://github.com/apache/fineract/pull/465#issuecomment-470906245
@vishwasbabu , @ShruthiRajaram , if this PR is merged and since it's UI
version is not yet implemented,
andrew-dzak closed pull request #567: FINERACT-752 fix interest posting when
savings-interest-posting-curre…
URL: https://github.com/apache/fineract/pull/567
This is an automated message from the Apache Git Service.
To
palanisami opened a new pull request #570: FINERACT-689
URL: https://github.com/apache/fineract/pull/570
Changes made for fixing FINERACT-689
## Description
FINERACT-689
## Checklist
Please make sure these boxes are checked before submitting your pull request
- thanks!
miPlodder commented on a change in pull request #30: feat: Fixed Action Bar
slides in LoginActivity
URL: https://github.com/apache/fineract-cn-mobile/pull/30#discussion_r287840729
##
File path:
app/src/main/java/org/apache/fineract/ui/online/login/LoginActivity.java
##
palanisami opened a new pull request #571: FINERACT-689
URL: https://github.com/apache/fineract/pull/571
## Description
FINERACT-689
## Checklist
Please make sure these boxes are checked before submitting your pull request
- thanks!
- [ ] Commit message starts with the
miPlodder commented on issue #35: style: Removed Hardcoded strings
URL: https://github.com/apache/fineract-cn-mobile/pull/35#issuecomment-496259888
@therajanmaurya Looks good.
This is an automated message from the Apache Git
palanisami closed pull request #570: FINERACT-689
URL: https://github.com/apache/fineract/pull/570
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
aasaru commented on issue #8: Add Docker configuration
URL:
https://github.com/apache/fineract-cn-provisioner/pull/8#issuecomment-496202957
Looks good to me as a start.
I would like to build on top of this to automate publishing a new Docker
image to Docker Hub every time something
abhijitramesh commented on a change in pull request #30: feat: Fixed Action Bar
slides in LoginActivity
URL: https://github.com/apache/fineract-cn-mobile/pull/30#discussion_r287870436
##
File path:
app/src/main/java/org/apache/fineract/ui/online/login/LoginActivity.java
angelboxes opened a new pull request #572: FINERACT-757: Client list retrieval
returns emtpy result when using search parameter
URL: https://github.com/apache/fineract/pull/572
## Description
While testing /clients endpoint to search clients using search parameters
such as firstName,
awasum commented on issue #13: Adding after_failure procedure to CI
URL:
https://github.com/apache/fineract-cn-notifications/pull/13#issuecomment-495983765
@aasaru Please review..
This is an automated message from the Apache
ebenezergraham opened a new pull request #13: Adding after_failure procedure to
CI
URL: https://github.com/apache/fineract-cn-notifications/pull/13
The build outputs compilations error hence, it will not be necessary to
output every log (component-test, service or api), however, no
DylanRobson opened a new pull request #574: FINERACT-609 Group Topup Loan Bug
Fix.
URL: https://github.com/apache/fineract/pull/574
Fix FINERACT-609 issue where topup loan wasn't working for group loan
accounts. This was because the server wasn't sending the JSON array (named
Anh3h opened a new pull request #575: random change
URL: https://github.com/apache/fineract/pull/575
## Description
Describe the changes made and why they were made. Ignore if these details
are present on the associated Jira ticket
## Checklist
Please make sure these boxes are
awasum commented on issue #10: Changing Notification Admin to OrgAdmin
URL:
https://github.com/apache/fineract-cn-notifications/pull/10#issuecomment-498856274
Fix this conflicts @ebenezergraham , lets merge this and move the project
forward. Can you do this tomorrow?
Anh3h closed pull request #575: random change - testing travis build
URL: https://github.com/apache/fineract/pull/575
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
kangbreder opened a new pull request #577: Corrected API description in the
infrastructure module
URL: https://github.com/apache/fineract/pull/577
## Description
Describe the changes made and why they were made. Ignore if these details
are present on the associated Jira ticket
kangbreder opened a new pull request #578: Organisation module
URL: https://github.com/apache/fineract/pull/578
## Description
Describe the changes made and why they were made. Ignore if these details
are present on the associated Jira ticket
## Checklist
Please make sure
awasum commented on issue #579: Portfolio module
URL: https://github.com/apache/fineract/pull/579#issuecomment-499031128
This code seems to include Commits from other PRs. Is that the correct way
to do it?
Also, Travis is failing. Can you investigate?
kangbreder opened a new pull request #579: Portfolio module
URL: https://github.com/apache/fineract/pull/579
## Description
Describe the changes made and why they were made. Ignore if these details
are present on the associated Jira ticket
## Checklist
Please make sure these
abhijitramesh commented on a change in pull request #31: fix Reduction in
Toolbar size on changing orientation
URL: https://github.com/apache/fineract-cn-mobile/pull/31#discussion_r289296894
##
File path: app/src/main/res/values/styles.xml
##
@@ -62,5 +62,8 @@
therajanmaurya merged pull request #36: docs: Improved pull request template
URL: https://github.com/apache/fineract-cn-mobile/pull/36
This is an automated message from the Apache Git Service.
To respond to the message,
therajanmaurya merged pull request #35: style: Removed Hardcoded strings
URL: https://github.com/apache/fineract-cn-mobile/pull/35
This is an automated message from the Apache Git Service.
To respond to the message, please
therajanmaurya merged pull request #6: feat : added review screens
URL: https://github.com/apache/fineract-cn-mobile/pull/6
This is an automated message from the Apache Git Service.
To respond to the message, please log on
therajanmaurya merged pull request #55: FINCN-147/150/153/151/152
URL: https://github.com/apache/fineract-cn-mobile/pull/55
This is an automated message from the Apache Git Service.
To respond to the message, please log on
miPlodder commented on issue #47: Updating dashboard activity
URL: https://github.com/apache/fineract-cn-mobile/pull/47#issuecomment-497792332
@therajanmaurya We can close it. It's redundant.
This is an automated message from
therajanmaurya closed pull request #47: Updating dashboard activity
URL: https://github.com/apache/fineract-cn-mobile/pull/47
This is an automated message from the Apache Git Service.
To respond to the message, please log on
therajanmaurya merged pull request #37: refactor: Minor gradle refactor
URL: https://github.com/apache/fineract-cn-mobile/pull/37
This is an automated message from the Apache Git Service.
To respond to the message, please
therajanmaurya merged pull request #50: Fix #143: Country name error fixed on
Edit Customer
URL: https://github.com/apache/fineract-cn-mobile/pull/50
This is an automated message from the Apache Git Service.
To respond to
Anh3h merged pull request #10: Add convenicence method to print out RSA keys.
URL: https://github.com/apache/fineract-cn-lang/pull/10
This is an automated message from the Apache Git Service.
To respond to the message,
ebenezergraham commented on issue #11: Thymeleaf templating for Email
URL:
https://github.com/apache/fineract-cn-notifications/pull/11#issuecomment-499796061
@awasum I have refactored the API Naming convention, please provide
feedback. Also, I have removed the concurrency configuration in
awasum commented on issue #11: Thymeleaf templating for Email
URL:
https://github.com/apache/fineract-cn-notifications/pull/11#issuecomment-499800854
Ok...test and make sure just one event is still been emitted per
command/action. Let me know.
Everything looking good so far.
miPlodder commented on issue #51: feat: Add Support Gradle Play Publisher
URL: https://github.com/apache/fineract-cn-mobile/pull/51#issuecomment-499233388
@therajanmaurya I guess we should close it, as lots of things need to be
configured and few files need to be generated and PR just
ebenezergraham opened a new pull request #12: Adding rat report to After
Failure procedure
URL: https://github.com/apache/fineract-cn-identity/pull/12
This is an automated message from the Apache Git Service.
To respond to
ebenezergraham opened a new pull request #16: Adding rat report to After
Failure procedure
URL: https://github.com/apache/fineract-cn-portfolio/pull/16
This is an automated message from the Apache Git Service.
To respond to
ebenezergraham opened a new pull request #10: Adding rat report to After
Failure procedure
URL: https://github.com/apache/fineract-cn-service-starter/pull/10
This is an automated message from the Apache Git Service.
To
miPlodder edited a comment on issue #30: fix: Action Bar slides in
LoginActivity
URL: https://github.com/apache/fineract-cn-mobile/pull/30#issuecomment-497003434
@therajanmaurya Looks good now (Build Script fixed
[here](https://github.com/apache/fineract-cn-mobile/pull/55))
miPlodder commented on issue #30: fix: Action Bar slides in LoginActivity
URL: https://github.com/apache/fineract-cn-mobile/pull/30#issuecomment-497003434
@therajanmaurya Looks good now
This is an automated message from the
ebenezergraham opened a new pull request #12: Adding rat report to After
Failure procedure
URL: https://github.com/apache/fineract-cn-deposit-account-management/pull/12
This is an automated message from the Apache Git
ebenezergraham opened a new pull request #7: Adding rat report to After Failure
procedure
URL: https://github.com/apache/fineract-cn-mariadb/pull/7
This is an automated message from the Apache Git Service.
To respond to the
ebenezergraham opened a new pull request #11: Adding rat report to After
Failure procedure
URL: https://github.com/apache/fineract-cn-payroll/pull/11
This is an automated message from the Apache Git Service.
To respond to
ebenezergraham opened a new pull request #11: Adding rat report to After
Failure procedure
URL: https://github.com/apache/fineract-cn-office/pull/11
This is an automated message from the Apache Git Service.
To respond to
ebenezergraham opened a new pull request #6: Adding rat report to After Failure
procedure
URL: https://github.com/apache/fineract-cn-permitted-feign-client/pull/6
This is an automated message from the Apache Git Service.
To
ebenezergraham opened a new pull request #6: Adding rat report to After Failure
procedure
URL: https://github.com/apache/fineract-cn-crypto/pull/6
This is an automated message from the Apache Git Service.
To respond to the
ebenezergraham opened a new pull request #14: Docker file to assemble a
notification service image
URL: https://github.com/apache/fineract-cn-notifications/pull/14
This is an automated message from the Apache Git Service.
ebenezergraham opened a new pull request #9: Adding rat report to After Failure
procedure
URL: https://github.com/apache/fineract-cn-lang/pull/9
This is an automated message from the Apache Git Service.
To respond to the
ebenezergraham opened a new pull request #9: Adding rat report to After Failure
procedure
URL: https://github.com/apache/fineract-cn-provisioner/pull/9
This is an automated message from the Apache Git Service.
To respond to
ebenezergraham opened a new pull request #13: Adding rat report to After
Failure procedure
URL: https://github.com/apache/fineract-cn-teller/pull/13
This is an automated message from the Apache Git Service.
To respond to
ebenezergraham opened a new pull request #8: Adding rat report to After Failure
procedure
URL: https://github.com/apache/fineract-cn-template/pull/8
This is an automated message from the Apache Git Service.
To respond to
ebenezergraham opened a new pull request #10: Adding rat report to After
Failure procedure
URL: https://github.com/apache/fineract-cn-rhythm/pull/10
This is an automated message from the Apache Git Service.
To respond to
ebenezergraham opened a new pull request #6: Adding rat report to After Failure
procedure
URL: https://github.com/apache/fineract-cn-anubis/pull/6
This is an automated message from the Apache Git Service.
To respond to the
ebenezergraham opened a new pull request #8: Adding rat report to After Failure
procedure
URL: https://github.com/apache/fineract-cn-async/pull/8
This is an automated message from the Apache Git Service.
To respond to the
ebenezergraham opened a new pull request #12: Adding rat report to After
Failure procedure
URL: https://github.com/apache/fineract-cn-customer/pull/12
This is an automated message from the Apache Git Service.
To respond to
ebenezergraham opened a new pull request #9: Adding rat report to After Failure
procedure
URL: https://github.com/apache/fineract-cn-default-setup/pull/9
This is an automated message from the Apache Git Service.
To respond
ebenezergraham opened a new pull request #7: Adding rat report to After Failure
procedure
URL: https://github.com/apache/fineract-cn-cheques/pull/7
This is an automated message from the Apache Git Service.
To respond to the
ebenezergraham opened a new pull request #13: Adding rat report to After
Failure procedure
URL: https://github.com/apache/fineract-cn-accounting/pull/13
This is an automated message from the Apache Git Service.
To respond
ebenezergraham opened a new pull request #8: Adding rat report to After Failure
procedure
URL: https://github.com/apache/fineract-cn-command/pull/8
This is an automated message from the Apache Git Service.
To respond to the
ebenezergraham opened a new pull request #6: Adding rat report to After Failure
procedure
URL: https://github.com/apache/fineract-cn-data-jpa/pull/6
This is an automated message from the Apache Git Service.
To respond to
Anh3h merged pull request #9: Add Docker configuration
URL: https://github.com/apache/fineract-cn-reporting/pull/9
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
Anh3h commented on a change in pull request #14: Docker file to assemble a
notification service image
URL:
https://github.com/apache/fineract-cn-notifications/pull/14#discussion_r288702211
##
File path: Dockerfile
##
@@ -0,0 +1,31 @@
+#
+# Licensed to the Apache Software
miPlodder edited a comment on issue #46: Creating hamburger menu for dashboard
URL: https://github.com/apache/fineract-cn-mobile/pull/46#issuecomment-497055068
menu is not tied to Fragment and do keep the PR Title consistent. Anyways,
not needed.
miPlodder commented on issue #38: chore: Placed google repository as first
priority
URL: https://github.com/apache/fineract-cn-mobile/pull/38#issuecomment-497075002
@therajanmaurya Looks good.
This is an automated message
Anh3h merged pull request #10: Add Docker configuration
URL: https://github.com/apache/fineract-cn-payroll/pull/10
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
miPlodder commented on a change in pull request #48: feat: added toast showing
log out status
URL: https://github.com/apache/fineract-cn-mobile/pull/48#discussion_r288701301
##
File path:
app/src/main/java/org/apache/fineract/ui/online/DashboardActivity.java
##
@@ -157,6
miPlodder edited a comment on issue #46: Creating hamburger menu for dashboard
URL: https://github.com/apache/fineract-cn-mobile/pull/46#issuecomment-497055068
menu is not tied to Fragment and do keep the PR Title consistent.
Anyways, not needed.
@therajanmaurya You can close it if
miPlodder commented on issue #41: feat: added roboto font
URL: https://github.com/apache/fineract-cn-mobile/pull/41#issuecomment-497066883
@abhijitramesh Can you look for a way so that all text fields font change by
making a change at one particular place.
miPlodder commented on issue #44: fix: travis CI failing fixed
URL: https://github.com/apache/fineract-cn-mobile/pull/44#issuecomment-497068250
@therajanmaurya I have fixed this PR in one of the
[commit](https://github.com/apache/fineract-cn-mobile/pull/55). Merge any one
of them, changes
miPlodder commented on a change in pull request #39: fix: Restricted text
characters in Mobile fields
URL: https://github.com/apache/fineract-cn-mobile/pull/39#discussion_r288726889
##
File path: app/src/main/res/layout/fragment_form_customer_address.xml
##
@@ -63,7 +63,8
miPlodder commented on issue #37: refactor: Minor gradle refactor
URL: https://github.com/apache/fineract-cn-mobile/pull/37#issuecomment-497075417
@therajanmaurya Looks good.
This is an automated message from the Apache Git
miPlodder commented on a change in pull request #31: fix Reduction in Toolbar
size on changing orientation
URL: https://github.com/apache/fineract-cn-mobile/pull/31#discussion_r288734234
##
File path: app/src/main/res/values/styles.xml
##
@@ -62,5 +62,8 @@
miPlodder commented on issue #46: Creating hamburger menu for dashboard
URL: https://github.com/apache/fineract-cn-mobile/pull/46#issuecomment-497055068
Not needed and do keep the PR Title consistent.
This is an automated
miPlodder commented on issue #36: docs: Improved pull request template
URL: https://github.com/apache/fineract-cn-mobile/pull/36#issuecomment-497075839
@therajanmaurya Looks good.
This is an automated message from the Apache
ebenezergraham commented on issue #14: Docker file to assemble a notification
service image
URL:
https://github.com/apache/fineract-cn-notifications/pull/14#issuecomment-497044659
@Anh3h Can you please review this
This is
miPlodder commented on a change in pull request #49: Improved Hamburger Menu
URL: https://github.com/apache/fineract-cn-mobile/pull/49#discussion_r288698676
##
File path: app/src/main/res/layout/layout_nav_header.xml
##
@@ -13,26 +13,43 @@
miPlodder commented on a change in pull request #49: Improved Hamburger Menu
URL: https://github.com/apache/fineract-cn-mobile/pull/49#discussion_r288698153
##
File path: app/src/main/res/layout/layout_nav_header.xml
##
@@ -13,26 +13,43 @@
miPlodder commented on a change in pull request #34: "feat: added double tap to
exit feature on Dashboard"
URL: https://github.com/apache/fineract-cn-mobile/pull/34#discussion_r288702894
##
File path:
app/src/main/java/org/apache/fineract/ui/online/DashboardActivity.java
miPlodder commented on issue #34: "feat: added double tap to exit feature on
Dashboard"
URL: https://github.com/apache/fineract-cn-mobile/pull/34#issuecomment-497053947
@abhijitramesh Add Screenshots or GIF for UI changes.
therajanmaurya merged pull request #12: feat: search customer
URL: https://github.com/apache/fineract-cn-mobile/pull/12
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
therajanmaurya closed pull request #40: feat: added abi filter in the app
URL: https://github.com/apache/fineract-cn-mobile/pull/40
This is an automated message from the Apache Git Service.
To respond to the message, please
therajanmaurya merged pull request #30: fix: Action Bar slides in LoginActivity
URL: https://github.com/apache/fineract-cn-mobile/pull/30
This is an automated message from the Apache Git Service.
To respond to the message,
therajanmaurya commented on issue #43: Login Activity crashing in Android
4.2.2, API 17
URL: https://github.com/apache/fineract-cn-mobile/pull/43#issuecomment-497923305
This is fixed in new support library.
This is an
therajanmaurya closed pull request #43: Login Activity crashing in Android
4.2.2, API 17
URL: https://github.com/apache/fineract-cn-mobile/pull/43
This is an automated message from the Apache Git Service.
To respond to the
therajanmaurya edited a comment on issue #43: Login Activity crashing in
Android 4.2.2, API 17
URL: https://github.com/apache/fineract-cn-mobile/pull/43#issuecomment-497923305
This is fixed in AndroidX library.
This is an
therajanmaurya merged pull request #33: feat: added sweet-error library
URL: https://github.com/apache/fineract-cn-mobile/pull/33
This is an automated message from the Apache Git Service.
To respond to the message, please
therajanmaurya commented on issue #31: fix Reduction in Toolbar size on
changing orientation
URL: https://github.com/apache/fineract-cn-mobile/pull/31#issuecomment-497922324
We are not supporting tablet now.
This is an
therajanmaurya closed pull request #31: fix Reduction in Toolbar size on
changing orientation
URL: https://github.com/apache/fineract-cn-mobile/pull/31
This is an automated message from the Apache Git Service.
To respond to
therajanmaurya commented on issue #42: fix: password required string coinciding
with eye icon
URL: https://github.com/apache/fineract-cn-mobile/pull/42#issuecomment-497923210
We are going to use easyvalidation library for Edit Test validation. So
closing it.
therajanmaurya closed pull request #42: fix: password required string
coinciding with eye icon
URL: https://github.com/apache/fineract-cn-mobile/pull/42
This is an automated message from the Apache Git Service.
To respond
therajanmaurya closed pull request #45: feat: made improvement in the UI of
dashboard
URL: https://github.com/apache/fineract-cn-mobile/pull/45
This is an automated message from the Apache Git Service.
To respond to the
therajanmaurya commented on issue #45: feat: made improvement in the UI of
dashboard
URL: https://github.com/apache/fineract-cn-mobile/pull/45#issuecomment-497917160
We are going to implement new dashboard. It does not make sense.
therajanmaurya closed pull request #44: fix: travis CI failing fixed
URL: https://github.com/apache/fineract-cn-mobile/pull/44
This is an automated message from the Apache Git Service.
To respond to the message, please log
therajanmaurya commented on issue #44: fix: travis CI failing fixed
URL: https://github.com/apache/fineract-cn-mobile/pull/44#issuecomment-497917523
Duplicate
This is an automated message from the Apache Git Service.
To
therajanmaurya merged pull request #29: feat: added malayalam translation
URL: https://github.com/apache/fineract-cn-mobile/pull/29
This is an automated message from the Apache Git Service.
To respond to the message, please
ebenezergraham closed pull request #11: Thymeleaf templating for Email
URL: https://github.com/apache/fineract-cn-notifications/pull/11
This is an automated message from the Apache Git Service.
To respond to the message,
miPlodder opened a new pull request #62: feat: added toast showing log out
status
URL: https://github.com/apache/fineract-cn-mobile/pull/62
- [x] Apply the `AndroidStyle.xml` style template to your code in Android
Studio.
- [x] Run the unit tests with `./gradlew check` to make sure
therajanmaurya commented on issue #46: Creating hamburger menu for dashboard
URL: https://github.com/apache/fineract-cn-mobile/pull/46#issuecomment-497923423
Like currently we don't have any feature list to use this UI. So closing it.
therajanmaurya closed pull request #46: Creating hamburger menu for dashboard
URL: https://github.com/apache/fineract-cn-mobile/pull/46
This is an automated message from the Apache Git Service.
To respond to the message,
therajanmaurya merged pull request #58: feat: list and search products
URL: https://github.com/apache/fineract-cn-mobile/pull/58
This is an automated message from the Apache Git Service.
To respond to the message, please log
1101 - 1200 of 15004 matches
Mail list logo