[GitHub] [fineract] santoshconflux edited a comment on issue #465: Fineract 614: Rates module

2019-03-08 Thread GitBox
santoshconflux edited a comment on issue #465: Fineract 614: Rates module URL: https://github.com/apache/fineract/pull/465#issuecomment-470904550 @awasum , We know @angelboxes did great job including this feature. Since UI is not yet developed in Community app level and we still have

[GitHub] [fineract] santoshconflux commented on issue #465: Fineract 614: Rates module

2019-03-08 Thread GitBox
santoshconflux commented on issue #465: Fineract 614: Rates module URL: https://github.com/apache/fineract/pull/465#issuecomment-470904550 @awasum , We know @angelboxes did great including this feature. Since UI is not yet developed in Community app level and we still have open ticket

[GitHub] [fineract] santoshconflux commented on issue #465: Fineract 614: Rates module

2019-03-08 Thread GitBox
santoshconflux commented on issue #465: Fineract 614: Rates module URL: https://github.com/apache/fineract/pull/465#issuecomment-470906245 @vishwasbabu , @ShruthiRajaram , if this PR is merged and since it's UI version is not yet implemented,

[GitHub] [fineract] andrew-dzak closed pull request #567: FINERACT-752 fix interest posting when savings-interest-posting-curre…

2019-05-12 Thread GitBox
andrew-dzak closed pull request #567: FINERACT-752 fix interest posting when savings-interest-posting-curre… URL: https://github.com/apache/fineract/pull/567 This is an automated message from the Apache Git Service. To

[GitHub] [fineract] palanisami opened a new pull request #570: FINERACT-689

2019-05-27 Thread GitBox
palanisami opened a new pull request #570: FINERACT-689 URL: https://github.com/apache/fineract/pull/570 Changes made for fixing FINERACT-689 ## Description FINERACT-689 ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks!

[GitHub] [fineract-cn-mobile] miPlodder commented on a change in pull request #30: feat: Fixed Action Bar slides in LoginActivity

2019-05-27 Thread GitBox
miPlodder commented on a change in pull request #30: feat: Fixed Action Bar slides in LoginActivity URL: https://github.com/apache/fineract-cn-mobile/pull/30#discussion_r287840729 ## File path: app/src/main/java/org/apache/fineract/ui/online/login/LoginActivity.java ##

[GitHub] [fineract] palanisami opened a new pull request #571: FINERACT-689

2019-05-27 Thread GitBox
palanisami opened a new pull request #571: FINERACT-689 URL: https://github.com/apache/fineract/pull/571 ## Description FINERACT-689 ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [ ] Commit message starts with the

[GitHub] [fineract-cn-mobile] miPlodder commented on issue #35: style: Removed Hardcoded strings

2019-05-27 Thread GitBox
miPlodder commented on issue #35: style: Removed Hardcoded strings URL: https://github.com/apache/fineract-cn-mobile/pull/35#issuecomment-496259888 @therajanmaurya Looks good. This is an automated message from the Apache Git

[GitHub] [fineract] palanisami closed pull request #570: FINERACT-689

2019-05-27 Thread GitBox
palanisami closed pull request #570: FINERACT-689 URL: https://github.com/apache/fineract/pull/570 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [fineract-cn-provisioner] aasaru commented on issue #8: Add Docker configuration

2019-05-27 Thread GitBox
aasaru commented on issue #8: Add Docker configuration URL: https://github.com/apache/fineract-cn-provisioner/pull/8#issuecomment-496202957 Looks good to me as a start. I would like to build on top of this to automate publishing a new Docker image to Docker Hub every time something

[GitHub] [fineract-cn-mobile] abhijitramesh commented on a change in pull request #30: feat: Fixed Action Bar slides in LoginActivity

2019-05-27 Thread GitBox
abhijitramesh commented on a change in pull request #30: feat: Fixed Action Bar slides in LoginActivity URL: https://github.com/apache/fineract-cn-mobile/pull/30#discussion_r287870436 ## File path: app/src/main/java/org/apache/fineract/ui/online/login/LoginActivity.java

[GitHub] [fineract] angelboxes opened a new pull request #572: FINERACT-757: Client list retrieval returns emtpy result when using search parameter

2019-05-27 Thread GitBox
angelboxes opened a new pull request #572: FINERACT-757: Client list retrieval returns emtpy result when using search parameter URL: https://github.com/apache/fineract/pull/572 ## Description While testing /clients endpoint to search clients using search parameters such as firstName,

[GitHub] [fineract-cn-notifications] awasum commented on issue #13: Adding after_failure procedure to CI

2019-05-26 Thread GitBox
awasum commented on issue #13: Adding after_failure procedure to CI URL: https://github.com/apache/fineract-cn-notifications/pull/13#issuecomment-495983765 @aasaru Please review.. This is an automated message from the Apache

[GitHub] [fineract-cn-notifications] ebenezergraham opened a new pull request #13: Adding after_failure procedure to CI

2019-05-26 Thread GitBox
ebenezergraham opened a new pull request #13: Adding after_failure procedure to CI URL: https://github.com/apache/fineract-cn-notifications/pull/13 The build outputs compilations error hence, it will not be necessary to output every log (component-test, service or api), however, no

[GitHub] [fineract] DylanRobson opened a new pull request #574: FINERACT-609 Group Topup Loan Bug Fix.

2019-06-04 Thread GitBox
DylanRobson opened a new pull request #574: FINERACT-609 Group Topup Loan Bug Fix. URL: https://github.com/apache/fineract/pull/574 Fix FINERACT-609 issue where topup loan wasn't working for group loan accounts. This was because the server wasn't sending the JSON array (named

[GitHub] [fineract] Anh3h opened a new pull request #575: random change

2019-06-04 Thread GitBox
Anh3h opened a new pull request #575: random change URL: https://github.com/apache/fineract/pull/575 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket ## Checklist Please make sure these boxes are

[GitHub] [fineract-cn-notifications] awasum commented on issue #10: Changing Notification Admin to OrgAdmin

2019-06-04 Thread GitBox
awasum commented on issue #10: Changing Notification Admin to OrgAdmin URL: https://github.com/apache/fineract-cn-notifications/pull/10#issuecomment-498856274 Fix this conflicts @ebenezergraham , lets merge this and move the project forward. Can you do this tomorrow?

[GitHub] [fineract] Anh3h closed pull request #575: random change - testing travis build

2019-06-04 Thread GitBox
Anh3h closed pull request #575: random change - testing travis build URL: https://github.com/apache/fineract/pull/575 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [fineract] kangbreder opened a new pull request #577: Corrected API description in the infrastructure module

2019-06-04 Thread GitBox
kangbreder opened a new pull request #577: Corrected API description in the infrastructure module URL: https://github.com/apache/fineract/pull/577 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket

[GitHub] [fineract] kangbreder opened a new pull request #578: Organisation module

2019-06-05 Thread GitBox
kangbreder opened a new pull request #578: Organisation module URL: https://github.com/apache/fineract/pull/578 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket ## Checklist Please make sure

[GitHub] [fineract] awasum commented on issue #579: Portfolio module

2019-06-05 Thread GitBox
awasum commented on issue #579: Portfolio module URL: https://github.com/apache/fineract/pull/579#issuecomment-499031128 This code seems to include Commits from other PRs. Is that the correct way to do it? Also, Travis is failing. Can you investigate?

[GitHub] [fineract] kangbreder opened a new pull request #579: Portfolio module

2019-06-05 Thread GitBox
kangbreder opened a new pull request #579: Portfolio module URL: https://github.com/apache/fineract/pull/579 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket ## Checklist Please make sure these

[GitHub] [fineract-cn-mobile] abhijitramesh commented on a change in pull request #31: fix Reduction in Toolbar size on changing orientation

2019-05-31 Thread GitBox
abhijitramesh commented on a change in pull request #31: fix Reduction in Toolbar size on changing orientation URL: https://github.com/apache/fineract-cn-mobile/pull/31#discussion_r289296894 ## File path: app/src/main/res/values/styles.xml ## @@ -62,5 +62,8 @@

[GitHub] [fineract-cn-mobile] therajanmaurya merged pull request #36: docs: Improved pull request template

2019-05-31 Thread GitBox
therajanmaurya merged pull request #36: docs: Improved pull request template URL: https://github.com/apache/fineract-cn-mobile/pull/36 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [fineract-cn-mobile] therajanmaurya merged pull request #35: style: Removed Hardcoded strings

2019-05-31 Thread GitBox
therajanmaurya merged pull request #35: style: Removed Hardcoded strings URL: https://github.com/apache/fineract-cn-mobile/pull/35 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [fineract-cn-mobile] therajanmaurya merged pull request #6: feat : added review screens

2019-05-31 Thread GitBox
therajanmaurya merged pull request #6: feat : added review screens URL: https://github.com/apache/fineract-cn-mobile/pull/6 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [fineract-cn-mobile] therajanmaurya merged pull request #55: FINCN-147/150/153/151/152

2019-05-31 Thread GitBox
therajanmaurya merged pull request #55: FINCN-147/150/153/151/152 URL: https://github.com/apache/fineract-cn-mobile/pull/55 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [fineract-cn-mobile] miPlodder commented on issue #47: Updating dashboard activity

2019-05-31 Thread GitBox
miPlodder commented on issue #47: Updating dashboard activity URL: https://github.com/apache/fineract-cn-mobile/pull/47#issuecomment-497792332 @therajanmaurya We can close it. It's redundant. This is an automated message from

[GitHub] [fineract-cn-mobile] therajanmaurya closed pull request #47: Updating dashboard activity

2019-05-31 Thread GitBox
therajanmaurya closed pull request #47: Updating dashboard activity URL: https://github.com/apache/fineract-cn-mobile/pull/47 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [fineract-cn-mobile] therajanmaurya merged pull request #37: refactor: Minor gradle refactor

2019-05-31 Thread GitBox
therajanmaurya merged pull request #37: refactor: Minor gradle refactor URL: https://github.com/apache/fineract-cn-mobile/pull/37 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [fineract-cn-mobile] therajanmaurya merged pull request #50: Fix #143: Country name error fixed on Edit Customer

2019-05-31 Thread GitBox
therajanmaurya merged pull request #50: Fix #143: Country name error fixed on Edit Customer URL: https://github.com/apache/fineract-cn-mobile/pull/50 This is an automated message from the Apache Git Service. To respond to

[GitHub] [fineract-cn-lang] Anh3h merged pull request #10: Add convenicence method to print out RSA keys.

2019-06-06 Thread GitBox
Anh3h merged pull request #10: Add convenicence method to print out RSA keys. URL: https://github.com/apache/fineract-cn-lang/pull/10 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [fineract-cn-notifications] ebenezergraham commented on issue #11: Thymeleaf templating for Email

2019-06-07 Thread GitBox
ebenezergraham commented on issue #11: Thymeleaf templating for Email URL: https://github.com/apache/fineract-cn-notifications/pull/11#issuecomment-499796061 @awasum I have refactored the API Naming convention, please provide feedback. Also, I have removed the concurrency configuration in

[GitHub] [fineract-cn-notifications] awasum commented on issue #11: Thymeleaf templating for Email

2019-06-07 Thread GitBox
awasum commented on issue #11: Thymeleaf templating for Email URL: https://github.com/apache/fineract-cn-notifications/pull/11#issuecomment-499800854 Ok...test and make sure just one event is still been emitted per command/action. Let me know. Everything looking good so far.

[GitHub] [fineract-cn-mobile] miPlodder commented on issue #51: feat: Add Support Gradle Play Publisher

2019-06-05 Thread GitBox
miPlodder commented on issue #51: feat: Add Support Gradle Play Publisher URL: https://github.com/apache/fineract-cn-mobile/pull/51#issuecomment-499233388 @therajanmaurya I guess we should close it, as lots of things need to be configured and few files need to be generated and PR just

[GitHub] [fineract-cn-identity] ebenezergraham opened a new pull request #12: Adding rat report to After Failure procedure

2019-05-29 Thread GitBox
ebenezergraham opened a new pull request #12: Adding rat report to After Failure procedure URL: https://github.com/apache/fineract-cn-identity/pull/12 This is an automated message from the Apache Git Service. To respond to

[GitHub] [fineract-cn-portfolio] ebenezergraham opened a new pull request #16: Adding rat report to After Failure procedure

2019-05-29 Thread GitBox
ebenezergraham opened a new pull request #16: Adding rat report to After Failure procedure URL: https://github.com/apache/fineract-cn-portfolio/pull/16 This is an automated message from the Apache Git Service. To respond to

[GitHub] [fineract-cn-service-starter] ebenezergraham opened a new pull request #10: Adding rat report to After Failure procedure

2019-05-29 Thread GitBox
ebenezergraham opened a new pull request #10: Adding rat report to After Failure procedure URL: https://github.com/apache/fineract-cn-service-starter/pull/10 This is an automated message from the Apache Git Service. To

[GitHub] [fineract-cn-mobile] miPlodder edited a comment on issue #30: fix: Action Bar slides in LoginActivity

2019-05-29 Thread GitBox
miPlodder edited a comment on issue #30: fix: Action Bar slides in LoginActivity URL: https://github.com/apache/fineract-cn-mobile/pull/30#issuecomment-497003434 @therajanmaurya Looks good now (Build Script fixed [here](https://github.com/apache/fineract-cn-mobile/pull/55))

[GitHub] [fineract-cn-mobile] miPlodder commented on issue #30: fix: Action Bar slides in LoginActivity

2019-05-29 Thread GitBox
miPlodder commented on issue #30: fix: Action Bar slides in LoginActivity URL: https://github.com/apache/fineract-cn-mobile/pull/30#issuecomment-497003434 @therajanmaurya Looks good now This is an automated message from the

[GitHub] [fineract-cn-deposit-account-management] ebenezergraham opened a new pull request #12: Adding rat report to After Failure procedure

2019-05-29 Thread GitBox
ebenezergraham opened a new pull request #12: Adding rat report to After Failure procedure URL: https://github.com/apache/fineract-cn-deposit-account-management/pull/12 This is an automated message from the Apache Git

[GitHub] [fineract-cn-mariadb] ebenezergraham opened a new pull request #7: Adding rat report to After Failure procedure

2019-05-29 Thread GitBox
ebenezergraham opened a new pull request #7: Adding rat report to After Failure procedure URL: https://github.com/apache/fineract-cn-mariadb/pull/7 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [fineract-cn-payroll] ebenezergraham opened a new pull request #11: Adding rat report to After Failure procedure

2019-05-29 Thread GitBox
ebenezergraham opened a new pull request #11: Adding rat report to After Failure procedure URL: https://github.com/apache/fineract-cn-payroll/pull/11 This is an automated message from the Apache Git Service. To respond to

[GitHub] [fineract-cn-office] ebenezergraham opened a new pull request #11: Adding rat report to After Failure procedure

2019-05-29 Thread GitBox
ebenezergraham opened a new pull request #11: Adding rat report to After Failure procedure URL: https://github.com/apache/fineract-cn-office/pull/11 This is an automated message from the Apache Git Service. To respond to

[GitHub] [fineract-cn-permitted-feign-client] ebenezergraham opened a new pull request #6: Adding rat report to After Failure procedure

2019-05-29 Thread GitBox
ebenezergraham opened a new pull request #6: Adding rat report to After Failure procedure URL: https://github.com/apache/fineract-cn-permitted-feign-client/pull/6 This is an automated message from the Apache Git Service. To

[GitHub] [fineract-cn-crypto] ebenezergraham opened a new pull request #6: Adding rat report to After Failure procedure

2019-05-29 Thread GitBox
ebenezergraham opened a new pull request #6: Adding rat report to After Failure procedure URL: https://github.com/apache/fineract-cn-crypto/pull/6 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [fineract-cn-notifications] ebenezergraham opened a new pull request #14: Docker file to assemble a notification service image

2019-05-29 Thread GitBox
ebenezergraham opened a new pull request #14: Docker file to assemble a notification service image URL: https://github.com/apache/fineract-cn-notifications/pull/14 This is an automated message from the Apache Git Service.

[GitHub] [fineract-cn-lang] ebenezergraham opened a new pull request #9: Adding rat report to After Failure procedure

2019-05-29 Thread GitBox
ebenezergraham opened a new pull request #9: Adding rat report to After Failure procedure URL: https://github.com/apache/fineract-cn-lang/pull/9 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [fineract-cn-provisioner] ebenezergraham opened a new pull request #9: Adding rat report to After Failure procedure

2019-05-29 Thread GitBox
ebenezergraham opened a new pull request #9: Adding rat report to After Failure procedure URL: https://github.com/apache/fineract-cn-provisioner/pull/9 This is an automated message from the Apache Git Service. To respond to

[GitHub] [fineract-cn-teller] ebenezergraham opened a new pull request #13: Adding rat report to After Failure procedure

2019-05-29 Thread GitBox
ebenezergraham opened a new pull request #13: Adding rat report to After Failure procedure URL: https://github.com/apache/fineract-cn-teller/pull/13 This is an automated message from the Apache Git Service. To respond to

[GitHub] [fineract-cn-template] ebenezergraham opened a new pull request #8: Adding rat report to After Failure procedure

2019-05-29 Thread GitBox
ebenezergraham opened a new pull request #8: Adding rat report to After Failure procedure URL: https://github.com/apache/fineract-cn-template/pull/8 This is an automated message from the Apache Git Service. To respond to

[GitHub] [fineract-cn-rhythm] ebenezergraham opened a new pull request #10: Adding rat report to After Failure procedure

2019-05-29 Thread GitBox
ebenezergraham opened a new pull request #10: Adding rat report to After Failure procedure URL: https://github.com/apache/fineract-cn-rhythm/pull/10 This is an automated message from the Apache Git Service. To respond to

[GitHub] [fineract-cn-anubis] ebenezergraham opened a new pull request #6: Adding rat report to After Failure procedure

2019-05-29 Thread GitBox
ebenezergraham opened a new pull request #6: Adding rat report to After Failure procedure URL: https://github.com/apache/fineract-cn-anubis/pull/6 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [fineract-cn-async] ebenezergraham opened a new pull request #8: Adding rat report to After Failure procedure

2019-05-29 Thread GitBox
ebenezergraham opened a new pull request #8: Adding rat report to After Failure procedure URL: https://github.com/apache/fineract-cn-async/pull/8 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [fineract-cn-customer] ebenezergraham opened a new pull request #12: Adding rat report to After Failure procedure

2019-05-29 Thread GitBox
ebenezergraham opened a new pull request #12: Adding rat report to After Failure procedure URL: https://github.com/apache/fineract-cn-customer/pull/12 This is an automated message from the Apache Git Service. To respond to

[GitHub] [fineract-cn-default-setup] ebenezergraham opened a new pull request #9: Adding rat report to After Failure procedure

2019-05-29 Thread GitBox
ebenezergraham opened a new pull request #9: Adding rat report to After Failure procedure URL: https://github.com/apache/fineract-cn-default-setup/pull/9 This is an automated message from the Apache Git Service. To respond

[GitHub] [fineract-cn-cheques] ebenezergraham opened a new pull request #7: Adding rat report to After Failure procedure

2019-05-29 Thread GitBox
ebenezergraham opened a new pull request #7: Adding rat report to After Failure procedure URL: https://github.com/apache/fineract-cn-cheques/pull/7 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [fineract-cn-accounting] ebenezergraham opened a new pull request #13: Adding rat report to After Failure procedure

2019-05-29 Thread GitBox
ebenezergraham opened a new pull request #13: Adding rat report to After Failure procedure URL: https://github.com/apache/fineract-cn-accounting/pull/13 This is an automated message from the Apache Git Service. To respond

[GitHub] [fineract-cn-command] ebenezergraham opened a new pull request #8: Adding rat report to After Failure procedure

2019-05-29 Thread GitBox
ebenezergraham opened a new pull request #8: Adding rat report to After Failure procedure URL: https://github.com/apache/fineract-cn-command/pull/8 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [fineract-cn-data-jpa] ebenezergraham opened a new pull request #6: Adding rat report to After Failure procedure

2019-05-29 Thread GitBox
ebenezergraham opened a new pull request #6: Adding rat report to After Failure procedure URL: https://github.com/apache/fineract-cn-data-jpa/pull/6 This is an automated message from the Apache Git Service. To respond to

[GitHub] [fineract-cn-reporting] Anh3h merged pull request #9: Add Docker configuration

2019-05-29 Thread GitBox
Anh3h merged pull request #9: Add Docker configuration URL: https://github.com/apache/fineract-cn-reporting/pull/9 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [fineract-cn-notifications] Anh3h commented on a change in pull request #14: Docker file to assemble a notification service image

2019-05-29 Thread GitBox
Anh3h commented on a change in pull request #14: Docker file to assemble a notification service image URL: https://github.com/apache/fineract-cn-notifications/pull/14#discussion_r288702211 ## File path: Dockerfile ## @@ -0,0 +1,31 @@ +# +# Licensed to the Apache Software

[GitHub] [fineract-cn-mobile] miPlodder edited a comment on issue #46: Creating hamburger menu for dashboard

2019-05-29 Thread GitBox
miPlodder edited a comment on issue #46: Creating hamburger menu for dashboard URL: https://github.com/apache/fineract-cn-mobile/pull/46#issuecomment-497055068 menu is not tied to Fragment and do keep the PR Title consistent. Anyways, not needed.

[GitHub] [fineract-cn-mobile] miPlodder commented on issue #38: chore: Placed google repository as first priority

2019-05-29 Thread GitBox
miPlodder commented on issue #38: chore: Placed google repository as first priority URL: https://github.com/apache/fineract-cn-mobile/pull/38#issuecomment-497075002 @therajanmaurya Looks good. This is an automated message

[GitHub] [fineract-cn-payroll] Anh3h merged pull request #10: Add Docker configuration

2019-05-29 Thread GitBox
Anh3h merged pull request #10: Add Docker configuration URL: https://github.com/apache/fineract-cn-payroll/pull/10 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [fineract-cn-mobile] miPlodder commented on a change in pull request #48: feat: added toast showing log out status

2019-05-29 Thread GitBox
miPlodder commented on a change in pull request #48: feat: added toast showing log out status URL: https://github.com/apache/fineract-cn-mobile/pull/48#discussion_r288701301 ## File path: app/src/main/java/org/apache/fineract/ui/online/DashboardActivity.java ## @@ -157,6

[GitHub] [fineract-cn-mobile] miPlodder edited a comment on issue #46: Creating hamburger menu for dashboard

2019-05-29 Thread GitBox
miPlodder edited a comment on issue #46: Creating hamburger menu for dashboard URL: https://github.com/apache/fineract-cn-mobile/pull/46#issuecomment-497055068 menu is not tied to Fragment and do keep the PR Title consistent. Anyways, not needed. @therajanmaurya You can close it if

[GitHub] [fineract-cn-mobile] miPlodder commented on issue #41: feat: added roboto font

2019-05-29 Thread GitBox
miPlodder commented on issue #41: feat: added roboto font URL: https://github.com/apache/fineract-cn-mobile/pull/41#issuecomment-497066883 @abhijitramesh Can you look for a way so that all text fields font change by making a change at one particular place.

[GitHub] [fineract-cn-mobile] miPlodder commented on issue #44: fix: travis CI failing fixed

2019-05-29 Thread GitBox
miPlodder commented on issue #44: fix: travis CI failing fixed URL: https://github.com/apache/fineract-cn-mobile/pull/44#issuecomment-497068250 @therajanmaurya I have fixed this PR in one of the [commit](https://github.com/apache/fineract-cn-mobile/pull/55). Merge any one of them, changes

[GitHub] [fineract-cn-mobile] miPlodder commented on a change in pull request #39: fix: Restricted text characters in Mobile fields

2019-05-29 Thread GitBox
miPlodder commented on a change in pull request #39: fix: Restricted text characters in Mobile fields URL: https://github.com/apache/fineract-cn-mobile/pull/39#discussion_r288726889 ## File path: app/src/main/res/layout/fragment_form_customer_address.xml ## @@ -63,7 +63,8

[GitHub] [fineract-cn-mobile] miPlodder commented on issue #37: refactor: Minor gradle refactor

2019-05-29 Thread GitBox
miPlodder commented on issue #37: refactor: Minor gradle refactor URL: https://github.com/apache/fineract-cn-mobile/pull/37#issuecomment-497075417 @therajanmaurya Looks good. This is an automated message from the Apache Git

[GitHub] [fineract-cn-mobile] miPlodder commented on a change in pull request #31: fix Reduction in Toolbar size on changing orientation

2019-05-29 Thread GitBox
miPlodder commented on a change in pull request #31: fix Reduction in Toolbar size on changing orientation URL: https://github.com/apache/fineract-cn-mobile/pull/31#discussion_r288734234 ## File path: app/src/main/res/values/styles.xml ## @@ -62,5 +62,8 @@

[GitHub] [fineract-cn-mobile] miPlodder commented on issue #46: Creating hamburger menu for dashboard

2019-05-29 Thread GitBox
miPlodder commented on issue #46: Creating hamburger menu for dashboard URL: https://github.com/apache/fineract-cn-mobile/pull/46#issuecomment-497055068 Not needed and do keep the PR Title consistent. This is an automated

[GitHub] [fineract-cn-mobile] miPlodder commented on issue #36: docs: Improved pull request template

2019-05-29 Thread GitBox
miPlodder commented on issue #36: docs: Improved pull request template URL: https://github.com/apache/fineract-cn-mobile/pull/36#issuecomment-497075839 @therajanmaurya Looks good. This is an automated message from the Apache

[GitHub] [fineract-cn-notifications] ebenezergraham commented on issue #14: Docker file to assemble a notification service image

2019-05-29 Thread GitBox
ebenezergraham commented on issue #14: Docker file to assemble a notification service image URL: https://github.com/apache/fineract-cn-notifications/pull/14#issuecomment-497044659 @Anh3h Can you please review this This is

[GitHub] [fineract-cn-mobile] miPlodder commented on a change in pull request #49: Improved Hamburger Menu

2019-05-29 Thread GitBox
miPlodder commented on a change in pull request #49: Improved Hamburger Menu URL: https://github.com/apache/fineract-cn-mobile/pull/49#discussion_r288698676 ## File path: app/src/main/res/layout/layout_nav_header.xml ## @@ -13,26 +13,43 @@

[GitHub] [fineract-cn-mobile] miPlodder commented on a change in pull request #49: Improved Hamburger Menu

2019-05-29 Thread GitBox
miPlodder commented on a change in pull request #49: Improved Hamburger Menu URL: https://github.com/apache/fineract-cn-mobile/pull/49#discussion_r288698153 ## File path: app/src/main/res/layout/layout_nav_header.xml ## @@ -13,26 +13,43 @@

[GitHub] [fineract-cn-mobile] miPlodder commented on a change in pull request #34: "feat: added double tap to exit feature on Dashboard"

2019-05-29 Thread GitBox
miPlodder commented on a change in pull request #34: "feat: added double tap to exit feature on Dashboard" URL: https://github.com/apache/fineract-cn-mobile/pull/34#discussion_r288702894 ## File path: app/src/main/java/org/apache/fineract/ui/online/DashboardActivity.java

[GitHub] [fineract-cn-mobile] miPlodder commented on issue #34: "feat: added double tap to exit feature on Dashboard"

2019-05-29 Thread GitBox
miPlodder commented on issue #34: "feat: added double tap to exit feature on Dashboard" URL: https://github.com/apache/fineract-cn-mobile/pull/34#issuecomment-497053947 @abhijitramesh Add Screenshots or GIF for UI changes.

[GitHub] [fineract-cn-mobile] therajanmaurya merged pull request #12: feat: search customer

2019-06-01 Thread GitBox
therajanmaurya merged pull request #12: feat: search customer URL: https://github.com/apache/fineract-cn-mobile/pull/12 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [fineract-cn-mobile] therajanmaurya closed pull request #40: feat: added abi filter in the app

2019-06-01 Thread GitBox
therajanmaurya closed pull request #40: feat: added abi filter in the app URL: https://github.com/apache/fineract-cn-mobile/pull/40 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [fineract-cn-mobile] therajanmaurya merged pull request #30: fix: Action Bar slides in LoginActivity

2019-06-01 Thread GitBox
therajanmaurya merged pull request #30: fix: Action Bar slides in LoginActivity URL: https://github.com/apache/fineract-cn-mobile/pull/30 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [fineract-cn-mobile] therajanmaurya commented on issue #43: Login Activity crashing in Android 4.2.2, API 17

2019-06-01 Thread GitBox
therajanmaurya commented on issue #43: Login Activity crashing in Android 4.2.2, API 17 URL: https://github.com/apache/fineract-cn-mobile/pull/43#issuecomment-497923305 This is fixed in new support library. This is an

[GitHub] [fineract-cn-mobile] therajanmaurya closed pull request #43: Login Activity crashing in Android 4.2.2, API 17

2019-06-01 Thread GitBox
therajanmaurya closed pull request #43: Login Activity crashing in Android 4.2.2, API 17 URL: https://github.com/apache/fineract-cn-mobile/pull/43 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [fineract-cn-mobile] therajanmaurya edited a comment on issue #43: Login Activity crashing in Android 4.2.2, API 17

2019-06-01 Thread GitBox
therajanmaurya edited a comment on issue #43: Login Activity crashing in Android 4.2.2, API 17 URL: https://github.com/apache/fineract-cn-mobile/pull/43#issuecomment-497923305 This is fixed in AndroidX library. This is an

[GitHub] [fineract-cn-mobile] therajanmaurya merged pull request #33: feat: added sweet-error library

2019-06-01 Thread GitBox
therajanmaurya merged pull request #33: feat: added sweet-error library URL: https://github.com/apache/fineract-cn-mobile/pull/33 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [fineract-cn-mobile] therajanmaurya commented on issue #31: fix Reduction in Toolbar size on changing orientation

2019-06-01 Thread GitBox
therajanmaurya commented on issue #31: fix Reduction in Toolbar size on changing orientation URL: https://github.com/apache/fineract-cn-mobile/pull/31#issuecomment-497922324 We are not supporting tablet now. This is an

[GitHub] [fineract-cn-mobile] therajanmaurya closed pull request #31: fix Reduction in Toolbar size on changing orientation

2019-06-01 Thread GitBox
therajanmaurya closed pull request #31: fix Reduction in Toolbar size on changing orientation URL: https://github.com/apache/fineract-cn-mobile/pull/31 This is an automated message from the Apache Git Service. To respond to

[GitHub] [fineract-cn-mobile] therajanmaurya commented on issue #42: fix: password required string coinciding with eye icon

2019-06-01 Thread GitBox
therajanmaurya commented on issue #42: fix: password required string coinciding with eye icon URL: https://github.com/apache/fineract-cn-mobile/pull/42#issuecomment-497923210 We are going to use easyvalidation library for Edit Test validation. So closing it.

[GitHub] [fineract-cn-mobile] therajanmaurya closed pull request #42: fix: password required string coinciding with eye icon

2019-06-01 Thread GitBox
therajanmaurya closed pull request #42: fix: password required string coinciding with eye icon URL: https://github.com/apache/fineract-cn-mobile/pull/42 This is an automated message from the Apache Git Service. To respond

[GitHub] [fineract-cn-mobile] therajanmaurya closed pull request #45: feat: made improvement in the UI of dashboard

2019-06-01 Thread GitBox
therajanmaurya closed pull request #45: feat: made improvement in the UI of dashboard URL: https://github.com/apache/fineract-cn-mobile/pull/45 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [fineract-cn-mobile] therajanmaurya commented on issue #45: feat: made improvement in the UI of dashboard

2019-06-01 Thread GitBox
therajanmaurya commented on issue #45: feat: made improvement in the UI of dashboard URL: https://github.com/apache/fineract-cn-mobile/pull/45#issuecomment-497917160 We are going to implement new dashboard. It does not make sense.

[GitHub] [fineract-cn-mobile] therajanmaurya closed pull request #44: fix: travis CI failing fixed

2019-06-01 Thread GitBox
therajanmaurya closed pull request #44: fix: travis CI failing fixed URL: https://github.com/apache/fineract-cn-mobile/pull/44 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [fineract-cn-mobile] therajanmaurya commented on issue #44: fix: travis CI failing fixed

2019-06-01 Thread GitBox
therajanmaurya commented on issue #44: fix: travis CI failing fixed URL: https://github.com/apache/fineract-cn-mobile/pull/44#issuecomment-497917523 Duplicate This is an automated message from the Apache Git Service. To

[GitHub] [fineract-cn-mobile] therajanmaurya merged pull request #29: feat: added malayalam translation

2019-06-01 Thread GitBox
therajanmaurya merged pull request #29: feat: added malayalam translation URL: https://github.com/apache/fineract-cn-mobile/pull/29 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [fineract-cn-notifications] ebenezergraham closed pull request #11: Thymeleaf templating for Email

2019-06-03 Thread GitBox
ebenezergraham closed pull request #11: Thymeleaf templating for Email URL: https://github.com/apache/fineract-cn-notifications/pull/11 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [fineract-cn-mobile] miPlodder opened a new pull request #62: feat: added toast showing log out status

2019-06-01 Thread GitBox
miPlodder opened a new pull request #62: feat: added toast showing log out status URL: https://github.com/apache/fineract-cn-mobile/pull/62 - [x] Apply the `AndroidStyle.xml` style template to your code in Android Studio. - [x] Run the unit tests with `./gradlew check` to make sure

[GitHub] [fineract-cn-mobile] therajanmaurya commented on issue #46: Creating hamburger menu for dashboard

2019-06-01 Thread GitBox
therajanmaurya commented on issue #46: Creating hamburger menu for dashboard URL: https://github.com/apache/fineract-cn-mobile/pull/46#issuecomment-497923423 Like currently we don't have any feature list to use this UI. So closing it.

[GitHub] [fineract-cn-mobile] therajanmaurya closed pull request #46: Creating hamburger menu for dashboard

2019-06-01 Thread GitBox
therajanmaurya closed pull request #46: Creating hamburger menu for dashboard URL: https://github.com/apache/fineract-cn-mobile/pull/46 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [fineract-cn-mobile] therajanmaurya merged pull request #58: feat: list and search products

2019-06-01 Thread GitBox
therajanmaurya merged pull request #58: feat: list and search products URL: https://github.com/apache/fineract-cn-mobile/pull/58 This is an automated message from the Apache Git Service. To respond to the message, please log

<    7   8   9   10   11   12   13   14   15   16   >