[GitHub] [fineract-cn-mobile] therajanmaurya merged pull request #59: feat: unit test

2019-06-01 Thread GitBox
therajanmaurya merged pull request #59: feat: unit test URL: https://github.com/apache/fineract-cn-mobile/pull/59 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [fineract-cn-mobile] miPlodder opened a new pull request #61: fix: Restricted text characters in Mobile fields

2019-06-01 Thread GitBox
miPlodder opened a new pull request #61: fix: Restricted text characters in Mobile fields URL: https://github.com/apache/fineract-cn-mobile/pull/61 - [x] Apply the `AndroidStyle.xml` style template to your code in Android Studio. - [x] Run the unit tests with `./gradlew check` to

[GitHub] [fineract-cn-mobile] miPlodder commented on issue #58: feat: list and search products

2019-06-01 Thread GitBox
miPlodder commented on issue #58: feat: list and search products URL: https://github.com/apache/fineract-cn-mobile/pull/58#issuecomment-497966879 @therajanmaurya PR - https://github.com/apache/fineract-cn-mobile/pull/21 This

[GitHub] [fineract-cn-mobile] miPlodder commented on issue #59: feat: unit test

2019-06-01 Thread GitBox
miPlodder commented on issue #59: feat: unit test URL: https://github.com/apache/fineract-cn-mobile/pull/59#issuecomment-497966838 @therajanmaurya Previous PR - https://github.com/apache/fineract-cn-mobile/pull/21 This is an

[GitHub] [fineract-cn-mobile] miPlodder edited a comment on issue #58: feat: list and search products

2019-06-01 Thread GitBox
miPlodder edited a comment on issue #58: feat: list and search products URL: https://github.com/apache/fineract-cn-mobile/pull/58#issuecomment-497966879 @therajanmaurya PR - https://github.com/apache/fineract-cn-mobile/pull/17

[GitHub] [fineract-cn-mobile] miPlodder opened a new pull request #60: Payroll

2019-06-01 Thread GitBox
miPlodder opened a new pull request #60: Payroll URL: https://github.com/apache/fineract-cn-mobile/pull/60 - [x] Apply the `AndroidStyle.xml` style template to your code in Android Studio. - [x] Run the unit tests with `./gradlew check` to make sure you didn't break anything.

[GitHub] [fineract-cn-mobile] miPlodder opened a new pull request #58: feat: list and search products

2019-06-01 Thread GitBox
miPlodder opened a new pull request #58: feat: list and search products URL: https://github.com/apache/fineract-cn-mobile/pull/58 Fixes #Issue_number Please Add Screenshots If any UI changes. Please Add Summary of what changes you have made and if possible provide

[GitHub] [fineract-cn-mobile] miPlodder opened a new pull request #59: feat: unit test

2019-06-01 Thread GitBox
miPlodder opened a new pull request #59: feat: unit test URL: https://github.com/apache/fineract-cn-mobile/pull/59 Fixes #Issue_number Please Add Screenshots If any UI changes. Please Add Summary of what changes you have made and if possible provide links.(Optional)

[GitHub] [fineract-cn-permitted-feign-client] awasum merged pull request #6: Adding rat report to After Failure procedure

2019-06-03 Thread GitBox
awasum merged pull request #6: Adding rat report to After Failure procedure URL: https://github.com/apache/fineract-cn-permitted-feign-client/pull/6 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [fineract-cn-office] awasum merged pull request #11: Adding rat report to After Failure procedure

2019-06-03 Thread GitBox
awasum merged pull request #11: Adding rat report to After Failure procedure URL: https://github.com/apache/fineract-cn-office/pull/11 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [fineract-cn-rhythm] awasum merged pull request #10: Adding rat report to After Failure procedure

2019-06-03 Thread GitBox
awasum merged pull request #10: Adding rat report to After Failure procedure URL: https://github.com/apache/fineract-cn-rhythm/pull/10 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [fineract-cn-template] awasum merged pull request #8: Adding rat report to After Failure procedure

2019-06-03 Thread GitBox
awasum merged pull request #8: Adding rat report to After Failure procedure URL: https://github.com/apache/fineract-cn-template/pull/8 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [fineract-cn-notifications] aasaru commented on issue #13: Adding after_failure procedure to CI

2019-06-03 Thread GitBox
aasaru commented on issue #13: Adding after_failure procedure to CI URL: https://github.com/apache/fineract-cn-notifications/pull/13#issuecomment-498390133 I reviewed the changes and I agree with them. This is an automated

[GitHub] [fineract-cn-lang] awasum merged pull request #9: Adding rat report to After Failure procedure

2019-06-03 Thread GitBox
awasum merged pull request #9: Adding rat report to After Failure procedure URL: https://github.com/apache/fineract-cn-lang/pull/9 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [fineract-cn-notifications] awasum commented on issue #10: Changing Notification Admin to OrgAdmin

2019-06-03 Thread GitBox
awasum commented on issue #10: Changing Notification Admin to OrgAdmin URL: https://github.com/apache/fineract-cn-notifications/pull/10#issuecomment-498436402 there is a conflict here This is an automated message from the

[GitHub] [fineract-cn-mobile] therajanmaurya merged pull request #62: feat: added toast showing log out status

2019-06-01 Thread GitBox
therajanmaurya merged pull request #62: feat: added toast showing log out status URL: https://github.com/apache/fineract-cn-mobile/pull/62 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [fineract-cn-mobile] therajanmaurya commented on a change in pull request #61: fix: Restricted text characters in Mobile fields

2019-06-01 Thread GitBox
therajanmaurya commented on a change in pull request #61: fix: Restricted text characters in Mobile fields URL: https://github.com/apache/fineract-cn-mobile/pull/61#discussion_r289626063 ## File path: app/src/main/res/values/strings.xml ## @@ -375,6 +375,9 @@ Please

[GitHub] [fineract-cn-mobile] therajanmaurya commented on a change in pull request #61: fix: Restricted text characters in Mobile fields

2019-06-01 Thread GitBox
therajanmaurya commented on a change in pull request #61: fix: Restricted text characters in Mobile fields URL: https://github.com/apache/fineract-cn-mobile/pull/61#discussion_r289626058 ## File path: app/src/main/res/values/strings.xml ## @@ -375,6 +375,9 @@ Please

[GitHub] [fineract-cn-payroll] awasum merged pull request #11: Adding rat report to After Failure procedure

2019-06-03 Thread GitBox
awasum merged pull request #11: Adding rat report to After Failure procedure URL: https://github.com/apache/fineract-cn-payroll/pull/11 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [fineract-cn-anubis] awasum merged pull request #6: Adding rat report to After Failure procedure

2019-06-03 Thread GitBox
awasum merged pull request #6: Adding rat report to After Failure procedure URL: https://github.com/apache/fineract-cn-anubis/pull/6 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [fineract-cn-async] awasum merged pull request #8: Adding rat report to After Failure procedure

2019-06-03 Thread GitBox
awasum merged pull request #8: Adding rat report to After Failure procedure URL: https://github.com/apache/fineract-cn-async/pull/8 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [fineract-cn-data-jpa] awasum merged pull request #6: Adding rat report to After Failure procedure

2019-06-03 Thread GitBox
awasum merged pull request #6: Adding rat report to After Failure procedure URL: https://github.com/apache/fineract-cn-data-jpa/pull/6 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [fineract-cn-mariadb] awasum merged pull request #7: Adding rat report to After Failure procedure

2019-06-03 Thread GitBox
awasum merged pull request #7: Adding rat report to After Failure procedure URL: https://github.com/apache/fineract-cn-mariadb/pull/7 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [fineract-cn-notifications] awasum commented on issue #10: Changing Notification Admin to OrgAdmin

2019-06-03 Thread GitBox
awasum commented on issue #10: Changing Notification Admin to OrgAdmin URL: https://github.com/apache/fineract-cn-notifications/pull/10#issuecomment-498388518 Is this ready to be merged? This is an automated message from the

[GitHub] [fineract-cn-notifications] awasum commented on issue #13: Adding after_failure procedure to CI

2019-06-03 Thread GitBox
awasum commented on issue #13: Adding after_failure procedure to CI URL: https://github.com/apache/fineract-cn-notifications/pull/13#issuecomment-498394853 Thank you, I will merge. @aasaru have u been able to setup ur apache account and connect it to GitHub so you can merge PRs?

[GitHub] [fineract-cn-service-starter] awasum merged pull request #10: Adding rat report to After Failure procedure

2019-06-03 Thread GitBox
awasum merged pull request #10: Adding rat report to After Failure procedure URL: https://github.com/apache/fineract-cn-service-starter/pull/10 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [fineract-cn-crypto] awasum merged pull request #6: Adding rat report to After Failure procedure

2019-06-03 Thread GitBox
awasum merged pull request #6: Adding rat report to After Failure procedure URL: https://github.com/apache/fineract-cn-crypto/pull/6 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [fineract-cn-teller] awasum merged pull request #13: Adding rat report to After Failure procedure

2019-06-03 Thread GitBox
awasum merged pull request #13: Adding rat report to After Failure procedure URL: https://github.com/apache/fineract-cn-teller/pull/13 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [fineract-cn-notifications] awasum commented on issue #13: Adding after_failure procedure to CI

2019-06-03 Thread GitBox
awasum commented on issue #13: Adding after_failure procedure to CI URL: https://github.com/apache/fineract-cn-notifications/pull/13#issuecomment-498387913 Is this also ready to be merged? This is an automated message from

[GitHub] [fineract-cn-notifications] awasum merged pull request #13: Adding after_failure procedure to CI

2019-06-03 Thread GitBox
awasum merged pull request #13: Adding after_failure procedure to CI URL: https://github.com/apache/fineract-cn-notifications/pull/13 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [fineract-cn-portfolio] awasum merged pull request #16: Adding rat report to After Failure procedure

2019-06-03 Thread GitBox
awasum merged pull request #16: Adding rat report to After Failure procedure URL: https://github.com/apache/fineract-cn-portfolio/pull/16 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [fineract-cn-provisioner] awasum merged pull request #9: Adding rat report to After Failure procedure

2019-06-03 Thread GitBox
awasum merged pull request #9: Adding rat report to After Failure procedure URL: https://github.com/apache/fineract-cn-provisioner/pull/9 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [fineract-cn-deposit-account-management] awasum merged pull request #12: Adding rat report to After Failure procedure

2019-06-03 Thread GitBox
awasum merged pull request #12: Adding rat report to After Failure procedure URL: https://github.com/apache/fineract-cn-deposit-account-management/pull/12 This is an automated message from the Apache Git Service. To respond

[GitHub] [fineract-cn-default-setup] awasum merged pull request #9: Adding rat report to After Failure procedure

2019-06-03 Thread GitBox
awasum merged pull request #9: Adding rat report to After Failure procedure URL: https://github.com/apache/fineract-cn-default-setup/pull/9 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [fineract-cn-identity] awasum merged pull request #12: Adding rat report to After Failure procedure

2019-06-03 Thread GitBox
awasum merged pull request #12: Adding rat report to After Failure procedure URL: https://github.com/apache/fineract-cn-identity/pull/12 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [fineract-cn-customer] awasum merged pull request #12: Adding rat report to After Failure procedure

2019-06-03 Thread GitBox
awasum merged pull request #12: Adding rat report to After Failure procedure URL: https://github.com/apache/fineract-cn-customer/pull/12 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [fineract-cn-cheques] awasum merged pull request #7: Adding rat report to After Failure procedure

2019-06-03 Thread GitBox
awasum merged pull request #7: Adding rat report to After Failure procedure URL: https://github.com/apache/fineract-cn-cheques/pull/7 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [fineract-cn-command] awasum merged pull request #8: Adding rat report to After Failure procedure

2019-06-03 Thread GitBox
awasum merged pull request #8: Adding rat report to After Failure procedure URL: https://github.com/apache/fineract-cn-command/pull/8 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [fineract-cn-notifications] ebenezergraham commented on issue #10: Changing Notification Admin to OrgAdmin

2019-06-05 Thread GitBox
ebenezergraham commented on issue #10: Changing Notification Admin to OrgAdmin URL: https://github.com/apache/fineract-cn-notifications/pull/10#issuecomment-499300657 @awasum I have resolved the conflict. We can merge now

[GitHub] [fineract-cn-notifications] ebenezergraham commented on a change in pull request #11: Thymeleaf templating for Email

2019-06-06 Thread GitBox
ebenezergraham commented on a change in pull request #11: Thymeleaf templating for Email URL: https://github.com/apache/fineract-cn-notifications/pull/11#discussion_r287134805 ## File path: component-test/src/main/java/org/apache/fineract/cn/notification/TestEmailService.java

[GitHub] [fineract-cn-notifications] awasum commented on a change in pull request #11: Thymeleaf templating for Email

2019-06-06 Thread GitBox
awasum commented on a change in pull request #11: Thymeleaf templating for Email URL: https://github.com/apache/fineract-cn-notifications/pull/11#discussion_r291150077 ## File path: component-test/src/main/java/org/apache/fineract/cn/notification/TestEmailService.java ##

[GitHub] [fineract-cn-notifications] awasum commented on a change in pull request #11: Thymeleaf templating for Email

2019-06-06 Thread GitBox
awasum commented on a change in pull request #11: Thymeleaf templating for Email URL: https://github.com/apache/fineract-cn-notifications/pull/11#discussion_r291148328 ## File path: api/src/main/java/org/apache/fineract/cn/notification/api/v1/client/NotificationManager.java

[GitHub] [fineract-cn-notifications] awasum commented on a change in pull request #11: Thymeleaf templating for Email

2019-06-06 Thread GitBox
awasum commented on a change in pull request #11: Thymeleaf templating for Email URL: https://github.com/apache/fineract-cn-notifications/pull/11#discussion_r291150077 ## File path: component-test/src/main/java/org/apache/fineract/cn/notification/TestEmailService.java ##

[GitHub] [fineract-cn-notifications] awasum commented on a change in pull request #11: Thymeleaf templating for Email

2019-06-06 Thread GitBox
awasum commented on a change in pull request #11: Thymeleaf templating for Email URL: https://github.com/apache/fineract-cn-notifications/pull/11#discussion_r291155440 ## File path:

[GitHub] [fineract-cn-notifications] awasum commented on a change in pull request #11: Thymeleaf templating for Email

2019-06-06 Thread GitBox
awasum commented on a change in pull request #11: Thymeleaf templating for Email URL: https://github.com/apache/fineract-cn-notifications/pull/11#discussion_r291155561 ## File path:

[GitHub] [fineract-cn-notifications] ebenezergraham commented on a change in pull request #11: Thymeleaf templating for Email

2019-06-06 Thread GitBox
ebenezergraham commented on a change in pull request #11: Thymeleaf templating for Email URL: https://github.com/apache/fineract-cn-notifications/pull/11#discussion_r291191504 ## File path:

[GitHub] [fineract-cn-notifications] awasum commented on a change in pull request #11: Thymeleaf templating for Email

2019-06-06 Thread GitBox
awasum commented on a change in pull request #11: Thymeleaf templating for Email URL: https://github.com/apache/fineract-cn-notifications/pull/11#discussion_r291153783 ## File path: service/src/main/java/org/apache/fineract/cn/notification/service/rest/TemplateRestController.java

[GitHub] [fineract-cn-notifications] awasum commented on a change in pull request #11: Thymeleaf templating for Email

2019-06-06 Thread GitBox
awasum commented on a change in pull request #11: Thymeleaf templating for Email URL: https://github.com/apache/fineract-cn-notifications/pull/11#discussion_r291153890 ## File path: service/src/main/java/org/apache/fineract/cn/notification/service/rest/TemplateRestController.java

[GitHub] [fineract-cn-notifications] awasum commented on a change in pull request #11: Thymeleaf templating for Email

2019-06-06 Thread GitBox
awasum commented on a change in pull request #11: Thymeleaf templating for Email URL: https://github.com/apache/fineract-cn-notifications/pull/11#discussion_r291153659 ## File path: service/src/main/java/org/apache/fineract/cn/notification/service/rest/TemplateRestController.java

[GitHub] [fineract] raakeshtomarnew commented on issue #429: EOY-Closure: FINERACT-38

2019-06-05 Thread GitBox
raakeshtomarnew commented on issue #429: EOY-Closure: FINERACT-38 URL: https://github.com/apache/fineract/pull/429#issuecomment-499341741 yes Thanks Rakesh Tomar *Team Lead* *8923306463* *8859127643* *EMail:-raakeshto...@gmail.com * *website:-www.bnkbiz.com

[GitHub] [fineract-cn-notifications] awasum merged pull request #10: Changing Notification Admin to OrgAdmin

2019-06-06 Thread GitBox
awasum merged pull request #10: Changing Notification Admin to OrgAdmin URL: https://github.com/apache/fineract-cn-notifications/pull/10 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [fineract-cn-notifications] awasum commented on issue #11: Thymeleaf templating for Email

2019-06-06 Thread GitBox
awasum commented on issue #11: Thymeleaf templating for Email URL: https://github.com/apache/fineract-cn-notifications/pull/11#issuecomment-499389386 Is there an issue for this? What is the use case here? How will it help?

[GitHub] [fineract-cn-notifications] ebenezergraham opened a new pull request #11: Thymeleaf templating for Email

2019-06-06 Thread GitBox
ebenezergraham opened a new pull request #11: Thymeleaf templating for Email URL: https://github.com/apache/fineract-cn-notifications/pull/11 Started HTML templating This is an automated message from the Apache Git Service.

[GitHub] [fineract-cn-notifications] ebenezergraham commented on a change in pull request #11: Thymeleaf templating for Email

2019-06-06 Thread GitBox
ebenezergraham commented on a change in pull request #11: Thymeleaf templating for Email URL: https://github.com/apache/fineract-cn-notifications/pull/11#discussion_r291198726 ## File path:

[GitHub] [fineract-cn-notifications] awasum commented on issue #11: Thymeleaf templating for Email

2019-06-06 Thread GitBox
awasum commented on issue #11: Thymeleaf templating for Email URL: https://github.com/apache/fineract-cn-notifications/pull/11#issuecomment-499601442 U already configured activemq concurrency to 1-1 in application. yml... Check..that's the duplication. Doe one of them not work?

[GitHub] [fineract-cn-lang] aasaru opened a new pull request #10: Add convenicence method to print out RSA keys.

2019-06-05 Thread GitBox
aasaru opened a new pull request #10: Add convenicence method to print out RSA keys. URL: https://github.com/apache/fineract-cn-lang/pull/10 Courage has created a separate service that generates RSA keys:

[GitHub] [fineract-cn-mobile] therajanmaurya commented on issue #21: feat: unit test

2019-06-01 Thread GitBox
therajanmaurya commented on issue #21: feat: unit test URL: https://github.com/apache/fineract-cn-mobile/pull/21#issuecomment-498001165 Good Job @mohak1712 We have merged your PR here #59 This is an automated message from

[GitHub] [fineract-cn-mobile] therajanmaurya commented on issue #17: feat: list and search products

2019-06-01 Thread GitBox
therajanmaurya commented on issue #17: feat: list and search products URL: https://github.com/apache/fineract-cn-mobile/pull/17#issuecomment-498001193 Good Job @mohak1712 we have merged your PR here #58 This is an automated

[GitHub] [fineract-cn-mobile] therajanmaurya closed pull request #21: feat: unit test

2019-06-01 Thread GitBox
therajanmaurya closed pull request #21: feat: unit test URL: https://github.com/apache/fineract-cn-mobile/pull/21 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [fineract-cn-mobile] therajanmaurya closed pull request #17: feat: list and search products

2019-06-01 Thread GitBox
therajanmaurya closed pull request #17: feat: list and search products URL: https://github.com/apache/fineract-cn-mobile/pull/17 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [fineract-cn-mobile] therajanmaurya closed pull request #48: feat: added toast showing log out status

2019-06-01 Thread GitBox
therajanmaurya closed pull request #48: feat: added toast showing log out status URL: https://github.com/apache/fineract-cn-mobile/pull/48 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [fineract-cn-mobile] therajanmaurya commented on issue #48: feat: added toast showing log out status

2019-06-01 Thread GitBox
therajanmaurya commented on issue #48: feat: added toast showing log out status URL: https://github.com/apache/fineract-cn-mobile/pull/48#issuecomment-498001087 Good Job @abhijitramesh We have merged your PR here #62 This is

[GitHub] [fineract-cn-mobile] miPlodder commented on issue #63: FINCN-138: Added Icons to Drawer

2019-06-02 Thread GitBox
miPlodder commented on issue #63: FINCN-138: Added Icons to Drawer URL: https://github.com/apache/fineract-cn-mobile/pull/63#issuecomment-498004514 Resolved PR - https://github.com/apache/fineract-cn-mobile/pull/49 This is an

[GitHub] [fineract-cn-mobile] therajanmaurya commented on a change in pull request #61: fix: Restricted text characters in Mobile fields

2019-06-02 Thread GitBox
therajanmaurya commented on a change in pull request #61: fix: Restricted text characters in Mobile fields URL: https://github.com/apache/fineract-cn-mobile/pull/61#discussion_r289630263 ## File path: app/src/main/res/layout/fragment_form_customer_contact.xml ## @@ -61,7

[GitHub] [fineract-cn-mobile] therajanmaurya commented on a change in pull request #61: fix: Restricted text characters in Mobile fields

2019-06-02 Thread GitBox
therajanmaurya commented on a change in pull request #61: fix: Restricted text characters in Mobile fields URL: https://github.com/apache/fineract-cn-mobile/pull/61#discussion_r289630261 ## File path: app/src/main/res/layout/fragment_form_customer_contact.xml ## @@ -75,7

[GitHub] [fineract-cn-mobile] therajanmaurya edited a comment on issue #49: Improved Hamburger Menu

2019-06-02 Thread GitBox
therajanmaurya edited a comment on issue #49: Improved Hamburger Menu URL: https://github.com/apache/fineract-cn-mobile/pull/49#issuecomment-498015230 Good Job @Vipinsoni38. As you were inactive, we have made required changes and merge it here #63

[GitHub] [fineract-cn-mobile] miPlodder commented on a change in pull request #65: feat# Roboto font added

2019-06-02 Thread GitBox
miPlodder commented on a change in pull request #65: feat# Roboto font added URL: https://github.com/apache/fineract-cn-mobile/pull/65#discussion_r289635259 ## File path: build.gradle ## @@ -31,7 +31,7 @@ task clean(type: Delete) { ext { // Sdk and tools -

[GitHub] [fineract-cn-mobile] therajanmaurya merged pull request #60: Payroll

2019-06-01 Thread GitBox
therajanmaurya merged pull request #60: Payroll URL: https://github.com/apache/fineract-cn-mobile/pull/60 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [fineract-cn-mobile] therajanmaurya commented on issue #19: added payroll api support

2019-06-01 Thread GitBox
therajanmaurya commented on issue #19: added payroll api support URL: https://github.com/apache/fineract-cn-mobile/pull/19#issuecomment-498001054 Good Job @mohak1712, We have merged your here #60 This is an automated message

[GitHub] [fineract-cn-mobile] therajanmaurya closed pull request #19: added payroll api support

2019-06-01 Thread GitBox
therajanmaurya closed pull request #19: added payroll api support URL: https://github.com/apache/fineract-cn-mobile/pull/19 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [fineract-cn-mobile] therajanmaurya commented on issue #61: fix: Restricted text characters in Mobile fields

2019-06-02 Thread GitBox
therajanmaurya commented on issue #61: fix: Restricted text characters in Mobile fields URL: https://github.com/apache/fineract-cn-mobile/pull/61#issuecomment-498015586 Looks fine now. This is an automated message from the

[GitHub] [fineract-cn-mobile] therajanmaurya commented on issue #39: fix: Restricted text characters in Mobile fields

2019-06-02 Thread GitBox
therajanmaurya commented on issue #39: fix: Restricted text characters in Mobile fields URL: https://github.com/apache/fineract-cn-mobile/pull/39#issuecomment-498015600 Fixed in #61 This is an automated message from the

[GitHub] [fineract-cn-mobile] therajanmaurya merged pull request #61: fix: Restricted text characters in Mobile fields

2019-06-02 Thread GitBox
therajanmaurya merged pull request #61: fix: Restricted text characters in Mobile fields URL: https://github.com/apache/fineract-cn-mobile/pull/61 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [fineract-cn-mobile] therajanmaurya closed pull request #39: fix: Restricted text characters in Mobile fields

2019-06-02 Thread GitBox
therajanmaurya closed pull request #39: fix: Restricted text characters in Mobile fields URL: https://github.com/apache/fineract-cn-mobile/pull/39 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [fineract-cn-mobile] miPlodder opened a new pull request #63: FINCN-138: Added Icons to Drawer

2019-06-02 Thread GitBox
miPlodder opened a new pull request #63: FINCN-138: Added Icons to Drawer URL: https://github.com/apache/fineract-cn-mobile/pull/63 Fixes #138 - [x] Apply the `AndroidStyle.xml` style template to your code in Android Studio. - [x] Run the unit tests with `./gradlew check` to

[GitHub] [fineract-cn-mobile] miPlodder opened a new pull request #64: Exit feature on Dashboard pressing back button twice

2019-06-02 Thread GitBox
miPlodder opened a new pull request #64: Exit feature on Dashboard pressing back button twice URL: https://github.com/apache/fineract-cn-mobile/pull/64 - [x] Apply the `AndroidStyle.xml` style template to your code in Android Studio. - [x] Run the unit tests with `./gradlew check`

[GitHub] [fineract-cn-mobile] therajanmaurya commented on issue #34: "feat: added double tap to exit feature on Dashboard"

2019-06-02 Thread GitBox
therajanmaurya commented on issue #34: "feat: added double tap to exit feature on Dashboard" URL: https://github.com/apache/fineract-cn-mobile/pull/34#issuecomment-498007635 Good Job, We have merged your changes here #64

[GitHub] [fineract-cn-mobile] therajanmaurya closed pull request #34: "feat: added double tap to exit feature on Dashboard"

2019-06-02 Thread GitBox
therajanmaurya closed pull request #34: "feat: added double tap to exit feature on Dashboard" URL: https://github.com/apache/fineract-cn-mobile/pull/34 This is an automated message from the Apache Git Service. To respond to

[GitHub] [fineract-cn-mobile] therajanmaurya merged pull request #64: Exit feature on Dashboard pressing back button twice

2019-06-02 Thread GitBox
therajanmaurya merged pull request #64: Exit feature on Dashboard pressing back button twice URL: https://github.com/apache/fineract-cn-mobile/pull/64 This is an automated message from the Apache Git Service. To respond to

[GitHub] [fineract-cn-mobile] therajanmaurya commented on issue #49: Improved Hamburger Menu

2019-06-02 Thread GitBox
therajanmaurya commented on issue #49: Improved Hamburger Menu URL: https://github.com/apache/fineract-cn-mobile/pull/49#issuecomment-498015230 Giod Job @Vipinsoni38. As you were inactive, we have made required changes and merge it here #63

[GitHub] [fineract-cn-mobile] therajanmaurya closed pull request #49: Improved Hamburger Menu

2019-06-02 Thread GitBox
therajanmaurya closed pull request #49: Improved Hamburger Menu URL: https://github.com/apache/fineract-cn-mobile/pull/49 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [fineract-cn-mobile] therajanmaurya merged pull request #63: FINCN-138: Added Icons to Drawer

2019-06-02 Thread GitBox
therajanmaurya merged pull request #63: FINCN-138: Added Icons to Drawer URL: https://github.com/apache/fineract-cn-mobile/pull/63 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [fineract-cn-mobile] miPlodder opened a new pull request #65: feat# Roboto font added

2019-06-02 Thread GitBox
miPlodder opened a new pull request #65: feat# Roboto font added URL: https://github.com/apache/fineract-cn-mobile/pull/65 - [x] Apply the `AndroidStyle.xml` style template to your code in Android Studio. - [x] Run the unit tests with `./gradlew check` to make sure you didn't break

[GitHub] [fineract-cn-mobile] miPlodder commented on a change in pull request #40: feat: added abi filter in the app

2019-05-29 Thread GitBox
miPlodder commented on a change in pull request #40: feat: added abi filter in the app URL: https://github.com/apache/fineract-cn-mobile/pull/40#discussion_r288737793 ## File path: app/build.gradle ## @@ -65,6 +66,26 @@ android { androidExtensions {

[GitHub] [fineract-cn-mobile] miPlodder commented on issue #33: feat: added sweet-error library

2019-05-29 Thread GitBox
miPlodder commented on issue #33: feat: added sweet-error library URL: https://github.com/apache/fineract-cn-mobile/pull/33#issuecomment-497085698 @therajanmaurya Looks good. This is an automated message from the Apache Git

[GitHub] [fineract-cn-notifications] Anh3h merged pull request #14: Docker file to assemble a notification service image

2019-05-29 Thread GitBox
Anh3h merged pull request #14: Docker file to assemble a notification service image URL: https://github.com/apache/fineract-cn-notifications/pull/14 This is an automated message from the Apache Git Service. To respond to

[GitHub] [fineract] vishwasbabu merged pull request #572: FINERACT-757: Client list retrieval returns emtpy result when using search parameter

2019-05-28 Thread GitBox
vishwasbabu merged pull request #572: FINERACT-757: Client list retrieval returns emtpy result when using search parameter URL: https://github.com/apache/fineract/pull/572 This is an automated message from the Apache Git

[GitHub] [fineract-cn-fims-web-app] vishwasbabu merged pull request #15: Angular 7 upgrade

2019-05-28 Thread GitBox
vishwasbabu merged pull request #15: Angular 7 upgrade URL: https://github.com/apache/fineract-cn-fims-web-app/pull/15 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [fineract-cn-mobile] miPlodder commented on issue #45: feat: made improvement in the UI of dashboard

2019-05-29 Thread GitBox
miPlodder commented on issue #45: feat: made improvement in the UI of dashboard URL: https://github.com/apache/fineract-cn-mobile/pull/45#issuecomment-497080941 UI design doesn't look good. @therajanmaurya I guess for the time being we should not change the Dashboard UI, after adding

[GitHub] [fineract-cn-notifications] ebenezergraham commented on a change in pull request #14: Docker file to assemble a notification service image

2019-05-29 Thread GitBox
ebenezergraham commented on a change in pull request #14: Docker file to assemble a notification service image URL: https://github.com/apache/fineract-cn-notifications/pull/14#discussion_r288755721 ## File path: Dockerfile ## @@ -0,0 +1,31 @@ +# +# Licensed to the Apache

[GitHub] [fineract-cn-mobile] miPlodder commented on a change in pull request #33: feat: added sweet-error library

2019-05-29 Thread GitBox
miPlodder commented on a change in pull request #33: feat: added sweet-error library URL: https://github.com/apache/fineract-cn-mobile/pull/33#discussion_r288744291 ## File path: app/src/main/java/org/apache/fineract/ui/online/customers/customerprofile/CustomerProfileActivity.java

[GitHub] [fineract] vishwasbabu merged pull request #573: FINERACT-758

2019-05-28 Thread GitBox
vishwasbabu merged pull request #573: FINERACT-758 URL: https://github.com/apache/fineract/pull/573 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [fineract] vorburger commented on a change in pull request #587: minor README clean up to remove more left over Gradle wrapper mentions

2019-06-14 Thread GitBox
vorburger commented on a change in pull request #587: minor README clean up to remove more left over Gradle wrapper mentions URL: https://github.com/apache/fineract/pull/587#discussion_r293794263 ## File path: README.md ## @@ -10,14 +10,12 @@ Requirements Instructions to

[GitHub] [fineract] vorburger commented on issue #294: FINERACT-374-Add Gradle wrapper download location in readme file

2019-06-14 Thread GitBox
vorburger commented on issue #294: FINERACT-374-Add Gradle wrapper download location in readme file URL: https://github.com/apache/fineract/pull/294#issuecomment-502098134 FTR #581 #587 #591 This is an automated message from

[GitHub] [fineract] vorburger closed pull request #583: add Fedora prereq install doc to README

2019-06-14 Thread GitBox
vorburger closed pull request #583: add Fedora prereq install doc to README URL: https://github.com/apache/fineract/pull/583 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [fineract] vorburger commented on issue #583: add Fedora prereq install doc to README

2019-06-14 Thread GitBox
vorburger commented on issue #583: add Fedora prereq install doc to README URL: https://github.com/apache/fineract/pull/583#issuecomment-502090053 Abandon, in favour of the containized #586 approach. This is an automated

[GitHub] [fineract] michaelbukachi commented on issue #550: Fineract 700 upgrade gradle - Flyway plugin Upgrade

2019-06-13 Thread GitBox
michaelbukachi commented on issue #550: Fineract 700 upgrade gradle - Flyway plugin Upgrade URL: https://github.com/apache/fineract/pull/550#issuecomment-501603316 @muarachmann Pull request #582 has been merged :-). You can now work on upgrading flyway based off the latest develop commit

[GitHub] [fineract] vorburger commented on issue #582: use MariaDB ConnectorJ instead of Drizzle MySQL JDBC driver -only- during build for Flyway (fixes FINERACT-761)

2019-06-12 Thread GitBox
vorburger commented on issue #582: use MariaDB ConnectorJ instead of Drizzle MySQL JDBC driver -only- during build for Flyway (fixes FINERACT-761) URL: https://github.com/apache/fineract/pull/582#issuecomment-501197159 I'm not sure I understand the TravisCI build failure here... don't see

[GitHub] [fineract] vorburger commented on issue #581: remove Instructions to download gradle wrapper from README

2019-06-12 Thread GitBox
vorburger commented on issue #581: remove Instructions to download gradle wrapper from README URL: https://github.com/apache/fineract/pull/581#issuecomment-501177433 > Good catch. @vorburger so merge it? :smile_cat:

[GitHub] [fineract] michaelbukachi commented on issue #525: FINERACT-700: upgrade Gradle from 2.10 to 5.2.1

2019-06-12 Thread GitBox
michaelbukachi commented on issue #525: FINERACT-700: upgrade Gradle from 2.10 to 5.2.1 URL: https://github.com/apache/fineract/pull/525#issuecomment-501182810 Awesome! I'm following this closely. This is related to pull request #550. Which has stalled due it becoming a legal matter.

<    8   9   10   11   12   13   14   15   16   17   >