francisguchie commented on pull request #2032:
URL: https://github.com/apache/fineract/pull/2032#issuecomment-1037178083
@rrpawar96 & @awasum
When would this be reviewed and / or merged??
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
github-actions[bot] commented on pull request #1884:
URL: https://github.com/apache/fineract/pull/1884#issuecomment-1037599900
This pull request seems to be stale. Are you still planning to work on it?
We will automatically close it in 30 days.
--
This is an automated message from the
github-actions[bot] commented on pull request #1811:
URL: https://github.com/apache/fineract/pull/1811#issuecomment-1037599918
This pull request seems to be stale. Are you still planning to work on it?
We will automatically close it in 30 days.
--
This is an automated message from the
rrpawar96 commented on pull request #1984:
URL: https://github.com/apache/fineract/pull/1984#issuecomment-1037225072
> 2. Why do we need to create a new table for country codes? Can't we just
treat it just like any other code value and use the existing code value
infrastructure...
@
fynmanoj opened a new pull request #2033:
URL: https://github.com/apache/fineract/pull/2033
…n-EMI
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA
ticket](https://github.com/apa
sandeepsoni911 opened a new pull request #2034:
URL: https://github.com/apache/fineract/pull/2034
Updated WebhookService to support all paths instead of only absolute path.
## Description
Current Implementation supports Webhook URL with absolute path like
https://www.hostname
sandeepsoni911 commented on pull request #2034:
URL: https://github.com/apache/fineract/pull/2034#issuecomment-1040599977
merged to forked branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
sandeepsoni911 commented on pull request #2034:
URL: https://github.com/apache/fineract/pull/2034#issuecomment-1040599977
merged to forked branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
ptuomola commented on pull request #2034:
URL: https://github.com/apache/fineract/pull/2034#issuecomment-1040817525
Hi - change looks good to me, but can you raise a JIRA for this and update
the commit to include the JIRA number please. That way the change will get
included in the release
sandeepsoni911 commented on pull request #2034:
URL: https://github.com/apache/fineract/pull/2034#issuecomment-1041110441
@ptuomola : Thank you for your comment, I will raise jira for this and will
update the commit to include jira. Thanks
--
This is an automated message from the Apache
rrpawar96 opened a new pull request #2035:
URL: https://github.com/apache/fineract/pull/2035
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA
ticket](https://github.com/apache/fineract/
rrpawar96 commented on pull request #2035:
URL: https://github.com/apache/fineract/pull/2035#issuecomment-1041594938
@vidakovic @ptuomola Please review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
sandeepsoni911 commented on pull request #2034:
URL: https://github.com/apache/fineract/pull/2034#issuecomment-1042721027
@ptuomola : I have created jira FINERACT-1502 and updated commit message.
Requesting you to review the same.
--
This is an automated message from the Apache Git Servi
avikganguly01 merged pull request #2033:
URL: https://github.com/apache/fineract/pull/2033
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits
fynmanoj opened a new pull request #2036:
URL: https://github.com/apache/fineract/pull/2036
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA
ticket](https://github.com/apache/fineract/p
fynmanoj commented on pull request #2036:
URL: https://github.com/apache/fineract/pull/2036#issuecomment-1045120728
@avikganguly01 please review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
avikganguly01 merged pull request #2036:
URL: https://github.com/apache/fineract/pull/2036
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits
ptuomola commented on pull request #2034:
URL: https://github.com/apache/fineract/pull/2034#issuecomment-1045562593
Looks good - thanks! One more small thing: to keep the commit history clean,
your PR should have 1 commit only. It currently has 3. Could you squash your
commits with git so
ptuomola merged pull request #2029:
URL: https://github.com/apache/fineract/pull/2029
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsu
ptuomola commented on pull request #2023:
URL: https://github.com/apache/fineract/pull/2023#issuecomment-1045564527
@vidakovic looks like some checkstyle errors... can you fix and we can then
merge?
--
This is an automated message from the Apache Git Service.
To respond to the message,
vidakovic commented on pull request #2023:
URL: https://github.com/apache/fineract/pull/2023#issuecomment-1045772957
@ptuomola yep, finally have some time to take care of this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
vidakovic opened a new pull request #2037:
URL: https://github.com/apache/fineract/pull/2037
## Description
Since we split the WAR build into a separate module we've excluded the WAR,
because of a circular dependency issue. Adding the WAR file again as there was
no general vote to r
vidakovic commented on pull request #2037:
URL: https://github.com/apache/fineract/pull/2037#issuecomment-1045938633
@ptuomola ... would be great if you could review this until Monday... you
can quickly test with:
```
./gradlew :fineract-war:binaryDistTar -x test
./gradlew :fi
sandeepsoni911 commented on pull request #2034:
URL: https://github.com/apache/fineract/pull/2034#issuecomment-1045945608
@ptuomola : Hi i have squashed my commit to 1 commit, I should have done
that earlier but forgot to do same. Requesting you to review and merge the
same. Thank you
--
vidakovic opened a new pull request #2038:
URL: https://github.com/apache/fineract/pull/2038
## Description
- Spring Boot 2.6.3
- Spring 5.3.16
- Gradle 7.4
- JUnit 5.8.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
vidakovic commented on pull request #2023:
URL: https://github.com/apache/fineract/pull/2023#issuecomment-1045966279
... still investigating why one test is failing. FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
vidakovic commented on pull request #2023:
URL: https://github.com/apache/fineract/pull/2023#issuecomment-1045969780
I think I know what's going on... the SSL settings are not properly applied
in Tomcat/WAR use case (i. e. integration testing)... ok, will check.
--
This is an automated
ptuomola merged pull request #2038:
URL: https://github.com/apache/fineract/pull/2038
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsu
ptuomola merged pull request #2037:
URL: https://github.com/apache/fineract/pull/2037
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsu
ptuomola merged pull request #2034:
URL: https://github.com/apache/fineract/pull/2034
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsu
vidakovic merged pull request #2030:
URL: https://github.com/apache/fineract/pull/2030
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
galovics opened a new pull request #2039:
URL: https://github.com/apache/fineract/pull/2039
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA
ticket](https://github.com/apache/fineract/p
galovics opened a new pull request #2040:
URL: https://github.com/apache/fineract/pull/2040
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA
ticket](https://github.com/apache/fineract/p
vidakovic merged pull request #2035:
URL: https://github.com/apache/fineract/pull/2035
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
vidakovic commented on pull request #2023:
URL: https://github.com/apache/fineract/pull/2023#issuecomment-1046333261
I just verified locally the failing tests... and they run without a hitch...
--
This is an automated message from the Apache Git Service.
To respond to the message, please
vidakovic merged pull request #2039:
URL: https://github.com/apache/fineract/pull/2039
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
vidakovic commented on pull request #2023:
URL: https://github.com/apache/fineract/pull/2023#issuecomment-1046340082
@ptuomola @galovics ... hosanna... it worked! In the end Cargo (well,
Tomcat) didn't like the base path property in application.properties... so I
just removed it, defaults
vidakovic merged pull request #2023:
URL: https://github.com/apache/fineract/pull/2023
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
vidakovic opened a new pull request #2041:
URL: https://github.com/apache/fineract/pull/2041
## Description
Looks like we forgot to add the Gradle wrapper files to the source
distribution; without it the "gradlew" command doesn't work.
--
This is an automated message from the Apac
vidakovic commented on pull request #2041:
URL: https://github.com/apache/fineract/pull/2041#issuecomment-1046418204
@ptuomola ... would be great if you could approve this one as soon as
possible. I'd like to start voting on the release 1.6.0 as early as possible
tomorrow. The distribution
galovics opened a new pull request #2042:
URL: https://github.com/apache/fineract/pull/2042
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA
ticket](https://github.com/apache/fineract/p
galovics closed pull request #2040:
URL: https://github.com/apache/fineract/pull/2040
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsu
galovics commented on pull request #2040:
URL: https://github.com/apache/fineract/pull/2040#issuecomment-1046576863
Not needed, opened https://github.com/apache/fineract/pull/2042 instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
vidakovic merged pull request #2041:
URL: https://github.com/apache/fineract/pull/2041
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
galovics opened a new pull request #2043:
URL: https://github.com/apache/fineract/pull/2043
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA
ticket](https://github.com/apache/fineract/p
galovics opened a new pull request #2044:
URL: https://github.com/apache/fineract/pull/2044
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA
ticket](https://github.com/apache/fineract/p
galovics opened a new pull request #2045:
URL: https://github.com/apache/fineract/pull/2045
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA
ticket](https://github.com/apache/fineract/p
vidakovic merged pull request #2042:
URL: https://github.com/apache/fineract/pull/2042
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
vidakovic merged pull request #2043:
URL: https://github.com/apache/fineract/pull/2043
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
vidakovic commented on a change in pull request #2044:
URL: https://github.com/apache/fineract/pull/2044#discussion_r811349981
##
File path:
fineract-provider/src/main/java/org/apache/fineract/interoperation/service/InteropServiceImpl.java
##
@@ -171,17 +171,17 @@ public Inter
galovics commented on a change in pull request #2044:
URL: https://github.com/apache/fineract/pull/2044#discussion_r811350411
##
File path:
fineract-provider/src/main/java/org/apache/fineract/interoperation/service/InteropServiceImpl.java
##
@@ -171,17 +171,17 @@ public Intero
vidakovic merged pull request #2044:
URL: https://github.com/apache/fineract/pull/2044
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
rrpawar96 commented on pull request #2032:
URL: https://github.com/apache/fineract/pull/2032#issuecomment-1047133345
@francisguchie, yes it's ready @galovics thanks for approval @vidakovic if
it looks good to you, can you merge it?
--
This is an automated message from the Apache Git Serv
fynmanoj opened a new pull request #2046:
URL: https://github.com/apache/fineract/pull/2046
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA
ticket](https://github.com/apache/fineract/p
vidakovic merged pull request #2032:
URL: https://github.com/apache/fineract/pull/2032
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
vidakovic commented on pull request #2046:
URL: https://github.com/apache/fineract/pull/2046#issuecomment-1047144021
@fynmanoj looks like a `./gradlew spotlessApply` will fix this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
vidakovic merged pull request #2045:
URL: https://github.com/apache/fineract/pull/2045
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
francisguchie commented on pull request #1984:
URL: https://github.com/apache/fineract/pull/1984#issuecomment-1047184410
@fynmanoj , @ptuomola and @vidakovic kindly help on reviewing this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
avikganguly01 commented on a change in pull request #2046:
URL: https://github.com/apache/fineract/pull/2046#discussion_r811780665
##
File path:
integration-tests/src/test/java/org/apache/fineract/integrationtests/ClientSavingsIntegrationTest.java
##
@@ -2324,4 +2324,56 @@ pub
avikganguly01 commented on pull request #2046:
URL: https://github.com/apache/fineract/pull/2046#issuecomment-1047635596
@fynmanoj : Some checkstyle errors are there in SavingsAccount files which
is failing the basicauth build.
--
This is an automated message from the Apache Git Service.
avikganguly01 commented on pull request #2046:
URL: https://github.com/apache/fineract/pull/2046#issuecomment-1047867093
testApplyAnnualFeeForSavingsJobOutcome seems to be failing. Is it passing if
you run that test separate from all the other integration tests?
--
This is an automated
fynmanoj commented on pull request #2046:
URL: https://github.com/apache/fineract/pull/2046#issuecomment-1047891528
I have changed migration script to liquibase format. Also this migration
script is running fine in my local when ran separately
--
This is an automated message from the Ap
avikganguly01 commented on pull request #2046:
URL: https://github.com/apache/fineract/pull/2046#issuecomment-1047916120
@fynmanoj : testAccountBalanceAfterSavingsTransactionReversalPosting() FAILED
java.lang.AssertionError: 1 expectation failed.
Expected status code <200> but was
galovics opened a new pull request #2047:
URL: https://github.com/apache/fineract/pull/2047
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA
ticket](https://github.com/apache/fineract/p
vidakovic commented on pull request #1984:
URL: https://github.com/apache/fineract/pull/1984#issuecomment-1047968075
@rrpawar96 @francisguchie ... most of it looks ok for me... but the database
migration scripts need to be rewritten for Liquibase... Flyway not used anymore.
--
This is an
vidakovic merged pull request #2047:
URL: https://github.com/apache/fineract/pull/2047
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
avikganguly01 merged pull request #2046:
URL: https://github.com/apache/fineract/pull/2046
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits
galovics opened a new pull request #2048:
URL: https://github.com/apache/fineract/pull/2048
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA
ticket](https://github.com/apache/fineract/p
galovics commented on a change in pull request #2046:
URL: https://github.com/apache/fineract/pull/2046#discussion_r812363808
##
File path:
fineract-provider/src/main/resources/db/changelog/tenant/parts/0005_savings_transaction_reversal.xml
##
@@ -0,0 +1,49 @@
+
+
+http://www.
francisguchie commented on pull request #1984:
URL: https://github.com/apache/fineract/pull/1984#issuecomment-1048480594
@vidakovic you so much, @rrpawar96 please address this. Reach out to me if
you need my help
--
This is an automated message from the Apache Git Service.
To respond t
fynmanoj commented on a change in pull request #2046:
URL: https://github.com/apache/fineract/pull/2046#discussion_r812612707
##
File path:
fineract-provider/src/main/resources/db/changelog/tenant/parts/0005_savings_transaction_reversal.xml
##
@@ -0,0 +1,49 @@
+
+
+http://www.
fynmanoj commented on a change in pull request #2046:
URL: https://github.com/apache/fineract/pull/2046#discussion_r812613556
##
File path:
fineract-provider/src/main/resources/db/changelog/tenant/parts/0005_savings_transaction_reversal.xml
##
@@ -0,0 +1,49 @@
+
+
+http://www.
fynmanoj opened a new pull request #2049:
URL: https://github.com/apache/fineract/pull/2049
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA
ticket](https://github.com/apache/fineract/p
fynmanoj commented on a change in pull request #2046:
URL: https://github.com/apache/fineract/pull/2046#discussion_r812615122
##
File path:
fineract-provider/src/main/resources/db/changelog/tenant/parts/0005_savings_transaction_reversal.xml
##
@@ -0,0 +1,49 @@
+
+
+http://www.
galovics commented on a change in pull request #2049:
URL: https://github.com/apache/fineract/pull/2049#discussion_r812617016
##
File path:
fineract-provider/src/main/resources/db/changelog/tenant/parts/0005_savings_transaction_reversal.xml
##
@@ -25,7 +25,7 @@
galovics commented on a change in pull request #2046:
URL: https://github.com/apache/fineract/pull/2046#discussion_r812617375
##
File path:
fineract-provider/src/main/resources/db/changelog/tenant/parts/0005_savings_transaction_reversal.xml
##
@@ -0,0 +1,49 @@
+
+
+http://www.
fynmanoj commented on a change in pull request #2049:
URL: https://github.com/apache/fineract/pull/2049#discussion_r812625983
##
File path:
fineract-provider/src/main/resources/db/changelog/tenant/parts/0005_savings_transaction_reversal.xml
##
@@ -25,7 +25,7 @@
vidakovic merged pull request #2049:
URL: https://github.com/apache/fineract/pull/2049
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
galovics opened a new pull request #2050:
URL: https://github.com/apache/fineract/pull/2050
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA
ticket](https://github.com/apache/fineract/p
galovics commented on pull request #2048:
URL: https://github.com/apache/fineract/pull/2048#issuecomment-1048794350
Replaced by https://github.com/apache/fineract/pull/2050
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
galovics closed pull request #2048:
URL: https://github.com/apache/fineract/pull/2048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsu
rrpawar96 commented on pull request #1984:
URL: https://github.com/apache/fineract/pull/1984#issuecomment-1048877398
@galovics @vidakovic Please review the migration script written for
Liquibase.
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
vidakovic merged pull request #2050:
URL: https://github.com/apache/fineract/pull/2050
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
galovics opened a new pull request #2051:
URL: https://github.com/apache/fineract/pull/2051
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA
ticket](https://github.com/apache/fineract/p
vidakovic merged pull request #2051:
URL: https://github.com/apache/fineract/pull/2051
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
galovics opened a new pull request #2052:
URL: https://github.com/apache/fineract/pull/2052
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA
ticket](https://github.com/apache/fineract/p
sonarcloud[bot] commented on pull request #2053:
URL: https://github.com/apache/fineract/pull/2053#issuecomment-1049604725
Kudos, SonarCloud Quality Gate passed! . It's just to
keep this in sync. The only reason to have
vidakovic commented on pull request #2053:
URL: https://github.com/apache/fineract/pull/2053#issuecomment-1051929636
FYI: conflict resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
sonarcloud[bot] removed a comment on pull request #2053:
URL: https://github.com/apache/fineract/pull/2053#issuecomment-1049604725
Kudos, SonarCloud Quality Gate passed! 