[GitHub] pembemiriam opened a new pull request #9: Added unit test

2018-10-24 Thread GitBox
pembemiriam opened a new pull request #9: Added unit test URL: https://github.com/apache/fineract-cn-group-finance/pull/9 ## Description I have added unit test for Center Module ### What's included? - Test if center is created - Test if the form saves the original

[GitHub] pembemiriam opened a new pull request #10: Unit test for center

2018-10-25 Thread GitBox
pembemiriam opened a new pull request #10: Unit test for center URL: https://github.com/apache/fineract-cn-group-finance/pull/10 ## Description I have added unit test for the Center Module ### What's included? - Test if center is created - Test if center is updated

[GitHub] pembemiriam commented on issue #9: Added unit test

2018-10-25 Thread GitBox
pembemiriam commented on issue #9: Added unit test URL: https://github.com/apache/fineract-cn-group-finance/pull/9#issuecomment-432968754 There are still some bugs that I did not see before sending the PR. This PR has to be closed so that I can send a new PR after I fix the bugs.

[GitHub] pembemiriam closed pull request #9: Added unit test

2018-10-25 Thread GitBox
pembemiriam closed pull request #9: Added unit test URL: https://github.com/apache/fineract-cn-group-finance/pull/9 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] kengneruphine commented on issue #12: Fixing the issue FINCN-101:Group Definition Minimum and Maximum Numbe…

2018-10-20 Thread GitBox
kengneruphine commented on issue #12: Fixing the issue FINCN-101:Group Definition Minimum and Maximum Numbe… URL: https://github.com/apache/fineract-cn-fims-web-app/pull/12#issuecomment-431570626 @cabrelkemfang , This error is generated by the unit test for the Group service which I

[GitHub] cabrelkemfang commented on issue #12: Fixing the issue FINCN-101:Group Definition Minimum and Maximum Numbe…

2018-10-20 Thread GitBox
cabrelkemfang commented on issue #12: Fixing the issue FINCN-101:Group Definition Minimum and Maximum Numbe… URL: https://github.com/apache/fineract-cn-fims-web-app/pull/12#issuecomment-431596460 @kengneruphine Can you please look at this ![screenshot from 2018-10-20

[GitHub] cabrelkemfang commented on issue #12: Fixing the issue FINCN-101:Group Definition Minimum and Maximum Numbe…

2018-10-20 Thread GitBox
cabrelkemfang commented on issue #12: Fixing the issue FINCN-101:Group Definition Minimum and Maximum Numbe… URL: https://github.com/apache/fineract-cn-fims-web-app/pull/12#issuecomment-431570300 When i run "npm run test" I have this error ![screenshot from 2018-10-20

[GitHub] crain opened a new pull request #13: Fix breaking build

2018-10-19 Thread GitBox
crain opened a new pull request #13: Fix breaking build URL: https://github.com/apache/fineract-cn-fims-web-app/pull/13 ## Description Use "map" instead of "for each" as uglify breaks because of global variable use within a for each loop Test Steps - [ ] run "npm

[GitHub] ShruthiRajaram opened a new pull request #490: FINERACT-662 activation date null check

2018-11-08 Thread GitBox
ShruthiRajaram opened a new pull request #490: FINERACT-662 activation date null check URL: https://github.com/apache/fineract/pull/490 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] ShruthiRajaram closed pull request #490: FINERACT-662 activation date null check

2018-11-12 Thread GitBox
ShruthiRajaram closed pull request #490: FINERACT-662 activation date null check URL: https://github.com/apache/fineract/pull/490 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] ShruthiRajaram closed pull request #488: FINERACT-656 and FINERACT-655 unable to import client via bulk import…

2018-11-12 Thread GitBox
ShruthiRajaram closed pull request #488: FINERACT-656 and FINERACT-655 unable to import client via bulk import… URL: https://github.com/apache/fineract/pull/488 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] Izakey commented on issue #9: Document Portfolio service API in component-test module

2018-11-12 Thread GitBox
Izakey commented on issue #9: Document Portfolio service API in component-test module URL: https://github.com/apache/fineract-cn-portfolio/pull/9#issuecomment-438147086 @pembemiriam Good progress with documenting the Portfolio API - I ran the unit tests and they were successful.

[GitHub] ShruthiRajaram commented on issue #489: FINERACT-659 Account Id issue while importing loan transaction

2018-11-11 Thread GitBox
ShruthiRajaram commented on issue #489: FINERACT-659 Account Id issue while importing loan transaction URL: https://github.com/apache/fineract/pull/489#issuecomment-437774103 @MexinaD Can you review and provide feedback/approve the PR?

[GitHub] pembemiriam opened a new pull request #9: Document Portfolio service API in component-test module

2018-11-11 Thread GitBox
pembemiriam opened a new pull request #9: Document Portfolio service API in component-test module URL: https://github.com/apache/fineract-cn-portfolio/pull/9 This is an automated message from the Apache Git Service. To

[GitHub] MexinaD commented on issue #489: FINERACT-659 Account Id issue while importing loan transaction

2018-11-12 Thread GitBox
MexinaD commented on issue #489: FINERACT-659 Account Id issue while importing loan transaction URL: https://github.com/apache/fineract/pull/489#issuecomment-437811484 Reviewed and can be merged This is an automated message

[GitHub] pembemiriam commented on issue #9: Document Portfolio service API in component-test module

2018-11-13 Thread GitBox
pembemiriam commented on issue #9: Document Portfolio service API in component-test module URL: https://github.com/apache/fineract-cn-portfolio/pull/9#issuecomment-438192805 Thanks @Izakey for your quick response. I also appreciate the work you did for the API documentations, it helped

[GitHub] ShruthiRajaram commented on issue #409: GSOC'17:swagger and swagger UI integration on fineract-provider

2018-11-12 Thread GitBox
ShruthiRajaram commented on issue #409: GSOC'17:swagger and swagger UI integration on fineract-provider URL: https://github.com/apache/fineract/pull/409#issuecomment-437858714 @nikpawar89 , @avikganguly01 , @nazeer1100126 and @vidakovic kindly review this PR. @Sanyam96 can you check

[GitHub] ShruthiRajaram commented on issue #409: GSOC'17:swagger and swagger UI integration on fineract-provider

2018-11-12 Thread GitBox
ShruthiRajaram commented on issue #409: GSOC'17:swagger and swagger UI integration on fineract-provider URL: https://github.com/apache/fineract/pull/409#issuecomment-437862843 @Sanyam96 kindly squash commits. This is an

[GitHub] Sanyam96 commented on issue #409: GSOC'17:swagger and swagger UI integration on fineract-provider

2018-11-12 Thread GitBox
Sanyam96 commented on issue #409: GSOC'17:swagger and swagger UI integration on fineract-provider URL: https://github.com/apache/fineract/pull/409#issuecomment-437861778 Okay, I'll check and remove the 'fineract-provider.iml' file Might be pushed because of IntelliJ IDEA.

[GitHub] ShruthiRajaram closed pull request #471: FINERACT-627 back dated client transfer

2018-11-16 Thread GitBox
ShruthiRajaram closed pull request #471: FINERACT-627 back dated client transfer URL: https://github.com/apache/fineract/pull/471 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] Sanyam96 commented on issue #409: GSOC'17:swagger and swagger UI integration on fineract-provider

2018-11-16 Thread GitBox
Sanyam96 commented on issue #409: GSOC'17:swagger and swagger UI integration on fineract-provider URL: https://github.com/apache/fineract/pull/409#issuecomment-439341524 @vidakovic the variable changed in the latest merge with develop branch with some other PR I'll solve the merge

[GitHub] Sanyam96 commented on issue #409: GSOC'17:swagger and swagger UI integration on fineract-provider

2018-11-16 Thread GitBox
Sanyam96 commented on issue #409: GSOC'17:swagger and swagger UI integration on fineract-provider URL: https://github.com/apache/fineract/pull/409#issuecomment-439363970 I have solved the merge conflicts This is an automated

[GitHub] ShruthiRajaram edited a comment on issue #409: GSOC'17:swagger and swagger UI integration on fineract-provider

2018-11-16 Thread GitBox
ShruthiRajaram edited a comment on issue #409: GSOC'17:swagger and swagger UI integration on fineract-provider URL: https://github.com/apache/fineract/pull/409#issuecomment-439371769 @vidakovic thanks for the review. @Sanyam96 has resolved issues mentioned and no other changes were

[GitHub] Sanyam96 edited a comment on issue #409: GSOC'17:swagger and swagger UI integration on fineract-provider

2018-11-16 Thread GitBox
Sanyam96 edited a comment on issue #409: GSOC'17:swagger and swagger UI integration on fineract-provider URL: https://github.com/apache/fineract/pull/409#issuecomment-439341524 @vidakovic the variable changed in the latest merge with develop branch with some other PR #488 I'll solve

[GitHub] ShruthiRajaram commented on issue #409: GSOC'17:swagger and swagger UI integration on fineract-provider

2018-11-16 Thread GitBox
ShruthiRajaram commented on issue #409: GSOC'17:swagger and swagger UI integration on fineract-provider URL: https://github.com/apache/fineract/pull/409#issuecomment-439371769 @alexivanov thanks for the review. @Sanyam96 has resolved issues mentioned and no other changes were introduced.

[GitHub] vidakovic commented on issue #409: GSOC'17:swagger and swagger UI integration on fineract-provider

2018-11-16 Thread GitBox
vidakovic commented on issue #409: GSOC'17:swagger and swagger UI integration on fineract-provider URL: https://github.com/apache/fineract/pull/409#issuecomment-439406684 :tada: @Sanyam96 thanks @ShruthiRajaram for the merge

[GitHub] ShruthiRajaram commented on issue #489: FINERACT-659 Account Id issue while importing loan transaction

2018-11-07 Thread GitBox
ShruthiRajaram commented on issue #489: FINERACT-659 Account Id issue while importing loan transaction URL: https://github.com/apache/fineract/pull/489#issuecomment-436595048 Hi @MexinaD I have made changes that fixes both download and upload of bulk loan repayment transaction

[GitHub] ShruthiRajaram edited a comment on issue #489: FINERACT-659 Account Id issue while importing loan transaction

2018-11-07 Thread GitBox
ShruthiRajaram edited a comment on issue #489: FINERACT-659 Account Id issue while importing loan transaction URL: https://github.com/apache/fineract/pull/489#issuecomment-436595048 Hi @MexinaD I have made changes that fixes both download and upload of bulk loan repayment transaction

[GitHub] ShruthiRajaram commented on issue #489: FINERACT-659 Account Id issue while importing loan transaction

2018-11-06 Thread GitBox
ShruthiRajaram commented on issue #489: FINERACT-659 Account Id issue while importing loan transaction URL: https://github.com/apache/fineract/pull/489#issuecomment-436513840 @MexinaD thanks for the input. I will try to include that modification as well

[GitHub] MexinaD commented on issue #489: FINERACT-659 Account Id issue while importing loan transaction

2018-11-05 Thread GitBox
MexinaD commented on issue #489: FINERACT-659 Account Id issue while importing loan transaction URL: https://github.com/apache/fineract/pull/489#issuecomment-436154841 Hello @ShruthiRajaram It seems you have handled during uploading the system to allow the Account id with Long

[GitHub] MexinaD edited a comment on issue #489: FINERACT-659 Account Id issue while importing loan transaction

2018-11-05 Thread GitBox
MexinaD edited a comment on issue #489: FINERACT-659 Account Id issue while importing loan transaction URL: https://github.com/apache/fineract/pull/489#issuecomment-436154841 Hello @ShruthiRajaram It seems you have handled during uploading the system to allow the Account id with Long

[GitHub] Ippezrobert commented on issue #429: EOY-Closure: FINERACT-38

2018-11-09 Thread GitBox
Ippezrobert commented on issue #429: EOY-Closure: FINERACT-38 URL: https://github.com/apache/fineract/pull/429#issuecomment-437335756 @avikganguly01 , @ShruthiRajaram, @raakeshtomarnew, @nazeer1100126, Ed Cable and others, is it possible to review this and make it as part of the next

[GitHub] raakeshtomarnew commented on issue #429: EOY-Closure: FINERACT-38

2018-11-09 Thread GitBox
raakeshtomarnew commented on issue #429: EOY-Closure: FINERACT-38 URL: https://github.com/apache/fineract/pull/429#issuecomment-437361672 yes its useful. Thanks Rakesh Tomar *Team Lead* *8923306463* *8859127643* *EMail:-raakeshto...@gmail.com *

[GitHub] MexinaD commented on issue #489: FINERACT-659 Account Id issue while importing loan transaction

2018-11-09 Thread GitBox
MexinaD commented on issue #489: FINERACT-659 Account Id issue while importing loan transaction URL: https://github.com/apache/fineract/pull/489#issuecomment-437379031 Hello @ShruthiRajaram I tested and it worked fine.

[GitHub] ShruthiRajaram closed pull request #489: FINERACT-659 Account Id issue while importing loan transaction

2018-11-12 Thread GitBox
ShruthiRajaram closed pull request #489: FINERACT-659 Account Id issue while importing loan transaction URL: https://github.com/apache/fineract/pull/489 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] ShruthiRajaram commented on issue #487: FINERACT-656 unable to import client via bulk import when address is …

2018-11-04 Thread GitBox
ShruthiRajaram commented on issue #487: FINERACT-656 unable to import client via bulk import when address is … URL: https://github.com/apache/fineract/pull/487#issuecomment-435757277 @raakeshtomarnew kindly refer https://github.com/apache/fineract/pull/488 PR and when you try to reproduce

[GitHub] ShruthiRajaram commented on issue #409: GSOC'17:swagger and swagger UI integration on fineract-provider

2018-10-03 Thread GitBox
ShruthiRajaram commented on issue #409: GSOC'17:swagger and swagger UI integration on fineract-provider URL: https://github.com/apache/fineract/pull/409#issuecomment-426626740 @Sanyam96 , kindly resolve the conflicts and squash the commits.

[GitHub] ShruthiRajaram closed pull request #477: FINERACT-546 remove group from center

2018-10-03 Thread GitBox
ShruthiRajaram closed pull request #477: FINERACT-546 remove group from center URL: https://github.com/apache/fineract/pull/477 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] ShruthiRajaram opened a new pull request #479: FINERACT-628 self service user reports

2018-10-05 Thread GitBox
ShruthiRajaram opened a new pull request #479: FINERACT-628 self service user reports URL: https://github.com/apache/fineract/pull/479 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] Izakey closed pull request #6: Document the Rhythm service viz beats and clockoffsets

2018-09-30 Thread GitBox
Izakey closed pull request #6: Document the Rhythm service viz beats and clockoffsets URL: https://github.com/apache/fineract-cn-rhythm/pull/6 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] Izakey opened a new pull request #5: Document provisioner service viz applications, tenants and clients

2018-09-30 Thread GitBox
Izakey opened a new pull request #5: Document provisioner service viz applications, tenants and clients URL: https://github.com/apache/fineract-cn-provisioner/pull/5 Document provisioner service viz applications, tenants and clients

[GitHub] Izakey closed pull request #5: Document provisioner service viz applications, tenants and clients

2018-09-30 Thread GitBox
Izakey closed pull request #5: Document provisioner service viz applications, tenants and clients URL: https://github.com/apache/fineract-cn-provisioner/pull/5 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] Izakey opened a new pull request #6: Document the Rhythm service viz beats and clockoffsets

2018-09-30 Thread GitBox
Izakey opened a new pull request #6: Document the Rhythm service viz beats and clockoffsets URL: https://github.com/apache/fineract-cn-rhythm/pull/6 Document the Rhythm service viz beats and clockoffsets This is an automated

[GitHub] MexinaD commented on issue #453: FINERACT-610 - Post Interest As On Permision

2018-09-28 Thread GitBox
MexinaD commented on issue #453: FINERACT-610 - Post Interest As On Permision URL: https://github.com/apache/fineract/pull/453#issuecomment-425339236 Hello @ShruthiRajaram The issue is in back end and not front end, since the permissions are created by schema and not through front end.

[GitHub] ShruthiRajaram commented on issue #453: FINERACT-610 - Post Interest As On Permision

2018-09-28 Thread GitBox
ShruthiRajaram commented on issue #453: FINERACT-610 - Post Interest As On Permision URL: https://github.com/apache/fineract/pull/453#issuecomment-425346151 Hi @MexinaD , I understand that permissions are stored in db. But the logic for the post as on date is present under a different

[GitHub] MexinaD commented on issue #453: FINERACT-610 - Post Interest As On Permision

2018-09-28 Thread GitBox
MexinaD commented on issue #453: FINERACT-610 - Post Interest As On Permision URL: https://github.com/apache/fineract/pull/453#issuecomment-425348524 Hello @ShruthiRajaram Thank you for that clarifications This is an

[GitHub] QiangZhu commented on issue #8: Compilation error

2018-09-30 Thread GitBox
QiangZhu commented on issue #8: Compilation error URL: https://github.com/apache/fineract-cn-fims-web-app/pull/8#issuecomment-425705568 My issue is as the same as Karthyk16 using Node 8.10.0 and NPM 3.5.2 , and change it to Node v10.11.0 and NPM 6.4.1 , the result is the same.

[GitHub] QiangZhu edited a comment on issue #8: Compilation error

2018-09-30 Thread GitBox
QiangZhu edited a comment on issue #8: Compilation error URL: https://github.com/apache/fineract-cn-fims-web-app/pull/8#issuecomment-425705568 My issue is as the same as Karthyk16 using Node 8.10.0 and NPM 3.5.2 , and change it to Node v10.11.0 and NPM 6.4.1 , the result is the

[GitHub] ShruthiRajaram commented on issue #431: Email Campaign fixes

2018-10-10 Thread GitBox
ShruthiRajaram commented on issue #431: Email Campaign fixes URL: https://github.com/apache/fineract/pull/431#issuecomment-428553442 @Ippezrobert kindly add the JIRA id for this PR This is an automated message from the

[GitHub] drarko opened a new pull request #481: Fix sql error

2018-10-10 Thread GitBox
drarko opened a new pull request #481: Fix sql error URL: https://github.com/apache/fineract/pull/481 Remove plus symbol from sql script that break migrations This is an automated message from the Apache Git Service. To

[GitHub] ShruthiRajaram opened a new pull request #480: FINERACT-628 guarantor api for self service user

2018-10-10 Thread GitBox
ShruthiRajaram opened a new pull request #480: FINERACT-628 guarantor api for self service user URL: https://github.com/apache/fineract/pull/480 This is an automated message from the Apache Git Service. To respond to the

[GitHub] drarko opened a new pull request #482: Fix Addresses Path

2018-10-10 Thread GitBox
drarko opened a new pull request #482: Fix Addresses Path URL: https://github.com/apache/fineract/pull/482 Path for addresses resource is inconsistent /client/{clientId}/addresses Other resources are plurals: /clients/{clientId}/charges /clients/{clientId}/identifiers

[GitHub] cabrelkemfang commented on issue #8: Fixing bug FINCN-22:Fix TestSuite in teller

2018-10-11 Thread GitBox
cabrelkemfang commented on issue #8: Fixing bug FINCN-22:Fix TestSuite in teller URL: https://github.com/apache/fineract-cn-teller/pull/8#issuecomment-428856997 Hello Myrle, I only removed the "ChequeService" MockBean while working on the issue and tried running the test again. I

[GitHub] myrle-krantz closed pull request #8: Fixing bug FINCN-22:Fix TestSuite in teller

2018-10-11 Thread GitBox
myrle-krantz closed pull request #8: Fixing bug FINCN-22:Fix TestSuite in teller URL: https://github.com/apache/fineract-cn-teller/pull/8 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] myrle-krantz commented on issue #8: Fixing bug FINCN-22:Fix TestSuite in teller

2018-10-11 Thread GitBox
myrle-krantz commented on issue #8: Fixing bug FINCN-22:Fix TestSuite in teller URL: https://github.com/apache/fineract-cn-teller/pull/8#issuecomment-428861214 Hey Cabrel, I just went ahead and merged. I would've preferred it without the gradle bits, but it wasn't that big of a

[GitHub] cabrelkemfang opened a new pull request #9: Fixing bug FINCN-88 :member loan ledger input help missing

2018-10-11 Thread GitBox
cabrelkemfang opened a new pull request #9: Fixing bug FINCN-88 :member loan ledger input help missing URL: https://github.com/apache/fineract-cn-fims-web-app/pull/9 This is an automated message from the Apache Git

[GitHub] myrle-krantz closed pull request #9: Fixing bug FINCN-88 :member loan ledger input help missing

2018-10-11 Thread GitBox
myrle-krantz closed pull request #9: Fixing bug FINCN-88 :member loan ledger input help missing URL: https://github.com/apache/fineract-cn-fims-web-app/pull/9 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] myrle-krantz commented on issue #9: Fixing bug FINCN-88 :member loan ledger input help missing

2018-10-11 Thread GitBox
myrle-krantz commented on issue #9: Fixing bug FINCN-88 :member loan ledger input help missing URL: https://github.com/apache/fineract-cn-fims-web-app/pull/9#issuecomment-428921516 Thanks Cabrel! This is an automated

[GitHub] ShruthiRajaram closed pull request #461: FINERACT-611 unable to create share product

2018-10-04 Thread GitBox
ShruthiRajaram closed pull request #461: FINERACT-611 unable to create share product URL: https://github.com/apache/fineract/pull/461 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] cabrelkemfang opened a new pull request #8: Fixing bug FINCN-22:Fix TestSuite in teller

2018-10-06 Thread GitBox
cabrelkemfang opened a new pull request #8: Fixing bug FINCN-22:Fix TestSuite in teller URL: https://github.com/apache/fineract-cn-teller/pull/8 This is an automated message from the Apache Git Service. To respond to the

[GitHub] myrle-krantz opened a new pull request #6: adding functionality for starting microservices in debug.

2018-10-06 Thread GitBox
myrle-krantz opened a new pull request #6: adding functionality for starting microservices in debug. URL: https://github.com/apache/fineract-cn-service-starter/pull/6 This is an automated message from the Apache Git

[GitHub] myrle-krantz opened a new pull request #21: microservices in debug

2018-10-06 Thread GitBox
myrle-krantz opened a new pull request #21: microservices in debug URL: https://github.com/apache/fineract-cn-demo-server/pull/21 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] myrle-krantz closed pull request #21: microservices in debug

2018-10-06 Thread GitBox
myrle-krantz closed pull request #21: microservices in debug URL: https://github.com/apache/fineract-cn-demo-server/pull/21 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] myrle-krantz closed pull request #6: adding functionality for starting microservices in debug.

2018-10-06 Thread GitBox
myrle-krantz closed pull request #6: adding functionality for starting microservices in debug. URL: https://github.com/apache/fineract-cn-service-starter/pull/6 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] myrle-krantz commented on issue #8: Fixing bug FINCN-22:Fix TestSuite in teller

2018-10-06 Thread GitBox
myrle-krantz commented on issue #8: Fixing bug FINCN-22:Fix TestSuite in teller URL: https://github.com/apache/fineract-cn-teller/pull/8#issuecomment-427598116 Hey Cabrel, this actually does fix the problem and I'm a little surprised, because I don't understand why. Can you please

[GitHub] ebenezergraham edited a comment on issue #5: Unit and component Tests, Rest and command updates and Bug Fixes

2018-10-07 Thread GitBox
ebenezergraham edited a comment on issue #5: Unit and component Tests,Rest and command updates and Bug Fixes URL: https://github.com/apache/fineract-cn-notifications/pull/5#issuecomment-415146388 @myrle-krantz @awasum @Izakey - [x] 1.) Comment - I have added the relevant licenses to

[GitHub] kengneruphine commented on issue #8: Compilation error

2018-09-30 Thread GitBox
kengneruphine commented on issue #8: Compilation error URL: https://github.com/apache/fineract-cn-fims-web-app/pull/8#issuecomment-425707104 Hey @QiangZhu , @karthyk16 , I am working on the issue This is an automated

[GitHub] awasum commented on issue #8: Compilation error

2018-09-30 Thread GitBox
awasum commented on issue #8: Compilation error URL: https://github.com/apache/fineract-cn-fims-web-app/pull/8#issuecomment-425706431 Hey @QiangZhu , Create an issue here: https://issues.apache.org/jira/projects/FINCN/issues/ Join the mailing list by sending a blank mail to :

[GitHub] awasum commented on issue #7: Document Customer API IN component-test module

2018-09-03 Thread GitBox
awasum commented on issue #7: Document Customer API IN component-test module URL: https://github.com/apache/fineract-cn-customer/pull/7#issuecomment-418102905 LGTM. Thanks @Izakey I am merging now. This is an

[GitHub] awasum commented on issue #7: Document Customer API IN component-test module

2018-09-03 Thread GitBox
awasum commented on issue #7: Document Customer API IN component-test module URL: https://github.com/apache/fineract-cn-customer/pull/7#issuecomment-418094151 ![image](https://user-images.githubusercontent.com/15528032/44985452-59a93d80-af78-11e8-85eb-a5271cb9354c.png) adjust the

[GitHub] awasum closed pull request #7: Document Customer API IN component-test module

2018-09-03 Thread GitBox
awasum closed pull request #7: Document Customer API IN component-test module URL: https://github.com/apache/fineract-cn-customer/pull/7 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] Izakey opened a new pull request #8: Remove expectation of PortraitNotFoundException from shouldDeletePort…

2018-09-03 Thread GitBox
Izakey opened a new pull request #8: Remove expectation of PortraitNotFoundException from shouldDeletePort… URL: https://github.com/apache/fineract-cn-customer/pull/8 Remove expectation of PortraitNotFoundException from shouldDeletePortrait() unit test

[GitHub] Izakey closed pull request #8: Remove expectation of PortraitNotFoundException from shouldDeletePort…

2018-09-03 Thread GitBox
Izakey closed pull request #8: Remove expectation of PortraitNotFoundException from shouldDeletePort… URL: https://github.com/apache/fineract-cn-customer/pull/8 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] Izakey opened a new pull request #8: Document Group API to manage group savings and lending

2018-09-03 Thread GitBox
Izakey opened a new pull request #8: Document Group API to manage group savings and lending URL: https://github.com/apache/fineract-cn-group/pull/8 Document Group API to manage group savings and lending This is an automated

[GitHub] Izakey opened a new pull request #7: Document APIs for transaction types, journal entries, accounts and le…

2018-09-03 Thread GitBox
Izakey opened a new pull request #7: Document APIs for transaction types, journal entries, accounts and le… URL: https://github.com/apache/fineract-cn-accounting/pull/7 Document APIs for transaction types, journal entries, accounts and ledgers

[GitHub] Izakey opened a new pull request #7: Document office API to manage offices & employees

2018-09-03 Thread GitBox
Izakey opened a new pull request #7: Document office API to manage offices & employees URL: https://github.com/apache/fineract-cn-office/pull/7 Set up testing and document office API to manage offices & employee This is an

[GitHub] awasum closed pull request #5: Fixed bugs on login and dashboard page

2018-09-24 Thread GitBox
awasum closed pull request #5: Fixed bugs on login and dashboard page URL: https://github.com/apache/fineract-cn-group-finance/pull/5 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] ShruthiRajaram closed pull request #476: Revert "FINERACT-546 disassociate group from center"

2018-09-24 Thread GitBox
ShruthiRajaram closed pull request #476: Revert "FINERACT-546 disassociate group from center" URL: https://github.com/apache/fineract/pull/476 This is an automated message from the Apache Git Service. To respond to the

[GitHub] ShruthiRajaram opened a new pull request #477: FINERACT-546 remove group from center

2018-09-24 Thread GitBox
ShruthiRajaram opened a new pull request #477: FINERACT-546 remove group from center URL: https://github.com/apache/fineract/pull/477 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] ShruthiRajaram closed pull request #474: FINERACT-546 disassociate group from center

2018-09-24 Thread GitBox
ShruthiRajaram closed pull request #474: FINERACT-546 disassociate group from center URL: https://github.com/apache/fineract/pull/474 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] ShruthiRajaram opened a new pull request #476: Revert "FINERACT-546 disassociate group from center"

2018-09-24 Thread GitBox
ShruthiRajaram opened a new pull request #476: Revert "FINERACT-546 disassociate group from center" URL: https://github.com/apache/fineract/pull/476 Reverts apache/fineract#474 This is an automated message from the Apache

[GitHub] mohak1712 commented on issue #6: feat : added review screens

2018-09-22 Thread GitBox
mohak1712 commented on issue #6: feat : added review screens URL: https://github.com/apache/fineract-cn-mobile/pull/6#issuecomment-423784943 @therajanmaurya done This is an automated message from the Apache Git Service. To

[GitHub] mohak1712 opened a new pull request #23: fix: updated overriden function

2018-09-22 Thread GitBox
mohak1712 opened a new pull request #23: fix: updated overriden function URL: https://github.com/apache/fineract-cn-mobile/pull/23 Please make sure these boxes are checked before submitting your pull request - thanks! - [x] Apply the `AndroidStyle.xml` style template to your code in

[GitHub] mohak1712 commented on issue #17: feat: list and search products

2018-09-22 Thread GitBox
mohak1712 commented on issue #17: feat: list and search products URL: https://github.com/apache/fineract-cn-mobile/pull/17#issuecomment-423784952 @therajanmaurya done This is an automated message from the Apache Git Service.

[GitHub] mohak1712 commented on issue #19: added payroll api support

2018-09-22 Thread GitBox
mohak1712 commented on issue #19: added payroll api support URL: https://github.com/apache/fineract-cn-mobile/pull/19#issuecomment-423784961 @therajanmaurya done This is an automated message from the Apache Git Service. To

[GitHub] ShruthiRajaram commented on issue #453: FINERACT-610 - Post Interest As On Permision

2018-09-26 Thread GitBox
ShruthiRajaram commented on issue #453: FINERACT-610 - Post Interest As On Permision URL: https://github.com/apache/fineract/pull/453#issuecomment-424666812 As it is related to front end, kindly close the PR This is an

[GitHub] ShruthiRajaram closed pull request #453: FINERACT-610 - Post Interest As On Permision

2018-09-26 Thread GitBox
ShruthiRajaram closed pull request #453: FINERACT-610 - Post Interest As On Permision URL: https://github.com/apache/fineract/pull/453 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] ShruthiRajaram edited a comment on issue #453: FINERACT-610 - Post Interest As On Permision

2018-09-26 Thread GitBox
ShruthiRajaram edited a comment on issue #453: FINERACT-610 - Post Interest As On Permision URL: https://github.com/apache/fineract/pull/453#issuecomment-424666812 As it is related to front end, closing the PR This is an

[GitHub] kelvinikome opened a new pull request #7: Bug fixes

2018-09-26 Thread GitBox
kelvinikome opened a new pull request #7: Bug fixes URL: https://github.com/apache/fineract-cn-group-finance/pull/7 ## Description Talk about the great work you've done! ### What's included? - One - Two - Three Test Steps - [ ] do this - [ ]

[GitHub] awasum closed pull request #7: Bug fixes

2018-09-26 Thread GitBox
awasum closed pull request #7: Bug fixes URL: https://github.com/apache/fineract-cn-group-finance/pull/7 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a

[GitHub] kelvinikome opened a new pull request #6: Bug fixes

2018-09-26 Thread GitBox
kelvinikome opened a new pull request #6: Bug fixes URL: https://github.com/apache/fineract-cn-group-finance/pull/6 ## Description Talk about the great work you've done! ### What's included? - One - Two - Three Test Steps - [ ] do this - [ ]

[GitHub] awasum commented on issue #6: Bug fixes

2018-09-26 Thread GitBox
awasum commented on issue #6: Bug fixes URL: https://github.com/apache/fineract-cn-group-finance/pull/6#issuecomment-424613744 ![image](https://user-images.githubusercontent.com/15528032/46063734-a641fc00-c165-11e8-9e95-aa253601491c.png) First this area is meant to be filled to

[GitHub] awasum closed pull request #6: Bug fixes

2018-09-26 Thread GitBox
awasum closed pull request #6: Bug fixes URL: https://github.com/apache/fineract-cn-group-finance/pull/6 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a

[GitHub] ShruthiRajaram closed pull request #454: FINERACT-623 - Restriction of product mix fix

2018-09-26 Thread GitBox
ShruthiRajaram closed pull request #454: FINERACT-623 - Restriction of product mix fix URL: https://github.com/apache/fineract/pull/454 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] ShruthiRajaram commented on issue #458: FINERACT-637: Implementing Trial balance job

2018-09-25 Thread GitBox
ShruthiRajaram commented on issue #458: FINERACT-637: Implementing Trial balance job URL: https://github.com/apache/fineract/pull/458#issuecomment-424594633 @wkk91193 kindly squash commits. This is an automated message

[GitHub] ShruthiRajaram closed pull request #446: FINERACT-546 - remove group from center fix

2018-09-25 Thread GitBox
ShruthiRajaram closed pull request #446: FINERACT-546 - remove group from center fix URL: https://github.com/apache/fineract/pull/446 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] awasum commented on issue #4: fixed bugs on login screen

2018-09-23 Thread GitBox
awasum commented on issue #4: fixed bugs on login screen URL: https://github.com/apache/fineract-cn-group-finance/pull/4#issuecomment-423803566 ![image](https://user-images.githubusercontent.com/15528032/45926553-c7171100-bf1b-11e8-98a8-2d2427ecc727.png) Please fill out this

[GitHub] awasum closed pull request #4: fixed bugs on login screen

2018-09-23 Thread GitBox
awasum closed pull request #4: fixed bugs on login screen URL: https://github.com/apache/fineract-cn-group-finance/pull/4 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] pembemiriam opened a new pull request #4: fixed bugs on login screen

2018-09-22 Thread GitBox
pembemiriam opened a new pull request #4: fixed bugs on login screen URL: https://github.com/apache/fineract-cn-group-finance/pull/4 ## Description Talk about the great work you've done! ### What's included? - One - Two - Three Test Steps - [ ]

[GitHub] pembemiriam opened a new pull request #5: Fixed bugs on login and dashboard page

2018-09-23 Thread GitBox
pembemiriam opened a new pull request #5: Fixed bugs on login and dashboard page URL: https://github.com/apache/fineract-cn-group-finance/pull/5 ## Description I have fixed the bugs found on the password section of the login UI and the navbar section of the dashboard ###

<    1   2   3   4   5   6   7   8   9   10   >