[GitHub] ShruthiRajaram opened a new pull request #478: FINERACT-628 self service APIs for client image management

2018-09-27 Thread GitBox
ShruthiRajaram opened a new pull request #478: FINERACT-628 self service APIs for client image management URL: https://github.com/apache/fineract/pull/478 This is an automated message from the Apache Git Service. To respond

[GitHub] karthyk16 commented on issue #8: Compilation error

2018-09-28 Thread GitBox
karthyk16 commented on issue #8: Compilation error URL: https://github.com/apache/fineract-cn-fims-web-app/pull/8#issuecomment-425478986 @awasum @kengneruphine : NPM 6.4.1 and Node 8.11.3 This is an automated message from

[GitHub] karthyk16 commented on issue #8: Compilation error

2018-09-28 Thread GitBox
karthyk16 commented on issue #8: Compilation error URL: https://github.com/apache/fineract-cn-fims-web-app/pull/8#issuecomment-425408783 @awasum @kengneruphine : We took the dev branch and ran the prod build command which is failing for Error in UglifyJS PFB the screenshot of the

[GitHub] awasum commented on issue #8: Compilation error

2018-09-28 Thread GitBox
awasum commented on issue #8: Compilation error URL: https://github.com/apache/fineract-cn-fims-web-app/pull/8#issuecomment-425418227 @kengneruphine , Please can you help look into this issue? @karthyk16 What version of node and npm are you using? Also create an issue on Fineract

[GitHub] Izakey opened a new pull request #11: Fixed undocumented parts of the payload and license API docs code

2018-12-29 Thread GitBox
Izakey opened a new pull request #11: Fixed undocumented parts of the payload and license API docs code URL: https://github.com/apache/fineract-cn-portfolio/pull/11 This is an automated message from the Apache Git Service.

[GitHub] Izakey closed pull request #11: Fixed undocumented parts of the payload and license API docs code

2018-12-29 Thread GitBox
Izakey closed pull request #11: Fixed undocumented parts of the payload and license API docs code URL: https://github.com/apache/fineract-cn-portfolio/pull/11 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] Izakey commented on issue #11: Fixed undocumented parts of the payload and license API docs code

2018-12-29 Thread GitBox
Izakey commented on issue #11: Fixed undocumented parts of the payload and license API docs code URL: https://github.com/apache/fineract-cn-portfolio/pull/11#issuecomment-450510421 @pembemiriam This fixes the issues I highlighted in #10 earlier.

[GitHub] Izakey closed pull request #10: Document Portfolio service API in component-test module

2018-12-29 Thread GitBox
Izakey closed pull request #10: Document Portfolio service API in component-test module URL: https://github.com/apache/fineract-cn-portfolio/pull/10 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] ShruthiRajaram closed pull request #470: FINERACT:681 Added total outstanding amount to loan repayment workbook

2018-12-31 Thread GitBox
ShruthiRajaram closed pull request #470: FINERACT:681 Added total outstanding amount to loan repayment workbook URL: https://github.com/apache/fineract/pull/470 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] ShruthiRajaram closed pull request #505: Revert "FINERACT-669 back dated client transfer changes"

2018-12-31 Thread GitBox
ShruthiRajaram closed pull request #505: Revert "FINERACT-669 back dated client transfer changes" URL: https://github.com/apache/fineract/pull/505 This is an automated message from the Apache Git Service. To respond to the

[GitHub] ShruthiRajaram opened a new pull request #505: Revert "FINERACT-669 back dated client transfer changes"

2018-12-31 Thread GitBox
ShruthiRajaram opened a new pull request #505: Revert "FINERACT-669 back dated client transfer changes" URL: https://github.com/apache/fineract/pull/505 Reverts apache/fineract#501 reverting since migration script v348 already exist

[GitHub] ShruthiRajaram closed pull request #503: FINERACT-680 market price update issue in share product

2018-12-31 Thread GitBox
ShruthiRajaram closed pull request #503: FINERACT-680 market price update issue in share product URL: https://github.com/apache/fineract/pull/503 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] ShruthiRajaram closed pull request #501: FINERACT-669 back dated client transfer changes

2018-12-31 Thread GitBox
ShruthiRajaram closed pull request #501: FINERACT-669 back dated client transfer changes URL: https://github.com/apache/fineract/pull/501 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] wkk91193 commented on a change in pull request #457: Fixing Apache POI issue - Formula Cell evaluation nullpointer exception

2018-12-28 Thread GitBox
wkk91193 commented on a change in pull request #457: Fixing Apache POI issue - Formula Cell evaluation nullpointer exception URL: https://github.com/apache/fineract/pull/457#discussion_r244279239 ## File path:

[GitHub] wkk91193 commented on a change in pull request #457: Fixing Apache POI issue - Formula Cell evaluation nullpointer exception

2018-12-28 Thread GitBox
wkk91193 commented on a change in pull request #457: Fixing Apache POI issue - Formula Cell evaluation nullpointer exception URL: https://github.com/apache/fineract/pull/457#discussion_r244279509 ## File path:

[GitHub] ShruthiRajaram closed pull request #458: FINERACT-637: Implementing Trial balance job

2018-12-27 Thread GitBox
ShruthiRajaram closed pull request #458: FINERACT-637: Implementing Trial balance job URL: https://github.com/apache/fineract/pull/458 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] ShruthiRajaram opened a new pull request #506: FINERACT-669 client transfer details

2019-01-01 Thread GitBox
ShruthiRajaram opened a new pull request #506: FINERACT-669 client transfer details URL: https://github.com/apache/fineract/pull/506 old PR : https://github.com/apache/fineract/pull/505 This is an automated message from the

[GitHub] ShruthiRajaram closed pull request #506: FINERACT-669 client transfer details

2019-01-01 Thread GitBox
ShruthiRajaram closed pull request #506: FINERACT-669 client transfer details URL: https://github.com/apache/fineract/pull/506 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] Izakey closed pull request #7: Document the notifications service

2019-01-02 Thread GitBox
Izakey closed pull request #7: Document the notifications service URL: https://github.com/apache/fineract-cn-notifications/pull/7 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] Izakey commented on issue #7: Document the notifications service

2019-01-02 Thread GitBox
Izakey commented on issue #7: Document the notifications service URL: https://github.com/apache/fineract-cn-notifications/pull/7#issuecomment-451014545 Document the Fineract CN Notifications API which is very helpful for notifying customers through SMS and Email on relevant transactions.

[GitHub] Izakey opened a new pull request #7: Document the notifications service

2019-01-02 Thread GitBox
Izakey opened a new pull request #7: Document the notifications service URL: https://github.com/apache/fineract-cn-notifications/pull/7 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] abhijitramesh commented on issue #27: style: removed hard_coded strings

2019-01-16 Thread GitBox
abhijitramesh commented on issue #27: style: removed hard_coded strings URL: https://github.com/apache/fineract-cn-mobile/pull/27#issuecomment-454775298 Changes were made to String that requires translation This is an

[GitHub] abhijitramesh opened a new pull request #27: style: removed hard_coded strings

2019-01-16 Thread GitBox
abhijitramesh opened a new pull request #27: style: removed hard_coded strings URL: https://github.com/apache/fineract-cn-mobile/pull/27 Fixes #33 - [x] Apply the `AndroidStyle.xml` style template to your code in Android Studio. - [x] Run the unit tests with

[GitHub] abhijitramesh opened a new pull request #28: style: removed redundant type casting

2019-01-16 Thread GitBox
abhijitramesh opened a new pull request #28: style: removed redundant type casting URL: https://github.com/apache/fineract-cn-mobile/pull/28 Fixes #32 - [x] Apply the `AndroidStyle.xml` style template to your code in Android Studio. - [x] Run the unit tests with

[GitHub] SunnyDay74 opened a new pull request #510: Thread.run()->Thread.start()

2019-01-16 Thread GitBox
SunnyDay74 opened a new pull request #510: Thread.run()->Thread.start() URL: https://github.com/apache/fineract/pull/510 Hello, To utilize the multiple-thread of Java, is it good to use Thread.start() instead of Thread.run()?

[GitHub] abhijitramesh opened a new pull request #29: feat: added malayalam translation

2019-01-17 Thread GitBox
abhijitramesh opened a new pull request #29: feat: added malayalam translation URL: https://github.com/apache/fineract-cn-mobile/pull/29 Fixes #37 - [x] Apply the `AndroidStyle.xml` style template to your code in Android Studio. - [x] Run the unit tests with `./gradlew

[GitHub] abhijitramesh opened a new pull request #30: feat: Fixed Action Bar slides in LoginActivity

2019-01-18 Thread GitBox
abhijitramesh opened a new pull request #30: feat: Fixed Action Bar slides in LoginActivity URL: https://github.com/apache/fineract-cn-mobile/pull/30 Fixes #69 - [x] Apply the `AndroidStyle.xml` style template to your code in Android Studio. - [x] Run the unit tests

[GitHub] therajanmaurya merged pull request #26: docs: fixed broken links in readme.md

2019-01-19 Thread GitBox
therajanmaurya merged pull request #26: docs: fixed broken links in readme.md URL: https://github.com/apache/fineract-cn-mobile/pull/26 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] therajanmaurya merged pull request #27: style: removed hard_coded strings

2019-01-19 Thread GitBox
therajanmaurya merged pull request #27: style: removed hard_coded strings URL: https://github.com/apache/fineract-cn-mobile/pull/27 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] therajanmaurya merged pull request #24: fix: onCreateViewHolder overrides nothing

2019-01-19 Thread GitBox
therajanmaurya merged pull request #24: fix: onCreateViewHolder overrides nothing URL: https://github.com/apache/fineract-cn-mobile/pull/24 This is an automated message from the Apache Git Service. To respond to the

[GitHub] therajanmaurya merged pull request #23: fix: updated overriden function

2019-01-19 Thread GitBox
therajanmaurya merged pull request #23: fix: updated overriden function URL: https://github.com/apache/fineract-cn-mobile/pull/23 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] dawoodjee commented on issue #451: FINERACT-613:500 Internal Server Errors on Data Tables

2019-01-14 Thread GitBox
dawoodjee commented on issue #451: FINERACT-613:500 Internal Server Errors on Data Tables URL: https://github.com/apache/fineract/pull/451#issuecomment-454024063 Ok guys. Kindly guide on how I update my fineractplatform-18.03.01.RELEASE from this point?

[GitHub] abhijitramesh opened a new pull request #31: fix Reduction in Toolbar size on changing orientation

2019-01-21 Thread GitBox
abhijitramesh opened a new pull request #31: fix Reduction in Toolbar size on changing orientation URL: https://github.com/apache/fineract-cn-mobile/pull/31 Fixes #72 - [x] Apply the `AndroidStyle.xml` style template to your code in Android Studio. - [x] Run the unit

[GitHub] Anh3h opened a new pull request #511: Fix bug in generating notification.

2019-01-21 Thread GitBox
Anh3h opened a new pull request #511: Fix bug in generating notification. URL: https://github.com/apache/fineract/pull/511 When querying the users required to get a notification, add new topic subscribers to the current set of subscribers, instead of replacing the currents set of

[GitHub] ShruthiRajaram merged pull request #508: FINERACT-682: SQL injection impact fixes

2019-01-23 Thread GitBox
ShruthiRajaram merged pull request #508: FINERACT-682: SQL injection impact fixes URL: https://github.com/apache/fineract/pull/508 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] santoshconflux commented on issue #511: Fix bug in generating notification.

2019-01-22 Thread GitBox
santoshconflux commented on issue #511: Fix bug in generating notification. URL: https://github.com/apache/fineract/pull/511#issuecomment-456672841 Related ticket: https://issues.apache.org/jira/browse/FINERACT-695 This is an

[GitHub] edcable commented on issue #492: glim_gsim

2018-12-11 Thread GitBox
edcable commented on issue #492: glim_gsim URL: https://github.com/apache/fineract/pull/492#issuecomment-446261191 Hi @rahulg963 and @rrpawar96 How is this task looking for shipment in 1.3? This is an automated message from

[GitHub] abhijitramesh opened a new pull request #24: fixed build error

2018-12-11 Thread GitBox
abhijitramesh opened a new pull request #24: fixed build error URL: https://github.com/apache/fineract-cn-mobile/pull/24 Please make sure these boxes are checked before submitting your pull request - thanks! Fixes #{Issue Number} - [x] Apply the `AndroidStyle.xml` style

[GitHub] abhijitramesh closed pull request #24: fixed build error

2018-12-11 Thread GitBox
abhijitramesh closed pull request #24: fixed build error URL: https://github.com/apache/fineract-cn-mobile/pull/24 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[GitHub] abhijitramesh commented on issue #24: fixed build error

2018-12-11 Thread GitBox
abhijitramesh commented on issue #24: fixed build error URL: https://github.com/apache/fineract-cn-mobile/pull/24#issuecomment-446282476 fixed kotlin compilation error during building This is an automated message from the

[GitHub] abhijitramesh closed pull request #25: docs: fixed broken links in readme.md

2018-12-13 Thread GitBox
abhijitramesh closed pull request #25: docs: fixed broken links in readme.md URL: https://github.com/apache/fineract-cn-mobile/pull/25 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] abhijitramesh opened a new pull request #26: docs: fixed broken links in readme.md

2018-12-13 Thread GitBox
abhijitramesh opened a new pull request #26: docs: fixed broken links in readme.md URL: https://github.com/apache/fineract-cn-mobile/pull/26 Please make sure these boxes are checked before submitting your pull request - thanks! Fixes

[GitHub] abhijitramesh opened a new pull request #25: docs: fixed broken links in readme.md

2018-12-13 Thread GitBox
abhijitramesh opened a new pull request #25: docs: fixed broken links in readme.md URL: https://github.com/apache/fineract-cn-mobile/pull/25 Please make sure these boxes are checked before submitting your pull request - thanks! Fixes

[GitHub] ShruthiRajaram opened a new pull request #501: FINERACT-669 back dated client transfer changes

2018-12-20 Thread GitBox
ShruthiRajaram opened a new pull request #501: FINERACT-669 back dated client transfer changes URL: https://github.com/apache/fineract/pull/501 This is an automated message from the Apache Git Service. To respond to the

[GitHub] rahulg963 opened a new pull request #502: FINERACT-589

2018-12-22 Thread GitBox
rahulg963 opened a new pull request #502: FINERACT-589 URL: https://github.com/apache/fineract/pull/502 Fix : Searching for groups while creating center is displaying groups which are already member of other center. This is

[GitHub] Izakey opened a new pull request #7: Change ActiveMQ default configuration

2018-12-25 Thread GitBox
Izakey opened a new pull request #7: Change ActiveMQ default configuration URL: https://github.com/apache/fineract-cn-service-starter/pull/7 Change ActiveMQ default configuration to 1-1 for the emission of 1 event This is an

[GitHub] ShruthiRajaram commented on issue #450: Adding a compress response filter, registering filter

2018-12-25 Thread GitBox
ShruthiRajaram commented on issue #450: Adding a compress response filter,registering filter URL: https://github.com/apache/fineract/pull/450#issuecomment-449918301 @avikganguly01 kindly review this PR This is an automated

[GitHub] ShruthiRajaram commented on issue #459: FINERACT-429: Node aware Scheduler

2018-12-25 Thread GitBox
ShruthiRajaram commented on issue #459: FINERACT-429: Node aware Scheduler URL: https://github.com/apache/fineract/pull/459#issuecomment-449922992 @avikganguly01 kindly review this PR This is an automated message from the

[GitHub] ShruthiRajaram commented on a change in pull request #458: FINERACT-637: Implementing Trial balance job

2018-12-25 Thread GitBox
ShruthiRajaram commented on a change in pull request #458: FINERACT-637: Implementing Trial balance job URL: https://github.com/apache/fineract/pull/458#discussion_r243952717 ## File path: fineract-provider/src/main/resources/sql/migrations/core_db/V343__m_trial_balance_table.sql

[GitHub] Izakey closed pull request #23: Optimize demo-server to run services in less time

2018-12-25 Thread GitBox
Izakey closed pull request #23: Optimize demo-server to run services in less time URL: https://github.com/apache/fineract-cn-demo-server/pull/23 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] Izakey closed pull request #7: Change ActiveMQ default configuration

2018-12-25 Thread GitBox
Izakey closed pull request #7: Change ActiveMQ default configuration URL: https://github.com/apache/fineract-cn-service-starter/pull/7 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] Izakey opened a new pull request #23: Optimize demo-server to run services in less time

2018-12-25 Thread GitBox
Izakey opened a new pull request #23: Optimize demo-server to run services in less time URL: https://github.com/apache/fineract-cn-demo-server/pull/23 - Remove the wait time between starting the microservices - Remove the wait time after migrating each service when local datastores

[GitHub] ShruthiRajaram commented on issue #492: glim_gsim

2018-12-25 Thread GitBox
ShruthiRajaram commented on issue #492: glim_gsim URL: https://github.com/apache/fineract/pull/492#issuecomment-449914840 @rrpawar96 your contribution is valuable. Kindly address the comments , so that this can be included in Fineract 1.3 release.

[GitHub] ShruthiRajaram closed pull request #500: FINERACT-671 loan charge specific due date fix

2018-12-25 Thread GitBox
ShruthiRajaram closed pull request #500: FINERACT-671 loan charge specific due date fix URL: https://github.com/apache/fineract/pull/500 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] ShruthiRajaram closed pull request #496: FINERACT-668 Download bulk import templates fix

2018-12-11 Thread GitBox
ShruthiRajaram closed pull request #496: FINERACT-668 Download bulk import templates fix URL: https://github.com/apache/fineract/pull/496 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] ShruthiRajaram closed pull request #498: FINERACT-574 share account reject issues

2018-12-12 Thread GitBox
ShruthiRajaram closed pull request #498: FINERACT-574 share account reject issues URL: https://github.com/apache/fineract/pull/498 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] ShruthiRajaram closed pull request #152: FINERACT-186 batch job optimisation

2018-12-25 Thread GitBox
ShruthiRajaram closed pull request #152: FINERACT-186 batch job optimisation URL: https://github.com/apache/fineract/pull/152 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] ShruthiRajaram opened a new pull request #503: FINERACT-680 market price update issue in share product

2018-12-25 Thread GitBox
ShruthiRajaram opened a new pull request #503: FINERACT-680 market price update issue in share product URL: https://github.com/apache/fineract/pull/503 This is an automated message from the Apache Git Service. To respond to

[GitHub] Izakey commented on issue #10: Document Portfolio service API in component-test module

2018-11-30 Thread GitBox
Izakey commented on issue #10: Document Portfolio service API in component-test module URL: https://github.com/apache/fineract-cn-portfolio/pull/10#issuecomment-443366343 Hey @pembemiriam There was no need to close PR #9 as you just needed to update it with a commit. Aside

[GitHub] ShruthiRajaram commented on issue #409: GSOC'17:swagger and swagger UI integration on fineract-provider

2018-12-05 Thread GitBox
ShruthiRajaram commented on issue #409: GSOC'17:swagger and swagger UI integration on fineract-provider URL: https://github.com/apache/fineract/pull/409#issuecomment-08102 Hi @MexinaD, run 1. ./gradlew -Penv=dev clean cleanEclipse eclipse and 2. ./gradlew -Penv=dev clean war then run

[GitHub] myrle-krantz closed pull request #497: Update README.md

2018-12-05 Thread GitBox
myrle-krantz closed pull request #497: Update README.md URL: https://github.com/apache/fineract/pull/497 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a

[GitHub] MexinaD commented on issue #409: GSOC'17:swagger and swagger UI integration on fineract-provider

2018-12-05 Thread GitBox
MexinaD commented on issue #409: GSOC'17:swagger and swagger UI integration on fineract-provider URL: https://github.com/apache/fineract/pull/409#issuecomment-07124 Hello @Sanyam96 @ShruthiRajaram I was building the platform when trying to merge one of the PRs but the build

[GitHub] MexinaD closed pull request #495: FINERACT-665 activation date validation for group and center

2018-12-05 Thread GitBox
MexinaD closed pull request #495: FINERACT-665 activation date validation for group and center URL: https://github.com/apache/fineract/pull/495 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] ShruthiRajaram opened a new pull request #498: FINERACT-574 share account reject issues

2018-12-04 Thread GitBox
ShruthiRajaram opened a new pull request #498: FINERACT-574 share account reject issues URL: https://github.com/apache/fineract/pull/498 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] ShruthiRajaram commented on issue #498: FINERACT-574 share account reject issues

2018-12-04 Thread GitBox
ShruthiRajaram commented on issue #498: FINERACT-574 share account reject issues URL: https://github.com/apache/fineract/pull/498#issuecomment-444091016 works on top of https://github.com/apache/fineract/pull/441 This is an

[GitHub] ShruthiRajaram closed pull request #441: FINERACT-574

2018-12-04 Thread GitBox
ShruthiRajaram closed pull request #441: FINERACT-574 URL: https://github.com/apache/fineract/pull/441 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the

[GitHub] itzamnamx opened a new pull request #497: Update README.md

2018-12-03 Thread GitBox
itzamnamx opened a new pull request #497: Update README.md URL: https://github.com/apache/fineract/pull/497 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use

[GitHub] m-sameer commented on issue #493: FINERACT-632 Make description field non mandatory in saving product

2018-12-02 Thread GitBox
m-sameer commented on issue #493: FINERACT-632 Make description field non mandatory in saving product URL: https://github.com/apache/fineract/pull/493#issuecomment-443494020 @ShruthiRajaram Any updates? This is an automated

[GitHub] ShruthiRajaram commented on issue #493: FINERACT-632 Make description field non mandatory in saving product

2018-12-02 Thread GitBox
ShruthiRajaram commented on issue #493: FINERACT-632 Make description field non mandatory in saving product URL: https://github.com/apache/fineract/pull/493#issuecomment-443604927 @m-sameer good job :) This is an automated

[GitHub] ShruthiRajaram closed pull request #493: FINERACT-632 Make description field non mandatory in saving product

2018-12-02 Thread GitBox
ShruthiRajaram closed pull request #493: FINERACT-632 Make description field non mandatory in saving product URL: https://github.com/apache/fineract/pull/493 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] m-sameer commented on issue #493: FINERACT-632 Make description field non mandatory in saving product

2018-12-02 Thread GitBox
m-sameer commented on issue #493: FINERACT-632 Make description field non mandatory in saving product URL: https://github.com/apache/fineract/pull/493#issuecomment-443606738 @ShruthiRajaram Thanks! :smiley: This is an

[GitHub] ShruthiRajaram closed pull request #494: FINERACT-618 Allow for Submitted On Date to be Edited for Groups

2018-11-29 Thread GitBox
ShruthiRajaram closed pull request #494: FINERACT-618 Allow for Submitted On Date to be Edited for Groups URL: https://github.com/apache/fineract/pull/494 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] m-sameer commented on issue #493: FINERACT-632 Make description field non mandatory in saving product

2018-11-30 Thread GitBox
m-sameer commented on issue #493: FINERACT-632 Make description field non mandatory in saving product URL: https://github.com/apache/fineract/pull/493#issuecomment-443138213 I have found 3 instances where a table called `m_savings_product` is being created with the **description** column

[GitHub] ShruthiRajaram commented on issue #493: FINERACT-632 Make description field non mandatory in saving product

2018-11-30 Thread GitBox
ShruthiRajaram commented on issue #493: FINERACT-632 Make description field non mandatory in saving product URL: https://github.com/apache/fineract/pull/493#issuecomment-443160523 @m-sameer the solution proposed by you is working because by default an empty string is getting assigned to

[GitHub] ShruthiRajaram opened a new pull request #495: FINERACT-665 activation date validation for group and center

2018-11-30 Thread GitBox
ShruthiRajaram opened a new pull request #495: FINERACT-665 activation date validation for group and center URL: https://github.com/apache/fineract/pull/495 This is an automated message from the Apache Git Service. To

[GitHub] m-sameer commented on issue #493: FINERACT-632 Make description field non mandatory in saving product

2018-11-29 Thread GitBox
m-sameer commented on issue #493: FINERACT-632 Make description field non mandatory in saving product URL: https://github.com/apache/fineract/pull/493#issuecomment-443121469 @ShruthiRajaram Sorry for the late reply. If I remove the description field the request is completed successfully

[GitHub] m-sameer commented on issue #493: FINERACT-632 Make description field non mandatory in saving product

2018-11-30 Thread GitBox
m-sameer commented on issue #493: FINERACT-632 Make description field non mandatory in saving product URL: https://github.com/apache/fineract/pull/493#issuecomment-443175594 @ShruthiRajaram If writing the migration script is part of this PR, can you please guide me how to write it? :)

[GitHub] pembemiriam closed pull request #9: Document Portfolio service API in component-test module

2018-11-30 Thread GitBox
pembemiriam closed pull request #9: Document Portfolio service API in component-test module URL: https://github.com/apache/fineract-cn-portfolio/pull/9 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] pembemiriam commented on issue #9: Document Portfolio service API in component-test module

2018-11-30 Thread GitBox
pembemiriam commented on issue #9: Document Portfolio service API in component-test module URL: https://github.com/apache/fineract-cn-portfolio/pull/9#issuecomment-443192693 I have added the license code and edited the code styling. I have to close this pull request so as to send

[GitHub] ShruthiRajaram commented on issue #493: FINERACT-632 Make description field non mandatory in saving product

2018-11-30 Thread GitBox
ShruthiRajaram commented on issue #493: FINERACT-632 Make description field non mandatory in saving product URL: https://github.com/apache/fineract/pull/493#issuecomment-443177731 @m-sameer goto location fineract-provider\src\main\resources\sql\migrations\core_db in your system. choose

[GitHub] m-sameer commented on issue #493: FINERACT-632 Make description field non mandatory in saving product

2018-11-30 Thread GitBox
m-sameer commented on issue #493: FINERACT-632 Make description field non mandatory in saving product URL: https://github.com/apache/fineract/pull/493#issuecomment-443188779 @ShruthiRajaram I have updated the PR. I have tested the changes on RESTClient, now there is no description field

[GitHub] ShruthiRajaram commented on issue #493: FINERACT-632 Make description field non mandatory in saving product

2018-11-30 Thread GitBox
ShruthiRajaram commented on issue #493: FINERACT-632 Make description field non mandatory in saving product URL: https://github.com/apache/fineract/pull/493#issuecomment-443191073 @m-sameer changes look good. But someone has already raised a PR with V344. So can you use V346 as your

[GitHub] pembemiriam opened a new pull request #10: Document Portfolio service API in component-test module

2018-11-30 Thread GitBox
pembemiriam opened a new pull request #10: Document Portfolio service API in component-test module URL: https://github.com/apache/fineract-cn-portfolio/pull/10 This is an automated message from the Apache Git Service. To

[GitHub] m-sameer commented on issue #493: FINERACT-632 Make description field non mandatory in saving product

2018-11-30 Thread GitBox
m-sameer commented on issue #493: FINERACT-632 Make description field non mandatory in saving product URL: https://github.com/apache/fineract/pull/493#issuecomment-443195305 @ShruthiRajaram The next version will be V345 instead of V346, which one should I use?

[GitHub] ShruthiRajaram opened a new pull request #496: FINERACT-668 Download bulk import templates fix

2018-11-30 Thread GitBox
ShruthiRajaram opened a new pull request #496: FINERACT-668 Download bulk import templates fix URL: https://github.com/apache/fineract/pull/496 This is an automated message from the Apache Git Service. To respond to the

[GitHub] m-sameer commented on issue #493: FINERACT-632 Make description field non mandatory in saving product

2018-11-30 Thread GitBox
m-sameer commented on issue #493: FINERACT-632 Make description field non mandatory in saving product URL: https://github.com/apache/fineract/pull/493#issuecomment-443200079 @ShruthiRajaram Done! This is an automated message

[GitHub] ShruthiRajaram commented on issue #493: FINERACT-632 Make description field non mandatory in saving product

2018-11-30 Thread GitBox
ShruthiRajaram commented on issue #493: FINERACT-632 Make description field non mandatory in saving product URL: https://github.com/apache/fineract/pull/493#issuecomment-443201419 @m-sameer use '-' (underscore) instead of '-' in the migration script name. I should have told this before,

[GitHub] ShruthiRajaram commented on issue #493: FINERACT-632 Make description field non mandatory in saving product

2018-11-30 Thread GitBox
ShruthiRajaram commented on issue #493: FINERACT-632 Make description field non mandatory in saving product URL: https://github.com/apache/fineract/pull/493#issuecomment-443196447 V345 is already merged. Use V346 This is an

[GitHub] m-sameer commented on issue #493: FINERACT-632 Make description field non mandatory in saving product

2018-11-30 Thread GitBox
m-sameer commented on issue #493: FINERACT-632 Make description field non mandatory in saving product URL: https://github.com/apache/fineract/pull/493#issuecomment-443204682 @ShruthiRajaram No problem. I have made the changes.

[GitHub] raakeshtomarnew commented on issue #487: FINERACT-656 unable to import client via bulk import when address is …

2018-11-22 Thread GitBox
raakeshtomarnew commented on issue #487: FINERACT-656 unable to import client via bulk import when address is … URL: https://github.com/apache/fineract/pull/487#issuecomment-441174202 Not Solved same problem This is an

[GitHub] m-sameer opened a new pull request #494: FINERACT-618 Allow for Submitted On Date to be Edited for Groups

2018-11-25 Thread GitBox
m-sameer opened a new pull request #494: FINERACT-618 Allow for Submitted On Date to be Edited for Groups URL: https://github.com/apache/fineract/pull/494 Allow for Submitted On Date to be Edited for Groups This is an

[GitHub] santoshconflux commented on issue #493: FINERACT-632 Make description field non mandatory in saving product

2018-11-21 Thread GitBox
santoshconflux commented on issue #493: FINERACT-632 Make description field non mandatory in saving product URL: https://github.com/apache/fineract/pull/493#issuecomment-440620311 @avikganguly01 , Could you review this if time permits?

[GitHub] m-sameer opened a new pull request #493: FINERACT-632 Make description field non mandatory in saving product

2018-11-21 Thread GitBox
m-sameer opened a new pull request #493: FINERACT-632 Make description field non mandatory in saving product URL: https://github.com/apache/fineract/pull/493 Make description field non-mandatory in saving product. This is an

[GitHub] rahulg963 commented on a change in pull request #492: glim_gsim

2018-11-21 Thread GitBox
rahulg963 commented on a change in pull request #492: glim_gsim URL: https://github.com/apache/fineract/pull/492#discussion_r235471810 ## File path:

[GitHub] rahulg963 commented on a change in pull request #492: glim_gsim

2018-11-21 Thread GitBox
rahulg963 commented on a change in pull request #492: glim_gsim URL: https://github.com/apache/fineract/pull/492#discussion_r235471777 ## File path:

[GitHub] rahulg963 commented on a change in pull request #492: glim_gsim

2018-11-21 Thread GitBox
rahulg963 commented on a change in pull request #492: glim_gsim URL: https://github.com/apache/fineract/pull/492#discussion_r235473274 ## File path: fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/api/SavingsAccountsApiResource.java ## @@ -255,6

[GitHub] rahulg963 commented on a change in pull request #492: glim_gsim

2018-11-21 Thread GitBox
rahulg963 commented on a change in pull request #492: glim_gsim URL: https://github.com/apache/fineract/pull/492#discussion_r235473478 ## File path:

[GitHub] rahulg963 commented on a change in pull request #492: glim_gsim

2018-11-21 Thread GitBox
rahulg963 commented on a change in pull request #492: glim_gsim URL: https://github.com/apache/fineract/pull/492#discussion_r235472954 ## File path: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanReadPlatformService.java ## @@ -132,6

[GitHub] rahulg963 commented on a change in pull request #492: glim_gsim

2018-11-21 Thread GitBox
rahulg963 commented on a change in pull request #492: glim_gsim URL: https://github.com/apache/fineract/pull/492#discussion_r235471754 ## File path:

[GitHub] rahulg963 commented on a change in pull request #492: glim_gsim

2018-11-21 Thread GitBox
rahulg963 commented on a change in pull request #492: glim_gsim URL: https://github.com/apache/fineract/pull/492#discussion_r235471728 ## File path:

<    2   3   4   5   6   7   8   9   10   11   >