[GitHub] vishwasbabu commented on a change in pull request #444: Bulk import-fixing importhandler integration test failures

2019-03-01 Thread GitBox
vishwasbabu commented on a change in pull request #444: Bulk import-fixing importhandler integration test failures URL: https://github.com/apache/fineract/pull/444#discussion_r261767597 ## File path:

[GitHub] vishwasbabu commented on a change in pull request #444: Bulk import-fixing importhandler integration test failures

2019-03-01 Thread GitBox
vishwasbabu commented on a change in pull request #444: Bulk import-fixing importhandler integration test failures URL: https://github.com/apache/fineract/pull/444#discussion_r261767400 ## File path:

[GitHub] vishwasbabu commented on a change in pull request #444: Bulk import-fixing importhandler integration test failures

2019-03-01 Thread GitBox
vishwasbabu commented on a change in pull request #444: Bulk import-fixing importhandler integration test failures URL: https://github.com/apache/fineract/pull/444#discussion_r261768550 ## File path:

[GitHub] vishwasbabu opened a new pull request #534: FINERACT-710

2019-03-01 Thread GitBox
vishwasbabu opened a new pull request #534: FINERACT-710 URL: https://github.com/apache/fineract/pull/534 ## Description Fixing test case failures as a result of changes for FINERACT-431 ## Checklist Please make sure these boxes are checked before submitting your pull request

[GitHub] vishwasbabu merged pull request #534: FINERACT-710

2019-03-01 Thread GitBox
vishwasbabu merged pull request #534: FINERACT-710 URL: https://github.com/apache/fineract/pull/534 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL

[GitHub] vishwasbabu opened a new pull request #535: FINERACT-716

2019-03-01 Thread GitBox
vishwasbabu opened a new pull request #535: FINERACT-716 URL: https://github.com/apache/fineract/pull/535 ## Description Fixing failures on the 1st of every month ! ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [ ]

[GitHub] vishwasbabu merged pull request #535: FINERACT-716

2019-03-01 Thread GitBox
vishwasbabu merged pull request #535: FINERACT-716 URL: https://github.com/apache/fineract/pull/535 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL

[GitHub] vishwasbabu merged pull request #536: FINERACT-717

2019-03-01 Thread GitBox
vishwasbabu merged pull request #536: FINERACT-717 URL: https://github.com/apache/fineract/pull/536 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] vishwasbabu opened a new pull request #536: FINERACT-717

2019-03-01 Thread GitBox
vishwasbabu opened a new pull request #536: FINERACT-717 URL: https://github.com/apache/fineract/pull/536 ## Description Lazy load child collections for savings Interest posting batch job ## Checklist Please make sure these boxes are checked before submitting your pull request

[GitHub] [fineract] vorburger closed pull request #431: Email Campaign fixes

2019-03-04 Thread GitBox
vorburger closed pull request #431: Email Campaign fixes URL: https://github.com/apache/fineract/pull/431 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [fineract] vorburger closed pull request #435: [FINERACT-593] Fix migration file V145 relate to DATE field by change default value

2019-03-04 Thread GitBox
vorburger closed pull request #435: [FINERACT-593] Fix migration file V145 relate to DATE field by change default value URL: https://github.com/apache/fineract/pull/435 This is an automated message from the Apache Git

[GitHub] [fineract] vorburger closed pull request #302: Ability to reopen savings accounts when closed or rejected - First stage

2019-03-04 Thread GitBox
vorburger closed pull request #302: Ability to reopen savings accounts when closed or rejected - First stage URL: https://github.com/apache/fineract/pull/302 This is an automated message from the Apache Git Service. To

[GitHub] [fineract] vorburger closed pull request #314: FINERACT-384 - Product Mix - for Saving Accounts

2019-03-04 Thread GitBox
vorburger closed pull request #314: FINERACT-384 - Product Mix - for Saving Accounts URL: https://github.com/apache/fineract/pull/314 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [fineract] vorburger closed pull request #192: commit FINERACT-54 (Add ability to delete code values by setting a flag (is_active) to 0)

2019-03-04 Thread GitBox
vorburger closed pull request #192: commit FINERACT-54 (Add ability to delete code values by setting a flag (is_active) to 0) URL: https://github.com/apache/fineract/pull/192 This is an automated message from the Apache Git

[GitHub] vishwasbabu commented on a change in pull request #514: [MIFOSX-2114] Change assignment staff to groups and clients in center.

2019-03-02 Thread GitBox
vishwasbabu commented on a change in pull request #514: [MIFOSX-2114] Change assignment staff to groups and clients in center. URL: https://github.com/apache/fineract/pull/514#discussion_r261844402 ## File path:

[GitHub] vishwasbabu commented on a change in pull request #514: [MIFOSX-2114] Change assignment staff to groups and clients in center.

2019-03-02 Thread GitBox
vishwasbabu commented on a change in pull request #514: [MIFOSX-2114] Change assignment staff to groups and clients in center. URL: https://github.com/apache/fineract/pull/514#discussion_r261844433 ## File path:

[GitHub] vishwasbabu commented on a change in pull request #514: [MIFOSX-2114] Change assignment staff to groups and clients in center.

2019-03-02 Thread GitBox
vishwasbabu commented on a change in pull request #514: [MIFOSX-2114] Change assignment staff to groups and clients in center. URL: https://github.com/apache/fineract/pull/514#discussion_r261844419 ## File path:

[GitHub] vishwasbabu commented on a change in pull request #514: [MIFOSX-2114] Change assignment staff to groups and clients in center.

2019-03-02 Thread GitBox
vishwasbabu commented on a change in pull request #514: [MIFOSX-2114] Change assignment staff to groups and clients in center. URL: https://github.com/apache/fineract/pull/514#discussion_r26188 ## File path:

[GitHub] vishwasbabu commented on issue #527: Glim gsim rebased

2019-03-02 Thread GitBox
vishwasbabu commented on issue #527: Glim gsim rebased URL: https://github.com/apache/fineract/pull/527#issuecomment-468966479 Thanks @rrpawar96  . I will close this pr for now This is an automated message from the Apache

[GitHub] vishwasbabu closed pull request #527: Glim gsim rebased

2019-03-02 Thread GitBox
vishwasbabu closed pull request #527: Glim gsim rebased URL: https://github.com/apache/fineract/pull/527 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] vishwasbabu removed a comment on issue #450: Adding a compress response filter, registering filter

2019-03-02 Thread GitBox
vishwasbabu removed a comment on issue #450: Adding a compress response filter,registering filter URL: https://github.com/apache/fineract/pull/450#issuecomment-468967158 @wkk91193: Stupid question, but can't we just enable gzip on tomcat instead?

[GitHub] vishwasbabu commented on a change in pull request #450: Adding a compress response filter, registering filter

2019-03-02 Thread GitBox
vishwasbabu commented on a change in pull request #450: Adding a compress response filter,registering filter URL: https://github.com/apache/fineract/pull/450#discussion_r261844733 ## File path:

[GitHub] vishwasbabu commented on issue #450: Adding a compress response filter, registering filter

2019-03-02 Thread GitBox
vishwasbabu commented on issue #450: Adding a compress response filter,registering filter URL: https://github.com/apache/fineract/pull/450#issuecomment-468967158 @wkk91193: Stupid question, but can't we just enable gzip on tomcat instead?

[GitHub] vishwasbabu opened a new pull request #537: fineract-provider/src/integrationTest/java/org/apache/fineract/integr…

2019-03-02 Thread GitBox
vishwasbabu opened a new pull request #537: fineract-provider/src/integrationTest/java/org/apache/fineract/integr… URL: https://github.com/apache/fineract/pull/537 …ationtests/common/shares/ShareAccountIntegrationTests.java ## Description Refer discussion at

[GitHub] vishwasbabu merged pull request #537: fineract-provider/src/integrationTest/java/org/apache/fineract/integr…

2019-03-02 Thread GitBox
vishwasbabu merged pull request #537: fineract-provider/src/integrationTest/java/org/apache/fineract/integr… URL: https://github.com/apache/fineract/pull/537 This is an automated message from the Apache Git Service. To

[GitHub] [fineract] vishwasbabu merged pull request #538: Fineract-719 and Fineract-707

2019-03-03 Thread GitBox
vishwasbabu merged pull request #538: Fineract-719 and Fineract-707 URL: https://github.com/apache/fineract/pull/538 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [fineract] vishwasbabu opened a new pull request #538: Fineract-719 and Fineract-707

2019-03-03 Thread GitBox
vishwasbabu opened a new pull request #538: Fineract-719 and Fineract-707 URL: https://github.com/apache/fineract/pull/538 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket ## Checklist Please

[GitHub] abhijitramesh opened a new pull request #45: feat: made improvement in the UI of dashboard

2019-02-21 Thread GitBox
abhijitramesh opened a new pull request #45: feat: made improvement in the UI of dashboard URL: https://github.com/apache/fineract-cn-mobile/pull/45 Please make sure these boxes are checked before submitting your pull request - thanks! Fixes #56 - [x] Apply the

[GitHub] hungnguyen2712 opened a new pull request #526: FINERACT-684: Create and approve loan on batch mode

2019-02-20 Thread GitBox
hungnguyen2712 opened a new pull request #526: FINERACT-684: Create and approve loan on batch mode URL: https://github.com/apache/fineract/pull/526 - https://issues.apache.org/jira/browse/FINERACT-684 - Integration test to cover the fix

[GitHub] hungnguyen2712 commented on issue #526: FINERACT-684: Create and approve loan on batch mode

2019-02-27 Thread GitBox
hungnguyen2712 commented on issue #526: FINERACT-684: Create and approve loan on batch mode URL: https://github.com/apache/fineract/pull/526#issuecomment-467770048 > @hungnguyen2712 , the integration test seems to be failing. Can you please address the same and resend the pr? Here's the

[GitHub] [fineract] vorburger commented on issue #465: Fineract 614: Rates module

2019-03-06 Thread GitBox
vorburger commented on issue #465: Fineract 614: Rates module URL: https://github.com/apache/fineract/pull/465#issuecomment-470053594 @angelboxes did you notice that the (new) Travis CI build failed? Note: `Building 95% > :integrationTest.googlecode.flyway.core.api.FlywayException:

[GitHub] [fineract] vorburger commented on a change in pull request #524: FINERACT-428 Parallelization of Jobs : Parallelizing and paging of recalculate interest for loans

2019-03-06 Thread GitBox
vorburger commented on a change in pull request #524: FINERACT-428 Parallelization of Jobs : Parallelizing and paging of recalculate interest for loans URL: https://github.com/apache/fineract/pull/524#discussion_r262893899 ## File path:

[GitHub] [fineract-cn-mobile] Vipinsoni38 opened a new pull request #49: Improved Hamburger Menu

2019-03-06 Thread GitBox
Vipinsoni38 opened a new pull request #49: Improved Hamburger Menu URL: https://github.com/apache/fineract-cn-mobile/pull/49 Added new drawable files in hamburger menu which relate to tittle of the item Repositioed Textview of email view (which was not visible earlier) Please

[GitHub] [fineract-cn-mobile] Vipinsoni38 commented on issue #46: Creating hamburger menu for dashboard

2019-03-06 Thread GitBox
Vipinsoni38 commented on issue #46: Creating hamburger menu for dashboard URL: https://github.com/apache/fineract-cn-mobile/pull/46#issuecomment-470051228 @riyasingh1004 I think the menu is already a hamburger menu, So what are you trying to change?

[GitHub] [fineract-cn-mobile] riyasingh1004 commented on issue #46: Creating hamburger menu for dashboard

2019-03-06 Thread GitBox
riyasingh1004 commented on issue #46: Creating hamburger menu for dashboard URL: https://github.com/apache/fineract-cn-mobile/pull/46#issuecomment-470123793 No a hamburger menu is a dotted overflow menu and it is not present in the dashboard.

[GitHub] [fineract] angelboxes commented on issue #465: Fineract 614: Rates module

2019-03-06 Thread GitBox
angelboxes commented on issue #465: Fineract 614: Rates module URL: https://github.com/apache/fineract/pull/465#issuecomment-470200868 > SQL script needs to be re-numbered Hi, I didn't noticed there was a more recent Travis build, I've changed the name of the script and rebased my

[GitHub] [fineract] vishwasbabu opened a new pull request #541: Revert "Revert "FINERACT-684: Create and approve loan on batch mode ""

2019-03-06 Thread GitBox
vishwasbabu opened a new pull request #541: Revert "Revert "FINERACT-684: Create and approve loan on batch mode "" URL: https://github.com/apache/fineract/pull/541 Reverts apache/fineract#529 This is an automated message

[GitHub] [fineract] vishwasbabu commented on issue #526: FINERACT-684: Create and approve loan on batch mode

2019-03-06 Thread GitBox
vishwasbabu commented on issue #526: FINERACT-684: Create and approve loan on batch mode URL: https://github.com/apache/fineract/pull/526#issuecomment-470376602 @hungnguyen2712 : Checking if test cases pass at https://github.com/apache/fineract/pull/541.

[GitHub] myrle-krantz merged pull request #9: Add Docker configuration

2019-02-22 Thread GitBox
myrle-krantz merged pull request #9: Add Docker configuration URL: https://github.com/apache/fineract-cn-customer/pull/9 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] Anh3h opened a new pull request #8: Add Docker configuration

2019-02-22 Thread GitBox
Anh3h opened a new pull request #8: Add Docker configuration URL: https://github.com/apache/fineract-cn-identity/pull/8 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] Anh3h opened a new pull request #8: Add Docker configuration

2019-02-22 Thread GitBox
Anh3h opened a new pull request #8: Add Docker configuration URL: https://github.com/apache/fineract-cn-office/pull/8 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] Anh3h opened a new pull request #9: Add Docker configuration

2019-02-22 Thread GitBox
Anh3h opened a new pull request #9: Add Docker configuration URL: https://github.com/apache/fineract-cn-customer/pull/9 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] santoshconflux commented on issue #504: GLIM_GSIM enhancement

2019-02-24 Thread GitBox
santoshconflux commented on issue #504: GLIM_GSIM enhancement URL: https://github.com/apache/fineract/pull/504#issuecomment-466860863 @rrpawar96 , if you sent new PR #527 , Can you close this one? This is an automated message

[GitHub] michaelbukachi commented on a change in pull request #525: FINERACT-700: upgrade Gradle from 2.10 to 5.2.1

2019-02-22 Thread GitBox
michaelbukachi commented on a change in pull request #525: FINERACT-700: upgrade Gradle from 2.10 to 5.2.1 URL: https://github.com/apache/fineract/pull/525#discussion_r259505963 ## File path: fineract-provider/build.gradle ## @@ -364,7 +363,7 @@ task

[GitHub] michaelbukachi commented on a change in pull request #525: FINERACT-700: upgrade Gradle from 2.10 to 5.2.1

2019-02-22 Thread GitBox
michaelbukachi commented on a change in pull request #525: FINERACT-700: upgrade Gradle from 2.10 to 5.2.1 URL: https://github.com/apache/fineract/pull/525#discussion_r259468873 ## File path: fineract-provider/build.gradle ## @@ -364,7 +363,7 @@ task

[GitHub] aasaru commented on issue #516: FINERACT-699 - new configuration parameters 'fromEmail' and 'fromName'

2019-02-24 Thread GitBox
aasaru commented on issue #516: FINERACT-699 - new configuration parameters 'fromEmail' and 'fromName' URL: https://github.com/apache/fineract/pull/516#issuecomment-466895685 @vorburger could the "changes requested" flag be now removed?

[GitHub] [fineract] vishwasbabu opened a new pull request #539: FINERACT-719 and FINERACT-720

2019-03-05 Thread GitBox
vishwasbabu opened a new pull request #539: FINERACT-719 and FINERACT-720 URL: https://github.com/apache/fineract/pull/539 ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [ ] Commit message starts with the issue number

[GitHub] [fineract] vishwasbabu opened a new pull request #540: Update PULL_REQUEST_TEMPLATE.MD

2019-03-05 Thread GitBox
vishwasbabu opened a new pull request #540: Update PULL_REQUEST_TEMPLATE.MD URL: https://github.com/apache/fineract/pull/540 By adding a link to guidelines for code reviews This is an automated message from the Apache Git

[GitHub] [fineract] vishwasbabu merged pull request #540: Update PULL_REQUEST_TEMPLATE.MD

2019-03-05 Thread GitBox
vishwasbabu merged pull request #540: Update PULL_REQUEST_TEMPLATE.MD URL: https://github.com/apache/fineract/pull/540 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [fineract] vishwasbabu merged pull request #539: FINERACT-719 and FINERACT-720

2019-03-05 Thread GitBox
vishwasbabu merged pull request #539: FINERACT-719 and FINERACT-720 URL: https://github.com/apache/fineract/pull/539 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] vishwasbabu opened a new pull request #533: FINERACT-708 , exclude .github from RAT checks

2019-03-01 Thread GitBox
vishwasbabu opened a new pull request #533: FINERACT-708 , exclude .github from RAT checks URL: https://github.com/apache/fineract/pull/533 ## Description excluding .github contents from RAT checks ## Checklist Please make sure these boxes are checked before submitting your

[GitHub] vishwasbabu merged pull request #533: FINERACT-708 , exclude .github from RAT checks

2019-03-01 Thread GitBox
vishwasbabu merged pull request #533: FINERACT-708 , exclude .github from RAT checks URL: https://github.com/apache/fineract/pull/533 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] vishwasbabu opened a new pull request #531: FINERACT-711

2019-02-28 Thread GitBox
vishwasbabu opened a new pull request #531: FINERACT-711 URL: https://github.com/apache/fineract/pull/531 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the

[GitHub] vishwasbabu merged pull request #531: FINERACT-711

2019-02-28 Thread GitBox
vishwasbabu merged pull request #531: FINERACT-711 URL: https://github.com/apache/fineract/pull/531 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL

[GitHub] vishwasbabu opened a new pull request #532: FINERACT-708

2019-02-28 Thread GitBox
vishwasbabu opened a new pull request #532: FINERACT-708 URL: https://github.com/apache/fineract/pull/532 ## Description Fixing failing test cases, see FINERACT-708 ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [ ]

[GitHub] vishwasbabu opened a new pull request #532: FINERACT-708

2019-02-28 Thread GitBox
vishwasbabu opened a new pull request #532: FINERACT-708 URL: https://github.com/apache/fineract/pull/532 ## Description Fixing failing test cases, see FINERACT-708 ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [x]

[GitHub] vishwasbabu closed pull request #532: FINERACT-708

2019-02-28 Thread GitBox
vishwasbabu closed pull request #532: FINERACT-708 URL: https://github.com/apache/fineract/pull/532 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL

[GitHub] vishwasbabu merged pull request #532: FINERACT-708

2019-03-01 Thread GitBox
vishwasbabu merged pull request #532: FINERACT-708 URL: https://github.com/apache/fineract/pull/532 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL

[GitHub] [fineract-cn-mobile] riyasingh1004 opened a new pull request #46: Creating hamburger menu for dashboard

2019-03-03 Thread GitBox
riyasingh1004 opened a new pull request #46: Creating hamburger menu for dashboard URL: https://github.com/apache/fineract-cn-mobile/pull/46 Fixes #247 - [x] Apply the `AndroidStyle.xml` style template to your code in Android Studio. - [x] Run the unit tests with

[GitHub] [fineract-cn-mobile] riyasingh1004 opened a new pull request #47: Updating dashboard activity

2019-03-03 Thread GitBox
riyasingh1004 opened a new pull request #47: Updating dashboard activity URL: https://github.com/apache/fineract-cn-mobile/pull/47 feat:Double back press to exit Fixes #209 - [x] Apply the `AndroidStyle.xml` style template to your code in Android Studio. - [x] Run the

[GitHub] [fineract-cn-mobile] abhijitramesh opened a new pull request #48: feat: added toast showing log out status

2019-03-03 Thread GitBox
abhijitramesh opened a new pull request #48: feat: added toast showing log out status URL: https://github.com/apache/fineract-cn-mobile/pull/48 Please make sure these boxes are checked before submitting your pull request - thanks! Fixes #{Issue Number} - [x] Apply the

[GitHub] [fineract-cn-mobile] riyasingh1004 commented on issue #34: "feat: added double tap to exit feature on Dashboard"

2019-03-03 Thread GitBox
riyasingh1004 commented on issue #34: "feat: added double tap to exit feature on Dashboard" URL: https://github.com/apache/fineract-cn-mobile/pull/34#issuecomment-469054480 Oh! But I saw the issue was still open. This is an

[GitHub] [fineract-cn-mobile] abhijitramesh commented on issue #34: "feat: added double tap to exit feature on Dashboard"

2019-03-03 Thread GitBox
abhijitramesh commented on issue #34: "feat: added double tap to exit feature on Dashboard" URL: https://github.com/apache/fineract-cn-mobile/pull/34#issuecomment-469054954 Yes it is still pending to be reviewed Make sure that you get issues assigned before working on them please

[GitHub] [fineract-cn-mobile] abhijitramesh commented on issue #47: Updating dashboard activity

2019-03-03 Thread GitBox
abhijitramesh commented on issue #47: Updating dashboard activity URL: https://github.com/apache/fineract-cn-mobile/pull/47#issuecomment-469056825 The issues for this project is listed in

[GitHub] [fineract-cn-mobile] abhijitramesh edited a comment on issue #47: Updating dashboard activity

2019-03-03 Thread GitBox
abhijitramesh edited a comment on issue #47: Updating dashboard activity URL: https://github.com/apache/fineract-cn-mobile/pull/47#issuecomment-469056825 The issues for this project is listed in

[GitHub] [fineract-cn-mobile] abhijitramesh commented on issue #47: Updating dashboard activity

2019-03-03 Thread GitBox
abhijitramesh commented on issue #47: Updating dashboard activity URL: https://github.com/apache/fineract-cn-mobile/pull/47#issuecomment-469053663 I have already made a pr for this issue https://github.com/apache/fineract-cn-mobile/pull/34

[GitHub] [fineract-cn-mobile] riyasingh1004 commented on issue #47: Updating dashboard activity

2019-03-03 Thread GitBox
riyasingh1004 commented on issue #47: Updating dashboard activity URL: https://github.com/apache/fineract-cn-mobile/pull/47#issuecomment-469055699 https://github.com/openMF/Fineract-CN-mobile/issues/209 But the issue was unassigned when I saw it.

[GitHub] [fineract-cn-mobile] riyasingh1004 commented on issue #47: Updating dashboard activity

2019-03-03 Thread GitBox
riyasingh1004 commented on issue #47: Updating dashboard activity URL: https://github.com/apache/fineract-cn-mobile/pull/47#issuecomment-469057068 Okay, thank you for informing. This is an automated message from the Apache

[GitHub] rrpawar96 commented on issue #504: GLIM_GSIM enhancement

2019-02-25 Thread GitBox
rrpawar96 commented on issue #504: GLIM_GSIM enhancement URL: https://github.com/apache/fineract/pull/504#issuecomment-467033525 @santoshconflux , PR has been kept open for reviewers for reference of previous comments. This

[GitHub] angelboxes commented on a change in pull request #465: Fineract 614: Rates module

2019-02-26 Thread GitBox
angelboxes commented on a change in pull request #465: Fineract 614: Rates module URL: https://github.com/apache/fineract/pull/465#discussion_r260537893 ## File path: fineract-provider/src/main/java/org/apache/fineract/portfolio/rate/domain/Rate.java ## @@ -0,0 +1,209 @@

[GitHub] [fineract] michaelbukachi commented on a change in pull request #525: FINERACT-700: upgrade Gradle from 2.10 to 5.2.1

2019-03-14 Thread GitBox
michaelbukachi commented on a change in pull request #525: FINERACT-700: upgrade Gradle from 2.10 to 5.2.1 URL: https://github.com/apache/fineract/pull/525#discussion_r265450539 ## File path: fineract-provider/build.gradle ## @@ -364,7 +363,7 @@ task

[GitHub] [fineract] muarachmann commented on a change in pull request #525: FINERACT-700: upgrade Gradle from 2.10 to 5.2.1

2019-03-14 Thread GitBox
muarachmann commented on a change in pull request #525: FINERACT-700: upgrade Gradle from 2.10 to 5.2.1 URL: https://github.com/apache/fineract/pull/525#discussion_r265450750 ## File path: fineract-provider/build.gradle ## @@ -364,7 +363,7 @@ task

[GitHub] [fineract] vorburger commented on a change in pull request #525: FINERACT-700: upgrade Gradle from 2.10 to 5.2.1

2019-03-14 Thread GitBox
vorburger commented on a change in pull request #525: FINERACT-700: upgrade Gradle from 2.10 to 5.2.1 URL: https://github.com/apache/fineract/pull/525#discussion_r265496890 ## File path: fineract-provider/build.gradle ## @@ -364,7 +363,7 @@ task

[GitHub] [fineract] hungnguyen2712 opened a new pull request #549: FINERACT-684

2019-03-14 Thread GitBox
hungnguyen2712 opened a new pull request #549: FINERACT-684 URL: https://github.com/apache/fineract/pull/549 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket ## Checklist Please make sure these

[GitHub] [fineract] awasum commented on a change in pull request #525: FINERACT-700: upgrade Gradle from 2.10 to 5.2.1

2019-03-14 Thread GitBox
awasum commented on a change in pull request #525: FINERACT-700: upgrade Gradle from 2.10 to 5.2.1 URL: https://github.com/apache/fineract/pull/525#discussion_r265521504 ## File path: fineract-provider/build.gradle ## @@ -364,7 +363,7 @@ task integrationTest(type:Test){

[GitHub] [fineract] ivange94 commented on issue #525: FINERACT-700: upgrade Gradle from 2.10 to 5.2.1

2019-03-17 Thread GitBox
ivange94 commented on issue #525: FINERACT-700: upgrade Gradle from 2.10 to 5.2.1 URL: https://github.com/apache/fineract/pull/525#issuecomment-473678593 @vorburger I have pulled your branch and tried building and running the application. **gradle build** completes successfully but

[GitHub] [fineract] myrle-krantz commented on issue #465: Fineract 614: Rates module

2019-03-17 Thread GitBox
myrle-krantz commented on issue #465: Fineract 614: Rates module URL: https://github.com/apache/fineract/pull/465#issuecomment-473655179 Hey y'all as per our discussion here:

[GitHub] [fineract] myrle-krantz closed pull request #465: Fineract 614: Rates module

2019-03-17 Thread GitBox
myrle-krantz closed pull request #465: Fineract 614: Rates module URL: https://github.com/apache/fineract/pull/465 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [fineract] avikganguly01 commented on a change in pull request #450: Adding a compress response filter, registering filter

2019-03-14 Thread GitBox
avikganguly01 commented on a change in pull request #450: Adding a compress response filter,registering filter URL: https://github.com/apache/fineract/pull/450#discussion_r265650964 ## File path:

[GitHub] [fineract] avikganguly01 commented on issue #450: Adding a compress response filter, registering filter

2019-03-14 Thread GitBox
avikganguly01 commented on issue #450: Adding a compress response filter,registering filter URL: https://github.com/apache/fineract/pull/450#issuecomment-472945510 @ShruthiRajaram : Can we merge this? I need this as part of the release. @wkk91193 : At some later point in time,

[GitHub] [fineract] muarachmann opened a new pull request #550: Fineract 700 upgrade gradle

2019-03-15 Thread GitBox
muarachmann opened a new pull request #550: Fineract 700 upgrade gradle URL: https://github.com/apache/fineract/pull/550 ## Description Upgraded flyway plugin to the latest as per #525 and added migration for `migrateTenantListDB` ## Checklist Please make sure these boxes are

[GitHub] [fineract] muarachmann commented on issue #550: Fineract 700 upgrade gradle

2019-03-15 Thread GitBox
muarachmann commented on issue #550: Fineract 700 upgrade gradle URL: https://github.com/apache/fineract/pull/550#issuecomment-473372422 @vorburger , @michaelbukachi, @vishwasbabu i have upgraded flyway plugin to the latest and the build is ok and very fast. See output `Deprecated

[GitHub] [fineract] vorburger merged pull request #450: Adding a compress response filter, registering filter

2019-03-14 Thread GitBox
vorburger merged pull request #450: Adding a compress response filter,registering filter URL: https://github.com/apache/fineract/pull/450 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [fineract] vorburger commented on issue #525: FINERACT-700: upgrade Gradle from 2.10 to 5.2.1

2019-03-14 Thread GitBox
vorburger commented on issue #525: FINERACT-700: upgrade Gradle from 2.10 to 5.2.1 URL: https://github.com/apache/fineract/pull/525#issuecomment-473079478 Ah yes, didn't realize that, good point worth checking out more... (I wonder how other Java projects at Apache.org use MariaDB, or

[GitHub] [fineract] TypicalGitHubUser removed a comment on issue #514: [MIFOSX-2114] Change assignment staff to groups and clients in center.

2019-03-10 Thread GitBox
TypicalGitHubUser removed a comment on issue #514: [MIFOSX-2114] Change assignment staff to groups and clients in center. URL: https://github.com/apache/fineract/pull/514#issuecomment-471314161 @vishwasbabu No, I won't be able to do this in near future.

[GitHub] [fineract] TypicalGitHubUser commented on issue #514: [MIFOSX-2114] Change assignment staff to groups and clients in center.

2019-03-10 Thread GitBox
TypicalGitHubUser commented on issue #514: [MIFOSX-2114] Change assignment staff to groups and clients in center. URL: https://github.com/apache/fineract/pull/514#issuecomment-471314161 @vishwasbabu No, I won't be able to do this in near future.

[GitHub] [fineract] TypicalGitHubUser commented on issue #514: [MIFOSX-2114] Change assignment staff to groups and clients in center.

2019-03-10 Thread GitBox
TypicalGitHubUser commented on issue #514: [MIFOSX-2114] Change assignment staff to groups and clients in center. URL: https://github.com/apache/fineract/pull/514#issuecomment-471314097 @vishwasbabu No, I won't be able to do this in near future.

[GitHub] [fineract] awasum commented on issue #545: Prevent Apache rat task from failing subsequently after building project: FINERACT-731

2019-03-10 Thread GitBox
awasum commented on issue #545: Prevent Apache rat task from failing subsequently after building project: FINERACT-731 URL: https://github.com/apache/fineract/pull/545#issuecomment-471363657 Don't merge this yet. I think I ignored the gradle folder. Is it suppose to be ignored or part of

[GitHub] [fineract] wkk91193 opened a new pull request #546: Consolidating changes: Bulk import-fixing importhandler integration t…

2019-03-10 Thread GitBox
wkk91193 opened a new pull request #546: Consolidating changes: Bulk import-fixing importhandler integration t… URL: https://github.com/apache/fineract/pull/546 Opening a new PR for #444 changes. This is an automated

[GitHub] [fineract] wkk91193 commented on issue #546: Consolidating changes: Bulk import-fixing importhandler integration t…

2019-03-10 Thread GitBox
wkk91193 commented on issue #546: Consolidating changes: Bulk import-fixing importhandler integration t… URL: https://github.com/apache/fineract/pull/546#issuecomment-471412451 @vishwasbabu Removed the Ignore annotation,code updated

[GitHub] [fineract] wkk91193 commented on issue #444: Bulk import-fixing importhandler integration test failures

2019-03-10 Thread GitBox
wkk91193 commented on issue #444: Bulk import-fixing importhandler integration test failures URL: https://github.com/apache/fineract/pull/444#issuecomment-471403607 @vishwasbabu @vorburger Opened a new PR #546 after rebasing and with the changes requested. Closing this one

[GitHub] [fineract] vishwasbabu closed pull request #444: Bulk import-fixing importhandler integration test failures

2019-03-10 Thread GitBox
vishwasbabu closed pull request #444: Bulk import-fixing importhandler integration test failures URL: https://github.com/apache/fineract/pull/444 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [fineract] vishwasbabu commented on issue #546: Consolidating changes: Bulk import-fixing importhandler integration t…

2019-03-10 Thread GitBox
vishwasbabu commented on issue #546: Consolidating changes: Bulk import-fixing importhandler integration t… URL: https://github.com/apache/fineract/pull/546#issuecomment-471410168 Looks good @wkk91193! Can you please remove the ignore annotation from all 4 test cases, so that Travis can

[GitHub] [fineract] wkk91193 commented on a change in pull request #450: Adding a compress response filter, registering filter

2019-03-10 Thread GitBox
wkk91193 commented on a change in pull request #450: Adding a compress response filter,registering filter URL: https://github.com/apache/fineract/pull/450#discussion_r264098243 ## File path:

[GitHub] [fineract] vishwasbabu commented on issue #545: Prevent Apache rat task from failing subsequently after building project: FINERACT-731

2019-03-10 Thread GitBox
vishwasbabu commented on issue #545: Prevent Apache rat task from failing subsequently after building project: FINERACT-731 URL: https://github.com/apache/fineract/pull/545#issuecomment-471410949 @awasum : you are correct, the gradle folder is a part of the codebase.

[GitHub] [fineract] awasum commented on issue #545: Prevent Apache rat task from failing subsequently after building project: FINERACT-731

2019-03-11 Thread GitBox
awasum commented on issue #545: Prevent Apache rat task from failing subsequently after building project: FINERACT-731 URL: https://github.com/apache/fineract/pull/545#issuecomment-471415269 The gradle folder I ignored is in the root directory( it was one which i added). The one inside

[GitHub] [fineract] awasum opened a new pull request #545: Prevent Apache rat task from failing subsequently after building project: FINERACT-731

2019-03-10 Thread GitBox
awasum opened a new pull request #545: Prevent Apache rat task from failing subsequently after building project: FINERACT-731 URL: https://github.com/apache/fineract/pull/545 ## Description Building project subsequently after the first build task make the rat task to fail: FINERACT-731

[GitHub] [fineract] vishwasbabu commented on issue #524: FINERACT-428 Parallelization of Jobs : Parallelizing and paging of recalculate interest for loans

2019-03-11 Thread GitBox
vishwasbabu commented on issue #524: FINERACT-428 Parallelization of Jobs : Parallelizing and paging of recalculate interest for loans URL: https://github.com/apache/fineract/pull/524#issuecomment-471446472 @wkk91193 : The travis build is failing.

[GitHub] [fineract] vishwasbabu commented on issue #514: [MIFOSX-2114] Change assignment staff to groups and clients in center.

2019-03-11 Thread GitBox
vishwasbabu commented on issue #514: [MIFOSX-2114] Change assignment staff to groups and clients in center. URL: https://github.com/apache/fineract/pull/514#issuecomment-471437500 Closing this PR This is an automated message

[GitHub] [fineract] vishwasbabu closed pull request #514: [MIFOSX-2114] Change assignment staff to groups and clients in center.

2019-03-11 Thread GitBox
vishwasbabu closed pull request #514: [MIFOSX-2114] Change assignment staff to groups and clients in center. URL: https://github.com/apache/fineract/pull/514 This is an automated message from the Apache Git Service. To

<    4   5   6   7   8   9   10   11   12   13   >