[GitHub] [fineract] vishwasbabu merged pull request #545: Prevent Apache rat task from failing subsequently after building project: FINERACT-731

2019-03-11 Thread GitBox
vishwasbabu merged pull request #545: Prevent Apache rat task from failing subsequently after building project: FINERACT-731 URL: https://github.com/apache/fineract/pull/545 This is an automated message from the Apache Git

[GitHub] [fineract] wkk91193 commented on issue #524: FINERACT-428 Parallelization of Jobs : Parallelizing and paging of recalculate interest for loans

2019-03-11 Thread GitBox
wkk91193 commented on issue #524: FINERACT-428 Parallelization of Jobs : Parallelizing and paging of recalculate interest for loans URL: https://github.com/apache/fineract/pull/524#issuecomment-471436769 @vorburger @vishwasbabu Requested changes made.Let me know if further changes are

[GitHub] [fineract] vorburger commented on issue #524: FINERACT-428 Parallelization of Jobs : Parallelizing and paging of recalculate interest for loans

2019-03-11 Thread GitBox
vorburger commented on issue #524: FINERACT-428 Parallelization of Jobs : Parallelizing and paging of recalculate interest for loans URL: https://github.com/apache/fineract/pull/524#issuecomment-471541218 > @wkk91193 : The travis build is failing. Two separate problems here, I

[GitHub] [fineract-cn-mobile] Vipinsoni38 commented on issue #46: Creating hamburger menu for dashboard

2019-03-07 Thread GitBox
Vipinsoni38 commented on issue #46: Creating hamburger menu for dashboard URL: https://github.com/apache/fineract-cn-mobile/pull/46#issuecomment-470506415 Cool! well you can add App Settings, Help and Feedback in it don't add log out because its already there in navigation drawer

[GitHub] [fineract-cn-mobile] riyasingh1004 commented on issue #46: Creating hamburger menu for dashboard

2019-03-07 Thread GitBox
riyasingh1004 commented on issue #46: Creating hamburger menu for dashboard URL: https://github.com/apache/fineract-cn-mobile/pull/46#issuecomment-470506824 Ya I think that's a good idea. Thank you This is an automated

[GitHub] [fineract] ShruthiRajaram commented on issue #465: Fineract 614: Rates module

2019-03-06 Thread GitBox
ShruthiRajaram commented on issue #465: Fineract 614: Rates module URL: https://github.com/apache/fineract/pull/465#issuecomment-470402375 @vorburger , we had a call with this team last year. And we requested some change in functionality. So I prefer Ed Cable or Santosh Math to review the

[GitHub] [fineract] ShruthiRajaram commented on issue #465: Fineract 614: Rates module

2019-03-06 Thread GitBox
ShruthiRajaram commented on issue #465: Fineract 614: Rates module URL: https://github.com/apache/fineract/pull/465#issuecomment-470402150 > OK for me now! @ShruthiRajaram ok for you as well as-is - merge? This is an

[GitHub] [fineract] vishwasbabu commented on issue #465: Fineract 614: Rates module

2019-03-08 Thread GitBox
vishwasbabu commented on issue #465: Fineract 614: Rates module URL: https://github.com/apache/fineract/pull/465#issuecomment-470939181 Santosh , I haven’t reviewed the code . -> The code dosen’t contain integration tests , so we cannot determine if it actually works without manually

[GitHub] [fineract-cn-api] marta-jankovics opened a new pull request #7: interoperable - framework changes

2019-03-08 Thread GitBox
marta-jankovics opened a new pull request #7: interoperable - framework changes URL: https://github.com/apache/fineract-cn-api/pull/7 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [fineract-cn-accounting] marta-jankovics opened a new pull request #10: interoperable - framework changes

2019-03-08 Thread GitBox
marta-jankovics opened a new pull request #10: interoperable - framework changes URL: https://github.com/apache/fineract-cn-accounting/pull/10 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [fineract-cn-demo-server] marta-jankovics opened a new pull request #26: interoperable - config, build

2019-03-08 Thread GitBox
marta-jankovics opened a new pull request #26: interoperable - config, build URL: https://github.com/apache/fineract-cn-demo-server/pull/26 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [fineract-cn-accounting] mgeiss commented on issue #10: interoperable - framework changes

2019-03-08 Thread GitBox
mgeiss commented on issue #10: interoperable - framework changes URL: https://github.com/apache/fineract-cn-accounting/pull/10#issuecomment-470972220 Hey Marta, using an Optional was a design decision, to not use objects directly. An Optional allows for an easier understand

[GitHub] [fineract] angelboxes commented on issue #465: Fineract 614: Rates module

2019-03-08 Thread GitBox
angelboxes commented on issue #465: Fineract 614: Rates module URL: https://github.com/apache/fineract/pull/465#issuecomment-471014902 @awasum Hi, I'm trying to assign the ticket to myself in Jira but I don't seem to find an option to do it. @santoshconflux This feature was

[GitHub] [fineract] edcable commented on issue #465: Fineract 614: Rates module

2019-03-08 Thread GitBox
edcable commented on issue #465: Fineract 614: Rates module URL: https://github.com/apache/fineract/pull/465#issuecomment-470990966 @vishwasbabu those replies were very helpful and clearly establishes the need for either a demo or for @santoshconflux to merge the UI code and manually test

[GitHub] [fineract] angelboxes commented on a change in pull request #465: Fineract 614: Rates module

2019-03-08 Thread GitBox
angelboxes commented on a change in pull request #465: Fineract 614: Rates module URL: https://github.com/apache/fineract/pull/465#discussion_r263940445 ## File path: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/api/LoanTransactionsApiResource.java

[GitHub] [fineract-cn-fims-web-app] marta-jankovics opened a new pull request #14: interoperable - config, build

2019-03-08 Thread GitBox
marta-jankovics opened a new pull request #14: interoperable - config, build URL: https://github.com/apache/fineract-cn-fims-web-app/pull/14 ## Description Talk about the great work you've done! ### What's included? - One - Two - Three Test Steps

[GitHub] [fineract] angelboxes commented on a change in pull request #465: Fineract 614: Rates module

2019-03-08 Thread GitBox
angelboxes commented on a change in pull request #465: Fineract 614: Rates module URL: https://github.com/apache/fineract/pull/465#discussion_r263940445 ## File path: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/api/LoanTransactionsApiResource.java

[GitHub] [fineract] angelboxes commented on a change in pull request #465: Fineract 614: Rates module

2019-03-08 Thread GitBox
angelboxes commented on a change in pull request #465: Fineract 614: Rates module URL: https://github.com/apache/fineract/pull/465#discussion_r263940758 ## File path: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/api/LoanTransactionsApiResource.java

[GitHub] [fineract] vishwasbabu commented on a change in pull request #465: Fineract 614: Rates module

2019-03-08 Thread GitBox
vishwasbabu commented on a change in pull request #465: Fineract 614: Rates module URL: https://github.com/apache/fineract/pull/465#discussion_r263870470 ## File path:

[GitHub] [fineract] vishwasbabu commented on a change in pull request #465: Fineract 614: Rates module

2019-03-08 Thread GitBox
vishwasbabu commented on a change in pull request #465: Fineract 614: Rates module URL: https://github.com/apache/fineract/pull/465#discussion_r263870329 ## File path: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/data/LoanTransactionData.java

[GitHub] [fineract] vishwasbabu commented on a change in pull request #465: Fineract 614: Rates module

2019-03-08 Thread GitBox
vishwasbabu commented on a change in pull request #465: Fineract 614: Rates module URL: https://github.com/apache/fineract/pull/465#discussion_r263870179 ## File path: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/data/LoanChargePaidByData.java

[GitHub] [fineract] vishwasbabu commented on a change in pull request #465: Fineract 614: Rates module

2019-03-08 Thread GitBox
vishwasbabu commented on a change in pull request #465: Fineract 614: Rates module URL: https://github.com/apache/fineract/pull/465#discussion_r263869893 ## File path: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/api/LoanTransactionsApiResource.java

[GitHub] [fineract] vishwasbabu commented on a change in pull request #465: Fineract 614: Rates module

2019-03-08 Thread GitBox
vishwasbabu commented on a change in pull request #465: Fineract 614: Rates module URL: https://github.com/apache/fineract/pull/465#discussion_r263871600 ## File path: fineract-provider/src/main/resources/sql/migrations/core_db/V352__rates.sql ## @@ -0,0 +1,67 @@ +-- +--

[GitHub] [fineract] vishwasbabu commented on a change in pull request #465: Fineract 614: Rates module

2019-03-08 Thread GitBox
vishwasbabu commented on a change in pull request #465: Fineract 614: Rates module URL: https://github.com/apache/fineract/pull/465#discussion_r263870540 ## File path:

[GitHub] [fineract-cn-accounting] myrle-krantz commented on issue #10: interoperable - framework changes

2019-03-09 Thread GitBox
myrle-krantz commented on issue #10: interoperable - framework changes URL: https://github.com/apache/fineract-cn-accounting/pull/10#issuecomment-471173517 Markus is absolutely correct. Using Optional turns runtime errors into compiletime errors thus making it much harder to forget to

[GitHub] [fineract-cn-teller] myrle-krantz merged pull request #10: Add Docker configuration

2019-03-09 Thread GitBox
myrle-krantz merged pull request #10: Add Docker configuration URL: https://github.com/apache/fineract-cn-teller/pull/10 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [fineract-cn-portfolio] myrle-krantz merged pull request #12: Add Docker configuration

2019-03-09 Thread GitBox
myrle-krantz merged pull request #12: Add Docker configuration URL: https://github.com/apache/fineract-cn-portfolio/pull/12 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [fineract-cn-deposit-account-management] myrle-krantz merged pull request #9: Add Docker configuration

2019-03-09 Thread GitBox
myrle-krantz merged pull request #9: Add Docker configuration URL: https://github.com/apache/fineract-cn-deposit-account-management/pull/9 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [fineract-cn-api] myrle-krantz commented on issue #7: interoperable - framework changes

2019-03-09 Thread GitBox
myrle-krantz commented on issue #7: interoperable - framework changes URL: https://github.com/apache/fineract-cn-api/pull/7#issuecomment-471173739 Hey Marta, I can't tell what you've changed at what you haven't Could you please keep the arrangement of the code as is to make code

[GitHub] [fineract-cn-rhythm] myrle-krantz commented on issue #7: Add Docker configuration

2019-03-09 Thread GitBox
myrle-krantz commented on issue #7: Add Docker configuration URL: https://github.com/apache/fineract-cn-rhythm/pull/7#issuecomment-471174882 Thank you Courage, This is beautiful. Greets, Myrle This is an

[GitHub] [fineract-cn-rhythm] myrle-krantz merged pull request #7: Add Docker configuration

2019-03-09 Thread GitBox
myrle-krantz merged pull request #7: Add Docker configuration URL: https://github.com/apache/fineract-cn-rhythm/pull/7 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [fineract-cn-office] myrle-krantz merged pull request #8: Add Docker configuration

2019-03-09 Thread GitBox
myrle-krantz merged pull request #8: Add Docker configuration URL: https://github.com/apache/fineract-cn-office/pull/8 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [fineract-cn-accounting] myrle-krantz merged pull request #9: Add Docker configuration

2019-03-09 Thread GitBox
myrle-krantz merged pull request #9: Add Docker configuration URL: https://github.com/apache/fineract-cn-accounting/pull/9 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [fineract-cn-identity] myrle-krantz merged pull request #8: Add Docker configuration

2019-03-09 Thread GitBox
myrle-krantz merged pull request #8: Add Docker configuration URL: https://github.com/apache/fineract-cn-identity/pull/8 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [fineract-cn-accounting] myrle-krantz closed pull request #10: interoperable - framework changes

2019-03-09 Thread GitBox
myrle-krantz closed pull request #10: interoperable - framework changes URL: https://github.com/apache/fineract-cn-accounting/pull/10 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [fineract-cn-demo-server] myrle-krantz commented on issue #26: interoperable - config, build

2019-03-09 Thread GitBox
myrle-krantz commented on issue #26: interoperable - config, build URL: https://github.com/apache/fineract-cn-demo-server/pull/26#issuecomment-471174008 Hello Marta, There is no fineract service under the name interoperation. You may have created one, but if I merge your code it

[GitHub] [fineract-cn-fims-web-app] myrle-krantz commented on issue #14: interoperable - config, build

2019-03-09 Thread GitBox
myrle-krantz commented on issue #14: interoperable - config, build URL: https://github.com/apache/fineract-cn-fims-web-app/pull/14#issuecomment-471174097 Hey Marta, Welcome to the Fineract project. I can't figure out what your change does. Can you provide a description, please?

[GitHub] [fineract] vishwasbabu commented on issue #541: Revert "Revert "FINERACT-684: Create and approve loan on batch mode ""

2019-03-06 Thread GitBox
vishwasbabu commented on issue #541: Revert "Revert "FINERACT-684: Create and approve loan on batch mode "" URL: https://github.com/apache/fineract/pull/541#issuecomment-470387838 Test case for Fineract-684 fails, relevant log snippet `[1m> Building 95% > :integrationTest > 209

[GitHub] [fineract] vishwasbabu commented on a change in pull request #444: Bulk import-fixing importhandler integration test failures

2019-03-06 Thread GitBox
vishwasbabu commented on a change in pull request #444: Bulk import-fixing importhandler integration test failures URL: https://github.com/apache/fineract/pull/444#discussion_r261767597 ## File path:

[GitHub] [fineract] vishwasbabu commented on issue #465: Fineract 614: Rates module

2019-03-08 Thread GitBox
vishwasbabu commented on issue #465: Fineract 614: Rates module URL: https://github.com/apache/fineract/pull/465#issuecomment-470857715 I am unable to select him from the typeahead . I shall reach out to infra for help. Meanwhile , can @angelboxes try assigning the issue to himself ?

[GitHub] [fineract] awasum commented on issue #465: Fineract 614: Rates module

2019-03-08 Thread GitBox
awasum commented on issue #465: Fineract 614: Rates module URL: https://github.com/apache/fineract/pull/465#issuecomment-470858631 That will be a good way to fix it. @angelboxes , please assign the issue to yourself on JIRA. @angelboxes I appreciate your patience on this issue, you are

[GitHub] [fineract] awasum commented on issue #465: Fineract 614: Rates module

2019-03-08 Thread GitBox
awasum commented on issue #465: Fineract 614: Rates module URL: https://github.com/apache/fineract/pull/465#issuecomment-470859798 @santoshconflux Why do you need a call or demo? Will pulling this code in and testing the feature on your environment not validate if the issue has been

[GitHub] [fineract-cn-rhythm] Anh3h opened a new pull request #7: Add Docker configuration

2019-03-07 Thread GitBox
Anh3h opened a new pull request #7: Add Docker configuration URL: https://github.com/apache/fineract-cn-rhythm/pull/7 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [fineract] muarachmann commented on a change in pull request #550: Fineract 700 upgrade gradle - Flyway plugin Upgrade

2019-03-18 Thread GitBox
muarachmann commented on a change in pull request #550: Fineract 700 upgrade gradle - Flyway plugin Upgrade URL: https://github.com/apache/fineract/pull/550#discussion_r266458322 ## File path: fineract-provider/build.gradle ## @@ -398,123 +398,127 @@

[GitHub] [fineract] muarachmann commented on a change in pull request #550: Fineract 700 upgrade gradle - Flyway plugin Upgrade

2019-03-18 Thread GitBox
muarachmann commented on a change in pull request #550: Fineract 700 upgrade gradle - Flyway plugin Upgrade URL: https://github.com/apache/fineract/pull/550#discussion_r266457934 ## File path: fineract-provider/build.gradle ## @@ -398,123 +398,127 @@

[GitHub] [fineract-cn-test] Izakey merged pull request #8: Fix typo in TestEnvironment method name generateUniqueIdentifier

2019-03-18 Thread GitBox
Izakey merged pull request #8: Fix typo in TestEnvironment method name generateUniqueIdentifier URL: https://github.com/apache/fineract-cn-test/pull/8 This is an automated message from the Apache Git Service. To respond to

[GitHub] [fineract-cn-test] Izakey opened a new pull request #8: Fix typo in TestEnvironment method name generateUniqueIdentifier

2019-03-18 Thread GitBox
Izakey opened a new pull request #8: Fix typo in TestEnvironment method name generateUniqueIdentifier URL: https://github.com/apache/fineract-cn-test/pull/8 Minor : Fix typo in TestEnvironment method name generateUniqueIdentifier()

[GitHub] [fineract-cn-identity] Izakey merged pull request #9: Fix typo in TestEnvironment generateUniqueIdentifier() method

2019-03-18 Thread GitBox
Izakey merged pull request #9: Fix typo in TestEnvironment generateUniqueIdentifier() method URL: https://github.com/apache/fineract-cn-identity/pull/9 This is an automated message from the Apache Git Service. To respond to

[GitHub] [fineract-cn-identity] Izakey opened a new pull request #9: Fix typo in TestEnvironment generateUniqueIdentifier() method

2019-03-18 Thread GitBox
Izakey opened a new pull request #9: Fix typo in TestEnvironment generateUniqueIdentifier() method URL: https://github.com/apache/fineract-cn-identity/pull/9 Fix typo in TestEnvironment generateUniqueIdentifier() method This

[GitHub] [fineract] muarachmann commented on issue #550: Fineract 700 upgrade gradle - Flyway plugin Upgrade

2019-03-18 Thread GitBox
muarachmann commented on issue #550: Fineract 700 upgrade gradle - Flyway plugin Upgrade URL: https://github.com/apache/fineract/pull/550#issuecomment-473835964 @michaelbukachi please can you help me here. I am stuck at this level. I tried running the commands you gave and it keeps

[GitHub] [fineract] michaelbukachi commented on issue #550: Fineract 700 upgrade gradle - Flyway plugin Upgrade

2019-03-18 Thread GitBox
michaelbukachi commented on issue #550: Fineract 700 upgrade gradle - Flyway plugin Upgrade URL: https://github.com/apache/fineract/pull/550#issuecomment-473846070 @muarachmann The migrations are different. See below ``` task migrateTenantDB << { description = "Migrates a

[GitHub] [fineract] vishwasbabu commented on issue #544: mojaloop-fineract integration 1.0

2019-03-18 Thread GitBox
vishwasbabu commented on issue #544: mojaloop-fineract integration 1.0 URL: https://github.com/apache/fineract/pull/544#issuecomment-473869843 > @vishwasbabu > Please can I get a task @fonlawrence : Apologies, I missed responding to you earlier. Here's one

[GitHub] [fineract] vorburger merged pull request #548: Use gradlew --console=plain, hoping to reduce output (FINERACT-732)

2019-03-12 Thread GitBox
vorburger merged pull request #548: Use gradlew --console=plain, hoping to reduce output (FINERACT-732) URL: https://github.com/apache/fineract/pull/548 This is an automated message from the Apache Git Service. To respond

[GitHub] [fineract] vorburger commented on issue #548: Use gradlew --console=plain, hoping to reduce output (FINERACT-732)

2019-03-12 Thread GitBox
vorburger commented on issue #548: Use gradlew --console=plain, hoping to reduce output (FINERACT-732) URL: https://github.com/apache/fineract/pull/548#issuecomment-471989423 this seems to be a Good Idea, see comments in https://jira.apache.org/jira/browse/FINERACT-732 for details.

[GitHub] [fineract] fonlawrence commented on issue #544: mojaloop-fineract integration 1.0

2019-03-12 Thread GitBox
fonlawrence commented on issue #544: mojaloop-fineract integration 1.0 URL: https://github.com/apache/fineract/pull/544#issuecomment-472171005 @vishwasbabu Please can I get a task This is an automated message from the

[GitHub] [fineract] awasum commented on issue #465: Fineract 614: Rates module

2019-03-08 Thread GitBox
awasum commented on issue #465: Fineract 614: Rates module URL: https://github.com/apache/fineract/pull/465#issuecomment-470847270 Hey @vishwasbabu , Please assign @angelboxes to this issue on JIRA: https://issues.apache.org/jira/projects/FINERACT/issues/FINERACT-614 He is the

[GitHub] [fineract] santoshconflux commented on issue #465: Fineract 614: Rates module

2019-03-08 Thread GitBox
santoshconflux commented on issue #465: Fineract 614: Rates module URL: https://github.com/apache/fineract/pull/465#issuecomment-470849467 Hi @angelboxes, Can we have one quick functionality demo regarding the ticket? This

[GitHub] [fineract] Anh3h commented on a change in pull request #525: FINERACT-700: upgrade Gradle from 2.10 to 5.2.1

2019-03-15 Thread GitBox
Anh3h commented on a change in pull request #525: FINERACT-700: upgrade Gradle from 2.10 to 5.2.1 URL: https://github.com/apache/fineract/pull/525#discussion_r266105822 ## File path: fineract-provider/build.gradle ## @@ -364,7 +363,7 @@ task integrationTest(type:Test){

[GitHub] [fineract-cn-test] Izakey opened a new pull request #7: Migrate test library from MariaDB to PostgreSQL

2019-03-15 Thread GitBox
Izakey opened a new pull request #7: Migrate test library from MariaDB to PostgreSQL URL: https://github.com/apache/fineract-cn-test/pull/7 Migrate test library from MariaDB to PostgreSQL This is an automated message from

[GitHub] [fineract] michaelbukachi commented on a change in pull request #550: Fineract 700 upgrade gradle - Flyway plugin Upgrade

2019-03-15 Thread GitBox
michaelbukachi commented on a change in pull request #550: Fineract 700 upgrade gradle - Flyway plugin Upgrade URL: https://github.com/apache/fineract/pull/550#discussion_r266087134 ## File path: fineract-provider/build.gradle ## @@ -471,21 +471,19 @@ task

[GitHub] [fineract] muarachmann commented on issue #550: Fineract 700 upgrade gradle - Flyway plugin Upgrade

2019-03-15 Thread GitBox
muarachmann commented on issue #550: Fineract 700 upgrade gradle - Flyway plugin Upgrade URL: https://github.com/apache/fineract/pull/550#issuecomment-473383246 Oh yes... Thanks awasum On Fri, Mar 15, 2019 at 6:47 PM Awasum Yannick wrote: > @muarachmann

[GitHub] [fineract] muarachmann commented on a change in pull request #550: Fineract 700 upgrade gradle - Flyway plugin Upgrade

2019-03-15 Thread GitBox
muarachmann commented on a change in pull request #550: Fineract 700 upgrade gradle - Flyway plugin Upgrade URL: https://github.com/apache/fineract/pull/550#discussion_r266087556 ## File path: fineract-provider/build.gradle ## @@ -471,21 +471,19 @@ task showTenantDBInfo {

[GitHub] [fineract] awasum commented on a change in pull request #550: Fineract 700 upgrade gradle - Flyway plugin Upgrade

2019-03-15 Thread GitBox
awasum commented on a change in pull request #550: Fineract 700 upgrade gradle - Flyway plugin Upgrade URL: https://github.com/apache/fineract/pull/550#discussion_r266085864 ## File path: fineract-provider/build.gradle ## @@ -471,21 +471,19 @@ task showTenantDBInfo { }

[GitHub] [fineract] muarachmann commented on issue #550: Fineract 700 upgrade gradle - Flyway plugin Upgrade

2019-03-15 Thread GitBox
muarachmann commented on issue #550: Fineract 700 upgrade gradle - Flyway plugin Upgrade URL: https://github.com/apache/fineract/pull/550#issuecomment-473392204 @awasum how can i know the sql files ran when i run this command `./gradlew migrateTenantListDB -PdbName=mifosplatform-tenants`

[GitHub] [fineract] awasum commented on issue #550: Fineract 700 upgrade gradle - Flyway plugin Upgrade

2019-03-15 Thread GitBox
awasum commented on issue #550: Fineract 700 upgrade gradle - Flyway plugin Upgrade URL: https://github.com/apache/fineract/pull/550#issuecomment-473382345 @muarachmann there are merge conflicts. This is an automated message

[GitHub] [fineract] awasum commented on issue #550: Fineract 700 upgrade gradle - Flyway plugin Upgrade

2019-03-15 Thread GitBox
awasum commented on issue #550: Fineract 700 upgrade gradle - Flyway plugin Upgrade URL: https://github.com/apache/fineract/pull/550#issuecomment-473393419 > @awasum how can i know the sql files ran when i run this command `./gradlew migrateTenantListDB -PdbName=mifosplatform-tenants` .

[GitHub] [fineract] awasum commented on issue #550: Fineract 700 upgrade gradle - Flyway plugin Upgrade

2019-03-15 Thread GitBox
awasum commented on issue #550: Fineract 700 upgrade gradle - Flyway plugin Upgrade URL: https://github.com/apache/fineract/pull/550#issuecomment-473403141 @muarachmann : https://travis-ci.org/apache/fineract/builds/506903718?utm_source=github_status_medium=notification

[GitHub] [fineract] vishwasbabu merged pull request #549: FINERACT-684

2019-03-14 Thread GitBox
vishwasbabu merged pull request #549: FINERACT-684 URL: https://github.com/apache/fineract/pull/549 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [fineract] muarachmann commented on a change in pull request #550: Fineract 700 upgrade gradle - Flyway plugin Upgrade

2019-03-15 Thread GitBox
muarachmann commented on a change in pull request #550: Fineract 700 upgrade gradle - Flyway plugin Upgrade URL: https://github.com/apache/fineract/pull/550#discussion_r266190289 ## File path: fineract-provider/build.gradle ## @@ -398,123 +398,127 @@

[GitHub] [fineract] muarachmann commented on a change in pull request #550: Fineract 700 upgrade gradle - Flyway plugin Upgrade

2019-03-15 Thread GitBox
muarachmann commented on a change in pull request #550: Fineract 700 upgrade gradle - Flyway plugin Upgrade URL: https://github.com/apache/fineract/pull/550#discussion_r266190386 ## File path: fineract-provider/build.gradle ## @@ -398,123 +398,127 @@

[GitHub] [fineract] michaelbukachi commented on issue #550: Fineract 700 upgrade gradle - Flyway plugin Upgrade

2019-03-16 Thread GitBox
michaelbukachi commented on issue #550: Fineract 700 upgrade gradle - Flyway plugin Upgrade URL: https://github.com/apache/fineract/pull/550#issuecomment-473503526 Just run `./gradlew migrateTenantListDB` and `./gradlew migrateTenantDB`. These are two different commands required. They

[GitHub] [fineract] muarachmann commented on issue #550: Fineract 700 upgrade gradle - Flyway plugin Upgrade

2019-03-15 Thread GitBox
muarachmann commented on issue #550: Fineract 700 upgrade gradle - Flyway plugin Upgrade URL: https://github.com/apache/fineract/pull/550#issuecomment-473502410 @michaelbukachi, @awasum i changed the drizzle driver to mysql-connector and that seems to work ok. Have a look when you have

[GitHub] [fineract] muarachmann commented on issue #550: Fineract 700 upgrade gradle - Flyway plugin Upgrade

2019-03-16 Thread GitBox
muarachmann commented on issue #550: Fineract 700 upgrade gradle - Flyway plugin Upgrade URL: https://github.com/apache/fineract/pull/550#issuecomment-473503760 > Just run `./gradlew migrateTenantListDB` and `./gradlew migrateTenantDB`. These are two different commands required. They each

[GitHub] [fineract] vorburger commented on issue #465: Fineract 614: Rates module

2019-03-07 Thread GitBox
vorburger commented on issue #465: Fineract 614: Rates module URL: https://github.com/apache/fineract/pull/465#issuecomment-470767585 @ShruthiRajaram my question was just if the points which YOU (earlier, above) raised are now adressed? Voice Calls without any public written record here

[GitHub] [fineract-cn-accounting] Anh3h opened a new pull request #9: Add Docker configuration

2019-03-07 Thread GitBox
Anh3h opened a new pull request #9: Add Docker configuration URL: https://github.com/apache/fineract-cn-accounting/pull/9 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [fineract] vorburger opened a new pull request #542: add new Governance and Policies section to Readme

2019-03-07 Thread GitBox
vorburger opened a new pull request #542: add new Governance and Policies section to Readme URL: https://github.com/apache/fineract/pull/542 With wording prohibiting PRs of thousands of lines. This is an automated message

[GitHub] [fineract-cn-portfolio] Anh3h opened a new pull request #12: Add Docker configuration

2019-03-07 Thread GitBox
Anh3h opened a new pull request #12: Add Docker configuration URL: https://github.com/apache/fineract-cn-portfolio/pull/12 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [fineract-cn-teller] Anh3h opened a new pull request #10: Add Docker configuration

2019-03-07 Thread GitBox
Anh3h opened a new pull request #10: Add Docker configuration URL: https://github.com/apache/fineract-cn-teller/pull/10 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [fineract] vishwasbabu commented on issue #515: FINERACT-698:Ability to associate a GUID with every request

2019-03-07 Thread GitBox
vishwasbabu commented on issue #515: FINERACT-698:Ability to associate a GUID with every request URL: https://github.com/apache/fineract/pull/515#issuecomment-470813095 The Jira ticket at https://jira.apache.org/jira/browse/FINERACT-698 has been updated with a sub-task for writing test

[GitHub] [fineract] vishwasbabu merged pull request #472: Make repayments file download for bulk import tool

2019-03-07 Thread GitBox
vishwasbabu merged pull request #472: Make repayments file download for bulk import tool URL: https://github.com/apache/fineract/pull/472 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [fineract] vishwasbabu commented on issue #514: [MIFOSX-2114] Change assignment staff to groups and clients in center.

2019-03-07 Thread GitBox
vishwasbabu commented on issue #514: [MIFOSX-2114] Change assignment staff to groups and clients in center. URL: https://github.com/apache/fineract/pull/514#issuecomment-470825960 @TypicalGitHubUser : Please let us know if you have the time to address these review comments anytime in the

[GitHub] [fineract] vishwasbabu closed pull request #541: Revert "Revert "FINERACT-684: Create and approve loan on batch mode ""

2019-03-07 Thread GitBox
vishwasbabu closed pull request #541: Revert "Revert "FINERACT-684: Create and approve loan on batch mode "" URL: https://github.com/apache/fineract/pull/541 This is an automated message from the Apache Git Service. To

[GitHub] [fineract] vishwasbabu commented on issue #526: FINERACT-684: Create and approve loan on batch mode

2019-03-07 Thread GitBox
vishwasbabu commented on issue #526: FINERACT-684: Create and approve loan on batch mode URL: https://github.com/apache/fineract/pull/526#issuecomment-470810722 @hungnguyen2712 : All existing test cases are currently. Details of the test cases failure related to this PR at

[GitHub] [fineract-cn-deposit-account-management] Anh3h opened a new pull request #9: Add Docker configuration

2019-03-07 Thread GitBox
Anh3h opened a new pull request #9: Add Docker configuration URL: https://github.com/apache/fineract-cn-deposit-account-management/pull/9 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [fineract] vishwasbabu commented on issue #472: Make repayments file download for bulk import tool

2019-03-07 Thread GitBox
vishwasbabu commented on issue #472: Make repayments file download for bulk import tool URL: https://github.com/apache/fineract/pull/472#issuecomment-470824140 @pwairuru : Since this is a simple fix. a jira ticket has been created at https://jira.apache.org/jira/browse/FINERACT-729 and

[GitHub] [fineract] vorburger opened a new pull request #543: link to (existing) Committer page on Wiki

2019-03-08 Thread GitBox
vorburger opened a new pull request #543: link to (existing) Committer page on Wiki URL: https://github.com/apache/fineract/pull/543 from the new Governance and Policies section in the README This is an automated message

[GitHub] [fineract] vorburger commented on issue #542: add new Governance and Policies section to Readme

2019-03-08 Thread GitBox
vorburger commented on issue #542: add new Governance and Policies section to Readme URL: https://github.com/apache/fineract/pull/542#issuecomment-470886762 As per @myrle-krantz feedback on PMC private list, instead of having this wording here, it's now linking to a (new) page on the Wiki

[GitHub] [fineract] marta-jankovics opened a new pull request #544: mojaloop-fineract integration 1.0

2019-03-08 Thread GitBox
marta-jankovics opened a new pull request #544: mojaloop-fineract integration 1.0 URL: https://github.com/apache/fineract/pull/544 ## Description - interoperable - service: new package supporting interoperable transactions - interoperable - config, build: database and build

[GitHub] [fineract] vishwasbabu merged pull request #542: add new Governance and Policies section to Readme

2019-03-08 Thread GitBox
vishwasbabu merged pull request #542: add new Governance and Policies section to Readme URL: https://github.com/apache/fineract/pull/542 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [fineract] vishwasbabu merged pull request #543: link to (existing) Committer page on Wiki

2019-03-08 Thread GitBox
vishwasbabu merged pull request #543: link to (existing) Committer page on Wiki URL: https://github.com/apache/fineract/pull/543 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] wkk91193 closed pull request #464: FINERACT-428 Parallelization of Jobs :Parallelizing and paging of update loan summary

2019-02-07 Thread GitBox
wkk91193 closed pull request #464: FINERACT-428 Parallelization of Jobs :Parallelizing and paging of update loan summary URL: https://github.com/apache/fineract/pull/464 This is an automated message from the Apache Git

[GitHub] wkk91193 closed pull request #462: FINERACT-428 Parallelization of Jobs :Parallelizing periodic accurual

2019-02-07 Thread GitBox
wkk91193 closed pull request #462: FINERACT-428 Parallelization of Jobs :Parallelizing periodic accurual URL: https://github.com/apache/fineract/pull/462 This is an automated message from the Apache Git Service. To respond

[GitHub] wkk91193 opened a new pull request #512: FINERACT-428 Parallelization of Jobs :Parallelizing and paging of update loan summary

2019-02-07 Thread GitBox
wkk91193 opened a new pull request #512: FINERACT-428 Parallelization of Jobs :Parallelizing and paging of update loan summary URL: https://github.com/apache/fineract/pull/512 Opening a new PR after feedback from PR #464

[GitHub] wkk91193 opened a new pull request #513: FINERACT-428 Parallelization of Jobs :Parallelizing periodic accurual

2019-02-07 Thread GitBox
wkk91193 opened a new pull request #513: FINERACT-428 Parallelization of Jobs :Parallelizing periodic accurual URL: https://github.com/apache/fineract/pull/513 Reopened a new PR based on the feedback from previous #462 This

[GitHub] wkk91193 commented on issue #462: FINERACT-428 Parallelization of Jobs :Parallelizing periodic accurual

2019-02-07 Thread GitBox
wkk91193 commented on issue #462: FINERACT-428 Parallelization of Jobs :Parallelizing periodic accurual URL: https://github.com/apache/fineract/pull/462#issuecomment-461548008 @vorburger @avikganguly01 Reopened a new PR #513 based on the feedback given. Closing this one.

[GitHub] wkk91193 commented on issue #464: FINERACT-428 Parallelization of Jobs :Parallelizing and paging of update loan summary

2019-02-07 Thread GitBox
wkk91193 commented on issue #464: FINERACT-428 Parallelization of Jobs :Parallelizing and paging of update loan summary URL: https://github.com/apache/fineract/pull/464#issuecomment-461483741 @vorburger @avikganguly01 Closing this as a new PR #512 opened after feedback

[GitHub] wkk91193 commented on a change in pull request #464: FINERACT-428 Parallelization of Jobs :Parallelizing and paging of update loan summary

2019-02-07 Thread GitBox
wkk91193 commented on a change in pull request #464: FINERACT-428 Parallelization of Jobs :Parallelizing and paging of update loan summary URL: https://github.com/apache/fineract/pull/464#discussion_r254743909 ## File path:

[GitHub] TypicalGitHubUser opened a new pull request #514: [MIFOSX-2114] Change assignment staff to groups and clients in center.

2019-02-08 Thread GitBox
TypicalGitHubUser opened a new pull request #514: [MIFOSX-2114] Change assignment staff to groups and clients in center. URL: https://github.com/apache/fineract/pull/514 Recreated from #275. This is an automated message from

[GitHub] TypicalGitHubUser commented on issue #275: [MIFOSX-2114] Change assignment staff to group and clients in center.

2019-02-08 Thread GitBox
TypicalGitHubUser commented on issue #275: [MIFOSX-2114] Change assignment staff to group and clients in center. URL: https://github.com/apache/fineract/pull/275#issuecomment-461751572 @vorburger I recreated this PR in #514. @nazeer1100126 Could you please review it again?

[GitHub] TypicalGitHubUser closed pull request #275: [MIFOSX-2114] Change assignment staff to group and clients in center.

2019-02-08 Thread GitBox
TypicalGitHubUser closed pull request #275: [MIFOSX-2114] Change assignment staff to group and clients in center. URL: https://github.com/apache/fineract/pull/275 This is an automated message from the Apache Git Service. To

<    5   6   7   8   9   10   11   12   13   14   >