[GitHub] [fineract] github-actions[bot] commented on pull request #1113: Need an option to filter provisioning entries by date, Fineract-462

2020-09-18 Thread GitBox
github-actions[bot] commented on pull request #1113: URL: https://github.com/apache/fineract/pull/1113#issuecomment-695138425 This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.

[GitHub] [fineract] renovate-bot opened a new pull request #1336: Update dependency com.diffplug.spotless:spotless-plugin-gradle to v5.5.2

2020-09-18 Thread GitBox
renovate-bot opened a new pull request #1336: URL: https://github.com/apache/fineract/pull/1336 This PR contains the following updates: | Package | Update | Change | |---|---|---| | [com.diffplug.spotless:spotless-plugin-gradle](https://togithub.com/diffplug/project) | patch

[GitHub] [fineract] renovate-bot opened a new pull request #1337: Update dependency com.github.librepdf:openpdf to v1.3.21

2020-09-18 Thread GitBox
renovate-bot opened a new pull request #1337: URL: https://github.com/apache/fineract/pull/1337 This PR contains the following updates: | Package | Update | Change | |---|---|---| | [com.github.librepdf:openpdf](com/github/librepdf/openpdf) | patch | `1.3.20` -> `1.3.21` |

[GitHub] [fineract] awasum merged pull request #1334: Update dependency org.mockito:mockito-junit-jupiter to v3.5.11

2020-09-18 Thread GitBox
awasum merged pull request #1334: URL: https://github.com/apache/fineract/pull/1334 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [fineract] vorburger merged pull request #1333: Update dependency org.mockito:mockito-core to v3.5.11

2020-09-18 Thread GitBox
vorburger merged pull request #1333: URL: https://github.com/apache/fineract/pull/1333 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [fineract] vorburger commented on pull request #1335: new

2020-09-18 Thread GitBox
vorburger commented on pull request #1335: URL: https://github.com/apache/fineract/pull/1335#issuecomment-694740057 Hello @hmdrzsharifi, welcome to the Apache Fineract Community. This Pull Request is empty. What did you want to propose? We will close this PR in 1 week without hearing back

[GitHub] [fineract] hmdrzsharifi opened a new pull request #1335: new

2020-09-18 Thread GitBox
hmdrzsharifi opened a new pull request #1335: URL: https://github.com/apache/fineract/pull/1335 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] renovate-bot opened a new pull request #1333: Update dependency org.mockito:mockito-core to v3.5.11

2020-09-17 Thread GitBox
renovate-bot opened a new pull request #1333: URL: https://github.com/apache/fineract/pull/1333 This PR contains the following updates: | Package | Update | Change | |---|---|---| | [org.mockito:mockito-core](https://togithub.com/mockito/mockito) | patch | `3.5.10` -> `3.5.11`

[GitHub] [fineract] renovate-bot opened a new pull request #1334: Update dependency org.mockito:mockito-junit-jupiter to v3.5.11

2020-09-17 Thread GitBox
renovate-bot opened a new pull request #1334: URL: https://github.com/apache/fineract/pull/1334 This PR contains the following updates: | Package | Update | Change | |---|---|---| | [org.mockito:mockito-junit-jupiter](https://togithub.com/mockito/mockito) | patch | `3.5.10` ->

[GitHub] [fineract] avikganguly01 commented on a change in pull request #1330: Interop KYC and Interop Loan Disbursement

2020-09-17 Thread GitBox
avikganguly01 commented on a change in pull request #1330: URL: https://github.com/apache/fineract/pull/1330#discussion_r490098735 ## File path: fineract-provider/src/main/java/org/apache/fineract/interoperation/api/InteropApiResource.java ## @@ -373,4 +374,29 @@ public

[GitHub] [fineract] ptuomola merged pull request #1332: Update dependency org.springframework.boot:spring-boot-gradle-plugin to v2.3.4.RELEASE

2020-09-17 Thread GitBox
ptuomola merged pull request #1332: URL: https://github.com/apache/fineract/pull/1332 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [fineract] renovate-bot opened a new pull request #1332: Update dependency org.springframework.boot:spring-boot-gradle-plugin to v2.3.4.RELEASE

2020-09-17 Thread GitBox
renovate-bot opened a new pull request #1332: URL: https://github.com/apache/fineract/pull/1332 This PR contains the following updates: | Package | Update | Change | |---|---|---| | [org.springframework.boot:spring-boot-gradle-plugin](https://spring.io/projects/spring-boot)

[GitHub] [fineract] avikganguly01 commented on pull request #1330: Interop KYC and Interop Loan Disbursement

2020-09-17 Thread GitBox
avikganguly01 commented on pull request #1330: URL: https://github.com/apache/fineract/pull/1330#issuecomment-694105848 @SubhamPramanik Can you fix the checkstyle violations? This is an automated message from the Apache Git

[GitHub] [fineract] github-actions[bot] commented on pull request #1032: FINERACT-1034-encryption-infra

2020-09-16 Thread GitBox
github-actions[bot] commented on pull request #1032: URL: https://github.com/apache/fineract/pull/1032#issuecomment-693738265 This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.

[GitHub] [fineract] github-actions[bot] closed pull request #1111: FINERACT-1012:Spring Security OAuth 2.x to Spring Security 5.2.x

2020-09-16 Thread GitBox
github-actions[bot] closed pull request #: URL: https://github.com/apache/fineract/pull/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [fineract] github-actions[bot] commented on pull request #1186: FINERACT-1052 global config for Loan OverPayment

2020-09-16 Thread GitBox
github-actions[bot] commented on pull request #1186: URL: https://github.com/apache/fineract/pull/1186#issuecomment-693738249 This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.

[GitHub] [fineract] awasum merged pull request #1331: Update dependency org.flywaydb:flyway-core to v6.5.6

2020-09-16 Thread GitBox
awasum merged pull request #1331: URL: https://github.com/apache/fineract/pull/1331 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [fineract] renovate-bot opened a new pull request #1331: Update dependency org.flywaydb:flyway-core to v6.5.6

2020-09-16 Thread GitBox
renovate-bot opened a new pull request #1331: URL: https://github.com/apache/fineract/pull/1331 This PR contains the following updates: | Package | Update | Change | |---|---|---| | [org.flywaydb:flyway-core](org/flywaydb/flyway-core) | patch | `6.5.5` -> `6.5.6` | ---

[GitHub] [fineract-cn-mobile] miPlodder edited a comment on pull request #112: Feat: Add UI/Integration tests for creating group, group list and group details

2020-09-15 Thread GitBox
miPlodder edited a comment on pull request #112: URL: https://github.com/apache/fineract-cn-mobile/pull/112#issuecomment-692874209 Can you check this [link](https://github.com/apache/fineract-cn-mobile/blob/development/.travis.yml#L29) and add `./gradlew build connectedAndroidTest

[GitHub] [fineract-cn-mobile] miPlodder edited a comment on pull request #112: Feat: Add UI/Integration tests for creating group, group list and group details

2020-09-15 Thread GitBox
miPlodder edited a comment on pull request #112: URL: https://github.com/apache/fineract-cn-mobile/pull/112#issuecomment-692874209 Can you change this [link](https://github.com/apache/fineract-cn-mobile/blob/development/.travis.yml#L29) and add `./gradlew build connectedAndroidTest

[GitHub] [fineract-cn-mobile] miPlodder edited a comment on pull request #112: Feat: Add UI/Integration tests for creating group, group list and group details

2020-09-15 Thread GitBox
miPlodder edited a comment on pull request #112: URL: https://github.com/apache/fineract-cn-mobile/pull/112#issuecomment-692874209 Can you change this [link](https://github.com/apache/fineract-cn-mobile/blob/development/.travis.yml#L29) and add `./gradlew build connectedAndroidTest

[GitHub] [fineract-cn-mobile] miPlodder commented on pull request #112: Feat: Add UI/Integration tests for creating group, group list and group details

2020-09-15 Thread GitBox
miPlodder commented on pull request #112: URL: https://github.com/apache/fineract-cn-mobile/pull/112#issuecomment-692874209 Can you change this [link](https://github.com/apache/fineract-cn-mobile/blob/development/.travis.yml#L29) `./gradlew build connectedAndroidTest --stacktrace` to

[GitHub] [fineract-cn-mobile] miPlodder edited a comment on pull request #112: Feat: Add UI/Integration tests for creating group, group list and group details

2020-09-15 Thread GitBox
miPlodder edited a comment on pull request #112: URL: https://github.com/apache/fineract-cn-mobile/pull/112#issuecomment-692874209 Can you change this [link](https://github.com/apache/fineract-cn-mobile/blob/development/.travis.yml#L29) and `./gradlew build connectedAndroidTest

[GitHub] [fineract] SubhamPramanik opened a new pull request #1330: Interop KYC and Interop Loan Disbursement

2020-09-15 Thread GitBox
SubhamPramanik opened a new pull request #1330: URL: https://github.com/apache/fineract/pull/1330 ## Description Describe the changes made and why they were made. - InteropAPI to get client KYC using account ID - Interop API to disburse loan Ignore if these details are

[GitHub] [fineract] ptuomola merged pull request #1329: Update dependency org.apache.tomcat:tomcat to v9.0.38

2020-09-15 Thread GitBox
ptuomola merged pull request #1329: URL: https://github.com/apache/fineract/pull/1329 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [fineract] renovate-bot opened a new pull request #1329: Update dependency org.apache.tomcat:tomcat to v9.0.38

2020-09-15 Thread GitBox
renovate-bot opened a new pull request #1329: URL: https://github.com/apache/fineract/pull/1329 This PR contains the following updates: | Package | Update | Change | |---|---|---| | [org.apache.tomcat:tomcat](https://tomcat.apache.org/) | patch | `9.0.37` -> `9.0.38` |

[GitHub] [fineract] avikganguly01 merged pull request #1328: FINERACT-1106-rework-skip-holiday-for-first-reschedule-date

2020-09-14 Thread GitBox
avikganguly01 merged pull request #1328: URL: https://github.com/apache/fineract/pull/1328 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [fineract] avikganguly01 merged pull request #1327: FINERACT-1109-rework-with-fixed-emi

2020-09-14 Thread GitBox
avikganguly01 merged pull request #1327: URL: https://github.com/apache/fineract/pull/1327 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [fineract] fynmanoj opened a new pull request #1328: FINERACT-1106-rework-skip-holiday-for-first-reschedule-date

2020-09-13 Thread GitBox
fynmanoj opened a new pull request #1328: URL: https://github.com/apache/fineract/pull/1328 ## Description 1. Instead of throwing error for first repayment falling on a holiday, the repayment is adjusted to fall on a working day. 2. This feature can be controlled by the

[GitHub] [fineract] fynmanoj opened a new pull request #1327: FINERACT-1109-rework-with-fixed-emi

2020-09-13 Thread GitBox
fynmanoj opened a new pull request #1327: URL: https://github.com/apache/fineract/pull/1327 ## Description 1. combination of fixed EMI with interst appropriation added. 2. reschedule enabled with interest recalculation Describe the changes made and why they were made.

[GitHub] [fineract] vorburger merged pull request #1326: Update dependency com.diffplug.spotless:spotless-plugin-gradle to v5.5.1

2020-09-13 Thread GitBox
vorburger merged pull request #1326: URL: https://github.com/apache/fineract/pull/1326 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [fineract] renovate-bot opened a new pull request #1326: Update dependency com.diffplug.spotless:spotless-plugin-gradle to v5.5.1

2020-09-12 Thread GitBox
renovate-bot opened a new pull request #1326: URL: https://github.com/apache/fineract/pull/1326 This PR contains the following updates: | Package | Update | Change | |---|---|---| | [com.diffplug.spotless:spotless-plugin-gradle](https://togithub.com/diffplug/project) | patch

[GitHub] [fineract] vorburger commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API

2020-09-12 Thread GitBox
vorburger commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-691273760 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [fineract] thesmallstar commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API

2020-09-12 Thread GitBox
thesmallstar commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-691527335 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [fineract] ptuomola merged pull request #1324: Update dependency com.diffplug.spotless:spotless-plugin-gradle to v5.5.0

2020-09-12 Thread GitBox
ptuomola merged pull request #1324: URL: https://github.com/apache/fineract/pull/1324 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [fineract] vorburger merged pull request #1325: Update dependency com.puppycrawl.tools:checkstyle to v8.36.1

2020-09-12 Thread GitBox
vorburger merged pull request #1325: URL: https://github.com/apache/fineract/pull/1325 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [fineract] vorburger commented on pull request #1290: Added and Enforced AbbreviationAsWordInName Checkstyle (FINERACT-821)

2020-09-12 Thread GitBox
vorburger commented on pull request #1290: URL: https://github.com/apache/fineract/pull/1290#issuecomment-691273960 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [fineract] ptuomola merged pull request #1323: Fix SQLBuilder IAE from StaffReadPlatformServiceImpl (FINERACT-1149)

2020-09-12 Thread GitBox
ptuomola merged pull request #1323: URL: https://github.com/apache/fineract/pull/1323 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [fineract] vorburger merged pull request #1322: Update dependency org.webjars.npm:swagger-ui-dist to v3.33.0

2020-09-12 Thread GitBox
vorburger merged pull request #1322: URL: https://github.com/apache/fineract/pull/1322 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [fineract] vorburger commented on pull request #1306: FINERACT-1113 add total_recovered_derived field to LoanSummaryData object

2020-09-12 Thread GitBox
vorburger commented on pull request #1306: URL: https://github.com/apache/fineract/pull/1306#issuecomment-691354973 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [fineract] thesmallstar commented on pull request #1290: Added and Enforced AbbreviationAsWordInName Checkstyle (FINERACT-821)

2020-09-12 Thread GitBox
thesmallstar commented on pull request #1290: URL: https://github.com/apache/fineract/pull/1290#issuecomment-691527360 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [fineract] vorburger commented on pull request #1156: Fineract-1058 added support for limit,offset and orderBy in SQLbuilder

2020-09-12 Thread GitBox
vorburger commented on pull request #1156: URL: https://github.com/apache/fineract/pull/1156#issuecomment-691273639 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [fineract] ptuomola merged pull request #1324: Update dependency com.diffplug.spotless:spotless-plugin-gradle to v5.5.0

2020-09-12 Thread GitBox
ptuomola merged pull request #1324: URL: https://github.com/apache/fineract/pull/1324 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [fineract] vorburger merged pull request #1325: Update dependency com.puppycrawl.tools:checkstyle to v8.36.1

2020-09-12 Thread GitBox
vorburger merged pull request #1325: URL: https://github.com/apache/fineract/pull/1325 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [fineract] vorburger commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API

2020-09-12 Thread GitBox
vorburger commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-691273760 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [fineract] thesmallstar commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API

2020-09-12 Thread GitBox
thesmallstar commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-691527335 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [fineract] vorburger commented on pull request #1290: Added and Enforced AbbreviationAsWordInName Checkstyle (FINERACT-821)

2020-09-12 Thread GitBox
vorburger commented on pull request #1290: URL: https://github.com/apache/fineract/pull/1290#issuecomment-691273960 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [fineract] ptuomola merged pull request #1323: Fix SQLBuilder IAE from StaffReadPlatformServiceImpl (FINERACT-1149)

2020-09-12 Thread GitBox
ptuomola merged pull request #1323: URL: https://github.com/apache/fineract/pull/1323 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [fineract] vorburger merged pull request #1322: Update dependency org.webjars.npm:swagger-ui-dist to v3.33.0

2020-09-12 Thread GitBox
vorburger merged pull request #1322: URL: https://github.com/apache/fineract/pull/1322 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [fineract] vorburger commented on pull request #1306: FINERACT-1113 add total_recovered_derived field to LoanSummaryData object

2020-09-12 Thread GitBox
vorburger commented on pull request #1306: URL: https://github.com/apache/fineract/pull/1306#issuecomment-691354973 Please make sure that the Fix Version on issues for merged PRs is set (this one in FINERACT-1113 was not); else they'll miss in the Release Notes.

[GitHub] [fineract] thesmallstar commented on pull request #1290: Added and Enforced AbbreviationAsWordInName Checkstyle (FINERACT-821)

2020-09-12 Thread GitBox
thesmallstar commented on pull request #1290: URL: https://github.com/apache/fineract/pull/1290#issuecomment-691527360 @vorburger sorry for the delay, I am in between of my college mid-semester exams, I will continue working as soon as I am done with it(hopefully no sooner than 19th

[GitHub] [fineract] vorburger commented on pull request #1156: Fineract-1058 added support for limit,offset and orderBy in SQLbuilder

2020-09-12 Thread GitBox
vorburger commented on pull request #1156: URL: https://github.com/apache/fineract/pull/1156#issuecomment-691273639 @thesmallstar remind us where we are with this one? Both #1171 and #1123 (mentioned above) are merged now.

[GitHub] [fineract] ptuomola merged pull request #1324: Update dependency com.diffplug.spotless:spotless-plugin-gradle to v5.5.0

2020-09-12 Thread GitBox
ptuomola merged pull request #1324: URL: https://github.com/apache/fineract/pull/1324 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [fineract] vorburger merged pull request #1325: Update dependency com.puppycrawl.tools:checkstyle to v8.36.1

2020-09-12 Thread GitBox
vorburger merged pull request #1325: URL: https://github.com/apache/fineract/pull/1325 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [fineract] thesmallstar commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API

2020-09-12 Thread GitBox
thesmallstar commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-691527335 @vorburger sorry for the delay, I am in between of my college mid-semester exams, I will continue working as soon as I am done with it(hopefully no sooner than 19th

[GitHub] [fineract] thesmallstar commented on pull request #1290: Added and Enforced AbbreviationAsWordInName Checkstyle (FINERACT-821)

2020-09-12 Thread GitBox
thesmallstar commented on pull request #1290: URL: https://github.com/apache/fineract/pull/1290#issuecomment-691527360 @vorburger sorry for the delay, I am in between of my college mid-semester exams, I will continue working as soon as I am done with it(hopefully no sooner than 19th

[GitHub] [fineract] vorburger merged pull request #1325: Update dependency com.puppycrawl.tools:checkstyle to v8.36.1

2020-09-12 Thread GitBox
vorburger merged pull request #1325: URL: https://github.com/apache/fineract/pull/1325 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [fineract] renovate-bot opened a new pull request #1325: Update dependency com.puppycrawl.tools:checkstyle to v8.36.1

2020-09-12 Thread GitBox
renovate-bot opened a new pull request #1325: URL: https://github.com/apache/fineract/pull/1325 This PR contains the following updates: | Package | Update | Change | |---|---|---| | [com.puppycrawl.tools:checkstyle](https://checkstyle.org/)

[GitHub] [fineract] ptuomola merged pull request #1323: Fix SQLBuilder IAE from StaffReadPlatformServiceImpl (FINERACT-1149)

2020-09-11 Thread GitBox
ptuomola merged pull request #1323: URL: https://github.com/apache/fineract/pull/1323 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [fineract] vorburger commented on pull request #1306: FINERACT-1113 add total_recovered_derived field to LoanSummaryData object

2020-09-11 Thread GitBox
vorburger commented on pull request #1306: URL: https://github.com/apache/fineract/pull/1306#issuecomment-691354973 Please make sure that the Fix Version on issues for merged PRs is set (this one in FINERACT-1113 was not); else they'll miss in the Release Notes.

[GitHub] [fineract] ptuomola merged pull request #1324: Update dependency com.diffplug.spotless:spotless-plugin-gradle to v5.5.0

2020-09-11 Thread GitBox
ptuomola merged pull request #1324: URL: https://github.com/apache/fineract/pull/1324 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [fineract] renovate-bot opened a new pull request #1324: Update dependency com.diffplug.spotless:spotless-plugin-gradle to v5.5.0

2020-09-11 Thread GitBox
renovate-bot opened a new pull request #1324: URL: https://github.com/apache/fineract/pull/1324 This PR contains the following updates: | Package | Update | Change | |---|---|---| | [com.diffplug.spotless:spotless-plugin-gradle](https://togithub.com/diffplug/project) | minor

[GitHub] [fineract] vorburger commented on pull request #1290: Added and Enforced AbbreviationAsWordInName Checkstyle (FINERACT-821)

2020-09-11 Thread GitBox
vorburger commented on pull request #1290: URL: https://github.com/apache/fineract/pull/1290#issuecomment-691273960 @thesmallstar friendly ping, will you finish this one off? This is an automated message from the Apache Git

[GitHub] [fineract] vorburger commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API

2020-09-11 Thread GitBox
vorburger commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-691273760 @thesmallstar friendly ping, update? (as well as now have to rebase and fix merge conflict) This is an

[GitHub] [fineract] vorburger commented on pull request #1156: Fineract-1058 added support for limit,offset and orderBy in SQLbuilder

2020-09-11 Thread GitBox
vorburger commented on pull request #1156: URL: https://github.com/apache/fineract/pull/1156#issuecomment-691273639 @thesmallstar remind us where we are with this one? Both #1171 and #1123 (mentioned above) are merged now.

[GitHub] [fineract] vorburger opened a new pull request #1323: Fix SQLBuilder IAE from StaffReadPlatformServiceImpl (FINERACT-1149)

2020-09-11 Thread GitBox
vorburger opened a new pull request #1323: URL: https://github.com/apache/fineract/pull/1323 see FINERACT-1149 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [fineract] vorburger merged pull request #1322: Update dependency org.webjars.npm:swagger-ui-dist to v3.33.0

2020-09-11 Thread GitBox
vorburger merged pull request #1322: URL: https://github.com/apache/fineract/pull/1322 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [fineract] renovate-bot opened a new pull request #1322: Update dependency org.webjars.npm:swagger-ui-dist to v3.33.0

2020-09-11 Thread GitBox
renovate-bot opened a new pull request #1322: URL: https://github.com/apache/fineract/pull/1322 This PR contains the following updates: | Package | Update | Change | |---|---|---| | [org.webjars.npm:swagger-ui-dist](https://www.webjars.org)

[GitHub] [fineract] ptuomola merged pull request #1319: Update dependency io.github.classgraph:classgraph to v4.8.90

2020-09-09 Thread GitBox
ptuomola merged pull request #1319: URL: https://github.com/apache/fineract/pull/1319 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [fineract] renovate-bot opened a new pull request #1319: Update dependency io.github.classgraph:classgraph to v4.8.90

2020-09-09 Thread GitBox
renovate-bot opened a new pull request #1319: URL: https://github.com/apache/fineract/pull/1319 This PR contains the following updates: | Package | Update | Change | |---|---|---| | [io.github.classgraph:classgraph](https://togithub.com/classgraph/classgraph) | patch |

[GitHub] [fineract] ptuomola merged pull request #1317: Update dependency com.diffplug.spotless:spotless-plugin-gradle to v5.4.0

2020-09-09 Thread GitBox
ptuomola merged pull request #1317: URL: https://github.com/apache/fineract/pull/1317 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [fineract] ptuomola merged pull request #1318: Update dependency commons-io:commons-io to v2.8.0

2020-09-09 Thread GitBox
ptuomola merged pull request #1318: URL: https://github.com/apache/fineract/pull/1318 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [fineract] renovate-bot opened a new pull request #1318: Update dependency commons-io:commons-io to v2.8.0

2020-09-09 Thread GitBox
renovate-bot opened a new pull request #1318: URL: https://github.com/apache/fineract/pull/1318 This PR contains the following updates: | Package | Update | Change | |---|---|---| | [commons-io:commons-io](https://commons.apache.org/proper/commons-io/)

[GitHub] [fineract] renovate-bot opened a new pull request #1317: Update dependency com.diffplug.spotless:spotless-plugin-gradle to v5.4.0

2020-09-08 Thread GitBox
renovate-bot opened a new pull request #1317: URL: https://github.com/apache/fineract/pull/1317 This PR contains the following updates: | Package | Update | Change | |---|---|---| | [com.diffplug.spotless:spotless-plugin-gradle](https://togithub.com/diffplug/project) | minor

[GitHub] [fineract] thesmallstar commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API

2020-09-06 Thread GitBox
thesmallstar commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-687846652 @vorburger yup I will fix this in a day or two. @ptuomola thanks for the suggestion!! This is an

[GitHub] [fineract] vorburger commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API

2020-09-06 Thread GitBox
vorburger commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-687845780 @thesmallstar the suggestion from @ptuomola in the last comment on FINERACT-1095 to use e.g. `"loanStatus": ["all","active","overpaid"], "loanProducts":

[GitHub] [fineract] vorburger commented on pull request #1290: Added and Enforced AbbreviationAsWordInName Checkstyle (FINERACT-821)

2020-09-06 Thread GitBox
vorburger commented on pull request #1290: URL: https://github.com/apache/fineract/pull/1290#issuecomment-687845113 @thesmallstar hope you saw @ptuomola review feedback on this PR and will have remember to update it when you have a moment? Tx!

[GitHub] [fineract] vorburger merged pull request #1284: add Merge Strategy section to README

2020-09-06 Thread GitBox
vorburger merged pull request #1284: URL: https://github.com/apache/fineract/pull/1284 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [fineract] ptuomola merged pull request #1316: Update dependency org.mockito:mockito-junit-jupiter to v3.5.10

2020-09-05 Thread GitBox
ptuomola merged pull request #1316: URL: https://github.com/apache/fineract/pull/1316 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [fineract] ptuomola merged pull request #1286: Removed string concatenated SQL & sqlSearch from Staff (Fineract-854)

2020-09-05 Thread GitBox
ptuomola merged pull request #1286: URL: https://github.com/apache/fineract/pull/1286 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [fineract] thesmallstar commented on pull request #1286: Removed string concatenated SQL & sqlSearch from Staff (Fineract-854)

2020-09-05 Thread GitBox
thesmallstar commented on pull request #1286: URL: https://github.com/apache/fineract/pull/1286#issuecomment-687663016 @ptuomola updated, thanks for pointing that out. This is an automated message from the Apache Git

[GitHub] [fineract] ptuomola merged pull request #1315: Update dependency org.mockito:mockito-core to v3.5.10

2020-09-04 Thread GitBox
ptuomola merged pull request #1315: URL: https://github.com/apache/fineract/pull/1315 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [fineract] edcable merged pull request #1314: FINERACT-1141: Backport FINERACT-1135 to 1.4.0 Error at Loan Repaymen…

2020-09-04 Thread GitBox
edcable merged pull request #1314: URL: https://github.com/apache/fineract/pull/1314 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [fineract] renovate-bot opened a new pull request #1316: Update dependency org.mockito:mockito-junit-jupiter to v3.5.10

2020-09-04 Thread GitBox
renovate-bot opened a new pull request #1316: URL: https://github.com/apache/fineract/pull/1316 This PR contains the following updates: | Package | Update | Change | |---|---|---| | [org.mockito:mockito-junit-jupiter](https://togithub.com/mockito/mockito) | patch | `3.5.9` ->

[GitHub] [fineract] renovate-bot opened a new pull request #1315: Update dependency org.mockito:mockito-core to v3.5.10

2020-09-04 Thread GitBox
renovate-bot opened a new pull request #1315: URL: https://github.com/apache/fineract/pull/1315 This PR contains the following updates: | Package | Update | Change | |---|---|---| | [org.mockito:mockito-core](https://togithub.com/mockito/mockito) | patch | `3.5.9` -> `3.5.10`

[GitHub] [fineract] vidakovic commented on pull request #1314: FINERACT-1141: Backport FINERACT-1135 to 1.4.0 Error at Loan Repaymen…

2020-09-04 Thread GitBox
vidakovic commented on pull request #1314: URL: https://github.com/apache/fineract/pull/1314#issuecomment-687156084 @francisguchie thanks a ton for taking the time... @ptuomola @vorburger can one of you take over the merge please as per new rules for PR merges? Thanks again.

[GitHub] [fineract] francisguchie edited a comment on pull request #1314: FINERACT-1141: Backport FINERACT-1135 to 1.4.0 Error at Loan Repaymen…

2020-09-04 Thread GitBox
francisguchie edited a comment on pull request #1314: URL: https://github.com/apache/fineract/pull/1314#issuecomment-687150803 > @francisguchie @vorburger @ptuomola could one of you please verify this PR if you have a moment and merge it if it's ok? Thanks. @vidakovic , i have

[GitHub] [fineract] francisguchie commented on pull request #1314: FINERACT-1141: Backport FINERACT-1135 to 1.4.0 Error at Loan Repaymen…

2020-09-04 Thread GitBox
francisguchie commented on pull request #1314: URL: https://github.com/apache/fineract/pull/1314#issuecomment-687150803 > @francisguchie @vorburger @ptuomola could one of you please verify this PR if you have a moment and merge it if it's ok? Thanks. @vidakovic , i have looked at

[GitHub] [fineract] vidakovic commented on pull request #1314: FINERACT-1141: Backport FINERACT-1135 to 1.4.0 Error at Loan Repaymen…

2020-09-04 Thread GitBox
vidakovic commented on pull request #1314: URL: https://github.com/apache/fineract/pull/1314#issuecomment-687132467 @francisguchie @vorburger @ptuomola could one of you please verify this PR if you have a moment and merge it if it's ok? Thanks.

[GitHub] [fineract] ptuomola merged pull request #1306: FINERACT-1113 add total_recovered_derived field to LoanSummaryData object

2020-09-04 Thread GitBox
ptuomola merged pull request #1306: URL: https://github.com/apache/fineract/pull/1306 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [fineract] ptuomola commented on pull request #1306: FINERACT-1113 add total_recovered_derived field to LoanSummaryData object

2020-09-04 Thread GitBox
ptuomola commented on pull request #1306: URL: https://github.com/apache/fineract/pull/1306#issuecomment-687040139 @luckyman20 I was waiting for a reply to the question from @thesmallstar above... but the code looks OK to me, so happy to merge.

[GitHub] [fineract] luckyman20 commented on pull request #1306: FINERACT-1113 add total_recovered_derived field to LoanSummaryData object

2020-09-03 Thread GitBox
luckyman20 commented on pull request #1306: URL: https://github.com/apache/fineract/pull/1306#issuecomment-686879376 @vorburger @ptuomola Is it good to merge? If yes, then I think we shouldn't delay it. This is an automated

[GitHub] [fineract] vidakovic commented on pull request #1314: FINERACT-1141: Backport FINERACT-1135 to 1.4.0 Error at Loan Repaymen…

2020-09-03 Thread GitBox
vidakovic commented on pull request #1314: URL: https://github.com/apache/fineract/pull/1314#issuecomment-686305803 @francisguchie please have a look at this when you have a moment This is an automated message from the

[GitHub] [fineract] vidakovic opened a new pull request #1314: FINERACT-1141: Backport FINERACT-1135 to 1.4.0 Error at Loan Repaymen…

2020-09-03 Thread GitBox
vidakovic opened a new pull request #1314: URL: https://github.com/apache/fineract/pull/1314 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket ## Checklist Please make sure these boxes are checked

[GitHub] [fineract-cn-mobile] jawidMuhammadi commented on a change in pull request #112: Feat: Add UI/Integration tests for creating group, group list and group details

2020-09-02 Thread GitBox
jawidMuhammadi commented on a change in pull request #112: URL: https://github.com/apache/fineract-cn-mobile/pull/112#discussion_r482117099 ## File path: app/build.gradle ## @@ -173,6 +173,7 @@ dependencies { androidTestImplementation

[GitHub] [fineract-cn-mobile] miPlodder commented on a change in pull request #112: Feat: Add UI/Integration tests for creating group, group list and group details

2020-09-02 Thread GitBox
miPlodder commented on a change in pull request #112: URL: https://github.com/apache/fineract-cn-mobile/pull/112#discussion_r482052418 ## File path: app/src/androidTest/java/org/apache/fineract/ui/online/groups/grouplist/GroupListFragmentAndroidTest.kt ## @@ -0,0 +1,54 @@

[GitHub] [fineract-cn-mobile] miPlodder commented on a change in pull request #112: Feat: Add UI/Integration tests for creating group, group list and group details

2020-09-02 Thread GitBox
miPlodder commented on a change in pull request #112: URL: https://github.com/apache/fineract-cn-mobile/pull/112#discussion_r482051034 ## File path: app/src/androidTest/java/org/apache/fineract/ui/online/groups/creategroup/CreateGroupActivityAndroidTest.kt ## @@ -0,0 +1,114

[GitHub] [fineract-cn-mobile] jawidMuhammadi commented on a change in pull request #112: Feat: Add UI/Integration tests for creating group, group list and group details

2020-09-02 Thread GitBox
jawidMuhammadi commented on a change in pull request #112: URL: https://github.com/apache/fineract-cn-mobile/pull/112#discussion_r481865551 ## File path: app/build.gradle ## @@ -71,6 +71,10 @@ android { sourceCompatibility JavaVersion.VERSION_1_8

[GitHub] [fineract-cn-mobile] miPlodder edited a comment on pull request #112: Feat: Add UI/Integration tests for creating group, group list and group details

2020-09-02 Thread GitBox
miPlodder edited a comment on pull request #112: URL: https://github.com/apache/fineract-cn-mobile/pull/112#issuecomment-685368624 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [fineract-cn-mobile] jawidMuhammadi commented on a change in pull request #112: Feat: Add UI/Integration tests for creating group, group list and group details

2020-09-02 Thread GitBox
jawidMuhammadi commented on a change in pull request #112: URL: https://github.com/apache/fineract-cn-mobile/pull/112#discussion_r481849104 ## File path: app/src/androidTest/java/org/apache/fineract/ui/online/groups/creategroup/CreateGroupActivityAndroidTest.kt ## @@ -0,0

  1   2   3   4   5   6   7   8   9   10   >