percyashu commented on pull request #1006:
URL: https://github.com/apache/fineract/pull/1006#issuecomment-661250752
I think we are doing a better job @thesmallstar
This is an automated message from the Apache Git Service.
T
percyashu commented on pull request #1006:
URL: https://github.com/apache/fineract/pull/1006#issuecomment-658309025
OK @awasum I have done that
This is an automated message from the Apache Git Service.
To respond to the m
percyashu commented on pull request #1006:
URL: https://github.com/apache/fineract/pull/1006#issuecomment-654591802
Created an issue for the WHOLE_TERM case
[this](https://issues.apache.org/jira/browse/FINERACT-1080).
@awasum @ptuomola should this Pr be closed or merged while awaiting s
percyashu commented on pull request #1006:
URL: https://github.com/apache/fineract/pull/1006#issuecomment-653594619
@awasum I will fix conflict now and concerning WHOLE_TERM case as @ptuomola
point out
> Is there someone with more functional knowledge on this particular logic
that could
percyashu commented on pull request #1006:
URL: https://github.com/apache/fineract/pull/1006#issuecomment-651801774
@vorburger I have address all requested changes and am waiting for another
review @ptuomola.
This is an
percyashu commented on pull request #1006:
URL: https://github.com/apache/fineract/pull/1006#issuecomment-645214196
@ptuomola LGTY?
This is an automated message from the Apache Git Service.
To respond to the message, please l
percyashu commented on pull request #1006:
URL: https://github.com/apache/fineract/pull/1006#issuecomment-643756592
@vorburger not fully yet. Will request a review from @ptuomola when complete
This is an automated message fr
percyashu commented on pull request #1006:
URL: https://github.com/apache/fineract/pull/1006#issuecomment-642955506
thanks @ptuomola for the feedback. I will address the requested changes
This is an automated message from th
