[GitHub] [fineract] ptuomola commented on pull request #1207: FINERACT-1095 Added status parameter in Clients API

2020-08-14 Thread GitBox
ptuomola commented on pull request #1207: URL: https://github.com/apache/fineract/pull/1207#issuecomment-674332537 Looks great to me! Thanks for your work on this @thesmallstar This is an automated message from the Apache

[GitHub] [fineract] ptuomola commented on pull request #1207: FINERACT-1095 Added status parameter in Clients API

2020-08-14 Thread GitBox
ptuomola commented on pull request #1207: URL: https://github.com/apache/fineract/pull/1207#issuecomment-673975607 @thesmallstar Finally had a chance to look at this and to test it out locally. The functionality itself works as expected - great work! The only concern I have is: I

[GitHub] [fineract] ptuomola commented on pull request #1207: FINERACT-1095 Added status parameter in Clients API

2020-08-12 Thread GitBox
ptuomola commented on pull request #1207: URL: https://github.com/apache/fineract/pull/1207#issuecomment-672784854 Sorry for the delay in looking into this - have been a bit busy! Will try to look at this tonight... This is

[GitHub] [fineract] ptuomola commented on pull request #1207: FINERACT-1095 Added status parameter in Clients API

2020-08-06 Thread GitBox
ptuomola commented on pull request #1207: URL: https://github.com/apache/fineract/pull/1207#issuecomment-670306126 @thesmallstar thanks - will take a look tomorrow morning! This is an automated message from the Apache Git

[GitHub] [fineract] ptuomola commented on pull request #1207: FINERACT-1095 Added status parameter in Clients API

2020-08-04 Thread GitBox
ptuomola commented on pull request #1207: URL: https://github.com/apache/fineract/pull/1207#issuecomment-668755830 > @ptuomola I am collectively answering to your doubts here: > > 1. I am actually adding clients, so there would be some clients in the database for sure. (Check the