[GitHub] [fineract] vorburger commented on issue #525: FINERACT-700: upgrade Gradle from 2.10 to 5.2.1

2019-07-11 Thread GitBox
vorburger commented on issue #525: FINERACT-700: upgrade Gradle from 2.10 to 5.2.1 URL: https://github.com/apache/fineract/pull/525#issuecomment-510348327 Great! I'll "self merge" this PR now. This is an automated message

[GitHub] [fineract] vorburger commented on issue #525: FINERACT-700: upgrade Gradle from 2.10 to 5.2.1

2019-07-10 Thread GitBox
vorburger commented on issue #525: FINERACT-700: upgrade Gradle from 2.10 to 5.2.1 URL: https://github.com/apache/fineract/pull/525#issuecomment-510243016 The last commit I just added to this PR will, hopefully, fix the problem above; see last comment in

[GitHub] [fineract] vorburger commented on issue #525: FINERACT-700: upgrade Gradle from 2.10 to 5.2.1

2019-07-10 Thread GitBox
vorburger commented on issue #525: FINERACT-700: upgrade Gradle from 2.10 to 5.2.1 URL: https://github.com/apache/fineract/pull/525#issuecomment-510211762 @awasum it used to pass, then we merged #607, then I merged `develop` into this PR _"just to make sure"_ , and boum - somehow that

[GitHub] [fineract] vorburger commented on issue #525: FINERACT-700: upgrade Gradle from 2.10 to 5.2.1

2019-07-10 Thread GitBox
vorburger commented on issue #525: FINERACT-700: upgrade Gradle from 2.10 to 5.2.1 URL: https://github.com/apache/fineract/pull/525#issuecomment-510183386 @conradsp would you perhaps like to review/test/merge this? This is

[GitHub] [fineract] vorburger commented on issue #525: FINERACT-700: upgrade Gradle from 2.10 to 5.2.1

2019-07-09 Thread GitBox
vorburger commented on issue #525: FINERACT-700: upgrade Gradle from 2.10 to 5.2.1 URL: https://github.com/apache/fineract/pull/525#issuecomment-509799632 > All checks have passed (1 successful check) > continuous-integration/travis-ci/pr — The Travis CI build passed Yay! Party

[GitHub] [fineract] vorburger commented on issue #525: FINERACT-700: upgrade Gradle from 2.10 to 5.2.1

2019-07-09 Thread GitBox
vorburger commented on issue #525: FINERACT-700: upgrade Gradle from 2.10 to 5.2.1 URL: https://github.com/apache/fineract/pull/525#issuecomment-509776986 > We'll see on Travis, but for me locally it still does not work, but due to what I think is a new and (finger crossed) other problem,

[GitHub] [fineract] vorburger commented on issue #525: FINERACT-700: upgrade Gradle from 2.10 to 5.2.1

2019-07-09 Thread GitBox
vorburger commented on issue #525: FINERACT-700: upgrade Gradle from 2.10 to 5.2.1 URL: https://github.com/apache/fineract/pull/525#issuecomment-509538390 I've just rebased this on latest `develop`, and resolved conflicts with recently merged changes. As before, `./gradlew

[GitHub] [fineract] vorburger commented on issue #525: FINERACT-700: upgrade Gradle from 2.10 to 5.2.1

2019-07-04 Thread GitBox
vorburger commented on issue #525: FINERACT-700: upgrade Gradle from 2.10 to 5.2.1 URL: https://github.com/apache/fineract/pull/525#issuecomment-508405755 I suggest that we ignore the entire Flyway related discussion (above, in previous inline review discussions), I think I actually got

[GitHub] [fineract] vorburger commented on issue #525: FINERACT-700: upgrade Gradle from 2.10 to 5.2.1

2019-06-13 Thread GitBox
vorburger commented on issue #525: FINERACT-700: upgrade Gradle from 2.10 to 5.2.1 URL: https://github.com/apache/fineract/pull/525#issuecomment-501922674 I've made further progress on this, and now almost works, except `./gradlew integrationTest` fails to start Tomact... one possible

[GitHub] [fineract] vorburger commented on issue #525: FINERACT-700: upgrade Gradle from 2.10 to 5.2.1

2019-06-12 Thread GitBox
vorburger commented on issue #525: FINERACT-700: upgrade Gradle from 2.10 to 5.2.1 URL: https://github.com/apache/fineract/pull/525#issuecomment-501171690 I've just rebased this on the current `develop`, and resolved the conflict it had in `fineract-provider/dependencies.gradle`; my main

[GitHub] [fineract] vorburger commented on issue #525: FINERACT-700: upgrade Gradle from 2.10 to 5.2.1

2019-03-14 Thread GitBox
vorburger commented on issue #525: FINERACT-700: upgrade Gradle from 2.10 to 5.2.1 URL: https://github.com/apache/fineract/pull/525#issuecomment-473079478 Ah yes, didn't realize that, good point worth checking out more... (I wonder how other Java projects at Apache.org use MariaDB, or