This is an automated email from the ASF dual-hosted git repository.
rajanmaurya154 pushed a commit to branch development
in repository https://gitbox.apache.org/repos/asf/fineract-cn-mobile.git
The following commit(s) were added to refs/heads/development by this push:
new 3011644 style: removed hard_coaded strings
3011644 is described below
commit 3011644fa9ccbb99df3611955e5e5996d4f94479
Author: abhijitramesh <abhijitrames...@gmail.com>
AuthorDate: Wed Jan 16 18:42:27 2019 +0530
style: removed hard_coaded strings
---
app/src/main/java/org/apache/fineract/ui/base/Toaster.java | 3 ++-
.../loanaccounts/loandetails/CustomerLoanDetailsFragment.java | 2 +-
app/src/main/res/layout/fragment_loan_document.xml | 6 +++---
app/src/main/res/menu/menu_navigation_drawer.xml | 2 +-
app/src/main/res/values/strings.xml | 5 +++++
5 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/app/src/main/java/org/apache/fineract/ui/base/Toaster.java
b/app/src/main/java/org/apache/fineract/ui/base/Toaster.java
index 611057f..ebff14b 100644
--- a/app/src/main/java/org/apache/fineract/ui/base/Toaster.java
+++ b/app/src/main/java/org/apache/fineract/ui/base/Toaster.java
@@ -7,6 +7,7 @@ import android.view.View;
import android.widget.TextView;
import org.apache.fineract.FineractApplication;
+import org.apache.fineract.R;
public class Toaster {
@@ -25,7 +26,7 @@ public class Toaster {
.snackbar_text);
textView.setTextColor(Color.WHITE);
textView.setTextSize(12);
- snackbar.setAction("OK", new View.OnClickListener() {
+ snackbar.setAction(R.string.OK, new View.OnClickListener() {
@Override
public void onClick(View view) {
snackbar.dismiss();
diff --git
a/app/src/main/java/org/apache/fineract/ui/online/loanaccounts/loandetails/CustomerLoanDetailsFragment.java
b/app/src/main/java/org/apache/fineract/ui/online/loanaccounts/loandetails/CustomerLoanDetailsFragment.java
index bd4f291..97bdcd1 100644
---
a/app/src/main/java/org/apache/fineract/ui/online/loanaccounts/loandetails/CustomerLoanDetailsFragment.java
+++
b/app/src/main/java/org/apache/fineract/ui/online/loanaccounts/loandetails/CustomerLoanDetailsFragment.java
@@ -272,7 +272,7 @@ public class CustomerLoanDetailsFragment extends
FineractBaseFragment implements
public boolean onOptionsItemSelected(MenuItem item) {
switch (item.getItemId()) {
case R.id.menu_loan_account_edit:
- Toaster.show(rootView, "Under construction");
+ Toaster.show(rootView, R.string.Under_construction);
return true;
default:
return super.onOptionsItemSelected(item);
diff --git a/app/src/main/res/layout/fragment_loan_document.xml
b/app/src/main/res/layout/fragment_loan_document.xml
index 6a901fc..485b18e 100644
--- a/app/src/main/res/layout/fragment_loan_document.xml
+++ b/app/src/main/res/layout/fragment_loan_document.xml
@@ -54,13 +54,13 @@
android:layout_marginStart="@dimen/layout_padding_16dp"
android:layout_marginTop="@dimen/layout_padding_16dp"
android:layout_width="wrap_content"
- android:text="Documents(Total: 0)"/>
+ android:text="@string/Documents"/>
<Button
android:layout_alignParentRight="true"
android:layout_height="match_parent"
android:layout_width="wrap_content"
- android:text="Add Document"
+ android:text="@string/add_document"
android:textAllCaps="false"
android:textSize="12sp"/>
@@ -81,7 +81,7 @@
android:layout_height="wrap_content"
android:layout_width="wrap_content"
android:padding="@dimen/layout_padding_24dp"
- android:text="No documents to show. add documents"
+
android:text="@string/no_documents_to_show_add_documents"
android:textSize="@dimen/text_small"
android:visibility="visible"/>
diff --git a/app/src/main/res/menu/menu_navigation_drawer.xml
b/app/src/main/res/menu/menu_navigation_drawer.xml
index d32c652..6b9b605 100644
--- a/app/src/main/res/menu/menu_navigation_drawer.xml
+++ b/app/src/main/res/menu/menu_navigation_drawer.xml
@@ -27,7 +27,7 @@
android:checked="true"
android:icon="@drawable/ic_customer_black_24dp"
android:id="@+id/item_customer_payload"
- android:title="Customer Payloads"/>
+ android:title="@string/customer_payloads"/>
<item
android:checked="true"
diff --git a/app/src/main/res/values/strings.xml
b/app/src/main/res/values/strings.xml
index 034ec59..dc99a36 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -457,4 +457,9 @@
<!-- TODO: Remove or change this placeholder text -->
<string name="hello_blank_fragment">Hello blank fragment</string>
+ <string name="Under_construction">Under construction</string>
+ <string name="OK">OK</string>
+ <string name="Documents">Documents(Total: 0)</string>
+ <string name="no_documents_to_show_add_documents">No documents to show.
add documents</string>
+ <string name="customer_payloads">Customer Payloads</string>
</resources>
