Re: [19/23] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35328 - Update MDLExample with DataFieldProviderBead

2020-01-28 Thread Alex Harui
Ran into this while doing the has/is refactor. In what ways is this different than the labelField in IDataProviderModel? Thanks, -Alex On 6/29/17, 12:22 PM, "pio...@apache.org" wrote: FLEX-35328 - Update MDLExample with DataFieldProviderBead Project:

Test from unsubscribed user. Please reject if moderated

2019-03-25 Thread Alex Harui
This is a test to commits@ from an unsubscribed user. Please reject if moderated.

Re: [8/8] flex-asjs git commit: stopPropogation on the goog BrowserEvent is needed. I don’t know if the stopImmediatePropagation on the real browser event actually does anything and I don’t know how t

2017-07-20 Thread Alex Harui
To test, wouldn't you just add multiple listeners to the element and the wrapper? HTH, -Alex On 7/20/17, 12:05 AM, "ha...@apache.org" wrote: >stopPropogation on the goog BrowserEvent is needed. >I don???t know if the stopImmediatePropagation on the real browser event

Re: [2/5] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35338 stop cursor from spinning / CPU from spiking

2017-07-11 Thread Alex Harui
This seems like "just-in-case" code. I could see that it might be needed in a different bead for Express though. Without this change, is there an infinite loop somewhere? Thanks, -Alex On 7/10/17, 10:40 PM, "jmcl...@apache.org" wrote: >FLEX-35338 stop cursor from spinning

Re: git commit: [flex-asjs] [refs/heads/develop] - Fix merge error removing support for numeric font size.

2017-06-29 Thread Alex Harui
That's not a merge error. That code is now in AllCSSValuesImpl and is not needed in SimpleCSSValuesImpl. Please follow the commits. Thanks, -Alex On 6/28/17, 11:20 PM, "jmcl...@apache.org" wrote: >Repository: flex-asjs >Updated Branches: > refs/heads/develop 18992c5fd ->

Re: git commit: [flex-asjs] [refs/heads/tlf] - Added callLater

2017-06-18 Thread Alex Harui
FWIW, There is already a CallLaterBead. -Alex On 6/18/17, 3:34 AM, "ha...@apache.org" wrote: >Repository: flex-asjs >Updated Branches: > refs/heads/tlf 914e666c7 -> 06f47590c > > >Added callLater > > >Project:

Re: [2/4] git commit: [flex-asjs] [refs/heads/develop] - LayoutBase Fix for strand set to null in remove bead, plus performance improvements in js

2017-06-09 Thread Alex Harui
I guess I don't believe that removing beads is so common that every app needs to carry this code around. I wonder if there is a way to inject removability as needed. Having a RemovableXXXLayout could override the strand setter and remove listeners if the handlers are protected. Thoughts? -Alex

Re: git commit: [flex-asjs] [refs/heads/feature/chart-work] - Method getElementAt should return null if element not exists on JS sight

2017-04-17 Thread Alex Harui
Hi Piotr, I'm wondering why some other code called getElementAt with an invalid index. Do we really need defensive code like this? Thanks, -Alex On 4/2/17, 1:54 PM, "pio...@apache.org" wrote: >Repository: flex-asjs >Updated Branches: > refs/heads/feature/chart-work

Re: [4/6] git commit: [flex-asjs] [refs/heads/develop] - replace existing format bead if it exists

2017-04-16 Thread Alex Harui
Hi Justin, What is the scenario where everybody will need this code? -Alex On 4/16/17, 9:24 PM, "jmcl...@apache.org" wrote: >replace existing format bead if it exists > > >Project: >https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us

Re: git commit: [flex-asjs] [refs/heads/develop] - CORS security. Allow auth credentials to be passed when using cross site calls. This is required as well as setting the Access-Control-Allow-Origin h

2017-04-08 Thread Alex Harui
IMO, with PAYG, this would go in an extension of HTTPService. Not all apps will need CORS. Thanks, -Alex On 4/8/17, 8:26 PM, "jmcl...@apache.org" wrote: >Repository: flex-asjs >Updated Branches: > refs/heads/develop 11ef21aae -> 326d69791 > > >CORS security. Allow auth

Re: git commit: [flex-falcon] [refs/heads/develop] - MXMLFlexJSEmitter: source maps for MXML event attributes

2017-03-23 Thread Alex Harui
Josh, Try running: ant flexjs.dependent.tests If the output has changed you may have to update some of the _results.js files. Thanks, -Alex On 3/23/17, 3:43 PM, "joshtynj...@apache.org" wrote: >Repository: flex-falcon >Updated Branches: > refs/heads/develop

Re: git commit: [flex-asjs] [refs/heads/develop] - FLEX-34414 - Add missing Apache headers

2017-03-14 Thread Alex Harui
Hi Piotr, Do JSON files accept comments? I thought not. Anyway, this file can actually be deleted now. We no longer use jshint. Thanks, -Alex On 3/14/17, 1:51 PM, "pio...@apache.org" wrote: >Repository: flex-asjs >Updated Branches: > refs/heads/develop cb67c4173 ->

Re: git commit: [flex-asjs] [refs/heads/develop] - Added Shader files (with compiler argument)

2017-03-07 Thread Alex Harui
Hi, Is it possible to use the upstream release instead? Even the flex-sdk uses pbj files from the upstream. IIRC, we did that because not everyone wanted to deal with installing the PB compiler. Thanks, -Alex On 3/7/17, 2:25 AM, "ha...@apache.org" wrote: >Repository:

Re: git commit: [flex-asjs] [refs/heads/develop] - Add JS support for non pixel numeric properties ie fontWeight

2017-03-04 Thread Alex Harui
Hi Justin, Again, with PAYG, we want SimpleCSSStylesImpl to be simple and we want the SWF side to remain at parity. This sort of thing is better placed in a NotSoSimpleCSSStylesImpl. Thanks, -Alex On 3/4/17, 5:54 PM, "jmcl...@apache.org" wrote: >Repository: flex-asjs

Re: [1/2] git commit: [flex-asjs] [refs/heads/develop] - Remove css prefixing whitespaces in UIBase when value is empty

2017-02-06 Thread Alex Harui
I just noticed this. What does it mean "value is empty"? Trim() can be really expensive, so should this code just test for value is empty and do something else? Thanks, -Alex On 1/3/17, 10:39 AM, "carlosrov...@apache.org" wrote: >Repository: flex-asjs >Updated

Re: [MAVEN-BUILD] FlexJS Framework (maven) - Build # 533 - Failure

2016-12-18 Thread Alex Harui
Yep. I've asked Chris for help. The console output ends with: [INFO] Apache Flex - FlexJS: Distribution . FAILURE [ 14.965 s] [INFO] [INFO] BUILD FAILURE [INFO]

Re: git commit: [flex-asjs] [refs/heads/develop] - Fix for bug FLEX-35201: TileLayout not working. Fixed the JS side by having it use flex-box display.

2016-12-07 Thread Alex Harui
Hmm. In my mind, TileLayout is different from flex-box. For a display of a month of a calendar, with fixed sizes on the day labels, if I set the width of the container to be something really wide, if I have set numColumns=7, I would expect that there would be 7 days displayed with lots of

Re: git commit: [flex-asjs] [refs/heads/develop] - FLEX-35187 - explicitly set default border to none, so viewports can ignore non-existent borders.

2016-11-29 Thread Alex Harui
ows: > > > >if (borderStyle == "none") > > > >was not met. > > > > > >Anyway, I just built FlexJSStore and the layout looks ok to me. I had to >manually copy the assets folder to see the pngs. > > > > > > > > >

Re: git commit: [flex-asjs] [refs/heads/develop] - FLEX-35187 - explicitly set default border to none, so viewports can ignore non-existent borders.

2016-11-28 Thread Alex Harui
Are you sure this did not impact any examples? -Alex On 11/28/16, 6:45 AM, "yish...@apache.org" wrote: >Repository: flex-asjs >Updated Branches: > refs/heads/develop 1ae995db3 -> d159d7ed1 > > >FLEX-35187 - explicitly set default border to none, so viewports can >ignore

Re: flex-typedefs git commit: add goog.DEBUG for debug-only code

2016-11-21 Thread Alex Harui
On 11/21/16, 12:01 PM, "Peter Ent" wrote: >What are the requirements for getting flex-asjs to compile with >goog.DEBUG? Is there a new version of google closure required or an >environment var to be set? Did you pull the latest from flex-typedefs repo and build it? -Alex

Re: git commit: [flex-asjs] [refs/heads/develop] - HTML now depends on Effects, so order is changed.

2016-11-16 Thread Alex Harui
Hi Yishay, Why should HTML components be dependent on Effects? IMO, basic components should not presume the existence of any effects/animation subsystem. In theory, HTML components might dispatch events that beads can watch and run effects if requested. -Alex On 11/16/16, 2:20 AM,

Re: git commit: [flex-asjs] [refs/heads/develop] - Add easing effect to accordion.

2016-11-16 Thread Alex Harui
On 11/15/16, 11:58 PM, "yish...@apache.org" wrote: > override public function addedToParent():void > { > super.addedToParent(); >+ accordionCollapseBead; // make sure it's initialized >

Re: [1/2] git commit: [flex-asjs] [refs/heads/develop] - Accordion added.

2016-11-15 Thread Alex Harui
Hey Yishay, Maven build does header checks and is failing on missing Apache headers on some of these new files. -Alex On 11/15/16, 12:24 AM, "yish...@apache.org" wrote: >Repository: flex-asjs >Updated Branches: > refs/heads/develop c9d3c3de0 -> 9834f8e3c > > >Accordion

Re: [2/4] git commit: [flex-asjs] [refs/heads/refactor-sprite] - Check for illegal color values

2016-10-26 Thread Alex Harui
On 10/26/16, 8:53 AM, "yish...@apache.org" wrote: > >http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/24c2fdfa/frameworks/ >projects/Core/src/main/flex/org/apache/flex/utils/CSSUtils.as >-- >diff --git

Re: [2/4] git commit: [flex-sdk] [refs/heads/develop] - FLEX-35126 Added a unit test to reprouce the bug. Currently it passes, as expected. (But if I manually put back the fix for FLEX-34088, it fails

2016-09-28 Thread Alex Harui
Mihai, The http://apacheflexbuild.cloudapp.net:8080/job/flex-sdk_test/ job keeps hanging on this new test. I have disabled the job. Please investigate and re-enable the job when things are working again. Thanks, -Alex On 9/19/16, 4:36 AM, "mih...@apache.org" wrote:

Re: Jenkins build is back to normal : flex-asjs #1413

2016-09-12 Thread Alex Harui
FWIW, prior builds were failing because Selenium didn't work with the latest FireFox. I upgraded to the latest Selenium and it still didn't work. Downgrading FF to 45.0 does work. I've disabled updates for now. Thanks, -Alex On 9/11/16, 10:16 PM, "flex.ci.bui...@gmail.com"

Re: git commit: [flex-falcon] [refs/heads/develop] - compiler-jx: Class class must be dynamic, added hasFunction() to ReferenceModel in externc, and added some tests for Class, int, uint, and trace()

2016-08-22 Thread Alex Harui
Is this intended for the 0.7.0 release? If so, it needs to go in the release0.7.0 branch. -Alex On 8/22/16, 3:54 PM, "joshtynj...@apache.org" wrote: >Repository: flex-falcon >Updated Branches: > refs/heads/develop f8fa738fb -> 2f6f611b1 > > >compiler-jx: Class class

Re: git commit: [flex-asjs] [refs/heads/refactor-sprite] - Allow classes that don't implement IChild to have a $displayObject, and other changes to make drag work in flash.

2016-08-11 Thread Alex Harui
Hi Yishay, Can you explain why IRenderedObject was needed? Thanks, -Alex On 8/11/16, 5:01 AM, "yish...@apache.org" wrote: >Repository: flex-asjs >Updated Branches: > refs/heads/refactor-sprite 4558126d0 -> 971cdf3d1 > > >Allow classes that don't implement IChild to have a

Re: AW: git commit: [flex-falcon] [refs/heads/featue/flexjs-ant-tasks] - fix FB integration when stringifying certain errors

2016-07-15 Thread Alex Harui
//git-wip-us.apache.org/repos/asf/flex-falcon/commit/a180e1e0 Tree: http://git-wip-us.apache.org/repos/asf/flex-falcon/tree/a180e1e0 Diff: http://git-wip-us.apache.org/repos/asf/flex-falcon/diff/a180e1e0 Branch: refs/heads/featue/flexjs-ant-tasks Commit: a180e1e07f9c917948a467ed86d0ce2c294dc126

Re: git commit: [flex-asjs] [refs/heads/develop] - - Bumped the version from 0.6.0-SNAPSHOT to 0.7.0-SNAPSHOT - Fixed the node extern build - Resolved some of the blocker sonarqube findings

2016-05-09 Thread Alex Harui
Chris, Looks like there was more than pom.xml changes which are breaking the build. Can you revert changes to the .as files? Thanks, -Alex On 5/7/16, 8:14 AM, "cd...@apache.org" wrote: >Repository: flex-asjs >Updated Branches: > refs/heads/develop 1149ba78c -> d26cf8091 >

Re: [2/7] git commit: [flex-sdk] [refs/heads/develop] - FLEX-35031 -Since I'm planning to use ObjectUtil.isDynamicObject() in the fix, I wanted to unit test it. -Also, I introduced a new function in O

2016-02-17 Thread Alex Harui
Looks like some nice new capabilities for ArrayUtil and ObjectUtil. Did you rule out using describeType for isDynamicObject? I know it is slow, but it should always be right. What should isDynamicObject return for XML, Proxy and ObjectProxy? Thanks, -Alex On 2/17/16, 8:00 AM,

Re: [4/5] git commit: [flex-falcon] [refs/heads/develop] - compiler.jx: added support for functions and variables in packages, and functions and variables after package (similar to internal classes)

2016-01-12 Thread Alex Harui
I haven't done thorough research, but I think this change is causing the last remaining failure in the Falcon build. The failing case is org.apache.flex.compiler.internal.codegen.js.vf2js.TestVF2JSFile.testVersio n in compiler.jx.tests. The test case is dealing with an variable defined in an

Re: flex-sdk_mustella - Build # 1694 - Fixed!

2015-12-18 Thread Alex Harui
these tests for now, or just live with the fact that they will fail the mustella run when we cycle around to using FP 18 and FP 19. So, I declare that Mustella is passing all tests and we are good to ship 4.15.0. I'm going back to FlexJS stuff now. -Alex On 12/17/15, 1:51 PM, "Alex Harui&

Re: flex-sdk_mustella - Build # 1689 - Still Failing!

2015-12-15 Thread Alex Harui
Hey look! The charts tests passed! Not sure why there are layout3D failures. I've performed the magic incantation on the mustella server so we'll see if that helps. -Alex On 12/15/15, 8:36 AM, "flex.muste...@gmail.com" wrote: >flex-sdk_mustella - Build # 1689 -

Merging

2015-12-14 Thread Alex Harui
Hi, I think flex-asjs has never had the master branch updated, so I am going to do that shortly. Apologies in advance for the tons of commits emails that I think will ensue. We are also almost ready to merge the back port branch into develop. Probably not today, but I hope early this week.

Re: git commit: [flex-sdk] [refs/heads/develop] - This closes #37

2015-11-18 Thread Alex Harui
Did this patch actually get tested to prove it solves the issue? The exception stack trace starts with: Error: Error #3200: Cannot perform operation on closed window. at Error$/throwError() at flash.display::NativeWindow/get minSize() ... Which makes me think that even the test of checking

Re: Build failed in Jenkins: flex-sdk #884

2015-10-21 Thread Alex Harui
Mihai, can you fix the build? It looks like an import statement got deleted. -Alex On 10/21/15, 8:49 AM, "flex.ci.bui...@gmail.com" wrote: >See > >Changes: > >[Mihai Chira] FLEX-34945 > >[Mihai

Re: Build failed in Jenkins: flex-sdk #884

2015-10-21 Thread Alex Harui
Nevermind, I pushed a fix. On 10/21/15, 11:35 AM, "Alex Harui" <aha...@adobe.com> wrote: >Mihai, can you fix the build? It looks like an import statement got >deleted. > >-Alex > >On 10/21/15, 8:49 AM, "flex.ci.bui...@gmail.com" >

Re: git commit: [flex-sdk] [refs/heads/develop] - Fix for https://issues.apache.org/jira/browse/FLEX-34909 (Embedded fonts not working on charts)

2015-09-09 Thread Alex Harui
Well, ok, but I was expecting that the fix would support Spark Label properly throughout the Chart code. -Alex On 9/9/15, 6:03 PM, "bigosma...@apache.org" wrote: >Repository: flex-sdk >Updated Branches: > refs/heads/develop 0b3a613ff -> 636859085 > > >Fix for

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34854 FLEX-34884 Adding unit test to make sure that the changes in FLEX-34854 haven't changed anything about findItem.

2015-07-16 Thread Alex Harui
Hi Mihai, We have seen mustella test failures that appear to be related to your changes. Can you take a look? [java] = [java] Failed: [java] = [java]

Re: [2/2] git commit: [flex-utilities] [refs/heads/develop] - moved new items to below header

2015-06-18 Thread Alex Harui
Justin, The “header” says Your use of the source code” but we are not bundling the source code for these differences in the binary license. Or maybe it is too early in the morning for me. -Alex On 6/18/15, 2:20 AM, jmcl...@apache.org jmcl...@apache.org wrote: moved new items to below header

Re: [1/2] git commit: [flex-utilities] [refs/heads/develop] - Changed year to be range as per http://www.apache.org/dev/licensing-howto.html#simple

2015-06-18 Thread Alex Harui
IMO, I don’t think you are supposed to use square brackets around the years. I think that’s just their symbol for replaceable text. On 6/18/15, 2:20 AM, jmcl...@apache.org jmcl...@apache.org wrote: Repository: flex-utilities Updated Branches: refs/heads/develop ce6849c3c - 0d7044548 Changed

Re: [2/2] git commit: [flex-falcon] [refs/heads/IDEA-FLEX_JS_COMPILER] - FLEX-34860 : Updated the Ant files

2015-05-27 Thread Alex Harui
These look fine for now. I want to avoid a dependency on the SDK’s swfutils because it has a dependency on Batik that we’ve hacked with some non-standard modifications. As I continue to try to get FDB to work without the SDK’s swfutils, I am basically copying more and more files from swfutils

Re: flex-sdk_mustella-mobile - Build # 1217 - Still Failing!

2015-03-05 Thread Alex Harui
I ran the SkinnablePopUpContainer folder. I got one bitmap compare failure, but no timeouts. On 3/5/15, 7:16 AM, Erik de Bruin e...@ixsoftware.nl wrote: Can someone with a properly set up Windows environment check if this test passes? Thanks, EdB On Thu, Mar 5, 2015 at 12:38 PM,

Re: flex-sdk_mustella-mobile - Build # 1217 - Still Failing!

2015-03-05 Thread Alex Harui
to consistently fail (as the only one) on the VM... EdB On Thu, Mar 5, 2015 at 6:19 PM, Alex Harui aha...@adobe.com wrote: I ran the SkinnablePopUpContainer folder. I got one bitmap compare failure, but no timeouts. On 3/5/15, 7:16 AM, Erik de Bruin e...@ixsoftware.nl wrote: Can someone

Re: Build failed in Jenkins: flex-tlf #367

2015-03-04 Thread Alex Harui
I think I saw that these tests generate a ton of trace statements. Commenting out those trace statements might be a better solution. -Alex From: Piotr Zarzycki piotrzarzyck...@gmail.commailto:piotrzarzyck...@gmail.com Reply-To: d...@flex.apache.orgmailto:d...@flex.apache.org

Re: git commit: [flex-sdk] [refs/heads/develop] - Falcon caught a duplicate variable

2015-03-02 Thread Alex Harui
/develop Commit: 3c40976eb0b3a73d2bb7180cc22400917f719fc4 Parents: ca32871 Author: Alex Harui aha...@apache.org Authored: Sat Feb 28 23:03:24 2015 -0800 Committer: Alex Harui aha...@apache.org Committed: Sat Feb 28 23:03:24 2015 -0800

Re: Build failed in Jenkins: flex-tlf #326

2015-02-02 Thread Alex Harui
Anybody know how to get the GeneralFunctionTests to run first? When I run the tests in the debugger they are not running first. Thanks, -Alex On 2/1/15, 10:54 PM, flex.ci.bui...@gmail.com flex.ci.bui...@gmail.com wrote: See http://apacheflexbuild.cloudapp.net:8080/job/flex-tlf/326/

Re: Build failed in Jenkins: flex-tlf #326

2015-02-02 Thread Alex Harui
but maybe I don’t know how to get it to work. From: Piotr Zarzycki piotrzarzyck...@gmail.commailto:piotrzarzyck...@gmail.com Date: Monday, February 2, 2015 at 7:11 AM To: Alex Harui aha...@adobe.commailto:aha...@adobe.com Cc: d...@flex.apache.orgmailto:d...@flex.apache.org d

Re: Build failed in Jenkins: flex-tlf #322

2015-01-30 Thread Alex Harui
I’m going to disable this job for the next hour or two and try to debug the test on the CI server over RDP On 1/29/15, 10:55 PM, flex.ci.bui...@gmail.com flex.ci.bui...@gmail.com wrote: See http://apacheflexbuild.cloudapp.net:8080/job/flex-tlf/322/ --

Re: Build failed in Jenkins: flex-tlf #322

2015-01-30 Thread Alex Harui
of computedFormat.blockProgression? -Alex On 1/30/15, 10:03 PM, Alex Harui aha...@adobe.com wrote: I’m going to disable this job for the next hour or two and try to debug the test on the CI server over RDP On 1/29/15, 10:55 PM, flex.ci.bui...@gmail.com flex.ci.bui...@gmail.com wrote: See http

Re: git commit: [flex-sdk] [refs/heads/release4.14.0] - Changed FlatSpark property to maintain proportions' name to 'fixedAspectRatio'

2014-12-19 Thread Alex Harui
You don’t have to make this change, but I just wanted to point out that SWFLoader has a property called ‘maintainAspectRatio’. Is this roughly the same thing? -Alex On 12/19/14, 2:04 AM, aka...@apache.org aka...@apache.org wrote: Repository: flex-sdk Updated Branches:

Re: Build failed in Jenkins: flex-sdk #446

2014-11-21 Thread Alex Harui
Looking into the failure. On 11/21/14, 3:35 AM, flex.ci.bui...@gmail.com flex.ci.bui...@gmail.com wrote: See http://apacheflexbuild.cloudapp.net:8080/job/flex-sdk/446/changes Changes: [erik] Added bug fix -- [...truncated 1871 lines...] main: tool:

Re: Build failed in Jenkins: MD5Checker #1010

2014-11-21 Thread Alex Harui
The last modified dates we’ve been using for cache ids have become unstable for AIR SDKs. I’m going to try using the Etag header instead. On 11/21/14, 10:40 AM, flex.ci.bui...@gmail.com flex.ci.bui...@gmail.com wrote: See http://apacheflexbuild.cloudapp.net:8080/job/MD5Checker/1010/

Re: flex-sdk_mustella - Build # 1166 - Failure!

2014-11-20 Thread Alex Harui
Just checked in a fix On 11/20/14, 6:15 PM, flex.muste...@gmail.com flex.muste...@gmail.com wrote: flex-sdk_mustella - Build # 1166 - Failure: http://flex-mustella.cloudapp.net/job/flex-sdk_mustella/1166/ Changes for Build #1166 [aharui] FLEX-34454 don't assume first modal has the blur

Re: git commit: [flex-utilities] [refs/heads/develop] - fix up a few spelling errors and the like

2014-11-14 Thread Alex Harui
I don’t think we agreed to use international English, so utilize should have a ‘z’. -You can always checkout the latest source via git using the following -command: +You can always checkout the latest source from Apache's source control repository +using the following commands:

Re: git commit: [flex-sdk] [refs/heads/feature/flex-tool-api] - Changed the tool classes to implement the flex-tool-api interfaces

2014-11-10 Thread Alex Harui
On 11/10/14, 1:16 AM, cd...@apache.org cd...@apache.org wrote: +target name=flex-tool-api-jar depends=flex-tool-api-jar-check unless=flexToolApi.jar.exists +description=Downloads and copies flex-tool-api.jar to the lib directory. + +get

Re: git commit: [flex-sdk] [refs/heads/develop] - Final adjustments for FlatSpark integration

2014-10-26 Thread Alex Harui
Hi Mahmoud, Actually, we don’t need a LICENSE.txt file in the FlatSpark folder because it will be packaged with the entire SDK in the next release. So all you needed to do was add the OFL entries for the fonts to the LICENSE file at the top of the flex-sdk repo. Thanks, and sorry of I wasn’t

Re: [3/3] git commit: [flex-sdk] [refs/heads/develop] - Increment and counterpart don't work with FlexJS '_get()' and '_set()'

2014-10-24 Thread Alex Harui
Is the plan to fix this in FalconJX so these kinds of changes aren’t necessary? -Alex On 10/24/14, 4:28 AM, erikdebr...@apache.org erikdebr...@apache.org wrote: Increment and counterpart don't work with FlexJS '_get()' and '_set()' In FlexJS, all properties are converted to a set of methods,

Re: git commit: [flex-utilities] [refs/heads/develop] - FLEX-34605 cleanup

2014-10-24 Thread Alex Harui
On 10/24/14, 9:56 PM, jmcl...@apache.org jmcl...@apache.org wrote: -import AntClasses; AntClasses; +import AntClasses; This one worries me. I should have left a comment on it, but the second “AntClasses” force-links all of the ant task handlers into the app. I’m not sure I’ve

Re: flex-sdk_mustella - Build # 1116 - Still Failing!

2014-10-22 Thread Alex Harui
So I poked into this a bit more. The failing bitmap has a smaller height than the reference/baseline bitmap (566 vs 600). I took a failing SWF from flex-mustella and ran it on my Windows machine and everything passed. So, the question is, why does the same SWF on flex-mustella think the

Re: flex-sdk_mustella - Build # 1117 - Still Failing!

2014-10-22 Thread Alex Harui
Good question. Around 3 hours ago I logged into flex-mustella and played around with the position that the FlashPlayer window shows up at. It keeps moving around, but I grabbed the title bar a few times and dragged it up to the top. Was that before the tests that were failing normally run?

Re: Build failed in Jenkins: flex-tlf #155

2014-10-20 Thread Alex Harui
Changes: [Alex Harui] try even more PermGen -- Started by timer Building remotely on flex_sdk_slave2 in workspace http://apacheflexbuild.cloudapp.net:8080/job/flex-tlf/ws/ No JDK named ‘(Default)’ found Fetching changes from the remote Git repository Fetching

Re: git commit: [flex-asjs] [refs/heads/develop] - Fixed a few compile errors that Flash Builder caught in FlexJSJX and FlexJSUI

2014-10-17 Thread Alex Harui
Om, what errors were coming from TitleBarView? It shouldn’t have been necessary to make those changes. -Alex On 10/13/14, 5:15 PM, bigosma...@apache.org bigosma...@apache.org wrote: Repository: flex-asjs Updated Branches: refs/heads/develop e25bb2223 - 9b58dece2 Fixed a few compile errors

Re: [1/7] git commit: [flex-asjs] [refs/heads/develop] - Add MouseEvent

2014-10-17 Thread Alex Harui
Why did we need our own MouseEvent? I was expecting to use flash.events.MouseEvent and whatever the native MouseEvent is in HTML/JS/CSS? -Alex On 10/17/14, 4:45 PM, bigosma...@apache.org bigosma...@apache.org wrote: Repository: flex-asjs Updated Branches: refs/heads/develop eed8bdaab -

Re: Jenkins build is still unstable: flex-falcon #173

2014-09-25 Thread Alex Harui
Erik, There are two test failures in VJS. There was one in SDKSWCTests I think I just fixed. Can you take a look at the VJS failures? Thanks, -Alex On 9/25/14 11:13 AM, flex.ci.bui...@gmail.com flex.ci.bui...@gmail.com wrote: See

Re: [1/2] git commit: [flex-sdk] [refs/heads/develop] - FLEX-34476 Added RichTextEditor

2014-08-26 Thread Alex Harui
Just happened to notice that ColorPicker's button appears to have been changed in a way that wouldn't be backward-compatible. Do we care? After all, it is still experimental. On 8/26/14 6:17 AM, jmcl...@apache.org jmcl...@apache.org wrote: Repository: flex-sdk Updated Branches:

Re: Build failed in Jenkins: InstallApacheFlex #136

2014-08-25 Thread Alex Harui
And while we're on the subject of install errors. The SDK build hung because it couldn't download a dependency, and now all of our other builds will fail until the sdk build recovers. External download reliability apparently just isn't that great. -Alex On 8/24/14 10:54 PM,

Re: git commit: [flex-asjs] [refs/heads/VF2JS] - First component, more to serve as a placeholder than anything else ; -)

2014-07-02 Thread Alex Harui
I know you hate this legal stuff, but don't forget your Apache headersŠ -Alex On 7/2/14 7:24 AM, erikdebr...@apache.org erikdebr...@apache.org wrote: Repository: flex-asjs Updated Branches: refs/heads/VF2JS [created] 95b41cfca First component, more to serve as a placeholder than anything

Re: git commit: [flex-asjs] [refs/heads/VF2JS] - First component, more to serve as a placeholder than anything else ; -)

2014-07-02 Thread Alex Harui
later. EdB On Wed, Jul 2, 2014 at 4:51 PM, Alex Harui aha...@adobe.com wrote: I know you hate this legal stuff, but don't forget your Apache headersŠ -Alex On 7/2/14 7:24 AM, erikdebr...@apache.org erikdebr...@apache.org wrote: Repository: flex-asjs Updated Branches: refs/heads/VF2JS

Re: flex-sdk_mustella - Build # 966 - Still Failing!

2014-06-29 Thread Alex Harui
I didn't look back too far, but it appears there is a hudson class in the first failure and after that we get Git failures? For the hudson failure (which is Jenkins, right?) I note that the failure was on one of the last batches of tests that are in a mustella run. Does jenkins try to timeout

Re: flex-sdk_mustella - Build # 960 - Still Failing!

2014-06-26 Thread Alex Harui
Erik, This one test has failed 3 times although other runs in between have resulted in crashes. All 3 failures are on FP 14. Can we get a run on FP 11 and see if it is player version specific? The tests pass locally for me on Mac using FP11.1. I don't have access to my Windows machine right

Re: [3/3] git commit: [flex-falcon] [refs/heads/develop] - Fix tests to use '[qname].base' instead of 'goog.base'.

2014-06-25 Thread Alex Harui
Thanks for doing this! Do you have time to upgrade the GCL on the builds machine? I don't have my windows machine handy and VMWare is painful slow. Or maybe you did it already, I haven't checked. Thanks, -Alex On 6/25/14 8:38 AM, erikdebr...@apache.org erikdebr...@apache.org wrote: Fix tests

Re: [3/3] git commit: [flex-falcon] [refs/heads/develop] - Fix tests to use '[qname].base' instead of 'goog.base'.

2014-06-25 Thread Alex Harui
being developed to keep up with the newest standards, browsers and JS VMs, and our framework should as well. EdB On Wed, Jun 25, 2014 at 7:22 PM, Alex Harui aha...@adobe.com wrote: Awesome, thanks. As you may have noted, the build/install script does not pull down the latest GCL. Do you

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34078 fix callouts closing when selecting dates in DateFields

2014-06-10 Thread Alex Harui
-1 for reasons stated below. Justin, you never responded so I'm thinking my attempts to ask you about this have been missed in all the other noise. -Alex On 5/26/14 10:12 PM, Alex Harui aha...@adobe.com wrote: This change broke Falcon, although Falcon is not reporting the failure correctly

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34078 fix callouts closing when selecting dates in DateFields

2014-05-26 Thread Alex Harui
This change broke Falcon, although Falcon is not reporting the failure correctly. And I'm sort of surprised it didn't break the SDK build because it introduces a dependency from spark.swc to mx.swc and mx.swc is not listed in the set of libraries used to build experimental.swc. It is also not a

Re: flex-sdk_mustella - Build # 904 - Still Failing!

2014-05-11 Thread Alex Harui
Forgot to look at this. Will try to find time today. On 5/10/14 5:31 PM, flex.muste...@gmail.com flex.muste...@gmail.com wrote: flex-sdk_mustella - Build # 904 - Still Failing: http://flex-mustella.cloudapp.net/job/flex-sdk_mustella/904/ Changes for Build #894 Changes for Build #895 [aharui]

Re: Build failed in Jenkins: flex-sdk #699

2014-03-20 Thread Alex Harui
Either the admins finally got around to cleaning up the lock, or the hack I did on the falcon build proves that we can do some file manipulation without the admins simply by using ant. The SDK build is making better progress. We'll see if it completes successfully. -Alex On 3/20/14 7:14 AM,

Re: Build failed in Jenkins: flex-sdk #699

2014-03-20 Thread Alex Harui
, Mar 20, 2014 at 3:46 PM, Alex Harui aha...@adobe.commailto:aha...@adobe.com wrote: Either the admins finally got around to cleaning up the lock, or the hack I did on the falcon build proves that we can do some file manipulation without the admins simply by using ant. The SDK build is making better

Re: [01/50] [abbrv] rename folder

2014-03-15 Thread Alex Harui
SWFObject probably shouldn't be in the repo. On 3/15/14 6:00 PM, jmcl...@apache.org jmcl...@apache.org wrote: Repository: flex-flexunit Updated Branches: refs/heads/develop fede2751f - 360e38257 http://git-wip-us.apache.org/repos/asf/flex-flexunit/blob/64592fdd/FlexUni

Re: Git Push Summary

2014-02-28 Thread Alex Harui
Hi Justin, I was about to push an installer fix to prevent caching of sdk-installer-config.xml. -Alex On 2/28/14 10:37 PM, jmcl...@apache.org jmcl...@apache.org wrote: Repository: flex-sdk Updated Tags: refs/tags/apache-flex-sdk-4.12.0RC3 [created] f363a0774

RE: [1/2] git commit: [flex-sdk] [refs/heads/develop] - Now able to compile on 10.2 and 10.3 which doesn't have JSON support

2014-02-23 Thread Alex Harui
Wow, didn't know you could do this[JSON] to access a top-level class. I guess that works because of lexical scoping? I think other places in the SDK use ApplicationDomain.hasDefinition/getDefinition. -Alex From: jmcl...@apache.org [jmcl...@apache.org]

Re: flex-sdk_mustella-mobile - Build # 539 - Still Failing!

2014-02-14 Thread Alex Harui
Well, it appears that in swf-version 15 and later, the behavior of 0.09765625.toFixed(1) changed from 0.1 to 0.0. I tried reading the ecma spec but it made my head spin. FP11.1 which is our baseline, is swf-version 14. Whenever the rotation gets around to 11.1, this test passes. Time to modify

Re: git commit: [flex-asjs] [refs/heads/develop] - Changes necessary to get ActionScript DataGrid to cross-compile to JavaScript DataGrid.

2014-01-28 Thread Alex Harui
Build failed. Did you somehow forget to check in DataGridColumn.as into FlexJSJX? On 1/28/14 2:08 PM, p...@apache.org p...@apache.org wrote: Updated Branches: refs/heads/develop 14a83f02b - 9c4b232f2 Changes necessary to get ActionScript DataGrid to cross-compile to JavaScript DataGrid.

Re: git commit: [flex-asjs] [refs/heads/develop] - Changes necessary to get ActionScript DataGrid to cross-compile to JavaScript DataGrid.

2014-01-28 Thread Alex Harui
I pushed an old copy of DataGridColumn just to fix the build. If you made changes, make sure you back up your copy before syncing so your changes don't get overwritten. -Alex On 1/28/14 2:54 PM, Alex Harui aha...@adobe.com wrote: Build failed. Did you somehow forget to check

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-33904 memory fix

2013-12-28 Thread Alex Harui
Just curious: I don't see how this saves an allocation. Can you explain? On 12/28/13 5:45 PM, jmcl...@apache.org jmcl...@apache.org wrote: Updated Branches: refs/heads/develop 03680f5b0 - b0e208c92 FLEX-33904 memory fix Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit:

Re: flex-sdk_mustella - Build # 631 - Failure!

2013-12-26 Thread Alex Harui
The problem is that the list is waiting on Timer events to do the dragScroll (like in many other UI's when you drag off the edge of something and it starts scrolling). Mustella lacks the infrastructure to perfectly control the number of timer events during the test run. The only idea I have to

Re: Build failed in Jenkins: flex-falcon #245

2013-12-14 Thread Alex Harui
My mistake. Hopefully fixed. Trying flex-sdk again and then these downstream builds. On 12/14/13 9:01 PM, Apache Jenkins Server jenk...@builds.apache.org wrote: See https://builds.apache.org/job/flex-falcon/245/ -- [...truncated 3824 lines...]

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-33984: Moved the placement logic from the hostComponent to the skin. Removed some code no longer needed.

2013-12-08 Thread Alex Harui
FWIW, at one point in time, Spark skins were supposed to have as few styles as possible since tools like Catalyst were supposed to make easier to just draw a different skin and not have to implement as much code in the skin. Custom skins were supposed to simply place the icon wherever it should

Re: Test job - Build # 3 - Successful!

2013-12-03 Thread Alex Harui
Adobe spam filters blocked it. It might be in the archives, but I haven't looked. On 12/3/13 12:05 PM, Maurice Amsellem maurice.amsel...@systar.com wrote: Did you receive build.zip attached with the email ? -Message d'origine- De : flex.muste...@gmail.com

Re: git commit: [flex-sdk] [refs/heads/develop] - FIXED broken mustella tests after : FIXED mispelled variable that caused getter to be used instead.

2013-11-17 Thread Alex Harui
Looks like there is a second test failing that might have been masked by the first one. Can you look at the latest run's failure? Thanks, -Alex On 11/16/13 12:09 PM, mamsel...@apache.org mamsel...@apache.org wrote: Updated Branches: refs/heads/develop fa12f02de - 78eab008d FIXED broken

Re: [1/4] Initial commit of 'correct' whitespace emission.

2013-11-12 Thread Alex Harui
I'm getting one failure in compiler.jx.tests in org.apache.flex.compiler.internal.codegen.mxml.flexjs.TestFlexJSMXMLApplica tion Is it passing for others? -Alex On 11/12/13 3:05 AM, erikdebr...@apache.org erikdebr...@apache.org wrote: Updated Branches: refs/heads/develop 026a53c72 -

Re: [1/4] Initial commit of 'correct' whitespace emission.

2013-11-12 Thread Alex Harui
about? EdB On Tue, Nov 12, 2013 at 8:07 PM, Alex Harui aha...@adobe.com wrote: I'm getting one failure in compiler.jx.tests in org.apache.flex.compiler.internal.codegen.mxml.flexjs.TestFlexJSMXMLAppli ca tion Is it passing for others? -Alex On 11/12/13 3:05 AM, erikdebr...@apache.org

Re: [1/4] Initial commit of 'correct' whitespace emission.

2013-11-12 Thread Alex Harui
Still failing after clean. Interesting, the test says FAILED, but from the command-line it still thinks the build succeeded. But Eclipse definitely knows it failed. I guess I'll have to dig into it. -Alex On 11/12/13 11:52 AM, Alex Harui aha...@adobe.com wrote: It's not picking up

Re: Build failed in Jenkins: flex-sdk_mustella #527

2013-11-11 Thread Alex Harui
I looked at the 3 ComboBox failures. This appears to be related to the scrolling change. In each of the failures, the ComboBox has a selectedIndex that is non-zero and there appears to be logic in ComboBox that ensures that the dropdown list is scrolled so that the selectedIndex is the top row,

Re: [2/3] git commit: [flex-asjs] [refs/heads/develop] - If bead value is not found, prevent set states from blowing up.

2013-11-07 Thread Alex Harui
FWIW, I was thinking that this kind of check should be replaced by some capability in the tool chain to verify a configuration, maybe by marking some values as required. In production, you hopefully don't need these kinds of checks. I've also floated the idea of debug-mode beads which have more

Re: git commit: [flex-asjs] [refs/heads/develop] - An example of how API parity would look. I started at SimpleStateImpl and worked my way up ; -)

2013-11-07 Thread Alex Harui
I'm good with that, but what if the original implementation was significantly faster on JS but not on AS? Would you then allow for a different implementation? On 11/7/13 11:27 AM, erikdebr...@apache.org erikdebr...@apache.org wrote: Updated Branches: refs/heads/develop 4b17f61ce - 9fa2c6f9b

Re: Build failed in Jenkins: flex-falcon #194

2013-11-05 Thread Alex Harui
Can someone with knowledge of the build system go an delete lib/guava*.*? Thanks, -Alex On 11/5/13 6:46 AM, Apache Jenkins Server jenk...@builds.apache.org wrote: See https://builds.apache.org/job/flex-falcon/194/changes Changes: [gordonsmith] Falcon: Updated guava.jar to the current release,

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-33875 check to stop RTE

2013-11-04 Thread Alex Harui
Hi Justin, I've been told that (foo in bar) is slow. Is this going to get called a lot? And why does a skin not have a hostcomponent property? I thought that was part of the contract. -Alex On 11/4/13 1:56 PM, jmcl...@apache.org jmcl...@apache.org wrote: Updated Branches:

Re: [1/2] git commit: [flex-sdk] [refs/heads/develop] - FIX FLEX-33861 Flex Incorrectly Scaling Down Application mutella test pass: tests/mobile/*

2013-11-01 Thread Alex Harui
Looks fine. One random thought: If this code doesn't get called often, putting some of the constants like 1024 and 2048 into static vars would allow someone to change those numbers if needed. -Alex On 11/1/13 3:27 PM, mamsel...@apache.org mamsel...@apache.org wrote: Updated Branches:

  1   2   >