RE: Build failed in Jenkins: flex-sdk_mustella #460

2013-10-09 Thread Alex Harui
Update: I synced up and ran the FTETextField tests on my Windows box and got the same 2 errors (FP11.1). I'll be doing some digging... Won't need the Mustella VM. -Alex From: flex.muste...@gmail.com [flex.muste...@gmail.com] Sent: Tuesday, October 08,

RE: Build failed in Jenkins: flex-sdk_mustella #460

2013-10-09 Thread Alex Harui
/src/mx/core/FTETextField.as? -Alex From: Alex Harui Sent: Wednesday, October 09, 2013 8:33 PM To: d...@flex.apache.org; d...@flex.apache.org; commits@flex.apache.org; jmcl...@apache.org; maurice.amsel...@systar.com Subject: RE: Build failed in Jenkins

Re: git commit: [flex-falcon] [refs/heads/develop] - FLEX-33307: adding these arguments makes most of the warnings and some of the errors go away. Baby steps ; -)

2013-09-23 Thread Alex Harui
Nevermind, I guess you need to do that for the AIR-related SWCs? -Alex On 9/23/13 9:51 AM, Alex Harui aha...@adobe.com wrote: I believe that we normally compile the framework against flex-config.xml not air-config.xml. Is there a reason you chose air-config? -Alex On 9/23/13 7:31 AM

Re: git commit: [flex-falcon] [refs/heads/develop] - FLEX-33307: adding these arguments makes most of the warnings and some of the errors go away. Baby steps ; -)

2013-09-23 Thread Alex Harui
I believe that we normally compile the framework against flex-config.xml not air-config.xml. Is there a reason you chose air-config? -Alex On 9/23/13 7:31 AM, erikdebr...@apache.org erikdebr...@apache.org wrote: Updated Branches: refs/heads/develop 5abe3d03d - 05cfdcb68 FLEX-33307: adding

Re: git commit: [flex-falcon] [refs/heads/develop] - FLEX-33713: An NPE is thrown by this code when compiling 'spark.swc' from the SDK. The null check bypasses the issue, it doesn't do anything to fix

2013-09-23 Thread Alex Harui
Hmm. Seems like methodBodyVisitor is needed to complete the codegen for the static initializer. Instead of a null check, a call to getMethodBodyVisitor() might be the right answer, but a simple test case that verifies correct codegen would be helpful. There might be something unique to

Re: [1/2] git commit: [flex-sdk] [refs/heads/develop] - FLEX-33740 made removedFromStageHandler protected so it could be overridden

2013-09-18 Thread Alex Harui
hard, Google decided the notification were spam. They got filtered out, so I didn't notice anything until Alex emailed. Sorry about that. I have paused the builds until the commit is reverted. EdB On Wed, Sep 18, 2013 at 4:07 PM, Alex Harui aha...@adobe.com wrote: Justin, please revert. I think

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-33702: Added column sort type access to the datagrid columns.

2013-09-09 Thread Alex Harui
Looks fine. One concern is that you changed an interface. We got burned by changing other interfaces in the past. Remember the IList snafu? But I don't know if there are any custom ISortField implementations in the wild so it may be ok. -Alex On 9/9/13 5:00 PM, mkess...@apache.org

Re: git commit: [flex-sdk] [refs/heads/develop] - Fixed build version number not being injected into configuration file

2013-08-08 Thread Alex Harui
Minor, but I think tstamp is called more than once now and could end up on both sides of midnight if you start a build too late at night. On 8/8/13 10:20 PM, jmcl...@apache.org jmcl...@apache.org wrote: Updated Branches: refs/heads/develop 57fffd956 - 9f3efa466 Fixed build version number not

Re: Build failed in Jenkins: flex-sdk_mustella-mobile #20

2013-07-02 Thread Alex Harui
Erik, I don't know how to use any of the editors on the VM that support unix line endings, but the jenkins.sh for mobile has an error where it isn't setting target_os_name in local.properties, but rather arget_os_name. I still got about 20 failures that I'm looking at, but fixing jenkins.sh

Mustella Tests are failing.

2013-06-30 Thread Alex Harui
Hi, While we're still ironing out the mustella test server, some tests are now breaking for me. I think sometime in the last couple of days some checkin broke tests in: Managers/StyleManager/AdvancedCSS Components/DateField Gumbo/components/FTETextField. If you've made changes recently could

Re: [2/3] git commit: [flex-sdk] [refs/heads/develop] - Fix for older version of AIR (including Linux)

2013-05-30 Thread Alex Harui
Minor nit: I think at one point we were told to use in instead of hasOwnProperty for non-dynamic instances, e.g. if (renderMode in init) On 5/30/13 6:18 PM, jmcl...@apache.org jmcl...@apache.org wrote: Fix for older version of AIR (including Linux) Project:

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-16857 Fixed RTE when adding items after setting sort to null

2013-05-14 Thread Alex Harui
/collections/ListCollectionView.as @@ -378,6 +378,10 @@ public class ListCollectionView extends Proxy public function set sort(s:ISort):void { _sort = s; + + if (s == null) + localIndex = null; + dispatchEvent(new Event(sortChanged)); } -- Alex Harui

Re: git commit: [flex-sdk] - FLEX-17210 Added check to see if locale exists when changing localeChain

2013-05-13 Thread Alex Harui
new Error( + Could not find compiled locale ' + locale + '.); + } + } update(); } -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui

Re: [3/3] git commit: [flex-sdk] [refs/heads/develop] - As the columns may not be committed yet initialiseHeaderInfo needs to use the column array passed not the internal one. Method is also called fo

2013-05-13 Thread Alex Harui
On 5/13/13 6:47 PM, jmcl...@apache.org jmcl...@apache.org wrote: AdvancedDataGridBase implements IIME /** * @private + * + * Note columns may not of been committed at this point. Shouldn't this be ...may not have been...? -- Alex Harui Flex SDK Team Adobe Systems

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-23486 propsedSeletedItemIndexes[uid] is undefined otherwise

2013-05-10 Thread Alex Harui
[proposedSelectedItemIndexes[uid]] = new ListBaseSelectionData(data, index, false); -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui

Re: git commit: [flex-asjs] [refs/heads/develop] - RadioButtons for jQuery. RadioButtons cannot be programmatically added due to a known jQuery bug (documented in the RadioButton.js file).

2013-05-09 Thread Alex Harui
= -function(value) { - this.element.childNodes.item(0).checked = value; +org.apache.flex.jquery.staticControls.RadioButton.prototype.set_selected = function(value) { +this.element.checked = value; }; -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-26048 check if date range actually contains dates

2013-05-06 Thread Alex Harui
()); } -if (value.rangeEnd) +if (value.hasOwnProperty(rangeEnd) value.rangeEnd is Date) { range.rangeEnd = new Date(value.rangeEnd.getFullYear(), value.rangeEnd.getMonth(), -- Alex Harui Flex SDK Team Adobe Systems

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-33524: Added convenience feature to enable/disable buttons in a ButtonBar/TabBar.

2013-05-02 Thread Alex Harui
; +} +} + + /** * @private */ -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui

Re: [ApacheFlexTest/whiteboard] a208d5: Testing email notification to Github whiteboard

2013-04-30 Thread Alex Harui
-30 (Tue, 30 Apr 2013) Changed paths: M README.md Log Message: --- Testing email notification to Github whiteboard -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui

<    1   2