FLEX-35031 FLEX-33058 Clarifying intent by renaming function and changing the order of its parameters.
Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/e255d6d8 Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/e255d6d8 Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/e255d6d8 Branch: refs/heads/develop Commit: e255d6d87f59ade95cb43285504f2097b41bd820 Parents: 94d038a Author: Mihai Chira <mih...@apache.org> Authored: Wed Feb 17 15:08:47 2016 +0100 Committer: Mihai Chira <mih...@apache.org> Committed: Wed Feb 17 15:08:47 2016 +0100 ---------------------------------------------------------------------- .../src/mx/collections/HierarchicalCollectionViewCursor.as | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/e255d6d8/frameworks/projects/advancedgrids/src/mx/collections/HierarchicalCollectionViewCursor.as ---------------------------------------------------------------------- diff --git a/frameworks/projects/advancedgrids/src/mx/collections/HierarchicalCollectionViewCursor.as b/frameworks/projects/advancedgrids/src/mx/collections/HierarchicalCollectionViewCursor.as index a55db72..dfe45a0 100644 --- a/frameworks/projects/advancedgrids/src/mx/collections/HierarchicalCollectionViewCursor.as +++ b/frameworks/projects/advancedgrids/src/mx/collections/HierarchicalCollectionViewCursor.as @@ -324,7 +324,7 @@ public class HierarchicalCollectionViewCursor extends EventDispatcher var done:Boolean = false; while (!done) { - if (objectMatchesValues(hierarchicalData.getData(current), valuesToMatch)) + if (valuesAreSubsetOfObject(valuesToMatch, hierarchicalData.getData(current))) return true; done = !moveNext(); @@ -333,7 +333,7 @@ public class HierarchicalCollectionViewCursor extends EventDispatcher return false; } - private static function objectMatchesValues(object:Object, values:Object):Boolean + private static function valuesAreSubsetOfObject(values:Object, object:Object):Boolean { if(!object && !values) return true; @@ -393,7 +393,7 @@ public class HierarchicalCollectionViewCursor extends EventDispatcher var done:Boolean = false; while (!done) { - if (objectMatchesValues(hierarchicalData.getData(current), valuesToMatch)) + if (valuesAreSubsetOfObject(valuesToMatch, hierarchicalData.getData(current))) return true; done = !movePrevious();
