from:"Piotr Zarzycki"

Re: git commit: [flex-tlf] [refs/heads/develop] - FLEX-34247 improve TLF performance. I added a flag in case some scenario really needs composition to start from the beginning, but the default is now

2014-05-22 Thread Piotr Zarzycki

I did run current TLF tests nothing blows up. :) Next week will commit 
new tests.


W dniu 2014-05-22 05:53, aha...@apache.org pisze:

Repository: flex-tlf
Updated Branches:
   refs/heads/develop 41fc042d0 - 592b45fa2


FLEX-34247 improve TLF performance.  I added a flag in case some scenario 
really needs composition to start from the beginning, but the default is now 
more like the TLF version that shipped with Adobe Flex 4.6


Project: http://git-wip-us.apache.org/repos/asf/flex-tlf/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-tlf/commit/592b45fa
Tree: http://git-wip-us.apache.org/repos/asf/flex-tlf/tree/592b45fa
Diff: http://git-wip-us.apache.org/repos/asf/flex-tlf/diff/592b45fa

Branch: refs/heads/develop
Commit: 592b45fa219af46592f30ad712b739ac606ed296
Parents: 41fc042
Author: Alex Harui aha...@apache.org
Authored: Wed May 21 20:52:45 2014 -0700
Committer: Alex Harui aha...@apache.org
Committed: Wed May 21 20:52:45 2014 -0700

--
  .../src/flashx/textLayout/compose/BaseCompose.as |  7 ---
  .../src/flashx/textLayout/compose/ComposeState.as| 15 +--
  .../textLayout/container/ContainerController.as  |  1 +
  3 files changed, 14 insertions(+), 9 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/flex-tlf/blob/592b45fa/textLayout/src/flashx/textLayout/compose/BaseCompose.as
--
diff --git a/textLayout/src/flashx/textLayout/compose/BaseCompose.as 
b/textLayout/src/flashx/textLayout/compose/BaseCompose.as
index 2ad0506..b7c4b02 100644
--- a/textLayout/src/flashx/textLayout/compose/BaseCompose.as
+++ b/textLayout/src/flashx/textLayout/compose/BaseCompose.as
@@ -30,6 +30,7 @@ package flashx.textLayout.compose
import flash.text.engine.TextLineValidity;
import flash.utils.Dictionary;

+   import flashx.textLayout.tlf_internal;
import flashx.textLayout.container.ContainerController;
import flashx.textLayout.debug.Debugging;
import flashx.textLayout.debug.assert;
@@ -69,7 +70,6 @@ package flashx.textLayout.compose
import flashx.textLayout.formats.TextLayoutFormat;
import flashx.textLayout.formats.VerticalAlign;
import flashx.textLayout.property.Property;
-   import flashx.textLayout.tlf_internal;
import flashx.textLayout.utils.LocaleUtil;
import flashx.textLayout.utils.Twips;
  
@@ -892,8 +892,9 @@ package flashx.textLayout.compose


resetControllerBounds();

-   // Bug, needs to remove
-   _startComposePosition = _startController.absoluteStart;
+   // Bug, needs to remove
+   if 
(ContainerController.tlf_internal::startComposeFromBeginning)
+   _startComposePosition = 
_startController.absoluteStart;

// This is where we will start composing from
_curElement = _textFlow.findLeaf(_startComposePosition);

http://git-wip-us.apache.org/repos/asf/flex-tlf/blob/592b45fa/textLayout/src/flashx/textLayout/compose/ComposeState.as
--
diff --git a/textLayout/src/flashx/textLayout/compose/ComposeState.as 
b/textLayout/src/flashx/textLayout/compose/ComposeState.as
index ce7bddc..d40dc2b 100644
--- a/textLayout/src/flashx/textLayout/compose/ComposeState.as
+++ b/textLayout/src/flashx/textLayout/compose/ComposeState.as
@@ -27,6 +27,7 @@ package flashx.textLayout.compose
import flash.text.engine.TextLineCreationResult;
import flash.text.engine.TextLineValidity;

+   import flashx.textLayout.tlf_internal;
import flashx.textLayout.container.ContainerController;
import flashx.textLayout.debug.Debugging;
import flashx.textLayout.debug.assert;
@@ -46,7 +47,6 @@ package flashx.textLayout.compose
import flashx.textLayout.formats.ListStylePosition;
import flashx.textLayout.formats.TextAlign;
import flashx.textLayout.formats.VerticalAlign;
-   import flashx.textLayout.tlf_internal;
import flashx.textLayout.utils.Twips;

use namespace tlf_internal;
@@ -340,11 +340,14 @@ package flashx.textLayout.compose
var line:TextFlowLine = _curLineIndex  
_flowComposer.numLines ? (_flowComposer as 
StandardFlowComposer).lines[_curLineIndex] : null;

var useExistingLine:Boolean = line  
(!line.isDamaged() || line.validity == FlowDamageType.GEOMETRY);
-   // if the line ends with a hyphen, don't use existing 
line because the player seems to mis-handle
-   // starting the next line.
-

Re: Build failed in Jenkins: flex-tlf #326

2015-02-02 Thread Piotr Zarzycki

Yep - You should add TestCase order inside every test classes.

Piotr

2015-02-02 16:39 GMT+01:00 Alex Harui aha...@adobe.com:

  Yeah, that’s the link I was using.  Actually, I think I read it wrong so
 maybe this next commit will work.

   From: Piotr Zarzycki piotrzarzyck...@gmail.com
 Date: Monday, February 2, 2015 at 7:20 AM

 To: Alex Harui aha...@adobe.com
 Cc: d...@flex.apache.org d...@flex.apache.org, commits@flex.apache.org
 commits@flex.apache.org, pio...@apache.org pio...@apache.org, 
 ha...@in-tools.com ha...@in-tools.com
 Subject: Re: Build failed in Jenkins: flex-tlf #326

   I remember that we have tried to achieve some order once for some case
 but it didn't work. However this is the link which could help:
 https://cwiki.apache.org/confluence/display/FLEX/FlexUnit+Order

  Maybe we should add Order tag to every TestCase class to have ordering.

  Piotr

 2015-02-02 16:16 GMT+01:00 Alex Harui aha...@adobe.com:

  I did run GeneralFunctionsTests by itself and it passed, so really, I’m
 interested in having it run as part of the full suite but still run early
 to see if other tests are messing it up and make it easier to debug if it
 still fails.  It looked like FlexUnit supported some “order” attribute but
 maybe I don’t know how to get it to work.

   From: Piotr Zarzycki piotrzarzyck...@gmail.com
 Date: Monday, February 2, 2015 at 7:11 AM
 To: Alex Harui aha...@adobe.com
 Cc: d...@flex.apache.org d...@flex.apache.org, commits@flex.apache.org
 commits@flex.apache.org, pio...@apache.org pio...@apache.org, 
 ha...@in-tools.com ha...@in-tools.com
 Subject: Re: Build failed in Jenkins: flex-tlf #326

   Alex,

  The simplest way to run only GeneralFunctionTests is to add this class
 to MinimalTestsSuite.as
 http://apacheflexbuild.cloudapp.net:8080/job/flex-tlf/ws/automation_tests/src/MinimalTestsSuite.as
  and
 change in build.properties minimalTests to true.

  Piotr

 2015-02-02 16:03 GMT+01:00 Alex Harui aha...@adobe.com:

 Anybody know how to get the GeneralFunctionTests to run first?  When I
 run
 the tests in the debugger they are not running first.

 Thanks,
 -Alex

 On 2/1/15, 10:54 PM, flex.ci.bui...@gmail.com 
 flex.ci.bui...@gmail.com
 wrote:

 See http://apacheflexbuild.cloudapp.net:8080/job/flex-tlf/326/
 
 --
 Started by timer
 Building remotely on flex_sdk_slave2 in workspace
 http://apacheflexbuild.cloudapp.net:8080/job/flex-tlf/ws/
   C:\Program Files (x86)\Git\cmd\git.exe rev-parse
 --is-inside-work-tree
 # timeout=10
 Fetching changes from the remote Git repository
   C:\Program Files (x86)\Git\cmd\git.exe config remote.origin.url
 https://git-wip-us.apache.org/repos/asf/flex-tlf.git # timeout=10
 Fetching upstream changes from
 https://git-wip-us.apache.org/repos/asf/flex-tlf.git
   C:\Program Files (x86)\Git\cmd\git.exe --version # timeout=10
   C:\Program Files (x86)\Git\cmd\git.exe fetch --tags --progress
 https://git-wip-us.apache.org/repos/asf/flex-tlf.git
 +refs/heads/*:refs/remotes/origin/*
   C:\Program Files (x86)\Git\cmd\git.exe rev-parse
 origin/develop^{commit} # timeout=10
 Checking out Revision b5a5407fd065ab82c9506a4380610bcc93efe36f
 (origin/develop)
   C:\Program Files (x86)\Git\cmd\git.exe config core.sparsecheckout #
 timeout=10
   C:\Program Files (x86)\Git\cmd\git.exe checkout -f
 b5a5407fd065ab82c9506a4380610bcc93efe36f
   C:\Program Files (x86)\Git\cmd\git.exe rev-list
 b5a5407fd065ab82c9506a4380610bcc93efe36f # timeout=10
 [flex-tlf] $ cmd.exe /C

 'c:\Jenkins\tools\hudson.tasks.Ant_AntInstallation\c_apache-ant-1.9.3\bin
 \ant.bat -file build.xml all  exit %%ERRORLEVEL%%'
 Buildfile:
 http://apacheflexbuild.cloudapp.net:8080/job/flex-tlf/ws/build.xml
  [echo] FLEX_HOME is
 http://apacheflexbuild.cloudapp.net:8080/job/flex-tlf/ws/../flex-sdk
  [echo] Minimal test is set false
 
 clean:
[delete] Deleting directory
 http://apacheflexbuild.cloudapp.net:8080/job/flex-tlf/ws/bin
[delete] Deleting:
 
 http://apacheflexbuild.cloudapp.net:8080/job/flex-tlf/ws/bundles.properti
 es
 
 textLayout:
 [compc] Loading configuration file
 C:\Jenkins\workspace\flex-sdk\frameworks\flex-config.xml
 [compc] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
 [compc] C:\Jenkins\workspace\flex-tlf\bin\textLayout.swc (548672
 bytes)
 
 main:
 
 asTestApps:
  [echo] FLEX_HOME is
 http://apacheflexbuild.cloudapp.net:8080/job/flex-tlf/ws/../flex-sdk
  [echo] Minimal test is set false
 
 asTestApp:
 [mxmlc] Loading configuration file
 C:\Jenkins\workspace\flex-sdk\frameworks\flex-config.xml
 [mxmlc]

 C:\Jenkins\workspace\flex-tlf\bin\apps\asTestApps\bin\ExplicitFormField.sw
 f (519803 bytes)
 [mxmlc] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
  [echo] FLEX_HOME is
 http://apacheflexbuild.cloudapp.net:8080/job/flex-tlf/ws/../flex-sdk
  [echo] Minimal test is set false
 
 asTestApp:
 [mxmlc] Loading configuration file
 C:\Jenkins\workspace\flex-sdk\frameworks\flex-config.xml

Re: Build failed in Jenkins: flex-tlf #367

2015-03-04 Thread Piotr Zarzycki

]) in suite UnitTest.Tests.ContainerAttributeTest was ignored.
  [flexunit] FlexUnit test checkColumnGapOnWidthChangeTest ([object
 TestCaseVo]) in suite UnitTest.Tests.ContainerAttributeTest was ignored.
  [flexunit] FlexUnit test paddingBottomTest ([object TestCaseVo]) in suite
 UnitTest.Tests.ContainerAttributeTest was ignored.
  [flexunit] FlexUnit test spanElementReplaceTextInvalidPos in suite
 UnitTest.Tests.ElementOperationTest was ignored.
  [flexunit] FlexUnit test arabicDirection in suite
 UnitTest.Tests.WritingModeTest was ignored.
  [flexunit] FlexUnit test noTabStop in suite UnitTest.Tests.TabTest was
 ignored.
  [flexunit] FlexUnit test endTabLongStringTest in suite
 UnitTest.Tests.TabTest was ignored.
  [flexunit]
  [flexunit] Stopping server ...
  [flexunit] End of test data reached, sending acknowledgement to player ...
  [flexunit] Closing client connection ...
  [flexunit] Closing server on port [1024] ...
  [flexunit] Analyzing reports ...
  [flexunit]
  [flexunit] Suite: UnitTest.Tests.OperationTest
  [flexunit] Tests run: 47, Failures: 0, Errors: 0, Skipped: 2, Time
 elapsed: 17.717 sec
  [flexunit] Suite: UnitTest.Tests.GeneralFunctionsTest
  [flexunit] Tests run: 36, Failures: 0, Errors: 0, Skipped: 0, Time
 elapsed: 7.331 sec
  [flexunit] Suite: UnitTest.Tests.CrossContainerTest
  [flexunit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time
 elapsed: 0.099 sec
  [flexunit] Suite: UnitTest.Tests.AllParaAttributeTest
  [flexunit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 1, Time
 elapsed: 4.792 sec
  [flexunit] Suite: UnitTest.Tests.TabTest
  [flexunit] Tests run: 19, Failures: 0, Errors: 0, Skipped: 2, Time
 elapsed: 1.669 sec
  [flexunit] Suite: UnitTest.Tests.EventOverrideTest
  [flexunit] Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time
 elapsed: 1.167 sec
  [flexunit] Suite: UnitTest.Tests.AllContAttributeTest
  [flexunit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time
 elapsed: 9.172 sec
  [flexunit] Suite: UnitTest.Tests.AccessibilityMethodsTest
  [flexunit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time
 elapsed: 0.471 sec
  [flexunit] Suite: UnitTest.Tests.FactoryImportTest
  [flexunit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time
 elapsed: 0.066 sec
  [flexunit] Suite: UnitTest.Tests.AllEventTest
  [flexunit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 4, Time
 elapsed: 3.992 sec
  [flexunit] Suite: UnitTest.Tests.BoundsAndAlignmentTest
  [flexunit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time
 elapsed: 4.282 sec
  [flexunit] Suite: UnitTest.Tests.TextFlowEditTest
  [flexunit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time
 elapsed: 0.350 sec
  [flexunit] Suite: UnitTest.Tests.AttributeTest
  [flexunit] Tests run: 44, Failures: 0, Errors: 0, Skipped: 0, Time
 elapsed: 4.376 sec
  [flexunit] Suite: UnitTest.Tests.ContainerTypeTest
  [flexunit] Tests run: 22, Failures: 0, Errors: 0, Skipped: 1, Time
 elapsed: 1.057 sec
  [flexunit] Suite: UnitTest.Tests.FloatTest
  [flexunit] Tests run: 56, Failures: 0, Errors: 0, Skipped: 1, Time
 elapsed: 82.483 sec
  [flexunit] Suite: UnitTest.Tests.WritingModeTest
  [flexunit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 1, Time
 elapsed: 1.736 sec
  [flexunit] Suite: UnitTest.Tests.FlowModelTest
  [flexunit] Tests run: 23, Failures: 0, Errors: 0, Skipped: 0, Time
 elapsed: 3.414 sec
  [flexunit] Suite: UnitTest.Tests.ElementOperationTest
  [flexunit] Tests run: 25, Failures: 0, Errors: 0, Skipped: 1, Time
 elapsed: 4.080 sec
  [flexunit] Suite: UnitTest.Tests.UndoRedoTest
  [flexunit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time
 elapsed: 0.101 sec
  [flexunit] Suite: UnitTest.Tests.ScrollingTest
  [flexunit] Tests run: 15, Failures: 0, Errors: 0, Skipped: 1, Time
 elapsed: 13.093 sec
  [flexunit] Suite: UnitTest.Tests.AllCharAttributeTest
  [flexunit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time
 elapsed: 32.289 sec
  [flexunit] Suite: UnitTest.Tests.BoxTest
  [flexunit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time
 elapsed: 3.539 sec
  [flexunit] Suite: UnitTest.Tests.ContainerAttributeTest
  [flexunit] Tests run: 31, Failures: 0, Errors: 3, Skipped: 3, Time
 elapsed: 457.948 sec
  [flexunit] Suite: UnitTest.Tests.CompositionTest
  [flexunit] Tests run: 24, Failures: 0, Errors: 0, Skipped: 4, Time
 elapsed: 12.455 sec
  [flexunit]
  [flexunit] Results :
  [flexunit]
  [flexunit] Tests run: 428, Failures: 0, Errors: 3, Skipped: 21, Time
 elapsed: 667.679 sec
  [flexunit]

 BUILD FAILED
 http://apacheflexbuild.cloudapp.net:8080/job/flex-tlf/ws/build.xml:313:
 FlexUnit tests failed during the test run.

 Total time: 15 minutes 55 seconds
 Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
 Build step 'Invoke Ant' marked build as failure
 Archiving artifacts
 Recording test results



-- 

Greetings
Piotr Zarzycki

Flex/AIR/AngularJS Developer

mobile: +48 880 859 557
e-mail: piotrzarzyck...@gmail.com
skype: zarzycki10

LinkedIn: http

Re: Build failed in Jenkins: flex-tlf #416

2015-04-08 Thread Piotr Zarzycki

, Skipped: 0, Time
 elapsed: 1.304 sec
  [flexunit] Suite: UnitTest.Tests.AllCharAttributeTest
  [flexunit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time
 elapsed: 55.540 sec
  [flexunit] Suite: org.flexunit.events.UnknownError
  [flexunit] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time
 elapsed: 60.532 sec
  [flexunit]
  [flexunit] Results :
  [flexunit]
  [flexunit] Tests run: 591, Failures: 8, Errors: 1, Skipped: 18, Time
 elapsed: 657.654 sec
  [flexunit]

 BUILD FAILED
 http://apacheflexbuild.cloudapp.net:8080/job/flex-tlf/ws/build.xml:313:
 FlexUnit tests failed during the test run.

 Total time: 14 minutes 42 seconds
 Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
 Build step 'Invoke Ant' marked build as failure
 Archiving artifacts
 Recording test results




-- 

Greetings
Piotr Zarzycki

Flex/AIR/AngularJS Developer

mobile: +48 880 859 557
e-mail: piotrzarzyck...@gmail.com
skype: zarzycki10

LinkedIn: http://www.linkedin.com/piotrzarzycki http://linkd.in/1aGNqao

Re: git commit: [flex-asjs] [refs/heads/refactor-sprite] - Added Binary to Images

2016-08-08 Thread Piotr Zarzycki

Hi Harbs,

I think the name of the event "urlChanged" - do not say anymore what
actually has changed.
What do you think to have more general name? "imageSourceChanged" or
"imageDataChanged". Second idea is to have separate events for changed
source binary and url.

Piotr

On Mon, Aug 8, 2016, 16:48  wrote:

> Repository: flex-asjs
> Updated Branches:
>   refs/heads/refactor-sprite a1b8ce133 -> c5a470bf8
>
>
> Added Binary to Images
>
>
> Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
> Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/c5a470bf
> Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/c5a470bf
> Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/c5a470bf
>
> Branch: refs/heads/refactor-sprite
> Commit: c5a470bf88377d5e68a9cbd5c429ad430afe0a03
> Parents: a1b8ce1
> Author: Harbs 
> Authored: Mon Aug 8 17:48:01 2016 +0300
> Committer: Harbs 
> Committed: Mon Aug 8 17:48:01 2016 +0300
>
> --
>  .../src/products/ProductItemRenderer.as |  2 +-
>  .../projects/Core/src/main/flex/CoreClasses.as  |  1 +
>  .../flex/org/apache/flex/core/IImageModel.as| 17 +-
>  .../main/flex/org/apache/flex/utils/URLUtils.as | 59 
>  .../src/main/flex/org/apache/flex/html/Image.as | 29 --
>  .../org/apache/flex/html/beads/ImageView.as | 26 +++--
>  .../apache/flex/html/beads/models/ImageModel.as | 46 ---
>  .../src/products/ProductItemRenderer.as |  2 +-
>  .../src/products/ProductItemRenderer.as |  2 +-
>  9 files changed, 162 insertions(+), 22 deletions(-)
> --
>
>
>
> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/c5a470bf/examples/flexjs/DataGridExample/src/products/ProductItemRenderer.as
> --
> diff --git
> a/examples/flexjs/DataGridExample/src/products/ProductItemRenderer.as
> b/examples/flexjs/DataGridExample/src/products/ProductItemRenderer.as
> index 4edc5b7..0a954b0 100644
> --- a/examples/flexjs/DataGridExample/src/products/ProductItemRenderer.as
> +++ b/examples/flexjs/DataGridExample/src/products/ProductItemRenderer.as
> @@ -48,7 +48,7 @@ package products
> {
> super.data = value;
>
> -   image.source = value.image;
> +   image.url = value.image;
> }
>
> override public function adjustSize():void
>
>
> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/c5a470bf/frameworks/projects/Core/src/main/flex/CoreClasses.as
> --
> diff --git a/frameworks/projects/Core/src/main/flex/CoreClasses.as
> b/frameworks/projects/Core/src/main/flex/CoreClasses.as
> index 11061f5..1e8622b 100644
> --- a/frameworks/projects/Core/src/main/flex/CoreClasses.as
> +++ b/frameworks/projects/Core/src/main/flex/CoreClasses.as
> @@ -141,6 +141,7 @@ internal class CoreClasses
> import org.apache.flex.utils.Timer; Timer;
> import org.apache.flex.utils.UIDUtil; UIDUtil;
> import org.apache.flex.utils.UIUtils; UIUtils;
> +   import org.apache.flex.utils.URLUtils; URLUtils;
>
> import org.apache.flex.core.ClassFactory; ClassFactory;
>  import org.apache.flex.states.AddItems; AddItems;
>
>
> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/c5a470bf/frameworks/projects/Core/src/main/flex/org/apache/flex/core/IImageModel.as
> --
> diff --git
> a/frameworks/projects/Core/src/main/flex/org/apache/flex/core/IImageModel.as
> b/frameworks/projects/Core/src/main/flex/org/apache/flex/core/IImageModel.as
> index 1551d0f..a810d71 100644
> ---
> a/frameworks/projects/Core/src/main/flex/org/apache/flex/core/IImageModel.as
> +++
> b/frameworks/projects/Core/src/main/flex/org/apache/flex/core/IImageModel.as
> @@ -19,6 +19,7 @@
>  package org.apache.flex.core
>  {
> import org.apache.flex.events.IEventDispatcher;
> +import org.apache.flex.utils.BinaryData;
>
>  /**
>   *  The IImageModel interface describes the minimum set of properties
> @@ -42,7 +43,19 @@ package org.apache.flex.core
>   *  @playerversion AIR 2.6
>   *  @productversion FlexJS 0.0
>   */
> -   function get source():String;
> -   function set source(value:String):void;
> +   function get url():String;
> +   function set url(value:String):void;
> +
> +/**
> + *  The BinaryData of the image.
> + *  This is used to set the image using binary content retrieved
> using HTTP requests or File APIs.
> + *
> + *  @langversion 3.0
> + *  @playerversion Flash 10.2
> + *

Re: git commit: [flex-asjs] [refs/heads/develop] - Don't let order of bead addition confuse collapse bead.

2016-11-28 Thread Piotr Zarzycki

Hi Yishay,

This layout property is not only returning something but also adding - It
doesn't look good. Is there any other option ?

2016-11-28 9:58 GMT+01:00 <yish...@apache.org>:

> Repository: flex-asjs
> Updated Branches:
>   refs/heads/develop ce807561d -> 1ae995db3
>
>
> Don't let order of bead addition confuse collapse bead.
>
>
> Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
> Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/1ae995db
> Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/1ae995db
> Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/1ae995db
>
> Branch: refs/heads/develop
> Commit: 1ae995db37ec4c8dbab763b4865a25cf2436e32a
> Parents: ce80756
> Author: yishayw <yishayj...@hotmail.com>
> Authored: Mon Nov 28 10:58:49 2016 +0200
> Committer: yishayw <yishayj...@hotmail.com>
> Committed: Mon Nov 28 10:58:49 2016 +0200
>
> --
>  .../flex/html/beads/AccordionCollapseBead.as| 23 +++-
>  1 file changed, 22 insertions(+), 1 deletion(-)
> --
>
>
> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/
> 1ae995db/frameworks/projects/HTML/src/main/flex/org/apache/
> flex/html/beads/AccordionCollapseBead.as
> --
> diff --git a/frameworks/projects/HTML/src/main/flex/org/apache/flex/
> html/beads/AccordionCollapseBead.as b/frameworks/projects/HTML/
> src/main/flex/org/apache/flex/html/beads/AccordionCollapseBead.as
> index d666fc1..f0e9081 100644
> --- a/frameworks/projects/HTML/src/main/flex/org/apache/flex/html/beads/
> AccordionCollapseBead.as
> +++ b/frameworks/projects/HTML/src/main/flex/org/apache/flex/html/beads/
> AccordionCollapseBead.as
> @@ -20,6 +20,7 @@ package org.apache.flex.html.beads
>  {
> import org.apache.flex.core.IStrand;
> import org.apache.flex.core.UIBase;
> +   import org.apache.flex.core.ValuesManager;
> import org.apache.flex.events.Event;
> import org.apache.flex.html.Accordion;
> import org.apache.flex.html.beads.layouts.IOneFlexibleChildLayout;
> @@ -29,6 +30,7 @@ package org.apache.flex.html.beads
> {
> private var _strand:IStrand;
> private var lastSelectedIndex:int = -1;
> +   private var _layout:IOneFlexibleChildLayout;
> public function AccordionCollapseBead()
> {
> }
> @@ -52,7 +54,6 @@ package org.apache.flex.html.beads
> {
> return;
> }
> -   var layout:IOneFlexibleChildLayout =
> host.getBeadByType(IOneFlexibleChildLayout) as IOneFlexibleChildLayout;
> if (lastSelectedIndex > -1)
> {
> var lastElement:ICollapsible =
> view.dataGroup.getItemRendererForIndex(lastSelectedIndex) as ICollapsible;
> @@ -62,5 +63,25 @@ package org.apache.flex.html.beads
> layout.flexibleChild = newChild.id;
> layout.layout();
> }
> +
> +   private function get layout():IOneFlexibleChildLayout
> +   {
> +   if (!_layout)
> +   {
> +   _layout = 
> _strand.getBeadByType(IOneFlexibleChildLayout)
> as IOneFlexibleChildLayout;
> +   if (!_layout) {
> +   var c:Class =
> ValuesManager.valuesImpl.getValue(host, "iBeadLayout");
> +   if (c) {
> +   _layout = new c() as
> IOneFlexibleChildLayout;
> +   }
> +   }
> +   if (_layout)
> +   {
> +   _strand.addBead(_layout);
> +   }
> +   }
> +   return _layout;
> +   }
> +
> }
>  }
> \ No newline at end of file
>
>


-- 

Greetings
Piotr Zarzycki

Flex/AIR/.NET Developer

mobile: +48 880 859 557
e-mail: piotrzarzyck...@gmail.com
skype: zarzycki10

LinkedIn: http://www.linkedin.com/piotrzarzycki
<https://pl.linkedin.com/in/piotr-zarzycki-92a53552>

Re: flex-asjs git commit: Change innerHTML for a textNode to avoid remove text when using beads that “append” html tags

2016-12-10 Thread Piotr Zarzycki

Hi Carlos,

Is it creation of internal elements shouldn't be in createElement instead
in some setter?

Piotr

On Sat, Dec 10, 2016, 17:36  wrote:

> Repository: flex-asjs
> Updated Branches:
>   refs/heads/develop 07dfd97bb -> 9b467ea51
>
>
> Change innerHTML for a textNode to avoid remove text when using beads that
> “append” html tags
>
>
> Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
> Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/9b467ea5
> Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/9b467ea5
> Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/9b467ea5
>
> Branch: refs/heads/develop
> Commit: 9b467ea5129b93d12e785b7a73de7a60303a01c2
> Parents: 07dfd97
> Author: Carlos Rovira 
> Authored: Sat Dec 10 17:36:13 2016 +0100
> Committer: Carlos Rovira 
> Committed: Sat Dec 10 17:36:13 2016 +0100
>
> --
>  .../HTML/src/main/flex/org/apache/flex/html/Span.as   | 14 --
>  1 file changed, 12 insertions(+), 2 deletions(-)
> --
>
>
>
> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/9b467ea5/frameworks/projects/HTML/src/main/flex/org/apache/flex/html/Span.as
> --
> diff --git
> a/frameworks/projects/HTML/src/main/flex/org/apache/flex/html/Span.as
> b/frameworks/projects/HTML/src/main/flex/org/apache/flex/html/Span.as
> index 1771948..7dbe220 100644
> --- a/frameworks/projects/HTML/src/main/flex/org/apache/flex/html/Span.as
> +++ b/frameworks/projects/HTML/src/main/flex/org/apache/flex/html/Span.as
> @@ -70,13 +70,23 @@ package org.apache.flex.html
>
> COMPILE::JS
> {
> -   if(MXMLDescriptor == null) {
> -   element.innerHTML = text;
> +   if(MXMLDescriptor == null)
> +{
> +if(textNode == null)
> +{
> +textNode = document.createTextNode('') as Text;
> +element.appendChild(textNode);
> +}
> +
> +textNode.nodeValue = value;
> }
> }
>
> }
>
> +COMPILE::JS
> +private var textNode:Text;
> +
>  /**
>   * @flexjsignorecoercion org.apache.flex.core.WrappedHTMLElement
>   */
>
>

Re: git commit: [flex-asjs] [refs/heads/develop] - MDL Table component and example initial implementation

2017-01-13 Thread Piotr Zarzycki

Love this commit :)

On Fri, Jan 13, 2017, 20:34  wrote:

> Repository: flex-asjs
> Updated Branches:
>   refs/heads/develop 2e52060f3 -> b0b41aefe
>
>
> MDL Table component and example initial implementation
>
>
> Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
> Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/b0b41aef
> Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/b0b41aef
> Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/b0b41aef
>
> Branch: refs/heads/develop
> Commit: b0b41aefe2a419d310c010299430ba56bf87d974
> Parents: 2e52060
> Author: Carlos Rovira 
> Authored: Fri Jan 13 20:34:17 2017 +0100
> Committer: Carlos Rovira 
> Committed: Fri Jan 13 20:34:17 2017 +0100
>
> --
>  .../src/main/flex/MainNavigation.mxml   |   1 +
>  .../flexjs/MDLExample/src/main/flex/Tables.mxml |  41 ++
>  .../src/main/flex/models/MainNavigationModel.as |   1 +
>  .../src/main/flex/models/TablesModel.as |  41 ++
>  .../MDLExample/src/main/flex/vos/MaterialVO.as  |  35 +
>  .../main/flex/org/apache/flex/mdl/Navigation.as |   2 +-
>  .../src/main/flex/org/apache/flex/mdl/Table.as  |  30 ++--
>  .../flex/mdl/itemRenderers/TableItemRenderer.as | 145 +++
>  .../src/main/resources/defaults.css |  10 ++
>  .../src/main/resources/mdl-manifest.xml |   2 +
>  10 files changed, 293 insertions(+), 15 deletions(-)
> --
>
>
>
> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/b0b41aef/examples/flexjs/MDLExample/src/main/flex/MainNavigation.mxml
> --
> diff --git a/examples/flexjs/MDLExample/src/main/flex/MainNavigation.mxml
> b/examples/flexjs/MDLExample/src/main/flex/MainNavigation.mxml
> index f056f18..a2414b8 100644
> --- a/examples/flexjs/MDLExample/src/main/flex/MainNavigation.mxml
> +++ b/examples/flexjs/MDLExample/src/main/flex/MainNavigation.mxml
> @@ -74,6 +74,7 @@ limitations under the License.
>  
>  
>  
> +
>  
>  
>  
>
>
> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/b0b41aef/examples/flexjs/MDLExample/src/main/flex/Tables.mxml
> --
> diff --git a/examples/flexjs/MDLExample/src/main/flex/Tables.mxml
> b/examples/flexjs/MDLExample/src/main/flex/Tables.mxml
> new file mode 100644
> index 000..a5591d7
> --- /dev/null
> +++ b/examples/flexjs/MDLExample/src/main/flex/Tables.mxml
> @@ -0,0 +1,41 @@
> +
> +
> +http://ns.adobe.com/mxml/2009;
> + xmlns:js="library://ns.apache.org/flexjs/basic"
> + xmlns:mdl="library://ns.apache.org/flexjs/mdl"
> + xmlns="http://www.w3.org/1999/xhtml;
> + xmlns:models="models.*">
> +
> +
> +
> +   
> +
> +
> +
> +
> + +sourceID="model"
> +sourcePropertyName="materials"
> +destinationPropertyName="dataProvider" />
> +
> +
> +
> +
> +
> \ No newline at end of file
>
>
> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/b0b41aef/examples/flexjs/MDLExample/src/main/flex/models/MainNavigationModel.as
> --
> diff --git
> a/examples/flexjs/MDLExample/src/main/flex/models/MainNavigationModel.as
> b/examples/flexjs/MDLExample/src/main/flex/models/MainNavigationModel.as
> index 5330ae4..12fbbf3 100644
> ---
> a/examples/flexjs/MDLExample/src/main/flex/models/MainNavigationModel.as
> +++
> b/examples/flexjs/MDLExample/src/main/flex/models/MainNavigationModel.as
> @@ -63,6 +63,7 @@ package models
>  new NavigationLinkVO("Snackbar", "snackbar_panel"),
>  new NavigationLinkVO("Toggles", "toggles_panel"),
>  new NavigationLinkVO("Lists", "lists_panel"),
> +new NavigationLinkVO("Tables", "tables_panel"),
>  new NavigationLinkVO("Loading", "loading_panel"),
>  new NavigationLinkVO("Menu", "menus_panel"),
>  new NavigationLinkVO("Badges", "badges_panel"),
>
>
> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/b0b41aef/examples/flexjs/MDLExample/src/main/flex/models/TablesModel.as
> --
> diff --git
> a/examples/flexjs/MDLExample/src/main/flex/models/TablesModel.as
> b/examples/flexjs/MDLExample/src/main/flex/models/TablesModel.as
> new file mode 100644
> index 000..19e355e
> --- /dev/null
> +++ b/examples/flexjs/MDLExample/src/main/flex/models/TablesModel.as
> @@ -0,0 +1,41 @@
>
>

Re: git commit: [flex-asjs] [refs/heads/develop] - Export common bead loading logic to a utils class.

2016-12-01 Thread Piotr Zarzycki

//  Class methods
> +   //
> +   //
> --
> +
> +   /**
> +*  @return Loaded Bead.
> +*
> +*  @langversion 3.0
> +*  @playerversion Flash 9
> +*  @playerversion AIR 1.1
> +*  @productversion Flex 3
> +*/
> +   public static function loadBead(classOrInterface:Class,
> classOrInterfaceName:String, strand:IStrand):IBead
> +   {
> +   var result:IBead = strand.getBeadByType(
> classOrInterface);
> +   if (result == null)
> +   {
> +   var c:Class = 
> ValuesManager.valuesImpl.getValue(strand,
> classOrInterfaceName) as Class;
> +   if (c)
> +   {
> +   result = new c as IBeadModel;
> +   if (result)
> +   strand.addBead(result);
> +   }
> +   }
> +   return result;
> +   }
> +   }
> +
> +}
>
> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/
> e5020da9/frameworks/projects/HTML/src/main/flex/org/apache/
> flex/html/beads/AccordionCollapseBead.as
> --
> diff --git a/frameworks/projects/HTML/src/main/flex/org/apache/flex/
> html/beads/AccordionCollapseBead.as b/frameworks/projects/HTML/
> src/main/flex/org/apache/flex/html/beads/AccordionCollapseBead.as
> index 75782c6..edc41e0 100644
> --- a/frameworks/projects/HTML/src/main/flex/org/apache/flex/html/beads/
> AccordionCollapseBead.as
> +++ b/frameworks/projects/HTML/src/main/flex/org/apache/flex/html/beads/
> AccordionCollapseBead.as
> @@ -21,11 +21,11 @@ package org.apache.flex.html.beads
> import org.apache.flex.core.IItemRendererParent;
> import org.apache.flex.core.IStrand;
> import org.apache.flex.core.UIBase;
> -   import org.apache.flex.core.ValuesManager;
> import org.apache.flex.events.Event;
> import org.apache.flex.html.Accordion;
> import org.apache.flex.html.beads.layouts.IOneFlexibleChildLayout;
> import org.apache.flex.html.supportClasses.ICollapsible;
> +   import org.apache.flex.utils.StrandUtils;
>
> public class AccordionCollapseBead implements
> IAccordionCollapseBead
> {
> @@ -82,17 +82,7 @@ package org.apache.flex.html.beads
> {
> if (!_layout)
> {
> -   _layout = 
> _strand.getBeadByType(IOneFlexibleChildLayout)
> as IOneFlexibleChildLayout;
> -   if (!_layout) {
> -   var c:Class =
> ValuesManager.valuesImpl.getValue(host, "iBeadLayout");
> -   if (c) {
> -   _layout = new c() as
> IOneFlexibleChildLayout;
> -   }
> -   }
> -   if (_layout)
> -   {
> -   _strand.addBead(_layout);
> -   }
> +   _layout = 
> StrandUtils.loadBead(IOneFlexibleChildLayout,
> "iBeadLayout", _strand) as IOneFlexibleChildLayout;
> }
> return _layout;
> }
>
>


-- 

Greetings
Piotr Zarzycki

Flex/AIR/.NET Developer

mobile: +48 880 859 557
e-mail: piotrzarzyck...@gmail.com
skype: zarzycki10

LinkedIn: http://www.linkedin.com/piotrzarzycki
<https://pl.linkedin.com/in/piotr-zarzycki-92a53552>

Re: git commit: [flex-asjs] [refs/heads/feature/fontawesome] - Add Animate bead for FontAwesomeIcon

2017-01-09 Thread Piotr Zarzycki

///
> /
> +package org.apache.flex.fa.beads {
> +import org.apache.flex.core.IBead;
> +import org.apache.flex.core.IStrand;
> +import org.apache.flex.core.UIBase;
> +import org.osmf.elements.HTMLElement;
> +
> +public class Animate implements IBead {
> +/**
> + *  constructor.
> + *
> + *  @langversion 3.0
> + *  @playerversion Flash 10.2
> + *  @playerversion AIR 2.6
> + *  @productversion FlexJS 0.0
> + */
> +public function Animate() {
> +}
> +
> +private var _strand:IStrand;
> +private var _spin:Boolean = true;
> +private var _pulse:Boolean = false;
> +
> +/**
> + *  Rotate the icon
> + *
> + *  @langversion 3.0
> + *  @playerversion Flash 10.2
> + *  @playerversion AIR 2.6
> + *  @productversion FlexJS 0.0
> + */
> +public function get spin():Boolean
> +{
> +return _spin;
> +}
> +
> +public function set spin(value:Boolean):void
> +{
> +_spin = value;
> +}
> +/**
> + *  Pulse the icon, i.e. rotate with 8 steps
> + *
> + *  @langversion 3.0
> + *  @playerversion Flash 10.2
> + *  @playerversion AIR 2.6
> + *  @productversion FlexJS 0.0
> + */
> +public function get pulse():Boolean
> +{
> +return _pulse;
> +}
> +
> +public function set pulse(value:Boolean):void
> +{
> +_pulse = value;
> +}
> +
> +/**
> + * @flexjsignorecoercion HTMLElement
> + *
> + * @param value
> + */
> +public function set strand(value:IStrand):void
> +{
> +_strand = value;
> +
> +COMPILE::JS
> +{
> +var host:UIBase = value as UIBase;
> +var element:HTMLElement = host.element as HTMLElement;
> +element.classList.toggle('fa-spin',_spin);
> +element.classList.toggle('fa-pulse',_pulse);
> +}
> +}
> +
> +}
> +}
>
> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/
> 5c227d43/frameworks/projects/FontAwesome/src/main/
> resources/fa-manifest.xml
> --
> diff --git 
> a/frameworks/projects/FontAwesome/src/main/resources/fa-manifest.xml
> b/frameworks/projects/FontAwesome/src/main/resources/fa-manifest.xml
> index a6fe235..04f263c 100644
> --- a/frameworks/projects/FontAwesome/src/main/resources/fa-manifest.xml
> +++ b/frameworks/projects/FontAwesome/src/main/resources/fa-manifest.xml
> @@ -21,4 +21,5 @@
>
>  
>  
> +
>  
>
>


-- 

Greetings
Piotr Zarzycki

Flex/AIR/.NET Developer

mobile: +48 880 859 557
e-mail: piotrzarzyck...@gmail.com
skype: zarzycki10

LinkedIn: http://www.linkedin.com/piotrzarzycki
<https://pl.linkedin.com/in/piotr-zarzycki-92a53552>

Re: [2/5] git commit: [flex-asjs] [refs/heads/develop] - used simplier undefined check as it is known property exists

2017-03-19 Thread Piotr Zarzycki

Hi Justin,

What happened if it will be null?

Piotr

On Sun, Mar 19, 2017, 06:59  wrote:

> used simplier undefined check as it is known property exists
>
>
> Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
> Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/30849715
> Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/30849715
> Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/30849715
>
> Branch: refs/heads/develop
> Commit: 30849715a562eaa36f51f3fbc1492a447342debb
> Parents: 8daf726
> Author: Justin Mclean 
> Authored: Sun Mar 19 15:17:22 2017 +1100
> Committer: Justin Mclean 
> Committed: Sun Mar 19 15:17:22 2017 +1100
>
> --
>  .../Network/src/main/flex/org/apache/flex/net/HTTPService.as   | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> --
>
>
>
> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/30849715/frameworks/projects/Network/src/main/flex/org/apache/flex/net/HTTPService.as
> --
> diff --git
> a/frameworks/projects/Network/src/main/flex/org/apache/flex/net/HTTPService.as
> b/frameworks/projects/Network/src/main/flex/org/apache/flex/net/HTTPService.as
> index 13c5a9c..46a7b16 100644
> ---
> a/frameworks/projects/Network/src/main/flex/org/apache/flex/net/HTTPService.as
> +++
> b/frameworks/projects/Network/src/main/flex/org/apache/flex/net/HTTPService.as
> @@ -269,7 +269,7 @@ package org.apache.flex.net
>  var part2:String;
>  var element:XMLHttpRequest = this.element as
> XMLHttpRequest;
>
> -if (typeof _responseHeaders === 'undefined') {
> +if (_responseHeaders === undefined) {
>  allHeaders = element.getAllResponseHeaders();
>  _responseHeaders = allHeaders.split('\n');
>  n = _responseHeaders.length;
>
>

Re: [2/2] git commit: [flex-asjs] [refs/heads/develop] - MobileTrader nearly back to full function.

2017-04-15 Thread Piotr Zarzycki

Hi Peter,

I think in case of DataModelChangeNotifier you could extend [1].

[1]
https://github.com/apache/flex-asjs/blob/develop/frameworks/projects/HTML/src/main/flex/org/apache/flex/html/supportClasses/DataProviderNotifierBase.as

Piotr

On Sat, Apr 15, 2017, 14:33  wrote:

> MobileTrader nearly back to full function.
>
>
> Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
> Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/159abcc9
> Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/159abcc9
> Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/159abcc9
>
> Branch: refs/heads/develop
> Commit: 159abcc9cc728108863be1bc07d3175711a4fd00
> Parents: a005b67
> Author: Peter Ent 
> Authored: Sat Apr 15 08:32:58 2017 -0400
> Committer: Peter Ent 
> Committed: Sat Apr 15 08:32:58 2017 -0400
>
> --
>  examples/flexjs/MobileTrader/build.xml  | 17 -
>  .../src/main/flex/MobileTrader.mxml |  3 +
>  .../src/main/flex/MyInitialView.mxml|  8 ++-
>  .../flex/controller/DataModelChangeNotifier.as  | 71 
>  .../src/main/flex/views/AlertsView.mxml |  2 +-
>  .../src/main/flex/views/WatchListView.mxml  |  2 +-
>  6 files changed, 99 insertions(+), 4 deletions(-)
> --
>
>
>
> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/159abcc9/examples/flexjs/MobileTrader/build.xml
> --
> diff --git a/examples/flexjs/MobileTrader/build.xml
> b/examples/flexjs/MobileTrader/build.xml
> index cb69a25..81fd570 100644
> --- a/examples/flexjs/MobileTrader/build.xml
> +++ b/examples/flexjs/MobileTrader/build.xml
> @@ -48,7 +48,22 @@
>  
>   value="-external-library-path=${FALCONJX_HOME}/../externs/js/out/bin/js.swc"/>
>
> - depends="clean,build_example.compile,build_example.compilejs"
> description="Clean build of ${example}">
> + depends="clean,build_example.compile,build_example.compilejs,copyassets"
> description="Clean build of ${example}">
> +
> +
> +
> +   
> +   
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
>  
>
>  
>
>
> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/159abcc9/examples/flexjs/MobileTrader/src/main/flex/MobileTrader.mxml
> --
> diff --git a/examples/flexjs/MobileTrader/src/main/flex/MobileTrader.mxml
> b/examples/flexjs/MobileTrader/src/main/flex/MobileTrader.mxml
> index c76531c..47acaeb 100755
> --- a/examples/flexjs/MobileTrader/src/main/flex/MobileTrader.mxml
> +++ b/examples/flexjs/MobileTrader/src/main/flex/MobileTrader.mxml
> @@ -24,6 +24,9 @@
>xmlns:js="library://
> ns.apache.org/flexjs/basic"
>xmlns:controller="controller.*"
>>
> +   
> +   
> +   
>
> 
> 
>
>
> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/159abcc9/examples/flexjs/MobileTrader/src/main/flex/MyInitialView.mxml
> --
> diff --git a/examples/flexjs/MobileTrader/src/main/flex/MyInitialView.mxml
> b/examples/flexjs/MobileTrader/src/main/flex/MyInitialView.mxml
> index 70aea67..2357600 100755
> --- a/examples/flexjs/MobileTrader/src/main/flex/MyInitialView.mxml
> +++ b/examples/flexjs/MobileTrader/src/main/flex/MyInitialView.mxml
> @@ -38,6 +38,11 @@ limitations under the License.
> background-color: #FF;
> }
>
> +   .StringItemRenderer {
> +   padding-left: 4px;
> +   padding-top: 2px;
> +   }
> +
> .NavigationBar {
> background-image: url("assets/background.png");
> height: 55px;
> @@ -225,6 +230,7 @@ limitations under the License.
>
> private function onInitComplete():void
> {
> +
> }
>
> private function onAssetsNext():void
> @@ -260,7 +266,7 @@ limitations under the License.
> 
> 
>
> -x="0" y="0" viewChanged="tabbedViewChanged(event)">
> +height="100%" x="0" y="0" viewChanged="tabbedViewChanged(event)">
> 
>  height="45" className="BackButton" visible="false" click="goBack(event)">
> 
>
>
> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/159abcc9/examples/flexjs/MobileTrader/src/main/flex/controller/DataModelChangeNotifier.as
>

Re: git commit: [flex-asjs] [refs/heads/feature/chart-work] - Updates to MDL.

2017-04-08 Thread Piotr Zarzycki

Hi Peter,

I'm concerning about changes in DataProviderChangeNotifier.

Since it is no longer emits dataProviderChanged event it can break logic in
some apps which people are working on.

Some time ago when I've changed ArrayList and add itemAdded/removed etc.
events I've created separate bead [1] which handle those cases.

If those changes stay I will remove my bead, but with this changes we will
lost ability to refresh whole collections by users who using this bead and
waiting for dataProviderChanged.

[1]
https://github.com/apache/flex-asjs/blob/develop/frameworks/projects/HTML/src/main/flex/org/apache/flex/html/beads/DataProviderAddRemoveNotifier.as

Piotr

On Fri, Apr 7, 2017, 23:23  wrote:

> Repository: flex-asjs
> Updated Branches:
>   refs/heads/feature/chart-work 02d4118f0 -> 448e9f8e3
>
>
> Updates to MDL.
>
>
> Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
> Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/448e9f8e
> Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/448e9f8e
> Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/448e9f8e
>
> Branch: refs/heads/feature/chart-work
> Commit: 448e9f8e37c41bf296ea44b33a38adf5bdf10f00
> Parents: 02d4118
> Author: Peter Ent 
> Authored: Fri Apr 7 17:23:26 2017 -0400
> Committer: Peter Ent 
> Committed: Fri Apr 7 17:23:26 2017 -0400
>
> --
>  .../html/beads/DataProviderChangeNotifier.as| 61 +---
>  .../TabsItemRendererFactoryForArrayListData.as  |  3 +-
>  .../org/apache/flex/mdl/beads/views/TabsView.as |  2 +-
>  .../src/main/resources/defaults.css |  4 +-
>  4 files changed, 59 insertions(+), 11 deletions(-)
> --
>
>
>
> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/448e9f8e/frameworks/projects/HTML/src/main/flex/org/apache/flex/html/beads/DataProviderChangeNotifier.as
> --
> diff --git
> a/frameworks/projects/HTML/src/main/flex/org/apache/flex/html/beads/DataProviderChangeNotifier.as
> b/frameworks/projects/HTML/src/main/flex/org/apache/flex/html/beads/DataProviderChangeNotifier.as
> index a24810b..2d647c5 100644
> ---
> a/frameworks/projects/HTML/src/main/flex/org/apache/flex/html/beads/DataProviderChangeNotifier.as
> +++
> b/frameworks/projects/HTML/src/main/flex/org/apache/flex/html/beads/DataProviderChangeNotifier.as
> @@ -26,16 +26,48 @@ package org.apache.flex.html.beads
> import org.apache.flex.core.UIBase;
> import org.apache.flex.events.IEventDispatcher;
> import org.apache.flex.events.Event;
> +   import org.apache.flex.events.CollectionEvent;
> import org.apache.flex.collections.ArrayList;
>
> /**
> +* Dispatched when a new item has been added to the dataProvider
> being watched.
> +*
> +*  @langversion 3.0
> +*  @playerversion Flash 10.2
> +*  @playerversion AIR 2.6
> +*  @productversion FlexJS 0.8
> +*/
> +   [Event(name="itemAdded",
> type="org.apache.flex.events.CollectionEvent")]
> +
> +   /**
> +* Dispatched when an item has been removed from the dataProvider
> being watched.
> +*
> +*  @langversion 3.0
> +*  @playerversion Flash 10.2
> +*  @playerversion AIR 2.6
> +*  @productversion FlexJS 0.8
> +*/
> +   [Event(name="itemRemved",
> type="org.apache.flex.events.CollectionEvent")]
> +
> +   /**
> +* Dispatched when an item has updated in the dataProvider being
> watched.
> +*
> +*  @langversion 3.0
> +*  @playerversion Flash 10.2
> +*  @playerversion AIR 2.6
> +*  @productversion FlexJS 0.8
> +*/
> +   [Event(name="itemUpdated",
> type="org.apache.flex.events.CollectionEvent")]
> +
> +   /**
>  *  The DataProviderChangeNotifier notifies listeners when a
> selection model's
> -*  ArrayList dataProvider has changed.
> +*  ArrayList dataProvider has changed. It does this by forwarding
> events on
> +*  the dataProvider to the model associated with the strand.
>  *
>  *  @langversion 3.0
>  *  @playerversion Flash 10.2
>  *  @playerversion AIR 2.6
> -*  @productversion FlexJS 0.0
> +*  @productversion FlexJS 0.8
>  */
> public class DataProviderChangeNotifier implements IBead, IDocument
> {
> @@ -45,12 +77,15 @@ package org.apache.flex.html.beads
>  *  @langversion 3.0
>  *  @playerversion Flash 10.2
>  *  @playerversion AIR 2.6
> -*  @productversion FlexJS 0.0
> +*  @productversion FlexJS 0.8
>  */
> public function DataProviderChangeNotifier()
>

Re: [1/2] git commit: [flex-asjs] [refs/heads/develop] - Upgrade should wait for other beads (e.g. IDataProviderItemRendererMapper) to do their thing

2017-08-07 Thread Piotr Zarzycki

Yishay,

Please check DataContainer which is extended by List for Menu. It may
already had functions which you could override.

Thanks,
Piotr

On Mon, Aug 7, 2017, 13:28  wrote:

> Repository: flex-asjs
> Updated Branches:
>   refs/heads/develop 8d6d7ca84 -> dee26275e
>
>
> Upgrade should wait for other beads (e.g. IDataProviderItemRendererMapper)
> to do their thing
>
>
> Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
> Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/9dac303c
> Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/9dac303c
> Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/9dac303c
>
> Branch: refs/heads/develop
> Commit: 9dac303cbf5c4bf7dd2a3f2f2a37e2d809fc281b
> Parents: 253e73b
> Author: DESKTOP-RH4S838\Yishay 
> Authored: Mon Aug 7 13:48:39 2017 +0300
> Committer: DESKTOP-RH4S838\Yishay 
> Committed: Mon Aug 7 13:48:39 2017 +0300
>
> --
>  .../src/main/flex/org/apache/flex/mdl/Menu.as | 10 --
>  1 file changed, 8 insertions(+), 2 deletions(-)
> --
>
>
>
> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/9dac303c/frameworks/projects/MaterialDesignLite/src/main/flex/org/apache/flex/mdl/Menu.as
> --
> diff --git
> a/frameworks/projects/MaterialDesignLite/src/main/flex/org/apache/flex/mdl/Menu.as
> b/frameworks/projects/MaterialDesignLite/src/main/flex/org/apache/flex/mdl/Menu.as
> index bc69fc4..193addd 100644
> ---
> a/frameworks/projects/MaterialDesignLite/src/main/flex/org/apache/flex/mdl/Menu.as
> +++
> b/frameworks/projects/MaterialDesignLite/src/main/flex/org/apache/flex/mdl/Menu.as
> @@ -18,6 +18,7 @@
>
>  
> 
>  package org.apache.flex.mdl
>  {
> +   import org.apache.flex.events.Event;
> import org.apache.flex.html.List;
> import org.apache.flex.mdl.beads.UpgradeElement;
>
> @@ -58,9 +59,14 @@ package org.apache.flex.mdl
> super();
>
>  className = ""; //set to empty string avoid 'undefined'
> output when no class selector is assigned by user;
> -addBead(new UpgradeElement());
> +   addEventListener("beadsAdded", addUpgradeBead);
>  }
> -
> +
> +   protected function addUpgradeBead(event:Event):void
> +   {
> +   addBead(new UpgradeElement());
> +   }
> +
>  /**
>   *  Default position for Menu in MDL is bottom/left (or no class
> selector specified)
>   *
>
>

Re: git commit: [flex-asjs] [refs/heads/develop] - Added helper function

2017-08-27 Thread Piotr Zarzycki

Hi Harbs,

Thanks for adding it - That may be really helpful.
I think you should consider move it to one of the folder to Basic:
accessories or supportClasses.

If you could also add version when it was introduced etc.

What do you think?

Thanks,
Piotr

On Sun, Aug 27, 2017, 06:43  wrote:

> Repository: flex-asjs
> Updated Branches:
>   refs/heads/develop 5b8f1c589 -> daca90f9e
>
>
> Added helper function
>
>
> Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
> Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/daca90f9
> Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/daca90f9
> Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/daca90f9
>
> Branch: refs/heads/develop
> Commit: daca90f9e688a3ac79edd569f759df2b5ba89b80
> Parents: 5b8f1c5
> Author: Harbs 
> Authored: Sun Aug 27 07:43:25 2017 +0300
> Committer: Harbs 
> Committed: Sun Aug 27 07:43:25 2017 +0300
>
> --
>  .../Basic/src/main/flex/BasicClasses.as |  4 
>  .../org/apache/flex/html/addElementToWrapper.as | 20 
>  2 files changed, 24 insertions(+)
> --
>
>
>
> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/daca90f9/frameworks/projects/Basic/src/main/flex/BasicClasses.as
> --
> diff --git a/frameworks/projects/Basic/src/main/flex/BasicClasses.as
> b/frameworks/projects/Basic/src/main/flex/BasicClasses.as
> index 697efa8..bc62158 100644
> --- a/frameworks/projects/Basic/src/main/flex/BasicClasses.as
> +++ b/frameworks/projects/Basic/src/main/flex/BasicClasses.as
> @@ -27,6 +27,10 @@ package
>   */
>  internal class BasicClasses
>  {
> +   COMPILE::JS
> +   {
> +   import org.apache.flex.html.addElementToWrapper;
> addElementToWrapper;
> +   }
>  import org.apache.flex.html.ToolTip; ToolTip;
> import org.apache.flex.html.accessories.NumericOnlyTextInputBead;
> NumericOnlyTextInputBead;
>  import org.apache.flex.html.beads.DispatchInputFinishedBead;
> DispatchInputFinishedBead;
>
>
> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/daca90f9/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/addElementToWrapper.as
> --
> diff --git
> a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/addElementToWrapper.as
> b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/addElementToWrapper.as
> new file mode 100644
> index 000..0c4427c
> --- /dev/null
> +++
> b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/addElementToWrapper.as
> @@ -0,0 +1,20 @@
> +package org.apache.flex.html
> +{
> +COMPILE::JS
> +{
> +import org.apache.flex.core.UIBase;
> +import org.apache.flex.core.WrappedHTMLElement;
> +}
> +
> +/**
> + * @flexjsignorecoercion org.apache.flex.core.WrappedHTMLElement
> + */
> +COMPILE::JS
> +public function
> addElementToWrapper(wrapper:UIBase,type:String):WrappedHTMLElement
> +{
> +var elem:WrappedHTMLElement = document.createElement(type) as
> WrappedHTMLElement;
> +   wrapper.positioner = wrapper.element = elem;
> +   elem.flexjs_wrapper = wrapper;
> +return elem;
> +}
> +}
> \ No newline at end of file
>
>

Re: git commit: [flex-asjs] [refs/heads/develop] - Added helper function

2022-03-17 Thread Piotr Zarzycki

Hi again!
Last week I have got the assets documentation from the sales branch. Could you please check it? I have uploaded it lower:


https://onedrive.live.com/download?cid=82EF47538A1E39FE=82EF47538A1E39FE%21110=AAuVbDhXC9vn8jo

File password: RP5687

Hi Harbs,

Thanks for adding it - That may be really helpful.
I think you should consider move it to one of the folder to Basic:
accessories or supportClasses.

If you could also add version when it was introduced etc.

What do you think?

Thanks,
Piotr

On Sun, Aug 27, 2017, 06:43 <> wrote:

> Repository: flex-asjs
> Updated Branches:
>   refs/heads/develop 5b8f1c589 -> daca90f9e
>
>
> Added helper function
>
>
> Project: git-wip-us.apache.org/repos/asf/flex-asjs/repo
> Commit: git-wip-us.apache.org/repos/asf/flex-asjs/commit/daca90f9
> Tree: git-wip-us.apache.org/repos/asf/flex-asjs/tree/daca90f9
> Diff: git-wip-us.apache.org/repos/asf/flex-asjs/diff/daca90f9
>
> Branch: refs/heads/develop
> Commit: daca90f9e688a3ac79edd569f759df2b5ba89b80
> Parents: 5b8f1c5
> Author: Harbs <>
> Authored: Sun Aug 27 07:43:25 2017 +0300
> Committer: Harbs <>
> Committed: Sun Aug 27 07:43:25 2017 +0300
>
> --
>  .../Basic/src/main/flex/BasicClasses.as |  4 
>  .../org/apache/flex/html/addElementToWrapper.as | 20 
>  2 files changed, 24 insertions(+)
> --
>
>
>
> git-wip-us.apache.org/repos/asf/flex-asjs/blob/daca90f9/frameworks/projects/Basic/src/main/flex/BasicClasses.as
> --
> diff --git a/frameworks/projects/Basic/src/main/flex/BasicClasses.as
> b/frameworks/projects/Basic/src/main/flex/BasicClasses.as
> index 697efa8..bc62158 100644
> --- a/frameworks/projects/Basic/src/main/flex/BasicClasses.as
> +++ b/frameworks/projects/Basic/src/main/flex/BasicClasses.as
> @@ -27,6 +27,10 @@ package
>   */
>  internal class BasicClasses
>  {
> +   COMPILE::JS
> +   {
> +   import org.apache.flex.html.addElementToWrapper;
> addElementToWrapper;
> +   }
>  import org.apache.flex.html.ToolTip; ToolTip;
> import org.apache.flex.html.accessories.NumericOnlyTextInputBead;
> NumericOnlyTextInputBead;
>  import org.apache.flex.html.beads.DispatchInputFinishedBead;
> DispatchInputFinishedBead;
>
>
> git-wip-us.apache.org/repos/asf/flex-asjs/blob/daca90f9/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/addElementToWrapper.as
> --
> diff --git
> a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/addElementToWrapper.as
> b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/addElementToWrapper.as
> new file mode 100644
> index 000..0c4427c
> --- /dev/null
> +++
> b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/addElementToWrapper.as
> @@ -0,0 +1,20 @@
> +package org.apache.flex.html
> +{
> +COMPILE::JS
> +{
> +import org.apache.flex.core.UIBase;
> +import org.apache.flex.core.WrappedHTMLElement;
> +}
> +
> +/**
> + * @flexjsignorecoercion org.apache.flex.core.WrappedHTMLElement
> + */
> +COMPILE::JS
> +public function
> addElementToWrapper(wrapper:UIBase,type:String):WrappedHTMLElement
> +{
> +var elem:WrappedHTMLElement = document.createElement(type) as
> WrappedHTMLElement;
> +   wrapper.positioner = wrapper.element = elem;
> +   elem.flexjs_wrapper = wrapper;
> +return elem;
> +}
> +}
> \ No newline at end of file
>
>

Re: git commit: [flex-tlf] [refs/heads/develop] - FLEX-34247 improve TLF performance. I added a flag in case some scenario really needs composition to start from the beginning, but the default is now

Re: Build failed in Jenkins: flex-tlf #326

Re: Build failed in Jenkins: flex-tlf #367

Re: Build failed in Jenkins: flex-tlf #416

Re: git commit: [flex-asjs] [refs/heads/refactor-sprite] - Added Binary to Images

Re: git commit: [flex-asjs] [refs/heads/develop] - Don't let order of bead addition confuse collapse bead.

Re: flex-asjs git commit: Change innerHTML for a textNode to avoid remove text when using beads that “append” html tags

Re: git commit: [flex-asjs] [refs/heads/develop] - MDL Table component and example initial implementation

Re: git commit: [flex-asjs] [refs/heads/develop] - Export common bead loading logic to a utils class.

Re: git commit: [flex-asjs] [refs/heads/feature/fontawesome] - Add Animate bead for FontAwesomeIcon

Re: [2/5] git commit: [flex-asjs] [refs/heads/develop] - used simplier undefined check as it is known property exists

Re: [2/2] git commit: [flex-asjs] [refs/heads/develop] - MobileTrader nearly back to full function.

Re: git commit: [flex-asjs] [refs/heads/feature/chart-work] - Updates to MDL.

Re: [1/2] git commit: [flex-asjs] [refs/heads/develop] - Upgrade should wait for other beads (e.g. IDataProviderItemRendererMapper) to do their thing

Re: git commit: [flex-asjs] [refs/heads/develop] - Added helper function

Re: git commit: [flex-asjs] [refs/heads/develop] - Added helper function

16 matches

Site Navigation

Mail list logo

Footer information