This is an automated email from the ASF dual-hosted git repository.

srichter pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git


The following commit(s) were added to refs/heads/master by this push:
     new 049de6628de [hotfix] Remove redundant call to remove().
049de6628de is described below

commit 049de6628dee1222b4f40eeb3bb5884e1ed9649a
Author: Stefan Richter <srich...@confluent.io>
AuthorDate: Tue Feb 20 12:01:03 2024 +0100

    [hotfix] Remove redundant call to remove().
---
 .../streaming/state/restore/RocksDBIncrementalRestoreOperation.java  | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git 
a/flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/restore/RocksDBIncrementalRestoreOperation.java
 
b/flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/restore/RocksDBIncrementalRestoreOperation.java
index c96d5d64224..afd19c75c7c 100644
--- 
a/flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/restore/RocksDBIncrementalRestoreOperation.java
+++ 
b/flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/restore/RocksDBIncrementalRestoreOperation.java
@@ -600,7 +600,7 @@ public class RocksDBIncrementalRestoreOperation<K> 
implements RocksDBRestoreOper
                 keyGroupRange.prettyPrintInterval(),
                 operatorIdentifier);
 
-        // Choose the best state handle for the initial DB
+        // Choose the best state handle for the initial DB and remove it from 
the list
         final IncrementalLocalKeyedStateHandle selectedInitialHandle =
                 localKeyedStateHandles.remove(
                         
RocksDBIncrementalCheckpointUtils.findTheBestStateHandleForInitial(
@@ -608,9 +608,6 @@ public class RocksDBIncrementalRestoreOperation<K> 
implements RocksDBRestoreOper
 
         Preconditions.checkNotNull(selectedInitialHandle);
 
-        // Remove the selected handle from the list so that we don't restore 
it twice.
-        localKeyedStateHandles.remove(selectedInitialHandle);
-
         // Init the base DB instance with the initial state
         initBaseDBFromSingleStateHandle(selectedInitialHandle);
 

Reply via email to